Commit Graph

2550 Commits

Author SHA1 Message Date
Jasper Woudenberg
a00c34a6f4
Merge pull request #22 from NoRedInk/extract-updated-segmented-control
Extract updated segmented control
2018-03-29 09:30:49 +02:00
Hardy Jones
fb2dbbfb47
Extract updated segmented control from the monolith
This version is like `Nri.Ui.SegmentedControl.V1` with the icon changes.
It has the fix for `box-sizing`.

All the other caveats from `Nri.Ui.SegmentedControl.V1`
(if there were any) apply here as well.
2018-03-28 18:20:58 -07:00
Hardy Jones
0a75e8229b
Extract Nri.Icon from the monolith
The recommendation is to break the styles API rather than the view API
when moving something out of the monolith into this repo.

`Nri.Icon` is not really setup for that sort of breakage.
If we would prefer to have the styles break rather than the view,
that will take more work.
Work that can be done independent of the extraction.

The transition in the monolith ought to look something like:

```elm
module Nri.Icon exposing (..)

import Html exposing (Html)
import Nri.SvgSprite
import Nri.Ui.Icon.V1 exposing (Assets, IconType)

icon : { alt : String, icon : IconType } -> Html msg
icon config =
  Nri.Ui.Icon.V1.icon assets

assets : Assets {}
assets =
  { activity = Nri.SvgSprite.activity
  , arrowDown = Nri.SvgSprite.arrowDown
  , attention_svg = Nri.Assets.attention_svg
  ...
  }
```

So hopefully, the change is still very small on the monolith side.

There's maybe a bigger concern than which API breaks.
`Nri.Icon` has some behavior for a11y.
We could definitely change the internals over during the extraction.
But, since all of these changes are value-level changes,
it's very likely that we'll break something in the process.
That's a bigger concern because instead of affecting
the handful of Engineers working at NRI,
we would be affecting the millions of people using the site.

We shouldn't fear making those kinds of changes.
However, we should make them when we can give them the appropriate
attention they deserve.
Not when one person is trying to move as fast as possible to avoid
race conditions of moving modules between repos.
2018-03-28 18:20:16 -07:00
Hardy Jones
7a5da8a78c
Merge pull request #21 from NoRedInk/set-shell-explicitly
Set shell explicitly
2018-03-28 12:23:00 -07:00
Hardy Jones
9bab3fe852
Use /bin/sh instead
Per Brian Hicks: people customize their .bashrc/.zshrc and
sometimes they take a long time to load,
but almost no one ever customizes `/bin/sh`.
2018-03-28 12:16:59 -07:00
Hardy Jones
00d61cb76b
Set the SHELL explicitly
On macOS/OSX, the shell is `/bin/sh`.
Most of the `elm` commands don't seem to work in `/bin/sh`.

If we use `/bin/bash`, the commands seem to work.
2018-03-28 12:05:11 -07:00
Jasper Woudenberg
330cce6a72
Merge pull request #19 from NoRedInk/joneshf-patch-1
Turn off email notifications
2018-03-28 20:12:59 +02:00
Jasper Woudenberg
5f5a060dd2
Merge branch 'master' into joneshf-patch-1 2018-03-28 19:56:09 +02:00
Michael Glass
23fd05e227
Merge pull request #20 from NoRedInk/makefile-uncontroversial
add a Makefile, speed up CI
2018-03-28 13:28:48 +02:00
Brian Hicks
89ee987118
cache slightly more aggressively to avoid downloads 2018-03-27 22:28:16 -05:00
Brian Hicks
a756a0a685
try node_modules again, while always saying to remake the dep targets 2018-03-27 22:23:32 -05:00
Brian Hicks
0515f1fbd6
how about caching elm packages!? 2018-03-27 22:19:13 -05:00
Brian Hicks
732a25a5cd
un-cache node_modules, which causes errors for some reason? 2018-03-27 22:16:57 -05:00
Brian Hicks
0fce84dc5e
update README with test/ci instructions 2018-03-27 22:14:55 -05:00
Brian Hicks
c3acc165d6
automatically calculate output file name 2018-03-27 22:14:24 -05:00
Brian Hicks
199b219a97
cache node_modules, too 2018-03-27 22:11:03 -05:00
Brian Hicks
30be6bfa06
define what I know node_modules will be later now
Travis can't determine what node_modules will be if it doesn't exist
yet, so it fails and has to retry. No need for that, so we'll just put
it where we know it will be.
2018-03-27 22:07:51 -05:00
Brian Hicks
6b717c6166
🎨 remove extra line 2018-03-27 22:04:00 -05:00
Brian Hicks
8923998ad8
use ci target 2018-03-27 22:03:45 -05:00
Brian Hicks
c14d5abc92
split out top level test targets 2018-03-27 22:00:47 -05:00
Brian Hicks
0cac3bf06b
combine sub-elm-stuffs 2018-03-27 22:00:36 -05:00
Brian Hicks
f9947b796b
use the right wildcard syntax 2018-03-27 21:42:59 -05:00
Brian Hicks
9298f45c16
inhibit parallel elm-package invocations, while allowing other parallel stuff 2018-03-27 21:37:47 -05:00
Brian Hicks
1e95da847b
add proper cleaning 2018-03-27 21:37:41 -05:00
Brian Hicks
4baed94472
cache more 2018-03-27 21:37:21 -05:00
Brian Hicks
19917279ba
be a little less eager about package installation 2018-03-27 21:32:45 -05:00
Brian Hicks
e15046d968
use travis_retry for transient network things 2018-03-27 21:31:05 -05:00
Brian Hicks
11255f2d88
fix paths 2018-03-27 21:28:49 -05:00
Brian Hicks
389c699f78
require less setup from Travis 2018-03-27 21:16:50 -05:00
Brian Hicks
c24e1641e3
download everything as parallel as possible 2018-03-27 21:14:16 -05:00
Brian Hicks
c1be619f59
be explicit about node_modules dependency 2018-03-27 21:13:14 -05:00
Brian Hicks
db726c5654
fix typo 2018-03-27 21:13:10 -05:00
Hardy Jones
13f605c58e
Turn off email notifications 2018-03-27 15:13:34 -07:00
Brian Hicks
98188d703e
separate styleguide-app's build 2018-03-27 17:01:08 -05:00
Brian Hicks
85a5157325
replace travis build with a Makefile
very on brand, yes?
2018-03-27 16:58:12 -05:00
Brian Hicks
a9361886f3
set versions with npm 2018-03-27 16:42:26 -05:00
Hardy Jones
fe7d580c5d
Merge commit '832c35b' into HEAD 2018-03-27 14:07:54 -07:00
Hardy Jones
832c35b3f8
Bump version to 3.5.1 2018-03-27 14:02:56 -07:00
Hardy Jones
7024806038
Bump version to 3.5.0 2018-03-27 14:02:16 -07:00
Hardy Jones
fe62d1633b
Merge pull request #17 from NoRedInk/expose-segmented-control-version-two
Expose v2 of segmented control
2018-03-27 13:57:25 -07:00
Hardy Jones
d3b7fe9c2d
Merge branch 'master' into expose-segmented-control-version-two 2018-03-27 13:53:02 -07:00
Hardy Jones
31604bfcce
Merge pull request #15 from NoRedInk/add-tests
Add elm tests
2018-03-27 13:49:53 -07:00
Hardy Jones
ee4343a046
Expose v2 of segmented control 2018-03-27 13:42:40 -07:00
Jasper Woudenberg
49f2f08948 Merge branch 'master' into add-tests 2018-03-27 16:27:52 +02:00
Jasper Woudenberg
c410e61a65 Fix error in .travis.yml
The style-guide compilation test was missing a `--yes` in the `elm-make`
command. As a result, the travis build would hang waiting for user
input.
2018-03-27 16:27:00 +02:00
Jasper Woudenberg
d41b889c2a Enable elm-test in .travis.yml 2018-03-27 16:22:18 +02:00
Jasper Woudenberg
19e58c4c23 Merge branch 'master' into add-tests 2018-03-27 16:21:47 +02:00
Jasper Woudenberg
c20b3b8936
Merge pull request #16 from NoRedInk/add-travis-yaml
Add a .travis.yaml
2018-03-27 16:17:33 +02:00
Jasper Woudenberg
04fb81d2da Add a .travis.yaml
For the most part this is shamelessly lifted from elm-spa-example:

https://github.com/rtfeldman/elm-spa-example/blob/master/.travis.yml

elm-test support is in there, but not yet enabled because we don't have
any tests yet.
2018-03-27 16:13:23 +02:00
Jasper Woudenberg
fd88711766 Add tests for checkbox
These tests are fresh from the monolith.
2018-03-27 15:59:09 +02:00