Commit Graph

5364 Commits

Author SHA1 Message Date
charbelrami
6bbc4b7237 write tests for highlighter 2022-09-26 10:14:33 -03:00
Tessa Kelly
ffce39d717 Adds initial keyboard test for right arrow without shift 2022-09-21 10:59:21 -06:00
Tessa Kelly
89c932ee07 Extract spec helpers for key events from Menu 2022-09-21 10:58:56 -06:00
Tessa Kelly
765412d5ab Sets up first test for Highlighter 2022-09-21 10:41:37 -06:00
charbelrami
ebca2778de remove empty segment after the sentences 2022-09-21 11:52:10 -03:00
charbelrami
d783f5978e remove empty segments 2022-09-21 11:19:43 -03:00
charbelrami
21a3b0ff20 highlighter nav: add Maybe to nextIndex 2022-09-20 12:04:49 -03:00
charbelrami
3eb9e2bc67 remove unused events from static elements 2022-09-19 20:41:20 -03:00
charbelrami
f793bfd7f7 highlighter: replace recursion with foldl/foldr 2022-09-19 18:03:33 -03:00
charbelrami
ea20308433 make arrow keys skip static elements 2022-09-19 10:11:29 -03:00
Charbel
cb6f8cd06b
Merge pull request #1072 from NoRedInk/highlighter-keyboard-nav
A11-1550 Highlighter keyboard nav and focus management
2022-09-15 13:46:49 -03:00
charbelrami
339ac575ce remove comment and tabindex 0 from mark element 2022-09-15 13:41:09 -03:00
Ben Dansby
cf3f536c7d
Merge pull request #1075 from NoRedInk/dansby/success
Make button success state use darkest green
2022-09-15 09:29:04 -07:00
Ben Dansby
5dd8afa995
Merge pull request #1073 from NoRedInk/dansby/sidenav-tweaks
Adjust SideNav styles
2022-09-15 09:28:24 -07:00
kristine
ad4ad79356
Merge pull request #1076 from NoRedInk/bat/highlighter-example-copy
Bat/highlighter example copy
2022-09-15 12:15:30 -04:00
Kristine
496954606e remove comment 2022-09-15 11:41:03 -04:00
Kristine
61ce70e63f nicer table 2022-09-15 11:39:31 -04:00
Kristine
ed6ef69ea4 update description copy 2022-09-15 11:35:21 -04:00
Kristine
69553aafd6 add explanatory h3s 2022-09-15 11:33:27 -04:00
Kristine
1908e7316f update h2 copy 2022-09-15 11:31:07 -04:00
Ben Dansby
2b37e03cbd darker green 2022-09-15 07:35:05 -07:00
Ben Dansby
ac26913fe6 styles 2022-09-14 12:54:23 -07:00
charbelrami
8f2d2446b3 add roving tabindex to highlightables 2022-09-14 14:16:10 -03:00
charbelrami
fd4a6c3ec1 focus on the mark element after applying highlight 2022-09-14 13:58:12 -03:00
noredinkbot-duet[bot]
b2c7efe0db
Merge #1071
1071: Bat/highlighter example improvements r=tesk9 a=tesk9

Adds:
- distinct color defaults
- more clear eraser styles
- removed default mark styles
- splitting the interactive example on sentences or by word
- a "clear all highlights" button

Fixes A11-1608
Fixes A11-1609
Fixes A11-1604

Paired with `@krinhorn` 

Co-authored-by: Tessa Kelly <tessakkelly@gmail.com>
2022-09-14 15:57:20 +00:00
Tessa Kelly
41a9d25a0a shake 2022-09-14 09:56:47 -06:00
Tessa
9c093ee094
Merge pull request #1070 from NoRedInk/bat/reduce-prominence-of-errorIf
Remove errorIf options from styleguide examples
2022-09-14 09:46:50 -06:00
charbelrami
03c9a16b96 implement highlighter shift + arrow keys nav 2022-09-13 18:41:14 -03:00
Tessa Kelly
4a93668504 Make the current settings more clear 2022-09-13 14:00:13 -06:00
Tessa Kelly
20b7e16e47 Add eraser model color 2022-09-13 13:53:01 -06:00
Tessa Kelly
eadb1fcaab Remove default mark styles 2022-09-13 13:48:43 -06:00
Tessa Kelly
2c5c64a35f Support sentence level segments in addition to word-level segments 2022-09-13 13:45:10 -06:00
Tessa Kelly
52af96526c Adds button to clear all existing highlights 2022-09-13 13:28:15 -06:00
Tessa Kelly
1b9cddaf57 Generalize the rotation helper 2022-09-13 13:18:31 -06:00
Tessa Kelly
5d08956313 Default each highlight color to a different starting color 2022-09-13 13:14:24 -06:00
noredinkbot-duet[bot]
aa55b34e50
Merge #1068
1068: Bat/confetti sample code r=ap-nri a=tesk9

Adds example code to the Confetti example.

Fixes A11-1471

Co-authored-by: Tessa Kelly <tessakkelly@gmail.com>
2022-09-12 23:03:07 +00:00
Tessa Kelly
13af8f55b4 Remove errorIf options from styleguide examples 2022-09-12 11:21:36 -06:00
Tessa Kelly
b2a1f5fae3 Merge remote-tracking branch 'origin/master' into bat/confetti-sample-code 2022-09-12 11:18:56 -06:00
Tessa
82c8415d7b
Merge pull request #1063 from NoRedInk/hack/tessa/layout
Hack day project: adding Layout
2022-09-12 10:00:01 -06:00
Tessa Kelly
7e78dbb687 Fix examples preview layout 2022-09-12 09:45:06 -06:00
Tessa Kelly
417db22399 Rename Layout to Spacing 2022-09-12 09:39:09 -06:00
Tessa Kelly
229fecebd1 Merge remote-tracking branch 'origin/master' into hack/tessa/layout 2022-09-12 09:31:00 -06:00
Tessa Kelly
1dab6e1fb2 Make sure when there's more than one highlighter on the page that the each highlightable has a unique id 2022-09-09 11:05:35 -06:00
Tessa Kelly
43010ee806 Support navigation events on static highlightables 2022-09-09 10:59:31 -06:00
charbelrami
b78d11a332 start adding roving tabindex to the highlighter 2022-09-09 13:49:56 -03:00
Tessa Kelly
3a629621e4 Support Focus action in highlghter 2022-09-09 10:22:33 -06:00
charbelrami
710d605713 start implementing highlighter keyboard navigation 2022-09-09 13:11:32 -03:00
Charbel
91f2a89f1e
Merge pull request #1069 from NoRedInk/bat/highlighter-high-contrast
Adds high contrast mode
2022-09-09 12:42:01 -03:00
Charbel
0508b39dfd
Merge pull request #1066 from NoRedInk/bat/highlighter-aria-roles
Bat/highlighter aria roles
2022-09-09 12:37:28 -03:00
Tessa Kelly
8105ab444e Adds high contrast mode 2022-09-08 16:46:37 -06:00