Commit Graph

4670 Commits

Author SHA1 Message Date
Brian Hicks
c1be619f59
be explicit about node_modules dependency 2018-03-27 21:13:14 -05:00
Brian Hicks
db726c5654
fix typo 2018-03-27 21:13:10 -05:00
Hardy Jones
13f605c58e
Turn off email notifications 2018-03-27 15:13:34 -07:00
Brian Hicks
98188d703e
separate styleguide-app's build 2018-03-27 17:01:08 -05:00
Brian Hicks
85a5157325
replace travis build with a Makefile
very on brand, yes?
2018-03-27 16:58:12 -05:00
Brian Hicks
a9361886f3
set versions with npm 2018-03-27 16:42:26 -05:00
Hardy Jones
fe7d580c5d
Merge commit '832c35b' into HEAD 2018-03-27 14:07:54 -07:00
Hardy Jones
832c35b3f8
Bump version to 3.5.1 2018-03-27 14:02:56 -07:00
Hardy Jones
7024806038
Bump version to 3.5.0 2018-03-27 14:02:16 -07:00
Hardy Jones
fe62d1633b
Merge pull request #17 from NoRedInk/expose-segmented-control-version-two
Expose v2 of segmented control
2018-03-27 13:57:25 -07:00
Hardy Jones
d3b7fe9c2d
Merge branch 'master' into expose-segmented-control-version-two 2018-03-27 13:53:02 -07:00
Hardy Jones
31604bfcce
Merge pull request #15 from NoRedInk/add-tests
Add elm tests
2018-03-27 13:49:53 -07:00
Hardy Jones
ee4343a046
Expose v2 of segmented control 2018-03-27 13:42:40 -07:00
Jasper Woudenberg
49f2f08948 Merge branch 'master' into add-tests 2018-03-27 16:27:52 +02:00
Jasper Woudenberg
c410e61a65 Fix error in .travis.yml
The style-guide compilation test was missing a `--yes` in the `elm-make`
command. As a result, the travis build would hang waiting for user
input.
2018-03-27 16:27:00 +02:00
Jasper Woudenberg
d41b889c2a Enable elm-test in .travis.yml 2018-03-27 16:22:18 +02:00
Jasper Woudenberg
19e58c4c23 Merge branch 'master' into add-tests 2018-03-27 16:21:47 +02:00
Jasper Woudenberg
c20b3b8936
Merge pull request #16 from NoRedInk/add-travis-yaml
Add a .travis.yaml
2018-03-27 16:17:33 +02:00
Jasper Woudenberg
04fb81d2da Add a .travis.yaml
For the most part this is shamelessly lifted from elm-spa-example:

https://github.com/rtfeldman/elm-spa-example/blob/master/.travis.yml

elm-test support is in there, but not yet enabled because we don't have
any tests yet.
2018-03-27 16:13:23 +02:00
Jasper Woudenberg
fd88711766 Add tests for checkbox
These tests are fresh from the monolith.
2018-03-27 15:59:09 +02:00
Jasper Woudenberg
07076cea55
Merge pull request #14 from NoRedInk/segmented-control-styling-fixes
Segmented control styling fixes
2018-03-27 13:47:56 +02:00
Hardy Jones
349e9760a3
Use V2 of the segmented control in the style guide 2018-03-26 19:56:20 -07:00
Hardy Jones
a00262c3aa
Set the backround color directly
The `initial` `background-color` is `transparent`.
We got away with not setting the background color before
as we were always using segmented controls on top of white backgrounds.

We now want to use a segmented control atop a non-white background,
so we have to explicitly set the `background-color`.
2018-03-26 19:53:33 -07:00
Hardy Jones
7ebb488786
Style the tabs directly
tl;dr; Use a class for each variant instead of overriding one variant.

Before, we relied on CSS specificity in an unclear way.
The `Focused` class was applying properly because it was ordered later
than the `Tab` class in the stylesheet.
The ordering that is important is the ordering in `styles` value.
Since `elm-css` generates the stylesheet in the order of the lists,
the `Focused` rule would be generated after the `Tab` rule.
Meaning the `Focused` rule would take precedence over the `Tab` rule
if an element had both classes as it was defined later in the stylesheet.

There are some concerns with this approach:
1. It's not readily apparent that the ordering in `styles` is important.
    It is pretty easy to change the ordering of the list
    and have it break the styling.
2. We rely on `elm-css` to generate the stylesheet in a specific order.
    If it changes the order of rules it generates,
    we're almost surely going to break the styling.
3. Altering styles for tabs that are not focused is even less intuitive.
    Since the specificity is the same,
    you might not know why a given rule applies (or doesn't apply).

Rather, we can eschew the specificity/precedence issues
by applying a different class to each tab.
The stuff that is the same can stay on the `Tab` class,
and the stuff that differs can be on different classes.
2018-03-26 19:53:19 -07:00
Hardy Jones
dd164e3e57
Bump version to 3.4.0 2018-03-26 16:26:36 -07:00
Hardy Jones
c838f4f322
Merge pull request #11 from NoRedInk/add-segmented-control
Add `SegmentedControl`
2018-03-26 16:23:10 -07:00
Richard Feldman
6b71b4378a
Merge pull request #13 from NoRedInk/add-forgotten-module
Add forgotten module
2018-03-26 17:49:22 -04:00
Brooke
25ddfb8e8e bump elm-package to 3.3.0 2018-03-26 14:24:16 -07:00
Brooke
e86fd17d2f add forgotten module to exposed-modules 2018-03-26 14:23:24 -07:00
Brooke
dad9d3e62f
Merge pull request #12 from NoRedInk/add-nri-styled
Add Nri.Ui.styled
2018-03-26 13:59:47 -07:00
Brooke
0297d2fda6 bump elm-package version 2018-03-26 12:39:36 -07:00
Brooke
5147e5c056 add Nri.Ui.styled 2018-03-26 12:08:16 -07:00
Jasper Woudenberg
af6fb30993 Add box-sizing attribute to segmented control
On the monolith we have a base css file somewhere that adds this
property by default. In this package we don't (and even if we did, we
couldn't bundle it with the elm code), so this commit adds the property
manually on a div that needs it.
2018-03-26 10:21:23 +02:00
Hardy Jones
3b99ba56a7
Add SegmentedControl 2018-03-23 19:05:34 -07:00
Tessa
ecf4de663c
Merge pull request #9 from NoRedInk/butteroala__condense-with-nri-elm-css
Butteroala  condense with nri elm css
2018-03-20 10:37:37 -07:00
Tessa Kelly
b4853feb69 MINOR version bump 2018-03-19 15:56:52 -07:00
Tessa Kelly
157d7d8a49 Adds the unused bool back into the Checkbox.V1 2018-03-19 15:56:12 -07:00
Tessa Kelly
e869f064ff Adds new version of the checkbox 2018-03-19 15:55:04 -07:00
Tessa Kelly
8766a17f4d Revert "MAJOR package bump"
This reverts commit b938cfc527.
2018-03-19 15:51:59 -07:00
Tessa Kelly
b938cfc527 MAJOR package bump 2018-03-16 17:33:43 -07:00
Tessa Kelly
af3feeed83 Expose the new modules 2018-03-16 17:33:25 -07:00
Tessa Kelly
98a8a5458c Remove dependency on nri-elm-css 2018-03-16 17:33:24 -07:00
Tessa Kelly
63d7178b32 🐛 fix duplicated package install (not sure how this every worked 😬:) 2018-03-16 17:33:24 -07:00
Tessa Kelly
e7b5d0e878 Nri.Colors -> Nri.Ui.Colors.V1 2018-03-16 17:33:24 -07:00
Tessa Kelly
ef390c606c Nri.Fonts -> Nri.Ui.Fonts.V1 2018-03-16 17:15:03 -07:00
Tessa Kelly
231911b013 Remove Nri.UI.Text dependency on Nri.Stylers 2018-03-16 17:12:55 -07:00
Tessa Kelly
f60277cc8b Remove dependence on Nri.Stylers for the outline 2018-03-16 17:09:37 -07:00
Tessa Kelly
bba1269d5f Remove checkbox dependence on nri stylers 2018-03-16 17:07:07 -07:00
Tessa Kelly
b72b362547 Remove dependency on NRi.Styelrs 2018-03-16 17:04:56 -07:00
Tessa Kelly
319c37caf4 Remove final dependence on Nri.Accessibility
Note: breaking API change. Better to keep the useless bool around..?
2018-03-16 16:53:43 -07:00