NoRedInk/noredink-ui
1
1
Fork 0
mirror of https://github.com/NoRedInk/noredink-ui.git synced 2024-12-19 11:41:32 +03:00
Code Issues Packages Projects Releases Wiki Activity
1,815 Commits 59 Branches 399 Tags 20 MiB
807764fc5d
Commit Graph

47 Commits

Author SHA1 Message Date
Tessa Kelly
807764fc5d Tag assignment icons as svg never 2019-09-30 17:13:00 -07:00
Tessa Kelly
555f876d05 🎨 dry up the icon examples helpers 2019-09-30 17:10:09 -07:00
Tessa Kelly
c971530a76 Update header name 
since we didn't end up deleting the entire assignment icon section, I think it's helpful for the section name to be a bit different
 2019-09-30 16:58:36 -07:00
Renee Tremlab
113a78c0ff Removing deprecated Icon approach from Examples.Icon 2019-09-30 16:47:02 -07:00
Renee Tremlab
7a4bac32de Adds selfReview Icon 2019-09-30 16:46:08 -07:00
Tessa Kelly
5de9ed53dc Adds guided draft 2019-09-30 16:33:44 -07:00
Tessa Kelly
9e681b7080 Adds quickWrite 2019-09-30 16:31:36 -07:00
Renee Tremlab
3d56f7c8c6 Adds quiz icon 2019-09-30 16:28:13 -07:00
Renee Tremlab
b985a6465b Adds practice icon 2019-09-30 16:23:47 -07:00
Tessa Kelly
476545c26d Show peerreview icon and name in the styleguide example 2019-09-30 16:18:37 -07:00
Renee Tremlab
9b21cc0c5a Adds diagnostic SVG directly 2019-09-30 16:07:13 -07:00
Brian Hicks
3935313198 upgrade use of Nri.Ui.Heading.V1 in the style guide 2019-07-23 09:53:43 -05:00
Brian Hicks
9fac5ad438 add Nri.Ui.Text.V4 without headings 2019-07-23 09:09:07 -05:00
Aaron VonderHaar
ce30943436 Add Nri.Ui.Text.V3 2019-06-27 16:03:47 -07:00
Tessa Kelly
04dd20022e Fix missing logo 2019-06-03 16:35:12 -07:00
Tessa Kelly
9ad34d6fd3 Remove the small checkmark and keep the equality sign 2019-06-03 15:43:28 -07:00
Tessa Kelly
372f577bf0 💀 unhelpful and out of date comment 2019-06-03 15:30:25 -07:00
Tessa Kelly
b2b9c215c3 Adds skip to the styleguide 2019-06-03 15:28:24 -07:00
Juan Edi
9619281ba4 Update imports to use new version of Nri.Ui.Icon 2019-05-29 14:20:30 -03:00
Tessa Kelly
2bd5ccb61f filename -> name 2019-05-03 09:56:43 -07:00
Tessa Kelly
8e4bf3c412 Standardize the module example naming 2019-05-03 09:54:34 -07:00
Tessa Kelly
bfa5266a03 Remove/reorg the icons further 2019-05-03 08:53:10 -07:00
Tessa Kelly
01266d82d0 💀 remote the obviously deprecated icons from the styleguide 2019-04-12 11:41:36 -07:00
Tessa Kelly
1015db5e6f 💀 remove the icon checkmarks 2019-04-12 11:33:43 -07:00
Tessa Kelly
4be0a29fc2 Make the svgs with their fill color set up properly green 
this will make it easer to tell which icons on the page are set up right and svgish
 2019-04-12 11:33:43 -07:00
Richard Feldman
e2907d9ba2 Prep for 0.19 dual-publish (#163) 
* Use elm-css 16.0.0

* 💀 Ui.Checkbox V1 and V2

* s/Css.Foreign/Css.Global/g

* 💀 Nri.Ui.Styles.V1

* 💀 BannerAlert.V1

* 💀 Modal.V1

* 💀 Dropdown.V1

* 💀 Select.V1 and V2

* 💀 Alert.V1

* 💀 Button.V1 and V2

* 💀 Divider.V1

* 💀 Icon.V1 and V2

* 💀 Outline.V1

* 💀 SegmentedControl.V1-V5

* 💀 TextArea.V1 and V2

* 💀 TextInput.V1

* delete the rest of the modules

* actually more deletions

* InputStyles v1 is unused

* move to src-0.18

* do the 0.19 upgrade

* select options are addressable by index

* elm-css 16

* update scripts

* elm-format

* Update V2.elm

* put the nbsp back

* elm-format validation for both versions
 2018-11-12 15:38:19 -08:00
Danielle Pham
2fb69ff347 Merge branch 'master' into ink__guided-draft-icon 
Move guided draft icon to Icon V4
 2018-10-29 12:51:12 -04:00
Danielle Pham
0278958762 Icon V4: use SvgIcon for assignment types 2018-10-26 12:49:26 -04:00
Tessa Kelly
fe8a66d772 Use an SVG sprite for the guided draft icon instead of an image 2018-10-24 09:55:35 -07:00
Tessa Kelly
08b67825c0 Adds the guided draft icon 2018-10-24 09:52:42 -07:00
mavnn
e50c15e49f
Add Self Review assignment type icon 
Add self review icon to style guide

Revert "index.html" changes

This reverts commit 7ea91a89fb74f9ce6d6b9e0889b8d5b1c29f6b1a.
 2018-10-24 09:38:58 +01:00
Luke Westby
c1ff19f0d0
Add Html.Styled versions for everything (#139) 
* make html.styled versions of remaining widgets

* upgrade all the examples

* change license name
 2018-10-23 09:55:30 -07:00
Danielle Pham
cabc2fd59e Rearrange icon examples 2018-10-15 17:22:58 -04:00
Danielle Pham
81ca29d946 Add assignmentTypeQuickWrite icon 2018-10-15 17:21:08 -04:00
Danielle Pham
87691d1a6b Add assignmentTypePeerReview icon 2018-10-15 17:15:57 -04:00
James Gary
78c62bbfb9 Add pen icon 2018-08-13 14:41:09 -07:00
Tessa Kelly
3a80a27ee4 Add student assignment actions sectoin 2018-06-22 17:29:18 -07:00
Tessa Kelly
afe0e046eb Expose and use the new Icon module 2018-06-22 11:00:34 -07:00
Tessa Kelly
5cb8d4ceff Use Text module for nicer headings 
:
 2018-06-22 11:00:34 -07:00
Tessa Kelly
0cc0b37509 Update the Icons in the styleguide 2018-06-22 11:00:34 -07:00
Jasper Woudenberg
56685a3019 Use new heading modules over standard h\d elements 
The inclusion of reset.css file nuked the default browser styles for
headers. This change sees us using custom styled headers instead to
bring structure back to the styleguide pages.
 2018-06-22 10:41:38 +01:00
James Gary
37c4d95bc3 Add mastery badge icon 2018-05-11 13:39:15 -07:00
James Gary
a4d3448b47 Add skip icon 2018-04-04 09:34:42 -07:00
Tessa Kelly
eb3d9f038c Adds sumitting, rating, and revising helpers 2018-04-02 17:17:42 -07:00
Tessa Kelly
1d28d9c617 :bowtie: move assignment type icons to the assignment type section 2018-04-02 17:10:32 -07:00
Jasper Woudenberg
6e041d9364 Styleguide uses latest Icon / SegmentedControl 2018-03-29 12:58:41 +02:00
Hardy Jones
0a75e8229b
Extract Nri.Icon from the monolith 
The recommendation is to break the styles API rather than the view API
when moving something out of the monolith into this repo.

`Nri.Icon` is not really setup for that sort of breakage.
If we would prefer to have the styles break rather than the view,
that will take more work.
Work that can be done independent of the extraction.

The transition in the monolith ought to look something like:

```elm
module Nri.Icon exposing (..)

import Html exposing (Html)
import Nri.SvgSprite
import Nri.Ui.Icon.V1 exposing (Assets, IconType)

icon : { alt : String, icon : IconType } -> Html msg
icon config =
  Nri.Ui.Icon.V1.icon assets

assets : Assets {}
assets =
  { activity = Nri.SvgSprite.activity
  , arrowDown = Nri.SvgSprite.arrowDown
  , attention_svg = Nri.Assets.attention_svg
  ...
  }
```

So hopefully, the change is still very small on the monolith side.

There's maybe a bigger concern than which API breaks.
`Nri.Icon` has some behavior for a11y.
We could definitely change the internals over during the extraction.
But, since all of these changes are value-level changes,
it's very likely that we'll break something in the process.
That's a bigger concern because instead of affecting
the handful of Engineers working at NRI,
we would be affecting the millions of people using the site.

We shouldn't fear making those kinds of changes.
However, we should make them when we can give them the appropriate
attention they deserve.
Not when one person is trying to move as fast as possible to avoid
race conditions of moving modules between repos.
 2018-03-28 18:20:16 -07:00