Commit Graph

2709 Commits

Author SHA1 Message Date
Michael Hadley
b907c12d7a Prevent text area with auto resize from jumping scroll position
The old logic looked like this:

```
if (this._textarea.scrollHeight > minHeight) {
  this._textarea.style.height = minHeight + 'px'
  this._textarea.style.height = this._textarea.scrollHeight + 'px'
}
```

Imagine a case where the `minHeight` is actually less than the current
height of the text area due to the current content. The height of the
element would be set to a smaller value, and then later reset to the
desired height. This causes the overall scroll height of the page to
shrink (because the text-area did), and then expand again. Now the
scroll position for the user on the page has changed, and this happens
on every keystroke.

This change just skips the first assignment to `.height`. I'm not sure why it
was initially there, but I can't see a reason for keeping it (especially
since it seems to be the cause of this bug).
2020-03-27 11:34:00 -07:00
Brian Hicks
751db493b9
Merge pull request #480 from NoRedInk/tessa/categories
Tessa/categories
2020-03-24 12:15:59 -05:00
Tessa Kelly
9a41c04a98 Cross-list clickable svg in button category and icon category 2020-03-23 17:49:37 -07:00
Tessa Kelly
5d1fb3c5ba Change category modeling to allow presence in multiple categories 2020-03-23 17:48:53 -07:00
Tessa Kelly
c0953e9354 Install elm-sorter-experiment 2020-03-23 17:40:14 -07:00
Tessa Kelly
75ce281f8a 💀 kill dead code 2020-03-23 17:37:50 -07:00
Tessa Kelly
4371963b0a 💀 remove dead code 2020-03-23 17:36:39 -07:00
Tessa Kelly
cf823c4b8a 🎨 move list of all catgories into Category 2020-03-23 17:35:08 -07:00
Tessa Kelly
2b87eb84df 🎨 Pull Category out into its own module 2020-03-23 17:33:42 -07:00
Tessa Kelly
f4a37acf76 🎨 fold all the styleguide TEA components into one module 2020-03-23 17:25:24 -07:00
Tessa
21c0e639e8
Merge pull request #479 from NoRedInk/tessa/new-icons
Bump
2020-03-23 14:53:26 -07:00
Tessa Kelly
6963ed1f61 Bump 2020-03-23 14:49:37 -07:00
Tessa
27140c8287
Merge pull request #478 from NoRedInk/tessa/update-premium-pennants
Tessa/update premium pennants
2020-03-23 12:17:20 -07:00
Tessa
ce510e3e59
Merge branch 'master' into tessa/update-premium-pennants 2020-03-23 12:03:04 -07:00
Tessa
6ca7a01724
Merge pull request #477 from NoRedInk/tessa/grow-some-trees
Adds sprout, sapling, and tree ui icons
2020-03-23 12:02:54 -07:00
Tessa Kelly
13d2d3ca2a Position the P letters against the same pennant background 2020-03-19 15:35:33 -07:00
Tessa Kelly
b7bd650fdf Adds premiumLock 2020-03-19 15:28:16 -07:00
Tessa Kelly
418c0e5781 Adds disabled flag 2020-03-19 15:23:16 -07:00
Tessa Kelly
afb8b371c7 Adds sprout, sapling, and tree ui icons 2020-03-19 14:51:40 -07:00
Tessa
24b16e3b75
Merge pull request #476 from NoRedInk/tessa/fix-banners
Bump to include firefox banner regression fix
2020-03-18 18:32:46 -07:00
Tessa Kelly
af13ab24e0 Bump 2020-03-18 18:29:35 -07:00
d pham (they/them)
e32386504c
Merge pull request #475 from NoRedInk/fix-banner-firefox
Fix Firefox banner alert alignment
2020-03-18 18:06:25 -04:00
Tessa Kelly
607271281d Fix Firefox banner alert alignment 2020-03-18 13:51:02 -07:00
Tessa
8eca25a267
Merge pull request #474 from NoRedInk/release-premiun-icon-and-customizable-banner
Bump
2020-03-18 09:06:57 -07:00
Tessa Kelly
d19317dea1 Bump 2020-03-18 08:58:43 -07:00
Tessa
0ec5f05b93
Merge pull request #473 from NoRedInk/tessa/add-banner-alert-custom
Tessa/add banner alert custom
2020-03-18 08:57:18 -07:00
Tessa Kelly
a124cb3220 Allow deprecated pennant import for now 2020-03-17 13:43:24 -07:00
Tessa Kelly
beb4bc89b2 Adds example code to the custom view 2020-03-17 13:37:12 -07:00
Tessa Kelly
0b05b192d7 Expect svg to be passed through to the custom banner 2020-03-17 13:36:20 -07:00
Tessa Kelly
d58f49f0c4 Separate the spacing of the icon styles from the icon circle styles 2020-03-17 13:34:14 -07:00
Tessa Kelly
ae787f13dc Use pennant v2 in the banner alert custom example 2020-03-17 13:12:31 -07:00
Tessa Kelly
5c565e1a9b Adds Pennant V2 2020-03-17 12:53:50 -07:00
Tessa Kelly
afd9d1da12 Adds initial version of custom helper 2020-03-17 12:04:13 -07:00
Tessa Kelly
0dc00acba1 Adjust the examples to include example code and to reduce the number of examples 2020-03-17 11:54:33 -07:00
Tessa Kelly
b832b092fd 🎨 have banner take a single configuration record rather than a config and two args 2020-03-17 11:40:31 -07:00
Tessa Kelly
c37fde752a 🎨 remove type alias for configurations and change banner to take icon html instead of an icon config 2020-03-17 11:38:14 -07:00
Tessa Kelly
5463f07e1e Switch to UiIcon icons 2020-03-17 11:34:36 -07:00
Tessa Kelly
46f8eb58c1 💀 remove update script that didn't render well on the package site 2020-03-17 11:28:08 -07:00
Tessa
a803b4b2c4
Merge pull request #472 from NoRedInk/tessa/bump-471
Bump
2020-03-16 11:25:35 -07:00
Tessa Kelly
da54b9afcb Bump 2020-03-16 09:14:18 -07:00
Tessa
39976c84b2
Merge pull request #469 from NoRedInk/tessa/extend-clickable-svg
Adds disabled clickable svg
2020-03-16 09:08:44 -07:00
Tessa Kelly
31b51291ea Doc comment 2020-03-13 14:59:31 -07:00
Tessa Kelly
04923c6d59 Adds disabled clickable svg 2020-03-12 14:42:55 -07:00
Tessa
bcd98df815
Merge pull request #468 from NoRedInk/tessa/upgrade-guided-draft-icons
Tessa/upgrade guided draft icons
2020-03-12 10:19:43 -07:00
Tessa Kelly
67e5923385 Adds keychain 2020-03-12 08:50:37 -07:00
Tessa Kelly
792917a5c5 Adds hat 2020-03-12 08:47:59 -07:00
Tessa
2515fe4d17
Merge pull request #467 from NoRedInk/bump-it
Bump for ClickableSvg
2020-03-11 14:09:49 -07:00
Tessa Kelly
89d94fc219 Bump 2020-03-11 14:05:59 -07:00
d pham (they/them)
26b169696a
Merge pull request #438 from NoRedInk/tessa/add-svg-button
Tessa/add svg button
2020-03-11 17:01:48 -04:00
Tessa Kelly
51f2ee0079 Hover dark on hover 2020-03-10 11:31:14 -07:00