Commit Graph

551 Commits

Author SHA1 Message Date
Juan Edi
d039512615 🎨 don't use extensible record for viewWithTabControls
mostly for consistency with the other use cases. changing it helped me
realize we were passing an extra attribute in a test so that's a good
sign I guess!
2023-09-05 15:09:28 -03:00
Juan Edi
79fced51d0 🎨 tidy up a bit
- hoping to make things more readable by replacing a bunch of booleans with a bunch of custom values.
  - rely on built in attribute rather than custom id to identify the root of the carousel
2023-09-05 15:09:28 -03:00
Juan Edi
2f2c527e86 more consistent carousel names in tests 2023-09-05 15:09:28 -03:00
Juan Edi
6366b1e8b8 fix ensureSlideIsVisible selectors
handing the list of selectors to ensureViewHas directly performs
multiple checks, rather than checking that there is a single element
satisfying all conditions.
2023-09-05 15:09:28 -03:00
Arthur Bernardi Jordão
1d4662feb5
Rename accessibleLabel->name 2023-09-05 12:45:01 -03:00
Arthur Bernardi Jordão
0520d52ff1
Add test for aria label on tab controls 2023-09-05 12:36:19 -03:00
Arthur Bernardi Jordão
4bcdff9e09
Add test for aria label on slides 2023-09-05 12:12:43 -03:00
Arthur Bernardi Jordão
f67f40300f
Add test for the aria labels on carousel container 2023-09-05 11:59:05 -03:00
Juan Edi
f192973511 fix tests 2023-09-05 11:29:51 -03:00
Juan Edi
a3fc5e1bc6 make tabs test helpers types more generic
needed to be used in carousel which requires other additional types of interactions
2023-09-05 10:41:58 -03:00
Juan Edi
c0d51483af selectAndAnnounce -> announceAndSelect
for consistency with Tabs' focusAndSelect
2023-09-05 10:07:27 -03:00
Juan Edi
e5ef6fa5fe standarize on "slide" over "panel"
still using "panel" internally when calling TabsInternal, though!
2023-09-05 09:47:38 -03:00
Juan Edi
7a7eeb7fbf test announcements, as much as we can 2023-09-01 17:58:04 -03:00
Juan Edi
ba6740b7b6 change API from focusAndSelect to selectAndAnnounce
we are now building a brief message for the ATAC. this should provide a
nicer UX for screen reader users and also for keyboard users as focus
isn't changed to the slide content after they press the buttongs.
2023-09-01 17:18:30 -03:00
Juan Edi
09ffe59cf7 decouple prev/next tests from TabsInternal helpers 2023-09-01 17:15:17 -03:00
Juan Edi
234a936597 organize tests by Carousel use case 2023-09-01 17:02:06 -03:00
Juan Edi
5dc122ca9c qualify calls to Spec.TabsInternalHelpers
we'll make it so that the non tabbed use case doesn't rely on that
2023-09-01 16:55:50 -03:00
Juan Edi
d4a2609a42 rename config fields that are not view functions anymore
viewPreviousButton -> previousButton
viewNextButton -> nextButton
2023-09-01 16:27:12 -03:00
Arthur Bernardi Jordão
1be3815769
Add tests for carousel with combined controls 2023-09-01 12:54:07 -03:00
Arthur Bernardi Jordão
3627ca16a7
Add test for carousel with prev/next controls 2023-09-01 12:23:10 -03:00
Arthur Bernardi Jordão
565115df6b
Adapt existing tests to v2 2023-08-31 22:59:23 -03:00
Tessa Kelly
eabe6c9bed Adds explicit tests against the checkbox behavior
note that these tests don't actually fail, because the node that they're testing against is in the DOM
2023-08-22 10:51:46 -06:00
Charbel
7c65f46a8a
Merge pull request #1471 from NoRedInk/highlight-hover-style
A11-3441 Prevent applying hover styles after toggling highlight
2023-08-21 18:03:02 -03:00
charbelrami
29a80f4d7a expose Highlighter.V5 module 2023-08-21 16:44:42 -03:00
charbelrami
8c179dc48e create Highlighter.V5, undo changes in V4 2023-08-21 16:39:47 -03:00
Micah Hahn
384e63828e Add width and alignment properties - flush out example page 2023-08-17 16:37:04 -05:00
Tessa
0d4ce06775
Merge pull request #1460 from NoRedInk/tessa/fix-checkbox-guidance-alignment
🔧 Fix checkbox guidance alignment
2023-08-17 08:52:21 -06:00
Micah Hahn
60fbe3b211 Create Mark.V5 2023-08-16 14:17:01 -05:00
Micah Hahn
73c6f68112 Change characterWidth to widthInChars 2023-08-16 09:13:51 -05:00
Micah Hahn
abfe5f525e Merge branch 'master' into phx-880-support-dynamic-blank-block-widths 2023-08-15 16:25:19 -05:00
Micah Hahn
37b277cb80 Update unit tests 2023-08-15 16:14:48 -05:00
Tessa Kelly
d87a897dc0 Fix test 2023-08-15 10:54:19 -06:00
Tessa Kelly
a885497211 Use Switch.V3 2023-08-15 10:54:19 -06:00
Micah Hahn
b5aa1370a6 Pull word ids from V6 2023-08-15 11:51:21 -05:00
Micah Hahn
c9ec219a6c Cerate Block.V6 2023-08-15 11:18:58 -05:00
Juliano Solanho
242b978fb0
Merge pull request #1459 from NoRedInk/tessa/fix-mark-version
🔧 Fix accidental major version change in Mark, adds Mark.V4
2023-08-14 12:07:03 +00:00
Tessa Kelly
9398718e62 Adds missing describedby relationship 2023-08-10 15:39:56 -06:00
Tessa Kelly
49697b2a34 Merge remote-tracking branch 'origin/master' into hack/tessa/auto-expanded-sidenav 2023-08-10 14:58:21 -06:00
Tessa Kelly
b2b5805a93 Fix accidental major version change in Mark 2023-08-10 12:18:54 -06:00
Tessa Kelly
b433937fc1 Elm review 2023-08-08 11:24:22 -06:00
Tessa Kelly
8e80f09b03 test the focus trap 2023-08-08 11:23:56 -06:00
Tessa Kelly
a581f5d462 Adds focus movement from modal title test 2023-08-08 11:14:34 -06:00
Tessa Kelly
dbbcb85e17 Don't start modal open -- we click to open it in the spec 2023-08-08 11:01:22 -06:00
Tessa Kelly
83c2374623 Set up effect pattern for modal tests 2023-08-08 11:00:43 -06:00
Tessa Kelly
7f536bab5d Prep for release 2023-08-08 10:51:32 -06:00
Tessa Kelly
284306fd1f Adds tests, exposing that the custom attributes aren't appropriately added currently 2023-08-04 16:00:40 -06:00
Tessa Kelly
70a6afafc1 Use SideNav.V5 2023-08-04 10:04:24 -06:00
Tessa
b8fa9f3224
Merge pull request #1441 from NoRedInk/zen/guidance-html
Added guidanceHtml
2023-08-03 16:24:38 -06:00
Charbel
28ade31949
Merge pull request #1432 from NoRedInk/message-v4
A11-3081 Create Message V4
2023-08-03 14:25:27 -03:00
Juan Wajnerman
ac8ddb8597
Added guidanceHtml 2023-08-02 17:22:53 -03:00