Commit Graph

4362 Commits

Author SHA1 Message Date
Ju Liu
d88a371b0e Add elm-review 2022-03-15 17:13:09 +00:00
Tessa
d0a7f520f3
Merge pull request #858 from NoRedInk/tessa/sidebar
Tessa/sidebar
2022-03-11 15:14:31 -08:00
Tessa Kelly
0200502053 Make sure the text doesn't overflow 2022-03-11 14:59:14 -08:00
Tessa Kelly
bcf5b113d0 Fix fixed height on sidebar nav elements 2022-03-11 14:58:01 -08:00
Tessa Kelly
a7590e7141 Fix ci 2022-03-11 14:48:11 -08:00
Tessa
1eae9f4796
Merge pull request #855 from NoRedInk/fix-premium-checkbox-locked-clicks
Fix premium checkbox locked clicks
2022-03-11 14:22:36 -08:00
Tessa Kelly
b007959cb9 Fix generated code 2022-03-11 13:54:18 -08:00
Tessa Kelly
95f2b11f46 Adds premium pennant 2022-03-11 13:50:35 -08:00
Tessa Kelly
30117e65cd Use strings for the routes 2022-03-11 13:47:03 -08:00
Tessa Kelly
62fc8e3dcb Adds secondary theme 2022-03-11 13:40:06 -08:00
Tessa Kelly
550e7b0e0e Adds icon 2022-03-11 13:37:44 -08:00
Tessa Kelly
07f31b4f6e Adds sidenav css 2022-03-11 13:35:57 -08:00
Brian J. Cardiff
354c77e3f1 Improove onLockedClick behavior to detect clicks any place
and not just pennant.

Similar to what we aim on PremiumCheckbox
2022-03-11 15:34:11 -03:00
Brian J. Cardiff
809d7e463a RadioButton: Rename onLockedPennantClick to onLockedClick 2022-03-11 14:55:42 -03:00
Brian J. Cardiff
6d12ed0821 Extend examples to cover unlocked and disabled better 2022-03-11 14:47:38 -03:00
Brian J. Cardiff
1cc2127883 PremiumCheckbox.V8: Rename and fix showPennant to onLockedClick 2022-03-11 14:39:15 -03:00
Tessa
b2853e62f0
Merge pull request #854 from NoRedInk/premium-checkbox-id
Allow setting custom ID attribute on PremiumCheckbox
2022-03-11 09:18:04 -08:00
Celso Bonutti
3480986bf5 formats 'PremiumCheckbox.V8' 2022-03-11 10:56:04 -03:00
Celso Bonutti
f24b2283ac adds 'id' to PremiumCheckbox.v8 docs 2022-03-11 10:11:59 -03:00
Celso Bonutti
36fd725752 formats 'PremiumCheckbox.V8' 2022-03-11 10:06:47 -03:00
Casey Webb
1844d0cc04
Allow setting custom ID property on PremiumCheckbox
Note, this fixes a regression introduced V6 -> V7
2022-03-11 00:33:03 -06:00
Tessa Kelly
72d4087fb1 Recursion makes the ui too bad. Give up and proceed with other features 2022-03-10 19:11:38 -08:00
Tessa Kelly
ef530533e3 Adds listItems helper 2022-03-10 18:01:47 -08:00
Tessa Kelly
0534c35a17 Implement dynamic list
because of how debug.controls renders records, this implementation artificially indents. This should be fixed in order to make the controls actually usable
2022-03-10 17:13:39 -08:00
Tessa Kelly
ee0e46f06d Start outlining the sidenav example 2022-03-10 16:36:59 -08:00
Tessa Kelly
e514dcf173 Adds little minit preview 2022-03-10 15:53:50 -08:00
Tessa Kelly
5656e9e595 Adds SideNav example 2022-03-10 15:42:13 -08:00
Tessa
7ee0ef1fba
Merge pull request #853 from NoRedInk/tessa/shadows
Adds Shadows
2022-03-10 13:01:24 -08:00
Brian J. Cardiff
24fbceebc8
Merge pull request #850 from NoRedInk/growth/premium-display
Introduces PremiumDisplay
2022-03-10 16:41:48 -03:00
Celso Bonutti
738e45a9d4 formats CommonControls 2022-03-10 16:18:14 -03:00
Celso Bonutti
a521c09ee0 Merge branch 'master' into growth/premium-display 2022-03-10 16:09:41 -03:00
Brian J. Cardiff
dce31c6a14
Merge pull request #852 from NoRedInk/tessa/media-support-3
Tessa/media support 3
2022-03-10 15:27:58 -03:00
Tessa Kelly
4c2076cd27 Adds Shadows 2022-03-10 08:53:28 -08:00
Tessa Kelly
e35672e4aa Merge remote-tracking branch 'origin/master' into tessa/media-support-3 2022-03-10 08:14:42 -08:00
Tessa
abd0c584f0
Merge pull request #851 from NoRedInk/bressa/media-support-2
Bressa/media support 2
2022-03-10 08:11:21 -08:00
Tessa
5b3f8b7f01
Merge pull request #849 from NoRedInk/tessa/media-support
Tessa/media support
2022-03-10 08:09:36 -08:00
Brian J. Cardiff
e8c30bc4e8 Rename onPennantClick to onLockedPennantClick
Make the unlocked pennant not clickable
Update changes from V3
2022-03-10 11:30:21 -03:00
Celso Bonutti
6a978cb762 updates RadioButton example controls 2022-03-10 11:06:40 -03:00
Celso Bonutti
2f1227634c don't use ClickableSvg for non-clickable pennant 2022-03-10 11:06:24 -03:00
Celso Bonutti
df0bde0077 Merge branch 'growth/premium-display' of github.com:NoRedInk/noredink-ui into growth/premium-display 2022-03-10 10:43:25 -03:00
Celso Bonutti
8a92d905a0 always show Premium Pennant on Premium-content RadioButton 2022-03-10 10:35:40 -03:00
Tessa Kelly
2be5eed9cd Use value directly rather than threading bool through 2022-03-09 17:18:15 -08:00
Tessa Kelly
a761c9c404 Remove brittle css parsing to simplify example code 2022-03-09 17:16:13 -08:00
Tessa Kelly
ff290dd7e2 Use common controls for text 2022-03-09 15:59:41 -08:00
Tessa Kelly
e097368032 Fix the selector for the icon so that icons don't accidentally disappear 2022-03-09 15:48:50 -08:00
Tessa Kelly
2e31f2c4d1 Hide the icon background for mobile 2022-03-09 15:32:40 -08:00
Tessa Kelly
3e75b090c8 WIP 2022-03-09 15:30:50 -08:00
Tessa Kelly
e47373b8b6 Highlight the child icon issue 2022-03-09 15:30:50 -08:00
Tessa Kelly
622ae05ea4 Adds example use of hideIconForMobile
coupla problems left:
- add example icon in the html, and make sure these icons aren't hidden
- hide the circle for the banner icons
2022-03-09 15:30:50 -08:00
Tessa Kelly
b84f306cfd Adds css breakpoint helper examples 2022-03-09 15:30:50 -08:00