Commit Graph

5056 Commits

Author SHA1 Message Date
Tessa
5d3ad438aa
Merge pull request #973 from NoRedInk/growth/menu-containsForm
Add Menu.containsForm
2022-07-11 10:26:21 -07:00
Tessa
a479276106
Merge pull request #981 from NoRedInk/bat/temp-revert
Revert "Merge pull request #979 from NoRedInk/bat/svgs"
2022-07-11 10:23:47 -07:00
Tessa Kelly
da57bb4bbc Revert "Merge pull request #979 from NoRedInk/bat/svgs"
This reverts commit f4fbe9d283, reversing
changes made to c2b5300e5f.
2022-07-11 10:18:08 -07:00
Mandla
f4fbe9d283
Merge pull request #979 from NoRedInk/bat/svgs
Use svg titles rather than aria-label
2022-07-11 15:41:33 +01:00
Brian J. Cardiff
b2d09b237c Add docs 2022-07-11 11:22:51 -03:00
Brian J. Cardiff
cc614340bc Add tests 2022-07-11 11:10:31 -03:00
Brian J. Cardiff
ae3b259d25 Fix esc handing: use a single keydown 2022-07-11 10:50:36 -03:00
Brian J. Cardiff
35dbf0bd93 Add WhenFocusLeaves.toDecoder for better composability
Use normal event Decoder msg instead of custom event decoder. We were using normal behaviour {preventDefault = False , stopPropagation = False}
2022-07-11 10:49:37 -03:00
Tessa Kelly
3aed554cc9 remove aria-label 2022-07-08 19:44:07 -07:00
Tessa Kelly
831d885b7f fix ci 2022-07-08 19:39:38 -07:00
Tessa Kelly
71fff82add Expose example helper from icon examples 2022-07-08 19:34:28 -07:00
Tessa Kelly
151ba0a9d5 Paramaterize the gened code 2022-07-08 19:17:34 -07:00
Tessa Kelly
795b01e3b9 Apply example pattern 2022-07-08 19:13:47 -07:00
Tessa Kelly
9d821061d5 Add example usage to assignment icons 2022-07-08 18:52:07 -07:00
Tessa Kelly
3ba4cf51f6 By default, prevent any shrinkage of svgs 2022-07-08 18:42:31 -07:00
Tessa Kelly
92bbd369e0 Add a border setting to svg example 2022-07-08 18:42:31 -07:00
Tessa Kelly
3697b756dd Reorder the settings and use a better example 2022-07-08 18:42:31 -07:00
Tessa Kelly
07f4025d50 Follow the uiicon pattern in assignment icon 2022-07-08 18:42:31 -07:00
Tessa Kelly
e17fffad52 Use Select instead of Menu for icon selector 2022-07-08 18:42:31 -07:00
Tessa Kelly
2ff116155e Fix current color implementation 2022-07-08 18:42:31 -07:00
Tessa Kelly
b584b3a916 Make a color mistake in SVG apparent 2022-07-08 18:42:31 -07:00
Tessa Kelly
586d53c423 Refactor examples so that the organized list of uiicons is available 2022-07-08 18:42:31 -07:00
Tessa Kelly
931e66bc8f 💀 remove old spritesheet 2022-07-08 18:42:31 -07:00
Tessa Kelly
ca6328f562 Use title to attach info 2022-07-08 18:42:31 -07:00
Tessa Kelly
d4b9aeb505 Use new API 2022-07-08 18:42:31 -07:00
Tessa Kelly
60d39c8ca3 Aggressively remove the container div
Converting to use the new API remains
2022-07-08 18:42:31 -07:00
Tessa Kelly
f1ba22f6b6 Generalize the docs 2022-07-08 18:42:31 -07:00
Tessa Kelly
5983e10cc9 Remove withNriDescription 2022-07-08 18:42:31 -07:00
Tessa Kelly
917f775131 💀 remove toRawSvg 2022-07-08 18:42:31 -07:00
Brian J. Cardiff
d45bca0a4f Appease formatter 2022-07-08 17:26:58 -03:00
Brian J. Cardiff
e06981b198 Drop role="menu" when Menu.disclosure 2022-07-08 17:12:28 -03:00
Brian J. Cardiff
41a318d6f9
Update src/Nri/Ui/Menu/V3.elm
Co-authored-by: Tessa <tesk9@users.noreply.github.com>
2022-07-08 17:04:49 -03:00
Brian J. Cardiff
c2b5300e5f
Merge pull request #978 from NoRedInk/add-school-category-icons
Add school category icons
2022-07-08 15:54:57 -03:00
Luiz Carlos L. G. de Oliveira
e5d3ab88ff
Merge pull request #977 from NoRedInk/que-202-a11y-defect-131-view-answers-01
Remove id from SVGs
2022-07-08 18:18:38 +00:00
Brian J. Cardiff
ed06e5a929 Merge branch 'master' into growth/menu-containsForm 2022-07-08 15:18:32 -03:00
Brian J. Cardiff
8ceb7b8e1a Make lastId required for disclosure 2022-07-08 15:18:15 -03:00
Brian J. Cardiff
97ead64d23 Make close after the last element is tabbed out 2022-07-08 15:16:37 -03:00
Brian J. Cardiff
7a2c284eac Update key bindings for disclosure 2022-07-08 15:06:47 -03:00
Brian J. Cardiff
dbf1d2c448 Comply with aria attributes for disclosure 2022-07-08 15:01:17 -03:00
Brian J. Cardiff
1722204874 Change api to use lastId. Revert change of behaviour for now
Fix examples with control to be disclosure
2022-07-08 14:57:40 -03:00
Brian J. Cardiff
b8c04eeef5 Update api to Menu.disclosure 2022-07-08 14:48:33 -03:00
Brian J. Cardiff
88074d1150 Fix missing currentcolor 2022-07-08 14:19:55 -03:00
Brian J. Cardiff
dc3da6d594 Drop ids on new icons 2022-07-08 12:32:01 -03:00
Brian J. Cardiff
878901d359 Fix docs comment 2022-07-08 11:55:22 -03:00
Brian J. Cardiff
3dffe35248 Fix missing currentcolor 2022-07-08 11:24:33 -03:00
Brian J. Cardiff
85e3e7f7af Add new icons 2022-07-08 11:23:35 -03:00
Juliano Solanho
e9acb582f9 Bump version 2022-07-07 19:58:41 -03:00
Juliano Solanho
480cce00c9 Remove id from SVGs
WCAG automated checkers complain about these when we have the same image
more than once in a page
2022-07-07 19:53:02 -03:00
Brian J. Cardiff
0a51e865fb
Merge pull request #857 from NoRedInk/add-button-ternary 2022-07-07 18:42:09 -03:00
Tessa
d88a914b5d
Merge pull request #976 from NoRedInk/dansby/slow-caret
Change transition time of menu caret
2022-07-07 14:25:37 -07:00