1024: Resolves A11-1254, A11-1235, and A11-1277: remove roving tabindex and `aria-hidden` from tab panels, add a fixed `tabindex="0"` r=charbelrami a=charbelrami
Roving tabindex is not necessary on the panels. Panels with `display: none` are not focusable even with `tabindex="0"`. Added a fixed `tabindex="0"` to all panels to ensure they are focusable even when there are no focusable descendants.
Co-authored-by: charbelrami <charbel.f.rami@gmail.com>
1021: Adds disabled and loading attributes/config r=erik-nri a=erik-nri
This implements similar attributes to how it is being done over in
TextInput.
### Motivation
For hackday I was updating the sign up with email form and adding the disabled / loading attributes for the TextInputs. I noticed that the Select did not have similar functionality and thought it might be worth adding 😄.
One odd thing to note, when adding the fields to the examples app, I noticed that I needed to flip the order in the list of the select input and its label. If I did not the styles did not work out for some reason. I was pairing with `@charbelrami` at the time and we decided to hold off on spending a bunch of time trying to figure out why this was happening.
This update only incurs a minor change!
Co-authored-by: Erik Feeley <erikfeeley@eriks-mbp.turkey-snapper.ts.net>
Co-authored-by: Erik Feeley <erik@noredink.com>
1014: A11-1247 add `role="switch"` to Switch checkbox r=charbelrami a=charbelrami
Makes the SR interpret the Switch checkbox input as a switch (on/off as opposed to checked/unchecked)
<img width="704" alt="Screen Shot 2022-08-04 at 17 37 54" src="https://user-images.githubusercontent.com/5647344/182948116-d8b739e1-aa95-4582-a63d-dd0d2364f928.png">
Co-authored-by: charbelrami <charbel.f.rami@gmail.com>
Co-authored-by: Tessa Kelly <tessakkelly@gmail.com>
1015: A11-1241 remove `aria-hidden` from Menu r=tesk9 a=charbelrami
removes `aria-hidden` from the menu because we already have `display: none`
Co-authored-by: charbelrami <charbel.f.rami@gmail.com>
1013: ask Bors to check the tests r=caiquefigueiredo a=BrianHicks
This sets up Bors, which will automatically merge PRs that pass all the checks. It works like Homu did, but batches PRs into bigger groups for efficiency's sake.
Once this merges, you can talk to it the same way we do `@NoRedInkBot` in the monorepo, except we call it "duet" instead (for now... we just don't want to cause a conflict with two merge robots running on the same triggers!) So for example, `duet r+` will add the PR to the merge batch, `duet r-` will remove it, et cetera.
Fixes FXN-1289
Co-authored-by: Brian Hicks <brian@brianthicks.com>
