NoRedInk/noredink-ui
1
1
Fork 0
mirror of https://github.com/NoRedInk/noredink-ui.git synced 2024-12-25 06:33:09 +03:00
Code Issues Packages Projects Releases Wiki Activity
Component Library package & Component Catalog app code
1,459 Commits 59 Branches 399 Tags 20 MiB
Elm 95.7%
Nix 2.7%
JavaScript 0.7%
Shell 0.3%
Haskell 0.3%
Other 0.2%
b1d44c054f
Go to file
Tessa Kelly b1d44c054f 🎨 avoid passing along a function with lots of arguments
2019-06-18 09:00:01 -07:00
docs Reviews go through Teambot 2018-10-16 10:40:20 +01:00
lib Export CustomElement 2019-01-16 17:44:22 -08:00
script Remove elm-package checks 2019-05-22 13:48:51 -07:00
src Use a type alias to describe the focusable elements 2019-06-18 08:54:20 -07:00
styleguide-app 🎨 avoid passing along a function with lots of arguments 2019-06-18 09:00:01 -07:00
tests/Spec/Nri/Ui add select v6 tests 2019-05-17 15:38:47 -07:00
.envrc.nix use absolute path for node binaries 2019-02-14 10:12:31 +01:00
.gitattributes Only store images in git lfs 2018-05-04 13:44:30 +02:00
.gitignore build public 2019-04-01 09:26:15 -05:00
.npmignore Updates to TextArea (#70) 2018-06-11 11:08:49 -07:00
.travis.yml Use node 10 for now on CI 2019-05-02 16:44:31 -07:00
elm.json Apply dissmissibility fix 2019-06-12 11:20:44 -07:00
LICENSE Initial commit 2017-11-14 16:24:25 -08:00
Makefile call it develop instead of watch 2019-04-02 15:54:10 -05:00
netlify.toml fix key name in netlify.toml 2019-04-03 05:56:38 -05:00
package-lock.json remove clipboard 2019-04-02 15:32:31 -05:00
package.json remove clipboard 2019-04-02 15:32:31 -05:00
README.md 💀 remove dual publishing notes 2019-05-22 13:40:21 -07:00
shell.nix add entr 2019-04-02 15:07:26 -05:00

README.md

noredink-ui

UI widgets we use.

Versioning policy

We try to avoid breaking changes and the associated major version bumps in this package. The reason for that is to avoid the following scenario:

  |
  x   4.6.0: Adding RadioButton widget
  |
  x   5.0.0: Breaking change in the TextArea widget
  |
  x   5.0.1: Styling fix in the Checkbox widget
  |

Suppose you just released version 5.0.1, a small styling fix in the checkbox widget, for a story you're working on. If the project you're working in currently pulls in noredink-ui at version 4.x, then getting to your styling fix means pulling in a new major version of noredink-ui. This breaks all TextArea widgets across the project, so those will need to be fixed before you can do anything else, potentially a big effort.

To prevent these big Yaks from suddenly showing up in seemingly trivial tasks we prefer to avoid breaking changes in the package. Instead when we need to make a breaking change in a widget, we create a new module for it Nri.Ui.MyWidget.VX. Similarly, when we build custom elements in JavaScript we create a file lib/MyWidget/VX.js and define a custom element nri-mywidget-vX.

We should change this process if we feel it's not working for us!

Moving Widgets to noredink-ui

If you are moving in a widget from the monolith:

  • Copy the contents of Nri.SomeModule and its tests to Nri.Ui.SomeModule.V1 in noredink-ui
  • Publish!
  • If Nri.Ui.SomeModule.V1 is a direct copy of Nri.SomeModule, switch over to it everywhere!
  • If Nri.Ui.SomeModule.V1 makes changes, rename Nri.SomeModule to Nri.DEPRECATEDSomeModule in the monolith and start using Nri.Ui.SomeModule.V1 where you need it

Phasing out old versions

Our goal is to gradually move to the newest version of each widget, and remove the old versions when they are no longer used.

Currently, noredink-ui is used by the monolith and by CCS. When neither of these repos use a version of a widget, it can be deleted. (Note: this will be a major version bump, so you may want to batch deletions together.)

When touching code that uses a widget, prefer upgrading to the latest version.

Examples

This repo contains an app showcasing all of these UI widgets.

To see them locally:

script/develop.sh

If you'd like to test your widget in the monolith before publishing, run script/test-elm-package.py ../path_to_this_repo from the monolith's directory.

Tests

Run tests with

make test

CI (Travis)

Travis will run make ci to verify everything looks good. You can run this locally to catch errors before you push!

Deploying

Once your PR is merged, you can publish master as a new version:

Run the following to bump && publish the version in elm.json:

elm bump

Commit and push your changes in a PR. Once it's approved and merged, then:

git tag -a 5.10.0 -m "release version 5.10.0"
git push origin 5.10.0
elm publish

You can also add a tag in https://github.com/NoRedInk/noredink-ui/releases/new if you want to add more detail.

Once you've published, you should see the latest version at https://package.elm-lang.org/packages/NoRedInk/noredink-ui/.