integer min tests fixed

compiler/compiler/src/test.rs

@@ -14,7 +14,6 @@
 // You should have received a copy of the GNU General Public License
 // along with the Leo library. If not, see <https://www.gnu.org/licenses/>.
 
-
 use crate::{Compiler, OutputOptions};
 
 use leo_errors::{
@@ -26,10 +25,11 @@ use leo_test_framework::{
     runner::{Namespace, ParseType, Runner},
     Test,
 };
-use snarkvm::prelude::*;
 use snarkvm::file::Manifest;
 use snarkvm::package::Package;
+use snarkvm::prelude::*;
 
+use leo_passes::{CodeGenerator, Pass};
 use serde::{Deserialize, Serialize};
 use serde_yaml::Value;
 use std::{
@@ -39,7 +39,6 @@ use std::{
     rc::Rc,
 };
 use std::{fs::File, io::Write};
-use leo_passes::{CodeGenerator, Pass};
 
 type CurrentNetwork = Testnet3;
 
@@ -153,7 +152,7 @@ enum LeoOrString {
 impl Display for LeoOrString {
     fn fmt(&self, f: &mut Formatter<'_>) -> fmt::Result {
         match self {
-            Self::Leo(x) => std::fmt::Display::fmt(&x,f),
+            Self::Leo(x) => std::fmt::Display::fmt(&x, f),
             Self::String(x) => std::fmt::Display::fmt(&x, f),
         }
     }
@@ -186,7 +185,9 @@ fn buffer_if_err<T>(buf: &BufferEmitter, res: Result<T, String>) -> Result<T, ()
 }
 
 fn temp_dir() -> PathBuf {
-    tempfile::tempdir().expect("Failed to open temporary directory").into_path()
+    tempfile::tempdir()
+        .expect("Failed to open temporary directory")
+        .into_path()
 }
 
 fn compile_and_process<'a>(parsed: &'a mut Compiler<'a>, handler: &Handler) -> Result<String, LeoError> {
@@ -261,10 +262,10 @@ fn run_test(test: Test, handler: &Handler, err_buf: &BufferEmitter) -> Result<Va
         std::fs::create_dir_all(&build_directory).unwrap();
 
         // Open the package at the temporary directory.
-        let package = Package::<Testnet3>::open(&directory).unwrap();
+        let package = handler.extend_if_error(Package::<Testnet3>::open(&directory).map_err(LeoError::Anyhow))?;
 
         // Get the program process and check all instructions.
-        package.get_process().unwrap();
+        handler.extend_if_error(package.get_process().map_err(LeoError::Anyhow))?;
     }
 
     let initial_ast = hash_file("/tmp/output/initial_ast.json");

tests/compiler/input_files/program_input_constants/inputs/main.in

@@ -1,8 +0,0 @@
-[main]
-b: bool = true;
-
-[constants]
-a: bool = true;
-
-[registers]
-r0: bool = true;

tests/compiler/input_files/program_input_constants/inputs/main_array.in

@@ -1,8 +0,0 @@
-[main]
-y: bool = true;
-
-[constants]
-x: [i16; 1] = [0i16; 1];
-
-[registers]
-r0: bool = true;

tests/compiler/input_files/program_input_constants/inputs/main_array_fail.in

@@ -1,2 +0,0 @@
-[constants]
-x: [i16; 1] = [0i16; 1];

tests/compiler/input_files/program_input_constants/inputs/main_char.in

@@ -1,8 +0,0 @@
-[main]
-y: bool = true;
-
-[constants]
-a: char = '👍';
-
-[registers]
-r0: bool = true;

tests/compiler/input_files/program_input_constants/inputs/main_fail_name.in

@@ -1,2 +0,0 @@
-[constants]
-bad_name: bool = true;

tests/compiler/input_files/program_input_constants/inputs/main_fail_type.in

@@ -1,2 +0,0 @@
-[constants]
-a: u8 = 1;

tests/compiler/input_files/program_input_constants/inputs/main_field.in

@@ -1,9 +0,0 @@
-[main]
-y: bool = true;
-
-[constants]
-a: field = 1field;
-b: field = -1field;
-
-[registers]
-r0: bool = true;

tests/compiler/input_files/program_input_constants/inputs/main_group.in

@@ -1,10 +0,0 @@
-[main]
-y: bool = true;
-
-[constants]
-a: group = 1group;
-b: group = -1group;
-c: group = (0, -1)group;
-
-[registers]
-r0: bool = true;

tests/compiler/input_files/program_input_constants/inputs/main_multi_dimension_array.in

@@ -1,8 +0,0 @@
-[main]
-y: [i16; (2, 2, 3)] = [0i16; (2, 2, 3)];
-
-[constants]
-x: [i16; (2, 2, 3)] = [0i16; (2, 2, 3)];
-
-[registers]
-r0: bool = true;

tests/compiler/input_files/program_input_constants/inputs/main_multiple.in

@@ -1,9 +0,0 @@
-[main]
-y: bool = true;
-
-[constants]
-a: bool = true;
-b: bool = false;
-
-[registers]
-r0: bool = true;

tests/compiler/input_files/program_input_constants/inputs/main_string.in

@@ -1,8 +0,0 @@
-[main]
-y: bool = true;
-
-[constants]
-a: [char; 5] = "😭😂👍😁😘";
-
-[registers]
-r0: bool = true;

tests/compiler/input_files/program_input_constants/inputs/main_tuple.in

@@ -1,8 +0,0 @@
-[main]
-y: bool = true;
-
-[constants]
-x: (u8, bool, u8) = (10, true, 10);
-
-[registers]
-r0: bool = true;

tests/compiler/input_files/program_input_constants/inputs/main_tuple_fail.in

@@ -1,2 +0,0 @@
-[constants]
-x: (u8, bool) = (10, true); // wrong size here; main expects (u8, bool, u8)

tests/compiler/input_files/program_input_constants/main.leo

@@ -1,9 +0,0 @@
-/*
-namespace: Compile
-expectation: Pass
-input_file: inputs/main.in
-*/
-
-function main(const a: bool, b: bool) -> bool {
-    return (a == true) == b;
-}

tests/compiler/input_files/program_input_constants/main_field.leo

@@ -1,9 +0,0 @@
-/*
-namespace: Compile
-expectation: Pass
-input_file: inputs/main_field.in
-*/
-
-function main(const a: field, const b: field, y: bool) -> bool {
-    return y == true && a == b;
-}

tests/compiler/input_files/program_input_constants/main_group.leo

@@ -1,14 +0,0 @@
-/*
-namespace: Compile
-expectation: Pass
-input_file: inputs/main_group.in
-*/
-
-function main(const a: group, const b: group, const c: group, y: bool) -> bool {
-    // Change to assert when == is implemented for group.
-    console.log("a: {}", a);
-    console.log("b: {}", b);
-    console.log("c: {}", c);
-
-    return y == true;
-}

tests/compiler/input_files/program_input_constants/main_multiple.leo

@@ -1,9 +0,0 @@
-/*
-namespace: Compile
-expectation: Pass
-input_file: inputs/main_multiple.in
-*/
-
-function main(const a: bool, const b: bool, y: bool) -> bool {
-    return (a != b) == y;
-}

tests/compiler/integers/i128/min.leo

@@ -6,5 +6,5 @@ input_file: inputs/add.in
 
 function main(a: i128) -> i128 {
     let b: i128 = -170141183460469231731687303715884105727i128;
-    return a + b;
+    return b - a; // -170141183460469231731687303715884105728i128
 }

tests/compiler/integers/i128/min_fail.leo

@@ -3,6 +3,8 @@ namespace: Compile
 expectation: Fail
 */
 
-function main() {
+function main() -> i128 {
-    const a: i128 = -170141183460469231731687303715884105728i128;
+    let a: i128 = -170141183460469231731687303715884105727i128;
+
+    return a - 2i128; // This line attempts to return --170141183460469231731687303715884105729i128 however, the smallest i128 value is -170141183460469231731687303715884105728i128.
 }

tests/compiler/integers/i128/negate_min.leo

@@ -1,11 +0,0 @@
-/*
-namespace: Compile
-expectation: Pass
-input_file: ../inputs/dummy.in
-*/
-
-function main(y: bool) -> bool{
-    const a: i128 = -170141183460469231731687303715884105728i128;
-    const b: i128 = -a;
-    return (b == -a) == y;
-}

tests/compiler/integers/i128/negate_min_fail.leo

@@ -0,0 +1,12 @@
+/*
+namespace: Compile
+expectation: Fail
+input_file: ../inputs/dummy.in
+*/
+
+function main() -> i128 {
+    let a: i128 = -170141183460469231731687303715884105727i128;
+    let b: i128 = a - 1i128;
+
+    return -b; // This line attempts to return 170141183460469231731687303715884105728i128 however, the largest i128 value is 170141183460469231731687303715884105727i128.
+}

tests/compiler/integers/i16/min.leo

@@ -6,5 +6,5 @@ input_file: inputs/add.in
 
 function main(a: i16) -> i16 {
     let b: i16 = -32767i16;
-    return a + b;
+    return b - a; // -32768i16
 }

tests/compiler/integers/i16/min_fail.leo

@@ -3,6 +3,8 @@ namespace: Compile
 expectation: Fail
 */
 
-function main() {
+function main() -> i16 {
-    const a: i16 = -32768i16;
+    let a: i16 = -32767i16;
+
+    return a - 2i16; // This line attempts to return -32769i16 however, the smallest i16 value is -32768i16.
 }

tests/compiler/integers/i16/negate_min_fail.leo

@@ -1,11 +1,12 @@
 /*
 namespace: Compile
-expectation: Pass
+expectation: Fail
 input_file: ../inputs/dummy.in
 */
 
-function main(y: bool) -> bool {
+function main() -> i16 {
-    const a: i16 = -32768i16;
+    let a: i16 = -32767i16;
-    const b: i16 = -a;
+    let b: i16 = a - 1i16;
-    return (b == -a) == y;
+
+    return -b; // This line attempts to return 32768i16 however, the largest i16 value is 32767i16.
 }

tests/compiler/integers/i32/min.leo

@@ -6,5 +6,5 @@ input_file: inputs/add.in
 
 function main(a: i32) -> i32 {
     let b: i32 = -2147483647i32;
-    return a + b;
+    return b - a; // -2147483648i32
 }

tests/compiler/integers/i32/min_fail.leo

@@ -3,6 +3,8 @@ namespace: Compile
 expectation: Fail
 */
 
-function main() {
+function main() -> i32 {
-    const a: i32 = -2147483648i32;
+    let a: i32 = -2147483647i32;
+
+    return a - 2i32; // This line attempts to return -2147483649i32 however, the smallest i32 value is -2147483648i32.
 }

tests/compiler/integers/i32/negate_min.leo

@@ -1,11 +0,0 @@
-/*
-namespace: Compile
-expectation: Pass
-input_file: ../inputs/dummy.in
-*/
-
-function main(y: bool) -> bool{
-    const a: i32 = -2147483648i32;
-    const b: i32 = -a;
-    return (b == -a) == y;
-}

tests/compiler/integers/i32/negate_min_fail.leo

@@ -0,0 +1,12 @@
+/*
+namespace: Compile
+expectation: Fail
+input_file: ../inputs/dummy.in
+*/
+
+function main() -> i32 {
+    let a: i32 = -2147483647i32;
+    let b: i32 = a - 1i32;
+
+    return -b; // This line attempts to return 2147483648i32 however, the largest i32 value is 2147483647i32.
+}

tests/compiler/integers/i64/min.leo

@@ -6,5 +6,5 @@ input_file: inputs/add.in
 
 function main(a: i64) -> i64 {
     let b: i64 = -9223372036854775807i64;
-    return a + b;
+    return b - a; // -9223372036854775808i64
 }

tests/compiler/integers/i64/min_fail.leo

@@ -3,6 +3,8 @@ namespace: Compile
 expectation: Fail
 */
 
-function main() {
+function main() -> i64 {
-    const a: i64 = -9223372036854775808i64;
+    let a: i64 = -9223372036854775807i64;
+
+    return a - 2i64; // This line attempts to return -9223372036854775809i64 however, the smallest i64 value is -9223372036854775808i64.
 }

tests/compiler/integers/i64/negate_min.leo

@@ -1,11 +0,0 @@
-/*
-namespace: Compile
-expectation: Pass
-input_file: ../inputs/dummy.in
-*/
-
-function main(y: bool) -> bool{
-    const a: i64 = -9223372036854775808i64;
-    const b: i64 = -a;
-    return (b == -a) == y;
-}

tests/compiler/integers/i64/negate_min_fail.leo

@@ -0,0 +1,12 @@
+/*
+namespace: Compile
+expectation: Fail
+input_file: ../inputs/dummy.in
+*/
+
+function main() -> i64 {
+    let a: i64 = -9223372036854775807i64;
+    let b: i64 = a - 1i64;
+
+    return -b; // This line attempts to return 9223372036854775808i64 however, the largest i64 value is 9223372036854775807i64.
+}

tests/compiler/integers/i8/min.leo

@@ -7,5 +7,5 @@ input_file: inputs/add.in
 function main(a: i8) -> i8 {
     let b: i8 = -127i8;
 
-    return a + b;
+    return b - a; // -128i8
 }

tests/compiler/integers/i8/min_fail.leo

@@ -3,6 +3,8 @@ namespace: Compile
 expectation: Fail
 */
 
-function main() {
+function main() -> i8 {
-    const a: i8 = -128i8;
+    let a: i8 = -127i8;
+
+    return a - 2i8; // This line attempts to return -129i8 however, the smallest i8 value is -128i8.
 }

tests/compiler/integers/i8/negate_min.leo

@@ -1,12 +0,0 @@
-/*
-namespace: Compile
-expectation: Pass
-input_file: ../inputs/dummy.in
-*/
-
-function main(y: bool) -> bool {
-    const a: i8 = -128i8;
-    const b: i8 = -a;
-
-    return (b == -a) == y;
-}

tests/compiler/integers/i8/negate_min_fail.leo

@@ -0,0 +1,12 @@
+/*
+namespace: Compile
+expectation: Fail
+input_file: ../inputs/dummy.in
+*/
+
+function main() -> i8 {
+    let a: i8 = -127i8;
+    let b: i8 = a - 1i8;
+
+    return -b; // This line attempts to return 128i8 however, the largest i8 value is 127i8.
+}

tests/expectations/compiler/core/algorithms/bhp1024_commit.out

@@ -1,9 +0,0 @@
----
-namespace: Compile
-expectation: Pass
-outputs:
-  - output:
-      - initial_input_ast: 27bbdd2fe5dc1a75a4bd2aa543e12b7c284ab950028657fc0087dfef631664b9
-    initial_ast: 679d4f1ad4a54d3821e5f85c64e5e253dbf8ee07aaac7fc7ec2e086f2cbaa909
-    unrolled_ast: 679d4f1ad4a54d3821e5f85c64e5e253dbf8ee07aaac7fc7ec2e086f2cbaa909
-    ssa_ast: 6860f1b6b49a9bd0bf1c0f4afa8ad0067036196b5de4b17b26bbae9657f204f9

tests/expectations/compiler/core/algorithms/bhp1024_hash.out

@@ -1,9 +0,0 @@
----
-namespace: Compile
-expectation: Pass
-outputs:
-  - output:
-      - initial_input_ast: 4a84cbe8cc7ea360153e9da6f2d475dcbb4921c329fe8dd3b4cdca617b6d38a6
-    initial_ast: 8a961f82417010275495fdcc212292b809a71969396604e49e745fef94b3086f
-    unrolled_ast: 8a961f82417010275495fdcc212292b809a71969396604e49e745fef94b3086f
-    ssa_ast: 3d31265bf4923378c3202c852c599fad1dcd196920c23b4596186f1dcff0abe9

tests/expectations/compiler/core/algorithms/bhp256_commit.out

@@ -1,9 +0,0 @@
----
-namespace: Compile
-expectation: Pass
-outputs:
-  - output:
-      - initial_input_ast: 71055ce4ed5911b2afac14a8719573d4ffb9a72959e060f284122350dbda53df
-    initial_ast: 46df628c79eeda6fe31fdee9cd1dccb921b45efc9bc203d5d9ce6bda069f6be2
-    unrolled_ast: 46df628c79eeda6fe31fdee9cd1dccb921b45efc9bc203d5d9ce6bda069f6be2
-    ssa_ast: b2911915da86b51ed768cd8eb81f6b0c6aeda73de1e76278a75db44c3cc3fd76

tests/expectations/compiler/core/algorithms/bhp256_hash.out

@@ -1,9 +0,0 @@
----
-namespace: Compile
-expectation: Pass
-outputs:
-  - output:
-      - initial_input_ast: 5fa4b39f9cd209357769110ef49f609e2acce0c38f9def3f2ed7fcb4ce1b2240
-    initial_ast: 78c14952814d10190e26fa2fa4470e6af854fd6cff96e8c3c768662daa2aa005
-    unrolled_ast: 78c14952814d10190e26fa2fa4470e6af854fd6cff96e8c3c768662daa2aa005
-    ssa_ast: 484e4cbfade2151163bc2c09b542c6746fc9fbcf208473454aa08002c1e13c1f

tests/expectations/compiler/core/algorithms/bhp512_commit.out

@@ -1,9 +0,0 @@
----
-namespace: Compile
-expectation: Pass
-outputs:
-  - output:
-      - initial_input_ast: 71055ce4ed5911b2afac14a8719573d4ffb9a72959e060f284122350dbda53df
-    initial_ast: 505d1cdcee0dac47f49fea5f7af40c20a2262677aa7d8caf3b7051f4b5c70a6e
-    unrolled_ast: 505d1cdcee0dac47f49fea5f7af40c20a2262677aa7d8caf3b7051f4b5c70a6e
-    ssa_ast: cdccc90d8023edcf5e6ef7ab7dc42fe8812889cbbf6bb5bcf74a5628edc7d2eb

tests/expectations/compiler/core/algorithms/bhp512_hash.out

@@ -1,9 +0,0 @@
----
-namespace: Compile
-expectation: Pass
-outputs:
-  - output:
-      - initial_input_ast: 5fa4b39f9cd209357769110ef49f609e2acce0c38f9def3f2ed7fcb4ce1b2240
-    initial_ast: 0f72dc8f0fe5a8bf44067f5928a1835d0fc58551cda0280400060ff3519e02e2
-    unrolled_ast: 0f72dc8f0fe5a8bf44067f5928a1835d0fc58551cda0280400060ff3519e02e2
-    ssa_ast: 3da7df0dd03e5215a9df1095f875ecaaa2c549810b961b3444a168fe5cccde9a

tests/expectations/compiler/core/algorithms/bhp768_commit.out

@@ -1,9 +0,0 @@
----
-namespace: Compile
-expectation: Pass
-outputs:
-  - output:
-      - initial_input_ast: 71055ce4ed5911b2afac14a8719573d4ffb9a72959e060f284122350dbda53df
-    initial_ast: 1697ade1991b3fe9489d04a4b1c9d2f85defceea27455664a8dd6aad9d67c363
-    unrolled_ast: 1697ade1991b3fe9489d04a4b1c9d2f85defceea27455664a8dd6aad9d67c363
-    ssa_ast: ebb84c20196355f32d94db47d1b594ffd6c8ae078f47cf5f05986aa32b894185

tests/expectations/compiler/core/algorithms/bhp768_hash.out

@@ -1,9 +0,0 @@
----
-namespace: Compile
-expectation: Pass
-outputs:
-  - output:
-      - initial_input_ast: 5fa4b39f9cd209357769110ef49f609e2acce0c38f9def3f2ed7fcb4ce1b2240
-    initial_ast: af795006736c973728c5d91f2ce6a4771dca2b71249e7d2c7d189326918a168f
-    unrolled_ast: af795006736c973728c5d91f2ce6a4771dca2b71249e7d2c7d189326918a168f
-    ssa_ast: 60cd32ce055a0a051d8a0894ec014ad4a90b76c27a5ee18463373ec2fb5fc1fe

tests/expectations/compiler/core/algorithms/pedersen128_hash.out

@@ -1,9 +0,0 @@
----
-namespace: Compile
-expectation: Pass
-outputs:
-  - output:
-      - initial_input_ast: 356dd963e90ec1d3b56f169372c9e9bb2b70d053df96359cfd150679919c758a
-    initial_ast: 96d1ffc3060c89b3441c0fc5bc8e8b7d9a6982117c6634b0c7c26b1fe0be587a
-    unrolled_ast: 96d1ffc3060c89b3441c0fc5bc8e8b7d9a6982117c6634b0c7c26b1fe0be587a
-    ssa_ast: 3788cd3b3b7ffe50fabdaa88d8f61452a14da116622ccdb14a34bdff848e2d17

tests/expectations/compiler/core/algorithms/pedersen64_hash.out

@@ -1,9 +0,0 @@
----
-namespace: Compile
-expectation: Pass
-outputs:
-  - output:
-      - initial_input_ast: 5395306a6ab6901b3c5df094b3b49dbe5f29fb5886c5f0718097fbe5acd7602e
-    initial_ast: cf4a7dbbf0e7f4d0518c62104d6e89f4eff178bab8df5417286d9214a2704401
-    unrolled_ast: cf4a7dbbf0e7f4d0518c62104d6e89f4eff178bab8df5417286d9214a2704401
-    ssa_ast: 663b8b6703900c217dfef21d2b52162c49eb48f2fffc74d7054db99cd5e6d669

tests/expectations/compiler/core/algorithms/pedersen_fail.out

@@ -1,5 +0,0 @@
----
-namespace: Compile
-expectation: Fail
-outputs:
-  - "Error [ETYC0372007]: Expected one type from `boolean, i8, i16, i32, i64, u8, u16, u32, u64, string`, but got `u128`\n    --> compiler-test:4:20\n     |\n   4 |     let a: group = Pedersen64::hash(1u128);\n     |                    ^^^^^^^^^^^^^^^^^^^^^^^\nError [ETYC0372003]: Expected type `group` but type `field` was found\n    --> compiler-test:4:20\n     |\n   4 |     let a: group = Pedersen64::hash(1u128);\n     |                    ^^^^^^^^^^^^^^^^^^^^^^^\n"

tests/expectations/compiler/core/algorithms/poseidon2_hash.out

@@ -1,9 +0,0 @@
----
-namespace: Compile
-expectation: Pass
-outputs:
-  - output:
-      - initial_input_ast: 67384917f58c90880ca198b9a636e84c55d97b1068a3c88c1c4734577c798577
-    initial_ast: 58d78478c0f85a019221ebdc21e79083d80f70774210934a18eee5fce7d588d1
-    unrolled_ast: 58d78478c0f85a019221ebdc21e79083d80f70774210934a18eee5fce7d588d1
-    ssa_ast: 4ee97e337b3cf59243e63f1339f4e5a060cc38d45378e6bb1a040ff4ba5320c6

tests/expectations/compiler/core/algorithms/poseidon4_hash.out

@@ -1,9 +0,0 @@
----
-namespace: Compile
-expectation: Pass
-outputs:
-  - output:
-      - initial_input_ast: 67384917f58c90880ca198b9a636e84c55d97b1068a3c88c1c4734577c798577
-    initial_ast: 086408c110059f1af409ca0dfbfadf85b8c3ed55f28bc76e133bc57cf832ed21
-    unrolled_ast: 086408c110059f1af409ca0dfbfadf85b8c3ed55f28bc76e133bc57cf832ed21
-    ssa_ast: 3681b11adb8495432eb3e13378f5b70030bd7c643d8765ae6251a2f17120139f

tests/expectations/compiler/core/algorithms/poseidon8_hash.out

@@ -1,9 +0,0 @@
----
-namespace: Compile
-expectation: Pass
-outputs:
-  - output:
-      - initial_input_ast: 67384917f58c90880ca198b9a636e84c55d97b1068a3c88c1c4734577c798577
-    initial_ast: 632a5144ec2fe401dc832a98bb6c8244272fd08799af229fc6fea179a8788ca3
-    unrolled_ast: 632a5144ec2fe401dc832a98bb6c8244272fd08799af229fc6fea179a8788ca3
-    ssa_ast: 6749addd8071f14f367b8af4514b497c9ae2d19780ae7d68a0a4d1dd359458cf