ProvableHQ/leo
1
1
Fork 0
mirror of https://github.com/ProvableHQ/leo.git synced 2024-09-20 02:07:38 +03:00
Code Issues Packages Projects Releases Wiki Activity

remove leftover traces of previous import system

Browse Source
This commit is contained in:
evan-schott 2023-12-01 16:09:59 -08:00
parent 4b3b198850
commit 94b3290681
3 changed files with 7 additions and 99 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

78
compiler/passes/src/code_generation/visit_program.rs
View File

@ -14,11 +14,11 @@
// You should have received a copy of the GNU General Public License
// along with the Leo library. If not, see <https://www.gnu.org/licenses/>.
use crate::{CodeGenerator, DiGraph};
use crate::CodeGenerator;
use leo_ast::{functions, Function, Mapping, Mode, Program, ProgramScope, Struct, Type, Variant};
use indexmap::{IndexMap, IndexSet};
use indexmap::IndexMap;
use itertools::Itertools;
use leo_span::{sym, Symbol};
use std::fmt::Write as _;
@ -28,67 +28,10 @@ impl<'a> CodeGenerator<'a> {
// Accumulate instructions into a program string.
let mut program_string = String::new();
if !input.imports.is_empty() {
// Visit each import statement and produce a Aleo import instruction.
program_string.push_str(
&input
.imports
.iter()
.map(|(identifier, (imported_program, _))| self.visit_import(identifier, imported_program))
.join("\n"),
);
// Newline separator.
program_string.push('\n');
}
// Create directed graph representation of program dependencies.
let (mut dependency_graph, mut unexplored, mut explored): (
DiGraph<Symbol>,
IndexSet<Symbol>,
IndexSet<Symbol>,
) = (DiGraph::new(IndexSet::new()), input.stubs.keys().cloned().collect(), IndexSet::new());
while !unexplored.is_empty() {
let mut current_dependencies: IndexSet<Symbol> = IndexSet::new();
for program_name in unexplored.iter() {
// Not all dependencies will be represented as stubs, only the ones directly interacted with by `.leo` program
if let Some(stub) = input.stubs.get(program_name) {
// Add the program to the explored set
explored.insert(*program_name);
for dependency in stub.imports.iter() {
dependency_graph.add_edge(*program_name, dependency.name.name);
// Mark each dependency the first time it is seen
if explored.insert(dependency.name.name) {
current_dependencies.insert(dependency.name.name);
}
}
}
}
// Create next batch to explore
unexplored = current_dependencies;
}
// Writes imports in post order to program string. This ordering is enforced by snarkVM.
program_string.push_str(
&dependency_graph
.post_order()
.expect("Retriever module ensures that dependency graph does not contain cycle")
.iter()
.map(|program_name| {
// After all the iterations explored will have all the programs that have no dependencies themselves
explored.remove(program_name);
format!("import {}.aleo;", program_name)
})
.join("\n"),
);
// Can add in anything in explored but not in DiGraph keys as well
program_string
.push_str(&explored.iter().map(|program_name| format!("import {}.aleo;", program_name)).join("\n"));
// Newline separator.
program_string.push('\n');
// Print out the dependencies of the program. Already arranged in post order by Retriever module.
input.stubs.iter().for_each(|(program_name, _)| {
program_string.push_str(&format!("import {}.aleo;\n", program_name));
});
// Retrieve the program scope.
// Note that type checking guarantees that there is exactly one program scope.
@ -157,15 +100,6 @@ impl<'a> CodeGenerator<'a> {
program_string
}
fn visit_stub(&mut self, input: &'a Stub) -> String {
format!("import {}.aleo;", input.stub_id.name)
}
fn visit_import(&mut self, import_name: &'a Symbol, _import_program: &'a Program) -> String {
// Generate string for import statement.
format!("import {import_name}.aleo;")
}
fn visit_struct_or_record(&mut self, struct_: &'a Struct) -> String {
if struct_.is_record { self.visit_record(struct_) } else { self.visit_struct(struct_) }
}

25
compiler/passes/src/type_checking/check_program.rs
View File

@ -28,25 +28,7 @@ use std::collections::HashSet;
impl<'a> ProgramVisitor<'a> for TypeChecker<'a> {
fn visit_program(&mut self, input: &'a Program) {
match self.is_imported {
// If the program is imported, then it is not allowed to import any other programs.
true => {
input.imports.values().for_each(|(_, span)| {
self.emit_err(TypeCheckerError::imported_program_cannot_import_program(*span))
});
}
// Otherwise, typecheck the imported programs.
false => {
// Set `self.is_imported`.
let previous_is_imported = core::mem::replace(&mut self.is_imported, true);
// Typecheck the imported programs.
input.imports.values().for_each(|import| self.visit_import(&import.0));
// Set `self.is_imported` to its previous state.
self.is_imported = previous_is_imported;
}
}
// Calculate the intersection of the imports specified in the `.leo` file and the dependencies derived from the `program.json` file.
// Typecheck the program's stubs.
input.stubs.values().for_each(|stub| self.visit_stub(stub));
@ -102,11 +84,6 @@ impl<'a> ProgramVisitor<'a> for TypeChecker<'a> {
}
fn visit_struct_stub(&mut self, input: &'a Struct) {
// Allow records only.
if !input.is_record {
self.emit_err(TypeCheckerError::stubs_cannot_have_non_record_structs(input.span));
}
self.visit_struct(input);
}

3
compiler/passes/src/type_checking/checker.rs
View File

@ -60,8 +60,6 @@ pub struct TypeChecker<'a> {
/// Whether or not we are currently traversing a finalize block.
pub(crate) is_finalize: bool,
/// Whether or not we are currently traversing an imported program.
pub(crate) is_imported: bool,
/// Whether or not we are currently traversing a return statement.
pub(crate) is_return: bool,
}
@ -129,7 +127,6 @@ impl<'a> TypeChecker<'a> {
has_return: false,
has_finalize: false,
is_finalize: false,
is_imported: false,
is_return: false,
}
}