ProvableHQ/leo
1
1
Fork 0
mirror of https://github.com/ProvableHQ/leo.git synced 2024-12-27 12:13:41 +03:00
Code Issues Packages Projects Releases Wiki Activity

Parser produces negative integer literals

Browse Source
This commit is contained in:
Pranav Gaddamadugu 2022-08-06 09:26:40 -07:00
parent 7826e2a739
commit a1d79da501
1 changed files with 27 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
compiler/parser/src/parser/expression.rs
View File

@ -252,11 +252,33 @@ impl ParserContext<'_> {
} }
let mut inner = self.parse_postfix_expression()?; let mut inner = self.parse_postfix_expression()?;
for (op, op_span) in ops.into_iter().rev() { for (op, op_span) in ops.into_iter().rev() {
inner = Expression::Unary(UnaryExpression { inner = match inner {
span: op_span + inner.span(), // If the unary operation is a negate, and the inner expression is a signed integer literal,
op, // then produce a negative integer literal.
receiver: Box::new(inner), // This helps handle a special case where -128i8, treated as a unary expression, overflows, but -128i8, treated as an integer literal doesn't.
}); // TODO: the parser produces a negative integer literal for both -(128i8) and -128i8. Is this an issue?
Expression::Literal(Literal::I8(string, span)) if op == UnaryOperation::Negate => {
Expression::Literal(Literal::I8(format!("-{}", string), op_span + span))
}
Expression::Literal(Literal::I16(string, span)) if op == UnaryOperation::Negate => {
Expression::Literal(Literal::I16(format!("-{}", string), op_span + span))
}
Expression::Literal(Literal::I32(string, span)) if op == UnaryOperation::Negate => {
Expression::Literal(Literal::I32(format!("-{}", string), op_span + span))
}
Expression::Literal(Literal::I64(string, span)) if op == UnaryOperation::Negate => {
Expression::Literal(Literal::I64(format!("-{}", string), op_span + span))
}
Expression::Literal(Literal::I128(string, span)) if op == UnaryOperation::Negate => {
Expression::Literal(Literal::I128(format!("-{}", string), op_span + span))
}
// Otherwise, produce a unary expression.
_ => Expression::Unary(UnaryExpression {
span: op_span + inner.span(),
op,
receiver: Box::new(inner),
}),
};
} }
Ok(inner) Ok(inner)
} }