fix(prompts): can now be removed (#2154)

# Description

Please include a summary of the changes and the related issue. Please
also include relevant motivation and context.

## Checklist before requesting a review

Please delete options that are not relevant.

- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my code
- [ ] I have commented hard-to-understand areas
- [ ] I have ideally added tests that prove my fix is effective or that
my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any dependent changes have been merged

## Screenshots (if appropriate):
This commit is contained in:
Stan Girard 2024-02-06 19:30:20 -08:00 committed by GitHub
parent b6571d6ea9
commit 11f76f4e75
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 22 additions and 7 deletions

View File

@ -137,17 +137,21 @@ async def update_existing_brain(
if existing_brain is None: if existing_brain is None:
raise HTTPException(status_code=404, detail="Brain not found") raise HTTPException(status_code=404, detail="Brain not found")
brain_service.update_brain_by_id(brain_id, brain_update_data)
if brain_update_data.prompt_id is None and existing_brain.prompt_id: if brain_update_data.prompt_id is None and existing_brain.prompt_id:
prompt = prompt_service.get_prompt_by_id(existing_brain.prompt_id) prompt = prompt_service.get_prompt_by_id(existing_brain.prompt_id)
if prompt and prompt.status == "private": if prompt and prompt.status == "private":
prompt_service.delete_prompt_by_id(existing_brain.prompt_id) prompt_service.delete_prompt_by_id(existing_brain.prompt_id)
if brain_update_data.status == "private" and existing_brain.status == "public": return {"message": f"Prompt {brain_id} has been updated."}
brain_user_service.delete_brain_users(brain_id)
return {"message": f"Brain {brain_id} has been updated."} elif brain_update_data.status == "private" and existing_brain.status == "public":
brain_user_service.delete_brain_users(brain_id)
return {"message": f"Brain {brain_id} has been deleted."}
else:
brain_service.update_brain_by_id(brain_id, brain_update_data)
return {"message": f"Brain {brain_id} has been updated."}
@brain_router.put( @brain_router.put(

View File

@ -268,7 +268,6 @@ class BrainService:
status_code=404, status_code=404,
detail=f"Brain with id {brain_id} not found", detail=f"Brain with id {brain_id} not found",
) )
brain_update_answer = self.brain_repository.update_brain_by_id( brain_update_answer = self.brain_repository.update_brain_by_id(
brain_id, brain_id,
brain=BrainUpdatableProperties( brain=BrainUpdatableProperties(

View File

@ -1,10 +1,10 @@
from fastapi import HTTPException from fastapi import HTTPException
from models.settings import get_supabase_client
from modules.prompt.entity.prompt import Prompt from modules.prompt.entity.prompt import Prompt
from modules.prompt.repository.prompts_interface import ( from modules.prompt.repository.prompts_interface import (
DeletePromptResponse, DeletePromptResponse,
PromptsInterface, PromptsInterface,
) )
from models.settings import get_supabase_client
class Prompts(PromptsInterface): class Prompts(PromptsInterface):
@ -30,6 +30,18 @@ class Prompts(PromptsInterface):
Returns: Returns:
A dictionary containing the status of the delete and prompt_id of the deleted prompt A dictionary containing the status of the delete and prompt_id of the deleted prompt
""" """
# Update brains where prompt_id is equal to the value to NULL
self.db.from_("brains").update({"prompt_id": None}).filter(
"prompt_id", "eq", prompt_id
).execute()
# Update chat_history where prompt_id is equal to the value to NULL
self.db.from_("chat_history").update({"prompt_id": None}).filter(
"prompt_id", "eq", prompt_id
).execute()
# Delete the prompt
response = ( response = (
self.db.from_("prompts") self.db.from_("prompts")
.delete() .delete()