mirror of
https://github.com/QuivrHQ/quivr.git
synced 2024-09-11 14:36:35 +03:00
fix(api): fixed issue with name function and ilmproved promtp (#1759)
# Description Please include a summary of the changes and the related issue. Please also include relevant motivation and context. ## Checklist before requesting a review Please delete options that are not relevant. - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my code - [ ] I have commented hard-to-understand areas - [ ] I have ideally added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged ## Screenshots (if appropriate):
This commit is contained in:
parent
a5db69439b
commit
a84219f193
@ -53,7 +53,13 @@ class APIBrainQA(
|
||||
messages,
|
||||
functions,
|
||||
brain_id: UUID,
|
||||
):
|
||||
recursive_count = 0,
|
||||
):
|
||||
if recursive_count > 5:
|
||||
yield "🧠<Deciding what to do>🧠"
|
||||
yield "The assistant is having issues and took more than 5 calls to the API. Please try again later or an other instruction."
|
||||
return
|
||||
|
||||
yield "🧠<Deciding what to do>🧠"
|
||||
response = completion(
|
||||
model=self.model,
|
||||
@ -71,22 +77,18 @@ class APIBrainQA(
|
||||
}
|
||||
for chunk in response:
|
||||
finish_reason = chunk.choices[0].finish_reason
|
||||
|
||||
if finish_reason == "stop":
|
||||
break
|
||||
if "function_call" in chunk.choices[0].delta and chunk.choices[0].delta["function_call"]:
|
||||
if "name" in chunk.choices[0].delta["function_call"]:
|
||||
function_call["name"] = chunk.choices[0].delta["function_call"][
|
||||
"name"
|
||||
]
|
||||
if "arguments" in chunk.choices[0].delta["function_call"]:
|
||||
if chunk.choices[0].delta["function_call"].name:
|
||||
function_call["name"] = chunk.choices[0].delta["function_call"].name
|
||||
if chunk.choices[0].delta["function_call"].arguments:
|
||||
function_call["arguments"] += chunk.choices[0].delta[
|
||||
"function_call"
|
||||
]["arguments"]
|
||||
].arguments
|
||||
|
||||
elif finish_reason == "function_call":
|
||||
try:
|
||||
logger.info(f"Function call: {function_call}")
|
||||
arguments = json.loads(function_call["arguments"])
|
||||
|
||||
except Exception:
|
||||
@ -104,18 +106,20 @@ class APIBrainQA(
|
||||
status_code=400,
|
||||
detail=f"Error while calling API: {e}",
|
||||
)
|
||||
|
||||
|
||||
function_name = function_call["name"]
|
||||
messages.append(
|
||||
{
|
||||
"role": "function",
|
||||
"name": str(brain_id),
|
||||
"content": api_call_response,
|
||||
"name": function_call["name"],
|
||||
"content": f"The function {function_name} was called and gave The following answer:(data from function) {api_call_response} (end of data from function). Don't call this function again unless there was an error or extremely necessary and asked specifically by the user.",
|
||||
}
|
||||
)
|
||||
async for value in self.make_completion(
|
||||
messages=messages,
|
||||
functions=functions,
|
||||
brain_id=brain_id,
|
||||
recursive_count=recursive_count + 1,
|
||||
):
|
||||
yield value
|
||||
|
||||
@ -142,7 +146,7 @@ class APIBrainQA(
|
||||
if not brain:
|
||||
raise HTTPException(status_code=404, detail="Brain not found")
|
||||
|
||||
prompt_content = "You'are a helpful assistant which can call APIs. Feel free to call the API when you need to. Don't force APIs call, do it when necessary. If it seems like you should call the API and there are missing parameters, ask user for them."
|
||||
prompt_content = "You are a helpful assistant that can access functions to help answer questions. If there are information missing in the question, you can ask follow up questions to get more information to the user. Once all the information is available, you can call the function to get the answer."
|
||||
|
||||
if self.prompt_to_use:
|
||||
prompt_content += self.prompt_to_use.content
|
||||
|
@ -30,13 +30,6 @@ def get_api_call_response_as_text(
|
||||
headers=headers or None,
|
||||
data=json.dumps(params) or None,
|
||||
)
|
||||
logger.info("🔥🔥🔥🔥🔥")
|
||||
logger.info(f"API call response: {response.text}")
|
||||
logger.info(f'API call search params: {search_params}')
|
||||
logger.info(f"API call response status code: {response.status_code}")
|
||||
logger.info(f"API call url with search params: {api_url_with_search_params}")
|
||||
logger.info(f"API call headers: {headers}")
|
||||
logger.info(f"API Response: {response.text}")
|
||||
return response.text
|
||||
except Exception as e:
|
||||
logger.error(f"Error calling API: {e}")
|
||||
|
Loading…
Reference in New Issue
Block a user