RoboSats/robosats
1
1
Fork 0
mirror of https://github.com/RoboSats/robosats.git synced 2024-12-26 05:43:34 +03:00
Code Issues Packages Projects Releases Wiki Activity

Add validation of invoice based on total cost of routing hints

Browse Source
This commit is contained in:
Reckless_Satoshi 2022-05-26 16:35:45 -07:00
parent 4da6a43a59
commit d24e01f1f5
No known key found for this signature in database
GPG Key ID: 9C4585B561315571
2 changed files with 28 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
api/lightning/node.py
View File

@ -190,6 +190,33 @@ class LNNode:
}
return payout
## Some wallet providers (e.g. Muun) force routing through a private channel with high fees >1500ppm
## These payments will fail. So it is best to let the user know in advance this invoice is not valid.
route_hints = payreq_decoded.route_hints
# Max amount RoboSats will pay for routing
max_routing_fee_sats = max(num_satoshis * float(config("PROPORTIONAL_ROUTING_FEE_LIMIT")), float(config("MIN_FLAT_ROUTING_FEE_LIMIT_REWARD")))
if route_hints:
routes_cost = []
# For every hinted route...
for hinted_route in route_hints:
route_cost = 0
# ...add up the cost of every hinted hop...
for hop_hint in hinted_route.hop_hints:
route_cost += hop_hint.fee_base_msat / 1000
route_cost += hop_hint.fee_proportional_millionths * num_satoshis / 1000000
# ...and store the cost of the route to the array
routes_cost.append(route_cost)
# If the cheapest possible private route is more expensive than what RoboSats is willing to pay
if min(routes_cost) >= max_routing_fee_sats :
payout["context"] = {
"bad_invoice": "The invoice submitted only has expensive routing hints, you are using an incompatible wallet (probably Muun?). Check the wallet compatibility guide at wallets.robosats.com"
}
return payout
if payreq_decoded.num_satoshis == 0:
payout["context"] = {
"bad_invoice": "The invoice provided has no explicit amount"

2
frontend/src/components/TradeBox.js
View File

@ -628,7 +628,7 @@ class TradeBox extends Component {
}}
multiline
minRows={5}
maxRows={this.state.qrscanner ? 5 : 14}
maxRows={this.state.qrscanner ? 5 : 10}
onChange={this.handleInputInvoiceChanged}
/>
</Grid>