StanGirard/quivr
1
1
Fork 0
mirror of https://github.com/StanGirard/quivr.git synced 2024-12-23 11:23:00 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix: fixing errors arising when the user input contains no tasks (#3525)

Browse Source 
We fix an error arising when the user input contains no tasks, but only
system instructions

# Description

Please include a summary of the changes and the related issue. Please
also include relevant motivation and context.

## Checklist before requesting a review

Please delete options that are not relevant.

- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my code
- [ ] I have commented hard-to-understand areas
- [ ] I have ideally added tests that prove my fix is effective or that
my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any dependent changes have been merged

## Screenshots (if appropriate):
This commit is contained in:
Jacopo Chevallard 2024-12-16 15:24:48 +01:00 committed by GitHub
parent e48044d36f
commit e28f7bcb9a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
core/quivr_core/rag/quivr_rag_langgraph.py
View File

@ -71,11 +71,11 @@ class SplittedInput(BaseModel):
class TasksCompletion(BaseModel): class TasksCompletion(BaseModel):
is_task_completable_reasoning: Optional[str] = Field( is_task_completable_reasoning: Optional[str] = Field(
default=None, default=None,
description="The reasoning that leads to identifying whether the user task or question can be completed using the provided context and chat history.", description="The reasoning that leads to identifying whether the user task or question can be completed using the provided context and chat history BEFORE any tool is used.",
) )
is_task_completable: bool = Field( is_task_completable: bool = Field(
description="Whether the user task or question can be completed using the provided context and chat history.", description="Whether the user task or question can be completed using the provided context and chat history BEFORE any tool is used.",
) )
tool_reasoning: Optional[str] = Field( tool_reasoning: Optional[str] = Field(
@ -667,7 +667,7 @@ class QuivrQARAGLangGraph:
MAX_ITERATIONS = 3 MAX_ITERATIONS = 3
tasks = state["tasks"] tasks = state["tasks"]
if not tasks.has_tasks(): if not tasks or not tasks.has_tasks():
return {**state} return {**state}
k = self.retrieval_config.k k = self.retrieval_config.k
@ -1031,7 +1031,7 @@ class QuivrQARAGLangGraph:
return { return {
"context": combine_documents(docs) if docs else "None", "context": combine_documents(docs) if docs else "None",
"question": user_question, "question": user_question,
"rephrased_task": state["tasks"].definitions, "rephrased_task": state["tasks"].definitions if state["tasks"] else "None",
"custom_instructions": prompt if prompt else "None", "custom_instructions": prompt if prompt else "None",
"files": files if files else "None", "files": files if files else "None",
"chat_history": state["chat_history"].to_list(), "chat_history": state["chat_history"].to_list(),