TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-11-25 09:03:12 +03:00
Code Issues Projects Releases Wiki Activity
0f8610a6e9
Ghost/ghost/admin/app/templates/application.hbs

28 lines
711 B
Handlebars
Raw Normal View History

Ran "no implicit this in templates" codemod no issue We were in a part-way state where some touched files had been (sometimes partially) migrated to explicit `this`. The codemod that was available has now fixed the formatting issues it had so it was a good time to run it. https://github.com/ember-codemods/ember-no-implicit-this-codemod - part of the migration path for https://github.com/emberjs/rfcs/pull/308 - starts to make template resolution rules more explicit - `<MyComponent />` - always a component - `{{my-component}}` - component or helper (components _must_ have a `-`. This style of component will go away once fully migrated to angle bracket components) - `{{value}}` - a helper or local template variable - `{{this.value}}` - reference to a property on the backing context (either a controller or a component JS file)
2019-12-13 17:20:29 +03:00
{{#gh-app showSettingsMenu=this.ui.showSettingsMenu}}
Make skip link work with Ember refs #5652 - handles the skip link using js so that ember doesn't interfere with the anchor - uses the code suggested here: https://www.codehive.io/boards/pZUuwIk
2015-08-27 20:41:14 +03:00
{{#gh-skip-link anchor=".gh-main"}}Skip to main content{{/gh-skip-link}}
Implement autonav
2015-05-20 18:37:06 +03:00
Remove unused top notification count functionality no issue - in a very old iteration of the admin design we needed a data attribute containing the number of notifications in order to add extra spacing in the styles. This hasn't been necessary for a long time and there are easier ways to do it now than using observers.
2017-11-24 13:47:06 +03:00
{{gh-alerts}}
Implement autonav
2015-05-20 18:37:06 +03:00
Ran "no implicit this in templates" codemod no issue We were in a part-way state where some touched files had been (sometimes partially) migrated to explicit `this`. The codemod that was available has now fixed the formatting issues it had so it was a good time to run it. https://github.com/ember-codemods/ember-no-implicit-this-codemod - part of the migration path for https://github.com/emberjs/rfcs/pull/308 - starts to make template resolution rules more explicit - `<MyComponent />` - always a component - `{{my-component}}` - component or helper (components _must_ have a `-`. This style of component will go away once fully migrated to angle bracket components) - `{{value}}` - a helper or local template variable - `{{this.value}}` - reference to a property on the backing context (either a controller or a component JS file)
2019-12-13 17:20:29 +03:00
<div class="gh-viewport {{if this.ui.showSettingsMenu 'settings-menu-expanded'}} {{if this.ui.showMobileMenu 'mobile-menu-expanded'}}">
{{#if this.showNavMenu}}
🐛 Fixed blog icon not shown in nav (#918) closes TryGhost/Ghost#9293 Added https://github.com/TryGhost/Ghost-Admin/commit/d982f7b520873f497c7fafc62c4c71fa95dfd5ab#diff-f63965ba48df687541db46e0e1b2c2ecL10 back, which broke the rendering of the blog icon in the nav menu.
2017-11-30 16:12:01 +03:00
{{gh-nav-menu
Ran "no implicit this in templates" codemod no issue We were in a part-way state where some touched files had been (sometimes partially) migrated to explicit `this`. The codemod that was available has now fixed the formatting issues it had so it was a good time to run it. https://github.com/ember-codemods/ember-no-implicit-this-codemod - part of the migration path for https://github.com/emberjs/rfcs/pull/308 - starts to make template resolution rules more explicit - `<MyComponent />` - always a component - `{{my-component}}` - component or helper (components _must_ have a `-`. This style of component will go away once fully migrated to angle bracket components) - `{{value}}` - a helper or local template variable - `{{this.value}}` - reference to a property on the backing context (either a controller or a component JS file)
2019-12-13 17:20:29 +03:00
icon=this.settings.settledIcon
🐛 Fixed blog icon not shown in nav (#918) closes TryGhost/Ghost#9293 Added https://github.com/TryGhost/Ghost-Admin/commit/d982f7b520873f497c7fafc62c4c71fa95dfd5ab#diff-f63965ba48df687541db46e0e1b2c2ecL10 back, which broke the rendering of the blog icon in the nav menu.
2017-11-30 16:12:01 +03:00
}}
don't show the nav menu when on a 404 route and not signed in no issue - fixes problem when the nav menu would be shown on an error404 route when the user is not logged in - adds failing test that passes with this change
2016-05-14 04:02:55 +03:00
{{/if}}
Introduce new notification and alerts components
2015-05-18 17:20:43 +03:00
Added ability to set `<main>` class using route metadata no issue - modified `ui` service's `routeDidChange` handler to update it's `mainClass` property based on the new route's metadata - used in the future for switching screen background colours To use the feature, modify or add a `buildRouteInfoMetadata` hook in the route which you'd like to change, eg: ```js export default AuthenticatedRoute.extend({ ... buildRouteInfoMetadata() { return { bodyClasses: ['my-body-class'], mainClasses: ['grey-bg'] // <-------- }; } }); ``` The route hierarchy is taken into consideration with classes being added for all currently shown routes. For example if you wanted to add an `editor` class to all editor routes you could use the hook in `routes/editor.js` then if you added an `editor-new` class in `routes/editor/new.js` the resulting HTML output on the "New story" screen would be: ```html <main class="gh-main editor editor-new"> ```
2019-05-20 17:33:12 +03:00
<main class="gh-main {{this.ui.mainClass}}" role="main">
Update Ember to 1.13.2 - Refactor to handle deprecations including removal of all Views, ArrayControllers, and ItemControllers.
2015-06-13 17:34:09 +03:00
{{outlet}}
Migrate to latest ember, ember-mocha and modern ember testing (#1044) no issue - upgrade to latest `ember-source` and related dependencies including `ember-cli` - upgrade to latest `ember-mocha` and modern ember testing setup - https://github.com/emberjs/rfcs/blob/master/text/0268-acceptance-testing-refactor.md - switch from using global acceptance test helpers and `native-dom-helpers` to using the new `ember-test-helpers` methods - use [`chai-dom`](https://github.com/nathanboktae/chai-dom) assertions where in some places (still a lot of places in the tests that could use these) - pin `ember-in-viewport` to 3.0.x to work around incompatibilities between different versions used in `ember-light-table`, `ember-infinity`, and `ember-sticky-element` - incompatibilities manifested as "Invalid value used as weak map key" errors thrown when using `ember-light-table` (subscribers screen) - pin `ember-power-datepicker` to unreleased version that contains a move from global acceptance test helpers to modern test helpers
2019-01-02 12:58:55 +03:00
</main>
Implement autonav
2015-05-20 18:37:06 +03:00
Update Ember to 1.13.2 - Refactor to handle deprecations including removal of all Views, ArrayControllers, and ItemControllers.
2015-06-13 17:34:09 +03:00
{{gh-notifications}}
Add mobile menu open button and close on click outside nav - Adds gh-view-title component to implement mobile menu button for titles on any page - Refactors the `content-cover` out into the application template - Fix various z-index issues with content-cover and gh-alert - Move `.settings-menu-expanded` application view state from body to `.gh-viewport` - Unify nav menu / mobile menu actions and code
2015-05-27 17:39:56 +03:00
Refactor general UI state into a service no issue - moves general UI state control such as menu display, autonav, settings menu, etc into a `ui` service for easier use within components - no longer required to jump through hoops passing state and actions down from application controller into components - removes indirect "route" actions in favour of calling actions/methods directly on the `ui` service
2017-08-14 15:30:00 +03:00
{{gh-content-cover}}
fixed notification components
2015-05-21 20:03:24 +03:00
Refactor general UI state into a service no issue - moves general UI state control such as menu display, autonav, settings menu, etc into a `ui` service for easier use within components - no longer required to jump through hoops passing state and actions down from application controller into components - removes indirect "route" actions in favour of calling actions/methods directly on the `ui` service
2017-08-14 15:30:00 +03:00
{{gh-mobile-nav-bar}}
✨ Added "What's new" indicator and modal to highlight recent updates (#1292) no issue - adds `whats-new` service that fetches the changelog from ghost.org and exposes the latest changelog entries - trigger a background fetch of the changelog from ghost.org when first loading the admin when logged in, or after signing in - adds a "What's new" menu item next to the user popup menu - adds an indicator to the user menu button and what's new menu item if there are unseen changelog entries - closing the changelog modal will update the "last seen date", clearing both indicators
2019-08-23 12:01:27 +03:00
<GhWhatsNew />
Update Ember to 1.13.2 - Refactor to handle deprecations including removal of all Views, ArrayControllers, and ItemControllers.
2015-06-13 17:34:09 +03:00
</div>{{!gh-viewport}}
{{/gh-app}}
Refactor modals refs #5798, closes #5018 - adds new `gh-fullscreen-modal` component - modals are now specified in-context so that they can have deeper interaction with their surrounding components/controller/route, i.e. a modal component can be a thin confirm/deny wrapper over the underlying controller action keeping all context-sensitive logic in one place - adds spin-buttons to all modals with async behaviour - adds/improves behaviour of inline-validation in modals - improves re-authenticate modal to properly handle validation and authentication errors
2015-11-18 13:50:48 +03:00
clean up content screen prototype refs https://github.com/TryGhost/Ghost/issues/7860 - load 30 posts per page - clean up unnecessary styles, match class name to component name - start moving towards desired content/styles end goal
2017-02-03 17:00:42 +03:00
{{ember-load-remover}}
Reference in New Issue Copy Permalink