Ghost/ghost/admin/app/components/gh-loading-spinner.hbs

{{#if this.showSpinner}}
    <div class="gh-loading-content" ...attributes>
        <div class="gh-loading-spinner"></div>
    </div>
{{/if}}
Ran "no implicit this in templates" codemod no issue We were in a part-way state where some touched files had been (sometimes partially) migrated to explicit `this`. The codemod that was available has now fixed the formatting issues it had so it was a good time to run it. https://github.com/ember-codemods/ember-no-implicit-this-codemod - part of the migration path for https://github.com/emberjs/rfcs/pull/308 - starts to make template resolution rules more explicit - `<MyComponent />` - always a component - `{{my-component}}` - component or helper (components _must_ have a `-`. This style of component will go away once fully migrated to angle bracket components) - `{{value}}` - a helper or local template variable - `{{this.value}}` - reference to a property on the backing context (either a controller or a component JS file) 2019-12-13 17:20:29 +03:00			`{{#if this.showSpinner}}`
Converted `<GhLoadingSpinner>` to glimmer component no issue - allows for attributes such as class/style to be set on it's container for better display in varying situations 2021-10-12 18:01:38 +03:00			`<div class="gh-loading-content" ...attributes>`
🏃 improve navigation responsiveness with loading substates (#495) no issue - add loading substates for all routes that previously blocked transitions until their model had finished loading - enables immediate response on navigation click - loading templates include the title bar to provide immediate indication of which page is loading - loading templates include a new `{{gh-loading-spinner}}` component that will only show the spinner after 200ms to avoid flashing a spinner for users on fast connections - updated Version Mismatch tests to match new behaviour of intermediate transitions when navigating 2017-01-18 02:44:08 +03:00			`<div class="gh-loading-spinner"></div>`
			`</div>`
			`{{/if}}`