TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-11-28 22:43:30 +03:00
Code Issues Projects Releases Wiki Activity
21f2a58a8a
Ghost/ghost/admin/app/components/gh-mobile-nav-bar.hbs

10 lines
696 B
Handlebars
Raw Normal View History

Responsive UI fixes
2021-02-12 16:29:44 +03:00
<LinkTo @route="dashboard" data-test-mobile-nav="dashboard">{{svg-jar "house"}}Dashboard</LinkTo>
Ran "no implicit this in templates" codemod no issue We were in a part-way state where some touched files had been (sometimes partially) migrated to explicit `this`. The codemod that was available has now fixed the formatting issues it had so it was a good time to run it. https://github.com/ember-codemods/ember-no-implicit-this-codemod - part of the migration path for https://github.com/emberjs/rfcs/pull/308 - starts to make template resolution rules more explicit - `<MyComponent />` - always a component - `{{my-component}}` - component or helper (components _must_ have a `-`. This style of component will go away once fully migrated to angle bracket components) - `{{value}}` - a helper or local template variable - `{{this.value}}` - reference to a property on the backing context (either a controller or a component JS file)
2019-12-13 17:20:29 +03:00
{{#if (eq this.router.currentRouteName "posts")}}
Responsive UI fixes
2021-02-12 16:29:44 +03:00
<LinkTo @route="posts" @query={{hash type=null}} @classNames="active" data-test-mobile-nav="posts">{{svg-jar "posts"}}Posts</LinkTo>
Prototype mobile navbar
2017-02-17 10:32:29 +03:00
{{else}}
Migrated to `<AngleBracketSyntax />` (#1460) no issue Ember is migrating to `<AngleBracketSyntax />` for component invocation, see https://github.com/emberjs/rfcs/blob/master/text/0311-angle-bracket-invocation.md We were in a half-way situation where some templates used angle bracket syntax in some places, this PR updates templates to use the syntax everywhere. This simplifies the rules for what template code is referring to... `<Component>` = a component `{{helper}}` = a helper (or locally assigned handlebars variable) `{{this.foo}}` = data on the template backing context (a component/controller) `{{@foo}}` = a named argument passed into the component that the component backing class has not modified (note: this commit does not introduce any named arguments) - ran codemod https://github.com/ember-codemods/ember-angle-brackets-codemod on the following directories: - `app/templates` - `lib/koenig-editor/addon/templates` - removed positional params from components as angle bracket syntax does not support them - `gh-feature-flag` - `gh-tour-item` - `gh-cm-editor` - `gh-fullscreen-modal` - `gh-task-button` - updates some code that was missed in https://github.com/TryGhost/Ghost-Admin/commit/3c851293c1f92d14bc6a49debf86a4663398315a to use explicit this
2020-01-16 18:14:03 +03:00
<LinkTo @route="posts">{{svg-jar "content" data-test-mobile-nav="posts"}}Posts</LinkTo>
Prototype mobile navbar
2017-02-17 10:32:29 +03:00
{{/if}}
Responsive UI fixes
2021-02-12 16:29:44 +03:00
<LinkTo @route="members" @classNames="gh-nav-main-users" data-test-mobile-nav="members">{{svg-jar "members"}}Members</LinkTo>
🐛 Fixed various small accessibility problems in the admin screen (#1583) refs #11863 * 🐛 Fixed accessible button label for showing and hiding custom post types. * 🐛 Made the menu separators accessible. * 🐛 Fixed the More item to be a button for assistive technologies.
2020-05-28 17:51:14 +03:00
<div role="button" class="gh-mobile-nav-bar-more" {{action "openMobileMenu" target=this.ui data-test-mobile-nav="more"}}>{{svg-jar "icon" class="icon-gh"}}More</div>
Prototype mobile navbar
2017-02-17 10:32:29 +03:00
{{yield}}
Reference in New Issue Copy Permalink