Ghost/ghost/admin/app/routes/settings/members-email.js

import AdminRoute from 'ghost-admin/routes/admin';

export default class MembersEmailRoute extends AdminRoute {
    beforeModel() {
        // Moved to newsletters
        return this.replaceWith('settings.newsletters');
    }
}
Refactored away CurrentUserSettings mixin (#2200) no issue Mixins are deprecated in Ember so we want to remove their usage. The `CurrentUserSettings` mixin was used in Route files to provide `transitionAuthor()` (that also transitions contributors) and `transitionEditor()` methods so the the consuming route could use them to prevent access to authors/editors. In practice the only reason this was used was to prevent access to admin-only routes. - added an `AdminRoute` class that inherits from our `AuthenticatedRoute` class - when any route inherits from this class it will only allow access to admins and owners, any other user will be redirected to the home screen (dashboard or site depending on permissions) - updated all of our admin-only routes to use the new `AdminRoute` - allowed for removal of `CurrentUserSettings` mixin usage - allowed for `beforeModel()` hooks to be removed from consuming routes in many cases - some admin-only routes were extending/inheriting directly from Ember's `Route` based on the assumption that the router hierarchy would have a parent route perform the redirect. Those have also been switched to `AdminRoute` for consistency and to prevent accidentally making them available if the router hierarchy changes - `/#/settings` does not use the `AdminRoute` so that it can redirect to the current user's setting page for non-admin users - removed `CurrentUserSettings` mixin file - cleaned up unnecessary computed property and function used for redirect-when-disabled in the Zapier route 2022-01-17 13:05:27 +03:00			`import AdminRoute from 'ghost-admin/routes/admin';`
Moved members settings to new page (#1736) no refs Moves members related settings in Labs to its own page to improve the overall UX and make it more consistent with the rest of the Admin. 2020-10-22 13:39:00 +03:00
Migrated route objects to native class syntax no issue - ran the `ember-native-class-codemod` codemod to convert just the route classes to native class syntax and performed some minor manual cleanup - modern Ember uses native classes rather than EmberObject-based objects, this brings us closer to normalizing our code style across the codebase - skipped the Application route as that requires deeper testing with a replacement for the `ShortcutsRoute` mixin 2022-01-17 12:34:55 +03:00			`export default class MembersEmailRoute extends AdminRoute {`
Renamed members-email-labs to newsletters and removed unused files no issue We still had some old components and templates from the `members-email` settings that were only were used when the (now GA) `multipleNewsletters` flag was disabled. I’ve removed them and renamed all routes and components from `members-email` and `members-email-labs` to just `newsletters` because it was sometimes hard to understand if a given components was still used or not when fixing issues. 2022-05-05 14:36:16 +03:00			`beforeModel() {`
			`// Moved to newsletters`
			`return this.replaceWith('settings.newsletters');`
Moved members settings to new page (#1736) no refs Moves members related settings in Labs to its own page to improve the overall UX and make it more consistent with the rest of the Admin. 2020-10-22 13:39:00 +03:00			`}`
Migrated route objects to native class syntax no issue - ran the `ember-native-class-codemod` codemod to convert just the route classes to native class syntax and performed some minor manual cleanup - modern Ember uses native classes rather than EmberObject-based objects, this brings us closer to normalizing our code style across the codebase - skipped the Application route as that requires deeper testing with a replacement for the `ShortcutsRoute` mixin 2022-01-17 12:34:55 +03:00			`}`