TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-11-30 01:42:29 +03:00
Code Issues Projects Releases Wiki Activity
3b87c9be53
Ghost/ghost/admin/app/components/gh-theme-error-li.hbs

32 lines
1.0 KiB
Handlebars
Raw Normal View History

💄 Theme upload modal style improvements (#784) no issue With GScan sending error details now, the modal was a bit overloaded. This PR adds a toggle for each error rule which - when clicked - shows the details and the affected files.
2017-07-20 13:30:45 +03:00
<a href="" class="theme-validation-toggle-details" {{action "toggleDetails"}} data-test-toggle-details>
Improved theme upload/activate flow and error styles (#1142) no issue * Update error and warning styles * Refined upload dialog * Theme upload and activation style refinements
2019-04-05 19:27:14 +03:00
<div class="theme-validation-type-label"></div>
<div class="flex items-center flex-auto">
<h4 class="theme-validation-rule-text">
Ran "no implicit this in templates" codemod no issue We were in a part-way state where some touched files had been (sometimes partially) migrated to explicit `this`. The codemod that was available has now fixed the formatting issues it had so it was a good time to run it. https://github.com/ember-codemods/ember-no-implicit-this-codemod - part of the migration path for https://github.com/emberjs/rfcs/pull/308 - starts to make template resolution rules more explicit - `<MyComponent />` - always a component - `{{my-component}}` - component or helper (components _must_ have a `-`. This style of component will go away once fully migrated to angle bracket components) - `{{value}}` - a helper or local template variable - `{{this.value}}` - reference to a property on the backing context (either a controller or a component JS file)
2019-12-13 17:20:29 +03:00
{{{this.error.rule}}}
Improved theme upload/activate flow and error styles (#1142) no issue * Update error and warning styles * Refined upload dialog * Theme upload and activation style refinements
2019-04-05 19:27:14 +03:00
</h4>
<div class="theme-validation-rule-icon">
Ran "no implicit this in templates" codemod no issue We were in a part-way state where some touched files had been (sometimes partially) migrated to explicit `this`. The codemod that was available has now fixed the formatting issues it had so it was a good time to run it. https://github.com/ember-codemods/ember-no-implicit-this-codemod - part of the migration path for https://github.com/emberjs/rfcs/pull/308 - starts to make template resolution rules more explicit - `<MyComponent />` - always a component - `{{my-component}}` - component or helper (components _must_ have a `-`. This style of component will go away once fully migrated to angle bracket components) - `{{value}}` - a helper or local template variable - `{{this.value}}` - reference to a property on the backing context (either a controller or a component JS file)
2019-12-13 17:20:29 +03:00
{{#if this.showDetails}}
Improved theme upload/activate flow and error styles (#1142) no issue * Update error and warning styles * Refined upload dialog * Theme upload and activation style refinements
2019-04-05 19:27:14 +03:00
{{svg-jar "arrow-down"}}
{{else}}
{{svg-jar "arrow-right"}}
{{/if}}
</div>
💄 Theme upload modal style improvements (#784) no issue With GScan sending error details now, the modal was a bit overloaded. This PR adds a toggle for each error rule which - when clicked - shows the details and the affected files.
2017-07-20 13:30:45 +03:00
</div>
</a>
✨ show theme warnings/errors when activating a theme (#576) closes https://github.com/TryGhost/Ghost/issues/8127 - update theme activation to manually set other themes to `active: false` in the store now that we only the active theme back from `/themes/:name/activate` endpoint - move theme warning list item rendering into `{{gh-theme-error-li error=x}}` - add `theme-warnings` modal that accepts a warnings list, title, and optional message - after activating a theme, check if the theme has any warnings or errors and display an appropriate modal informing the user
2017-03-14 16:54:58 +03:00
Ran "no implicit this in templates" codemod no issue We were in a part-way state where some touched files had been (sometimes partially) migrated to explicit `this`. The codemod that was available has now fixed the formatting issues it had so it was a good time to run it. https://github.com/ember-codemods/ember-no-implicit-this-codemod - part of the migration path for https://github.com/emberjs/rfcs/pull/308 - starts to make template resolution rules more explicit - `<MyComponent />` - always a component - `{{my-component}}` - component or helper (components _must_ have a `-`. This style of component will go away once fully migrated to angle bracket components) - `{{value}}` - a helper or local template variable - `{{this.value}}` - reference to a property on the backing context (either a controller or a component JS file)
2019-12-13 17:20:29 +03:00
{{#if this.showDetails}}
💄 Theme upload modal style improvements (#784) no issue With GScan sending error details now, the modal was a bit overloaded. This PR adds a toggle for each error rule which - when clicked - shows the details and the affected files.
2017-07-20 13:30:45 +03:00
<p class="theme-validation-details">
Ran "no implicit this in templates" codemod no issue We were in a part-way state where some touched files had been (sometimes partially) migrated to explicit `this`. The codemod that was available has now fixed the formatting issues it had so it was a good time to run it. https://github.com/ember-codemods/ember-no-implicit-this-codemod - part of the migration path for https://github.com/emberjs/rfcs/pull/308 - starts to make template resolution rules more explicit - `<MyComponent />` - always a component - `{{my-component}}` - component or helper (components _must_ have a `-`. This style of component will go away once fully migrated to angle bracket components) - `{{value}}` - a helper or local template variable - `{{this.value}}` - reference to a property on the backing context (either a controller or a component JS file)
2019-12-13 17:20:29 +03:00
{{{this.error.details}}}
💄 Theme upload modal style improvements (#784) no issue With GScan sending error details now, the modal was a bit overloaded. This PR adds a toggle for each error rule which - when clicked - shows the details and the affected files.
2017-07-20 13:30:45 +03:00
</p>
Ran "no implicit this in templates" codemod no issue We were in a part-way state where some touched files had been (sometimes partially) migrated to explicit `this`. The codemod that was available has now fixed the formatting issues it had so it was a good time to run it. https://github.com/ember-codemods/ember-no-implicit-this-codemod - part of the migration path for https://github.com/emberjs/rfcs/pull/308 - starts to make template resolution rules more explicit - `<MyComponent />` - always a component - `{{my-component}}` - component or helper (components _must_ have a `-`. This style of component will go away once fully migrated to angle bracket components) - `{{value}}` - a helper or local template variable - `{{this.value}}` - reference to a property on the backing context (either a controller or a component JS file)
2019-12-13 17:20:29 +03:00
{{#if this.error.failures}}
💄 Theme upload modal style improvements (#784) no issue With GScan sending error details now, the modal was a bit overloaded. This PR adds a toggle for each error rule which - when clicked - shows the details and the affected files.
2017-07-20 13:30:45 +03:00
<div class="theme-validation-list">
<h6>Affected files:</h6>
<ul>
Ran "no implicit this in templates" codemod no issue We were in a part-way state where some touched files had been (sometimes partially) migrated to explicit `this`. The codemod that was available has now fixed the formatting issues it had so it was a good time to run it. https://github.com/ember-codemods/ember-no-implicit-this-codemod - part of the migration path for https://github.com/emberjs/rfcs/pull/308 - starts to make template resolution rules more explicit - `<MyComponent />` - always a component - `{{my-component}}` - component or helper (components _must_ have a `-`. This style of component will go away once fully migrated to angle bracket components) - `{{value}}` - a helper or local template variable - `{{this.value}}` - reference to a property on the backing context (either a controller or a component JS file)
2019-12-13 17:20:29 +03:00
{{#each this.error.failures as |failure|}}
💄 Theme upload modal style improvements (#784) no issue With GScan sending error details now, the modal was a bit overloaded. This PR adds a toggle for each error rule which - when clicked - shows the details and the affected files.
2017-07-20 13:30:45 +03:00
<li><code>{{failure.ref}}</code>{{#if failure.message}}: {{failure.message}}{{/if}}</li>
{{/each}}
</ul>
</div>
{{/if}}
{{/if}}
Reference in New Issue Copy Permalink