Ghost/core/server/services/notifications/index.js

const settingsCache = require('../../../shared/settings-cache');
const Notifications = require('./notifications');
const models = require('../../models');

module.exports.notifications = new Notifications({
    settingsCache,
    SettingsModel: models.Settings
});
Moved settings/cache to shared/settings-cache - This is part of the quest to separate the frontend and server & get rid of all the places where there are cross-requires - At the moment the settings cache is one big shared cache used by the frontend and server liberally - This change doesn't really solve the fundamental problems, as we still depend on events, and requires from inside frontend - However it allows us to control the misuse slightly better by getting rid of restricted requires and turning on that eslint ruleset 2021-06-30 16:56:57 +03:00			`const settingsCache = require('../../../shared/settings-cache');`
Refactored notifications module into a class refs #12537 - Classes with DI friendly constructors are the pattern that are followed across the codebase 2021-01-14 06:19:15 +03:00			`const Notifications = require('./notifications');`
🐛 Fixed version update indicator on about page refs https://github.com/TryGhost/Team/issues/754 closes https://github.com/TryGhost/Ghost/issues/13088 refs https://github.com/TryGhost/Ghost/commit/a7dec233ba5c9b289a981a157e9de074369272bd - The corrupted data recovery mechanism for notifications is needed to be able to fix the data stored in `settings` table under `notifications` key. There was no validation in place, which has caused some instances to store data in unreadable/writable state - The recovery mechanism is in place to avoid adding migrations every time we spot a broken notifications data (will be fixed by validation soon). - The notification data is also NOT critical but valuable for system functioning properly, that's the reason why the data "healing" happens in less secure "fire-and-forget" way - The referenced commit is where the "bigger" problem that was causing the data corruption was at. This change is a "cleanup" after what has happened there - storing Ghost error object in `value` for `notifications` key 2021-06-24 15:33:01 +03:00			`const models = require('../../models');`
Refactored notifications module into a class refs #12537 - Classes with DI friendly constructors are the pattern that are followed across the codebase 2021-01-14 06:19:15 +03:00
🐛 Fixed version update indicator on about page refs https://github.com/TryGhost/Team/issues/754 closes https://github.com/TryGhost/Ghost/issues/13088 refs https://github.com/TryGhost/Ghost/commit/a7dec233ba5c9b289a981a157e9de074369272bd - The corrupted data recovery mechanism for notifications is needed to be able to fix the data stored in `settings` table under `notifications` key. There was no validation in place, which has caused some instances to store data in unreadable/writable state - The recovery mechanism is in place to avoid adding migrations every time we spot a broken notifications data (will be fixed by validation soon). - The notification data is also NOT critical but valuable for system functioning properly, that's the reason why the data "healing" happens in less secure "fire-and-forget" way - The referenced commit is where the "bigger" problem that was causing the data corruption was at. This change is a "cleanup" after what has happened there - storing Ghost error object in `value` for `notifications` key 2021-06-24 15:33:01 +03:00			`module.exports.notifications = new Notifications({`
			`settingsCache,`
			`SettingsModel: models.Settings`
			`});`