TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-02 08:13:34 +03:00
Code Issues Projects Releases Wiki Activity
5cce6138e5
Ghost/ghost/admin/app/components/modal-post-email-preview.hbs

28 lines
1.5 KiB
Handlebars
Raw Normal View History

Ran "no implicit this in templates" codemod no issue We were in a part-way state where some touched files had been (sometimes partially) migrated to explicit `this`. The codemod that was available has now fixed the formatting issues it had so it was a good time to run it. https://github.com/ember-codemods/ember-no-implicit-this-codemod - part of the migration path for https://github.com/emberjs/rfcs/pull/308 - starts to make template resolution rules more explicit - `<MyComponent />` - always a component - `{{my-component}}` - component or helper (components _must_ have a `-`. This style of component will go away once fully migrated to angle bracket components) - `{{value}}` - a helper or local template variable - `{{this.value}}` - reference to a property on the backing context (either a controller or a component JS file)
2019-12-13 17:20:29 +03:00
<header class="modal-header gh-pe-header {{if (eq this.type "desktop") "gh-pe-header-border"}}" data-test-modal="preview-email" style="display:flex">
<h2 class="f6 fw6">{{this.subject}}</h2>
Refined browser preview
2019-11-06 08:07:43 +03:00
<div class="gh-contentfilter gh-btn-group gh-pe-btn-group" style="display:flex;flex-grow:1;justify-content:center">
Ran "no implicit this in templates" codemod no issue We were in a part-way state where some touched files had been (sometimes partially) migrated to explicit `this`. The codemod that was available has now fixed the formatting issues it had so it was a good time to run it. https://github.com/ember-codemods/ember-no-implicit-this-codemod - part of the migration path for https://github.com/emberjs/rfcs/pull/308 - starts to make template resolution rules more explicit - `<MyComponent />` - always a component - `{{my-component}}` - component or helper (components _must_ have a `-`. This style of component will go away once fully migrated to angle bracket components) - `{{value}}` - a helper or local template variable - `{{this.value}}` - reference to a property on the backing context (either a controller or a component JS file)
2019-12-13 17:20:29 +03:00
<button class="gh-btn {{if (eq this.type "desktop") "gh-btn-group-selected"}}" {{action "changeType" "desktop"}}><span>Desktop</span></button>
<button class="gh-btn {{if (eq this.type "mobile") "gh-btn-group-selected"}}" {{action "changeType" "mobile"}}><span>Mobile</span></button>
Refined browser preview
2019-11-06 08:07:43 +03:00
</div>
Refined email preview
2019-11-07 07:09:47 +03:00
<div class="gh-pe-close">
Ran "no implicit this in templates" codemod no issue We were in a part-way state where some touched files had been (sometimes partially) migrated to explicit `this`. The codemod that was available has now fixed the formatting issues it had so it was a good time to run it. https://github.com/ember-codemods/ember-no-implicit-this-codemod - part of the migration path for https://github.com/emberjs/rfcs/pull/308 - starts to make template resolution rules more explicit - `<MyComponent />` - always a component - `{{my-component}}` - component or helper (components _must_ have a `-`. This style of component will go away once fully migrated to angle bracket components) - `{{value}}` - a helper or local template variable - `{{this.value}}` - reference to a property on the backing context (either a controller or a component JS file)
2019-12-13 17:20:29 +03:00
<button class="close" href title="Close" {{on "click" this.closeModal}}>
Refined email preview
2019-11-07 07:09:47 +03:00
{{svg-jar "close"}}
</button>
</div>
Added email preview modal flow
2019-11-05 08:21:29 +03:00
</header>
Fixed scrolling and hid scrollbars in email preview
2019-11-07 13:11:53 +03:00
Ran "no implicit this in templates" codemod no issue We were in a part-way state where some touched files had been (sometimes partially) migrated to explicit `this`. The codemod that was available has now fixed the formatting issues it had so it was a good time to run it. https://github.com/ember-codemods/ember-no-implicit-this-codemod - part of the migration path for https://github.com/emberjs/rfcs/pull/308 - starts to make template resolution rules more explicit - `<MyComponent />` - always a component - `{{my-component}}` - component or helper (components _must_ have a `-`. This style of component will go away once fully migrated to angle bracket components) - `{{value}}` - a helper or local template variable - `{{this.value}}` - reference to a property on the backing context (either a controller or a component JS file)
2019-12-13 17:20:29 +03:00
{{#if (eq this.type "mobile")}}
Refined mobile email preview no refs. Issue was that the ratio of email mobile preview UI was completely off on higher screen resolutions. - set the email mobile preview UI to fixed size
2019-12-03 13:18:02 +03:00
<div class="modal-body modal-preview-email-content gh-pe-mobile-container" style="display: flex;justify-content: center;">
Fixed scrolling and hid scrollbars in email preview
2019-11-07 13:11:53 +03:00
<div class="gh-pe-mobile-bezel">
<div class="gh-pe-mobile-screen">
💄 Adjusted email previews to better represent email behaviour of embed cards (#1554) no issue - added `sandbox` attribute which blocks scripts from running inside the iframe - results in better representation of how embeds will render in emails where scripts are not allowed
2020-05-08 13:54:18 +03:00
<iframe class="bn gh-pe-iframe" {{did-insert this.renderEmailPreview}} sandbox="allow-same-origin"></iframe>
Added email preview modal flow
2019-11-05 08:21:29 +03:00
</div>
</div>
</div>
{{/if}}
Fixed scrolling and hid scrollbars in email preview
2019-11-07 13:11:53 +03:00
Ran "no implicit this in templates" codemod no issue We were in a part-way state where some touched files had been (sometimes partially) migrated to explicit `this`. The codemod that was available has now fixed the formatting issues it had so it was a good time to run it. https://github.com/ember-codemods/ember-no-implicit-this-codemod - part of the migration path for https://github.com/emberjs/rfcs/pull/308 - starts to make template resolution rules more explicit - `<MyComponent />` - always a component - `{{my-component}}` - component or helper (components _must_ have a `-`. This style of component will go away once fully migrated to angle bracket components) - `{{value}}` - a helper or local template variable - `{{this.value}}` - reference to a property on the backing context (either a controller or a component JS file)
2019-12-13 17:20:29 +03:00
{{#if (eq this.type "desktop")}}
Email preview refinements
2019-11-06 11:58:01 +03:00
<div class="modal-body modal-preview-email-content gh-pe-desktop-container">
💄 Adjusted email previews to better represent email behaviour of embed cards (#1554) no issue - added `sandbox` attribute which blocks scripts from running inside the iframe - results in better representation of how embeds will render in emails where scripts are not allowed
2020-05-08 13:54:18 +03:00
<iframe class="bn miw-100 gh-pe-iframe" style="height:100%;" {{did-insert this.renderEmailPreview}} sandbox="allow-same-origin"></iframe>
Added email preview modal flow
2019-11-05 08:21:29 +03:00
</div>
{{/if}}
Reference in New Issue Copy Permalink