Ghost/core/server/services/bulk-email/index.js

const {
    BATCH_SIZE,
    SuccessfulBatch,
    FailedBatch,
    processEmail,
    processEmailBatch,
    send
} = require('./bulk-email-processor');

module.exports = {
    BATCH_SIZE,
    SuccessfulBatch,
    FailedBatch,
    processEmail,
    processEmailBatch,
    send
};
Renamed bulk-email index to bulk email processor no issue - idex.js files are meant to expose the API of the module and not contain code - Next step would be reworking the code to use class/injection pattern 2021-06-22 19:19:45 +03:00			`const {`
			`BATCH_SIZE,`
			`SuccessfulBatch,`
			`FailedBatch,`
			`processEmail,`
			`processEmailBatch,`
			`send`
			`} = require('./bulk-email-processor');`
Added initial bulk-email service no-issue This is a simple wrapper around the current ghost mailer service for now 2019-11-04 08:36:10 +03:00
			`module.exports = {`
Refactor mega service to use stored email content and batch/recipient records no issue - store raw content in email record - keep any replacement strings in the html/plaintext content so that it can be used when sending email rather than needing to re-serialize the post content which may have changed - split post email serializer into separate serialization and replacement parsing functions - serialization now returns any email content that is derived from the post content (subject/html/plaintext) rather than post content plus replacements - `parseReplacements` has been split out so that it can be run against email content rather than a post, this allows mega and the email preview service to work with the stored email content - move mailgun-specific functionality into the mailgun provider - previously mailgun-specific behaviour was spread across the post email serializer, mega, and bulk-email service - the per-batch `send` functionality was moved from the `bulk-email` service to the mailgun provider and updated to take email content, recipient info, and replacement info so that all mailgun-specific headers and replacement formatting can be handled in one place - exposes the `BATCH_SIZE` constant because batch sizes are limited to what the provider allows - `bulk-email` service split into three methods - `send` responsible for taking email content and recipients, parsing replacement info from the email content and using that to collate a recipient data object, and finally coordinating the send via the mailgun provider. Usable directly for use-cases such as test emails - `processEmail` takes an email ID, loads it and coordinates sending related batches concurrently - `processEmailBatch` takes an email_batch ID, loads it along with associated email_recipient records and passes the data through to the `send` function, updating the batch status as it's processed - `processEmail` and `processEmailBatch` take IDs rather than objects ready for future use by job-queues, it's best to keep job parameters as minimal as possible - refactored `mega` service - modified `getEmailData` to collate email content (from/reply-to/subject/html/plaintext) rather than being responsible for dealing with replacements and mailgun-specific replacement formats - used for generating email content before storing in the email table, and when sending test emails - from/reply-to calculation moved out of the post-email-serializer into mega and extracted into separate functions used by `getEmailData` - `sendTestEmail` updated to generate `EmailRecipient`-like objects for each email address so that appropriate data can be supplied to the updated `bulk-email.send` method - `sendEmailJob` updated to create `email_batches` and associated `email_recipients` records then hand over processing to the `bulk-email` service - member row fetching extracted into a separate function and used by `createEmailBatches` - moved updating of email status from `mega` to the `bulk-email` service, keeps concept of Successful/FailedBatch internal to the `bulk-email` service 2020-09-24 11:35:29 +03:00			`BATCH_SIZE,`
Improved mega error handling (#11393) no issue - Increased default mailgun retry limit to 5 - Handling retry logic closer to SDK layer gives less future manual handling - Allowed failing request to be passed through to the caller - To be able to handle failed requests more gracefully in the future we need all available error information to be given to the caller - The previous method with `Promise.all` would have rejected a whole batch without providing details on each specific batch. - Limited data returned with a failed message to batch values - Added better error handling on mega layer - Added new column to store failed batch info - Added reference to mailgan error docs - Refactored batch emailer to respond with instances of an object - It's hard to reason about the response type of bulk mailer when multiple object types can be returned - This gives more clarity and ability to check with `instanceof` check 2019-11-15 14:25:33 +03:00			`SuccessfulBatch,`
			`FailedBatch,`
Renamed bulk-email index to bulk email processor no issue - idex.js files are meant to expose the API of the module and not contain code - Next step would be reworking the code to use class/injection pattern 2021-06-22 19:19:45 +03:00			`processEmail,`
			`processEmailBatch,`
			`send`
Added initial bulk-email service no-issue This is a simple wrapper around the current ghost mailer service for now 2019-11-04 08:36:10 +03:00			`};`