TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-20 01:03:23 +03:00
Code Issues Projects Releases Wiki Activity
6f5baca849
Ghost/ghost/admin/app/components/editor/publish-options/email-recipients.hbs

30 lines
1.4 KiB
Handlebars
Raw Normal View History

Added email limit checks and email disabled messaging to publish flow closes https://github.com/TryGhost/Team/issues/1584 refs https://github.com/TryGhost/Team/issues/1605 - added email limit check to PublishOptions setup - moved email disabled messaging from the email recipients option to the publish type option - it was confusing to have the email publish type options disabled without any indication of why, with the message hidden within the closed email recipients option
2022-05-11 19:00:20 +03:00
<div class="form-group max-width mb0">
Updated email recipient filter design Refs https://github.com/TryGhost/Team/issues/1544
2022-05-12 14:56:43 +03:00
<GhMembersRecipientSelect
@filter={{@publishOptions.recipientFilter}}
@newsletter={{@publishOptions.newsletter}}
@onChange={{@publishOptions.setRecipientFilter}}
@renderInPlace={{false}}
@dropdownClass="gh-publish-newsletter-dropdown"
/>
Hid total member counts in newsletter selection for authors/editors no issue - authors/editors don't yet have a way to fetch member counts for specific filters so the final member count is hidden in the publish options text, however we were still showing the total subscribed members for each newsletter in the dropdown which could lead to incorrect assumptions for how many members would receive the newsletter
2022-05-18 15:58:19 +03:00
Added email limit checks and email disabled messaging to publish flow closes https://github.com/TryGhost/Team/issues/1584 refs https://github.com/TryGhost/Team/issues/1605 - added email limit check to PublishOptions setup - moved email disabled messaging from the email recipients option to the publish type option - it was confusing to have the email publish type options disabled without any indication of why, with the message hidden within the closed email recipients option
2022-05-11 19:00:20 +03:00
{{#if (gt @publishOptions.newsletters.length 1)}}
Increased publish flow acceptance tests refs https://github.com/TryGhost/Team/issues/1586 - updated `?newsletter_id=id` handling in posts API mock to match the real `?newsletter=slug` behaviour - added additional publish flow acceptance tests for single/multiple newsletter behaviour, scheduling, and sending
2022-06-01 00:59:12 +03:00
<div class="mt4" data-test-select="newsletter">
Updated email recipient filter design Refs https://github.com/TryGhost/Team/issues/1544
2022-05-12 14:56:43 +03:00
<label class="gh-main-section-header small bn">Newsletter</label>
Added email limit checks and email disabled messaging to publish flow closes https://github.com/TryGhost/Team/issues/1584 refs https://github.com/TryGhost/Team/issues/1605 - added email limit check to PublishOptions setup - moved email disabled messaging from the email recipients option to the publish type option - it was confusing to have the email publish type options disabled without any indication of why, with the message hidden within the closed email recipients option
2022-05-11 19:00:20 +03:00
<PowerSelect
@selected={{@publishOptions.newsletter}}
@options={{@publishOptions.newsletters}}
@onChange={{@publishOptions.setNewsletter}}
Resolved power-select related deprecation warnings for loading components by string (#15466) no issue - in many places we were passing a string as an argument to a `<PowerSelect>` related component that referred to a component name, that was throwing deprecation warnings because those strings were used dynamically with `{{component}}` later on which isn't statically analyzable - switched to passing a component explicitly with `{{component}}` - https://github.com/embroider-build/embroider/blob/main/REPLACING-COMPONENT-HELPER.md#when-youre-passing-a-component-to-someone-else
2022-09-24 18:00:05 +03:00
@triggerComponent={{component "gh-power-select/trigger"}}
Added email limit checks and email disabled messaging to publish flow closes https://github.com/TryGhost/Team/issues/1584 refs https://github.com/TryGhost/Team/issues/1605 - added email limit check to PublishOptions setup - moved email disabled messaging from the email recipients option to the publish type option - it was confusing to have the email publish type options disabled without any indication of why, with the message hidden within the closed email recipients option
2022-05-11 19:00:20 +03:00
@triggerClass="gh-publish-newsletter-trigger"
@dropdownClass="gh-publish-newsletter-dropdown"
as |newsletter|
>
Increased publish flow acceptance tests refs https://github.com/TryGhost/Team/issues/1586 - updated `?newsletter_id=id` handling in posts API mock to match the real `?newsletter=slug` behaviour - added additional publish flow acceptance tests for single/multiple newsletter behaviour, scheduling, and sending
2022-06-01 00:59:12 +03:00
<span data-test-select-option={{newsletter.name}}>{{newsletter.name}}</span>
Hid total member counts in newsletter selection for authors/editors no issue - authors/editors don't yet have a way to fetch member counts for specific filters so the final member count is hidden in the publish options text, however we were still showing the total subscribed members for each newsletter in the dropdown which could lead to incorrect assumptions for how many members would receive the newsletter
2022-05-18 15:58:19 +03:00
{{!-- TODO: remove conditional when author/editor can fetch member counts --}}
{{#if @publishOptions.user.isAdmin}}
<span class="gh-newsletter-count">{{format-number newsletter.count.members}}</span>
{{/if}}
Added email limit checks and email disabled messaging to publish flow closes https://github.com/TryGhost/Team/issues/1584 refs https://github.com/TryGhost/Team/issues/1605 - added email limit check to PublishOptions setup - moved email disabled messaging from the email recipients option to the publish type option - it was confusing to have the email publish type options disabled without any indication of why, with the message hidden within the closed email recipients option
2022-05-11 19:00:20 +03:00
</PowerSelect>
</div>
{{/if}}
</div>
Reference in New Issue Copy Permalink