2020-04-29 18:44:27 +03:00
|
|
|
const should = require('should');
|
|
|
|
const sinon = require('sinon');
|
|
|
|
const Promise = require('bluebird');
|
|
|
|
const rewire = require('rewire');
|
|
|
|
const models = require('../../../../../core/server/models');
|
|
|
|
const baseUtils = require('../../../../../core/server/models/base/utils');
|
|
|
|
const fixtureUtils = rewire('../../../../../core/server/data/schema/fixtures/utils');
|
|
|
|
const fixtures = require('../../../../../core/server/data/schema/fixtures/fixtures');
|
2016-04-08 12:09:26 +03:00
|
|
|
|
✨ replace auto increment id's by object id (#7495)
* 🛠 bookshelf tarball, bson-objectid
* 🎨 schema changes
- change increment type to string
- add a default fallback for string length 191 (to avoid adding this logic to every single column which uses an ID)
- remove uuid, because ID now represents a global resource identifier
- keep uuid for post, because we are using this as preview id
- keep uuid for clients for now - we are using this param for Ghost-Auth
* ✨ base model: generate ObjectId on creating event
- each new resource get's a auto generate ObjectId
- this logic won't work for attached models, this commit comes later
* 🎨 centralised attach method
When attaching models there are two things important two know
1. To be able to attach an ObjectId, we need to register the `onCreating` event the fetched model!This is caused by the Bookshelf design in general. On this target model we are attaching the new model.
2. We need to manually fetch the target model, because Bookshelf has a weird behaviour (which is known as a bug, see see https://github.com/tgriesser/bookshelf/issues/629). The most important property when attaching a model is `parentFk`, which is the foreign key. This can be null when fetching the model with the option `withRelated`. To ensure quality and consistency, the custom attach wrapper always fetches the target model manual. By fetching the target model (again) is a little performance decrease, but it also has advantages: we can register the event, and directly unregister the event again. So very clean code.
Important: please only use the custom attach wrapper in the future.
* 🎨 token model had overriden the onCreating function because of the created_at field
- we need to ensure that the base onCreating hook get's triggered for ALL models
- if not, they don't get an ObjectId assigned
- in this case: be smart and check if the target model has a created_at field
* 🎨 we don't have a uuid field anymore, remove the usages
- no default uuid creation in models
- i am pretty sure we have some more definitions in our tests (for example in the export json files), but that is too much work to delete them all
* 🎨 do not parse ID to Number
- we had various occurances of parsing all ID's to numbers
- we don't need this behaviour anymore
- ID is string
- i will adapt the ID validation in the next commit
* 🎨 change ID regex for validation
- we only allow: ID as ObjectId, ID as 1 and ID as me
- we need to keep ID 1, because our whole software relies on ID 1 (permissions etc)
* 🎨 owner fixture
- roles: [4] does not work anymore
- 4 means -> static id 4
- this worked in an auto increment system (not even in a system with distributed writes)
- with ObjectId we generate each ID automatically (for static and dynamic resources)
- it is possible to define all id's for static resources still, but that means we need to know which ID is already used and for consistency we have to define ObjectId's for these static resources
- so no static id's anymore, except of: id 1 for owner and id 0 for external usage (because this is required from our permission system)
- NOTE: please read through the comment in the user model
* 🎨 tests: DataGenerator and test utils
First of all: we need to ensure using ObjectId's in the tests. When don't, we can't ensure that ObjectId's work properly.
This commit brings lot's of dynamic into all the static defined id's.
In one of the next commits, i will adapt all the tests.
* 🚨 remove counter in Notification API
- no need to add a counter
- we simply generate ObjectId's (they are auto incremental as well)
- our id validator does only allow ObjectId as id,1 and me
* 🎨 extend contextUser in Base Model
- remove isNumber check, because id's are no longer numbers, except of id 0/1
- use existing isExternalUser
- support id 0/1 as string or number
* ✨ Ghost Owner has id 1
- ensure we define this id in the fixtures.json
- doesn't matter if number or string
* 🎨 functional tests adaptions
- use dynamic id's
* 🎨 fix unit tests
* 🎨 integration tests adaptions
* 🎨 change importer utils
- all our export examples (test/fixtures/exports) contain id's as numbers
- fact: but we ignore them anyway when inserting into the database, see https://github.com/TryGhost/Ghost/blob/master/core/server/data/import/utils.js#L249
- in https://github.com/TryGhost/Ghost/pull/7495/commits/0e6ed957cd54dc02a25cf6fb1ab7d7e723295e2c#diff-70f514a06347c048648be464819503c4L67 i removed parsing id's to integers
- i realised that this ^ check just existed, because the userIdToMap was an object key and object keys are always strings!
- i think this logic is a little bit complicated, but i don't want to refactor this now
- this commit ensures when trying to find the user, the id comparison works again
- i've added more documentation to understand this logic ;)
- plus i renamed an attribute to improve readability
* 🎨 Data-Generator: add more defaults to createUser
- if i use the function DataGenerator.forKnex.createUser i would like to get a full set of defaults
* 🎨 test utils: change/extend function set for functional tests
- functional tests work a bit different
- they boot Ghost and seed the database
- some functional tests have mis-used the test setup
- the test setup needs two sections: integration/unit and functional tests
- any functional test is allowed to either add more data or change data in the existing Ghost db
- but what it should not do is: add test fixtures like roles or users from our DataGenerator and cross fingers it will work
- this commit adds a clean method for functional tests to add extra users
* 🎨 functional tests adaptions
- use last commit to insert users for functional tests clean
- tidy up usage of testUtils.setup or testUtils.doAuth
* 🐛 test utils: reset database before init
- ensure we don't have any left data from other tests in the database when starting ghost
* 🐛 fix test (unrelated to this PR)
- fixes a random failure
- return statement was missing
* 🎨 make changes for invites
2016-11-17 12:09:11 +03:00
|
|
|
describe('Migration Fixture Utils', function () {
|
2020-04-29 18:44:27 +03:00
|
|
|
let loggerStub;
|
2016-04-08 12:09:26 +03:00
|
|
|
|
|
|
|
beforeEach(function () {
|
|
|
|
loggerStub = {
|
2019-01-21 19:53:44 +03:00
|
|
|
info: sinon.stub(),
|
|
|
|
warn: sinon.stub()
|
2016-04-08 12:09:26 +03:00
|
|
|
};
|
|
|
|
|
|
|
|
models.init();
|
|
|
|
});
|
|
|
|
|
|
|
|
afterEach(function () {
|
2019-01-21 19:53:44 +03:00
|
|
|
sinon.restore();
|
2016-04-08 12:09:26 +03:00
|
|
|
});
|
|
|
|
|
|
|
|
describe('Match Func', function () {
|
2020-04-29 18:44:27 +03:00
|
|
|
const matchFunc = fixtureUtils.__get__('matchFunc');
|
|
|
|
let getStub;
|
2016-04-08 12:09:26 +03:00
|
|
|
|
|
|
|
beforeEach(function () {
|
2019-01-21 19:53:44 +03:00
|
|
|
getStub = sinon.stub();
|
2016-04-08 12:09:26 +03:00
|
|
|
getStub.withArgs('foo').returns('bar');
|
|
|
|
getStub.withArgs('fun').returns('baz');
|
|
|
|
});
|
|
|
|
|
|
|
|
it('should match undefined with no args', function () {
|
|
|
|
matchFunc()({get: getStub}).should.be.true();
|
|
|
|
getStub.calledOnce.should.be.true();
|
|
|
|
getStub.calledWith(undefined).should.be.true();
|
|
|
|
});
|
|
|
|
|
|
|
|
it('should match key with match string', function () {
|
|
|
|
matchFunc('foo', 'bar')({get: getStub}).should.be.true();
|
|
|
|
getStub.calledOnce.should.be.true();
|
|
|
|
getStub.calledWith('foo').should.be.true();
|
|
|
|
|
|
|
|
matchFunc('foo', 'buz')({get: getStub}).should.be.false();
|
|
|
|
getStub.calledTwice.should.be.true();
|
|
|
|
getStub.secondCall.calledWith('foo').should.be.true();
|
|
|
|
});
|
|
|
|
|
|
|
|
it('should match value when key is 0', function () {
|
|
|
|
matchFunc('foo', 0, 'bar')({get: getStub}).should.be.true();
|
|
|
|
getStub.calledOnce.should.be.true();
|
|
|
|
getStub.calledWith('foo').should.be.true();
|
|
|
|
|
|
|
|
matchFunc('foo', 0, 'buz')({get: getStub}).should.be.false();
|
|
|
|
getStub.calledTwice.should.be.true();
|
|
|
|
getStub.secondCall.calledWith('foo').should.be.true();
|
|
|
|
});
|
|
|
|
|
|
|
|
it('should match key & value when match is array', function () {
|
|
|
|
matchFunc(['foo', 'fun'], 'bar', 'baz')({get: getStub}).should.be.true();
|
|
|
|
getStub.calledTwice.should.be.true();
|
|
|
|
getStub.getCall(0).calledWith('fun').should.be.true();
|
|
|
|
getStub.getCall(1).calledWith('foo').should.be.true();
|
|
|
|
|
|
|
|
matchFunc(['foo', 'fun'], 'baz', 'bar')({get: getStub}).should.be.false();
|
|
|
|
getStub.callCount.should.eql(4);
|
|
|
|
getStub.getCall(2).calledWith('fun').should.be.true();
|
|
|
|
getStub.getCall(3).calledWith('foo').should.be.true();
|
|
|
|
});
|
|
|
|
|
|
|
|
it('should match key only when match is array, but value is all', function () {
|
|
|
|
matchFunc(['foo', 'fun'], 'bar', 'all')({get: getStub}).should.be.true();
|
|
|
|
getStub.calledOnce.should.be.true();
|
|
|
|
getStub.calledWith('foo').should.be.true();
|
|
|
|
|
|
|
|
matchFunc(['foo', 'fun'], 'all', 'bar')({get: getStub}).should.be.false();
|
|
|
|
getStub.callCount.should.eql(3);
|
|
|
|
getStub.getCall(1).calledWith('fun').should.be.true();
|
|
|
|
getStub.getCall(2).calledWith('foo').should.be.true();
|
|
|
|
});
|
|
|
|
|
|
|
|
it('should match key & value when match and value are arrays', function () {
|
|
|
|
matchFunc(['foo', 'fun'], 'bar', ['baz', 'buz'])({get: getStub}).should.be.true();
|
|
|
|
getStub.calledTwice.should.be.true();
|
|
|
|
getStub.getCall(0).calledWith('fun').should.be.true();
|
|
|
|
getStub.getCall(1).calledWith('foo').should.be.true();
|
|
|
|
|
|
|
|
matchFunc(['foo', 'fun'], 'bar', ['biz', 'buz'])({get: getStub}).should.be.false();
|
|
|
|
getStub.callCount.should.eql(4);
|
|
|
|
getStub.getCall(2).calledWith('fun').should.be.true();
|
|
|
|
getStub.getCall(3).calledWith('foo').should.be.true();
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('Add Fixtures For Model', function () {
|
|
|
|
it('should call add for main post fixture', function (done) {
|
2020-04-29 18:44:27 +03:00
|
|
|
const postOneStub = sinon.stub(models.Post, 'findOne').returns(Promise.resolve());
|
|
|
|
const postAddStub = sinon.stub(models.Post, 'add').returns(Promise.resolve({}));
|
2016-04-08 12:09:26 +03:00
|
|
|
|
2019-09-12 16:54:39 +03:00
|
|
|
fixtureUtils.addFixturesForModel(fixtures.models[4]).then(function (result) {
|
2016-04-08 12:09:26 +03:00
|
|
|
should.exist(result);
|
|
|
|
result.should.be.an.Object();
|
2018-08-08 15:24:56 +03:00
|
|
|
result.should.have.property('expected', 7);
|
|
|
|
result.should.have.property('done', 7);
|
2016-04-08 12:09:26 +03:00
|
|
|
|
2018-08-08 15:24:56 +03:00
|
|
|
postOneStub.callCount.should.eql(7);
|
|
|
|
postAddStub.callCount.should.eql(7);
|
2016-04-08 12:09:26 +03:00
|
|
|
|
|
|
|
done();
|
2017-03-13 14:44:44 +03:00
|
|
|
}).catch(done);
|
2016-04-08 12:09:26 +03:00
|
|
|
});
|
|
|
|
|
|
|
|
it('should not call add for main post fixture if it is already found', function (done) {
|
2020-04-29 18:44:27 +03:00
|
|
|
const postOneStub = sinon.stub(models.Post, 'findOne').returns(Promise.resolve({}));
|
|
|
|
const postAddStub = sinon.stub(models.Post, 'add').returns(Promise.resolve({}));
|
2018-03-27 17:16:15 +03:00
|
|
|
|
2019-09-12 16:54:39 +03:00
|
|
|
fixtureUtils.addFixturesForModel(fixtures.models[4]).then(function (result) {
|
2016-04-08 12:09:26 +03:00
|
|
|
should.exist(result);
|
|
|
|
result.should.be.an.Object();
|
2018-08-08 15:24:56 +03:00
|
|
|
result.should.have.property('expected', 7);
|
2017-03-21 11:24:11 +03:00
|
|
|
result.should.have.property('done', 0);
|
2016-04-08 12:09:26 +03:00
|
|
|
|
2018-08-08 15:24:56 +03:00
|
|
|
postOneStub.callCount.should.eql(7);
|
2017-06-08 18:36:14 +03:00
|
|
|
postAddStub.callCount.should.eql(0);
|
2016-04-08 12:09:26 +03:00
|
|
|
|
|
|
|
done();
|
2017-03-13 14:44:44 +03:00
|
|
|
}).catch(done);
|
2016-04-08 12:09:26 +03:00
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('Add Fixtures For Relation', function () {
|
|
|
|
it('should call attach for permissions-roles', function (done) {
|
2020-04-29 18:44:27 +03:00
|
|
|
const fromItem = {
|
|
|
|
related: sinon.stub().returnsThis(),
|
|
|
|
findWhere: sinon.stub().returns()
|
|
|
|
};
|
|
|
|
|
|
|
|
const toItem = [{get: sinon.stub()}];
|
|
|
|
|
|
|
|
const dataMethodStub = {
|
|
|
|
filter: sinon.stub().returns(toItem),
|
|
|
|
find: sinon.stub().returns(fromItem)
|
|
|
|
};
|
|
|
|
|
|
|
|
const baseUtilAttachStub = sinon.stub(baseUtils, 'attach').returns(Promise.resolve([{}]));
|
|
|
|
const permsAllStub = sinon.stub(models.Permission, 'findAll').returns(Promise.resolve(dataMethodStub));
|
|
|
|
const rolesAllStub = sinon.stub(models.Role, 'findAll').returns(Promise.resolve(dataMethodStub));
|
2016-04-08 12:09:26 +03:00
|
|
|
|
|
|
|
fixtureUtils.addFixturesForRelation(fixtures.relations[0]).then(function (result) {
|
|
|
|
should.exist(result);
|
|
|
|
result.should.be.an.Object();
|
2020-08-18 11:47:56 +03:00
|
|
|
result.should.have.property('expected', 69);
|
|
|
|
result.should.have.property('done', 69);
|
2016-04-08 12:09:26 +03:00
|
|
|
|
|
|
|
// Permissions & Roles
|
|
|
|
permsAllStub.calledOnce.should.be.true();
|
|
|
|
rolesAllStub.calledOnce.should.be.true();
|
2020-08-18 11:47:56 +03:00
|
|
|
dataMethodStub.filter.callCount.should.eql(69);
|
2019-07-31 23:34:49 +03:00
|
|
|
dataMethodStub.find.callCount.should.eql(7);
|
2020-08-18 11:47:56 +03:00
|
|
|
baseUtilAttachStub.callCount.should.eql(69);
|
2016-04-08 12:09:26 +03:00
|
|
|
|
2020-08-18 11:47:56 +03:00
|
|
|
fromItem.related.callCount.should.eql(69);
|
|
|
|
fromItem.findWhere.callCount.should.eql(69);
|
|
|
|
toItem[0].get.callCount.should.eql(138);
|
2016-04-08 12:09:26 +03:00
|
|
|
|
|
|
|
done();
|
|
|
|
}).catch(done);
|
|
|
|
});
|
|
|
|
|
|
|
|
it('should call attach for posts-tags', function (done) {
|
2020-04-29 18:44:27 +03:00
|
|
|
const fromItem = {
|
|
|
|
related: sinon.stub().returnsThis(),
|
|
|
|
findWhere: sinon.stub().returns()
|
|
|
|
};
|
|
|
|
|
|
|
|
const toItem = [{get: sinon.stub()}];
|
|
|
|
|
|
|
|
const dataMethodStub = {
|
|
|
|
filter: sinon.stub().returns(toItem),
|
|
|
|
find: sinon.stub().returns(fromItem)
|
|
|
|
};
|
|
|
|
|
|
|
|
const baseUtilAttachStub = sinon.stub(baseUtils, 'attach').returns(Promise.resolve([{}]));
|
|
|
|
const postsAllStub = sinon.stub(models.Post, 'findAll').returns(Promise.resolve(dataMethodStub));
|
|
|
|
const tagsAllStub = sinon.stub(models.Tag, 'findAll').returns(Promise.resolve(dataMethodStub));
|
2016-04-08 12:09:26 +03:00
|
|
|
|
|
|
|
fixtureUtils.addFixturesForRelation(fixtures.relations[1]).then(function (result) {
|
|
|
|
should.exist(result);
|
|
|
|
result.should.be.an.Object();
|
2017-06-08 18:36:14 +03:00
|
|
|
result.should.have.property('expected', 7);
|
|
|
|
result.should.have.property('done', 7);
|
2016-04-08 12:09:26 +03:00
|
|
|
|
|
|
|
// Posts & Tags
|
|
|
|
postsAllStub.calledOnce.should.be.true();
|
|
|
|
tagsAllStub.calledOnce.should.be.true();
|
2017-06-08 18:36:14 +03:00
|
|
|
dataMethodStub.filter.callCount.should.eql(7);
|
|
|
|
dataMethodStub.find.callCount.should.eql(7);
|
|
|
|
fromItem.related.callCount.should.eql(7);
|
|
|
|
fromItem.findWhere.callCount.should.eql(7);
|
|
|
|
toItem[0].get.callCount.should.eql(7);
|
|
|
|
baseUtilAttachStub.callCount.should.eql(7);
|
2016-04-08 12:09:26 +03:00
|
|
|
|
|
|
|
done();
|
|
|
|
}).catch(done);
|
|
|
|
});
|
|
|
|
|
|
|
|
it('will not call attach for posts-tags if already present', function (done) {
|
2020-04-29 18:44:27 +03:00
|
|
|
const fromItem = {
|
|
|
|
related: sinon.stub().returnsThis(),
|
|
|
|
findWhere: sinon.stub().returns({}),
|
|
|
|
tags: sinon.stub().returnsThis(),
|
|
|
|
attach: sinon.stub().returns(Promise.resolve({}))
|
|
|
|
};
|
|
|
|
|
|
|
|
const toItem = [{get: sinon.stub()}];
|
|
|
|
|
|
|
|
const dataMethodStub = {
|
|
|
|
filter: sinon.stub().returns(toItem),
|
|
|
|
find: sinon.stub().returns(fromItem)
|
|
|
|
};
|
|
|
|
|
|
|
|
const postsAllStub = sinon.stub(models.Post, 'findAll').returns(Promise.resolve(dataMethodStub));
|
|
|
|
const tagsAllStub = sinon.stub(models.Tag, 'findAll').returns(Promise.resolve(dataMethodStub));
|
2016-04-08 12:09:26 +03:00
|
|
|
|
|
|
|
fixtureUtils.addFixturesForRelation(fixtures.relations[1]).then(function (result) {
|
|
|
|
should.exist(result);
|
|
|
|
result.should.be.an.Object();
|
2017-06-08 18:36:14 +03:00
|
|
|
result.should.have.property('expected', 7);
|
2017-03-21 11:24:11 +03:00
|
|
|
result.should.have.property('done', 0);
|
2016-04-08 12:09:26 +03:00
|
|
|
|
|
|
|
// Posts & Tags
|
|
|
|
postsAllStub.calledOnce.should.be.true();
|
|
|
|
tagsAllStub.calledOnce.should.be.true();
|
2017-06-08 18:36:14 +03:00
|
|
|
dataMethodStub.filter.callCount.should.eql(7);
|
|
|
|
dataMethodStub.find.callCount.should.eql(7);
|
2016-04-08 12:09:26 +03:00
|
|
|
|
2017-06-08 18:36:14 +03:00
|
|
|
fromItem.related.callCount.should.eql(7);
|
|
|
|
fromItem.findWhere.callCount.should.eql(7);
|
|
|
|
toItem[0].get.callCount.should.eql(7);
|
2016-04-08 12:09:26 +03:00
|
|
|
|
|
|
|
fromItem.tags.called.should.be.false();
|
|
|
|
fromItem.attach.called.should.be.false();
|
|
|
|
|
|
|
|
done();
|
|
|
|
}).catch(done);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('findModelFixtureEntry', function () {
|
|
|
|
it('should fetch a single fixture entry', function () {
|
2020-04-29 18:44:27 +03:00
|
|
|
const foundFixture = fixtureUtils.findModelFixtureEntry('Integration', {slug: 'zapier'});
|
2016-04-08 12:09:26 +03:00
|
|
|
foundFixture.should.be.an.Object();
|
|
|
|
foundFixture.should.eql({
|
2019-09-12 16:54:39 +03:00
|
|
|
slug: 'zapier',
|
|
|
|
name: 'Zapier',
|
|
|
|
description: 'Built-in Zapier integration',
|
|
|
|
type: 'builtin',
|
|
|
|
api_keys: [{type: 'admin'}]
|
2016-04-08 12:09:26 +03:00
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('findModelFixtures', function () {
|
|
|
|
it('should fetch a fixture with multiple entries', function () {
|
2020-04-29 18:44:27 +03:00
|
|
|
const foundFixture = fixtureUtils.findModelFixtures('Permission', {object_type: 'db'});
|
2016-04-08 12:09:26 +03:00
|
|
|
foundFixture.should.be.an.Object();
|
2019-08-07 09:12:11 +03:00
|
|
|
foundFixture.entries.should.be.an.Array().with.lengthOf(4);
|
2016-04-08 12:09:26 +03:00
|
|
|
foundFixture.entries[0].should.eql({
|
2019-08-09 01:53:59 +03:00
|
|
|
name: 'Export database',
|
|
|
|
action_type: 'exportContent',
|
|
|
|
object_type: 'db'
|
|
|
|
});
|
|
|
|
foundFixture.entries[3].should.eql({
|
2019-08-07 09:12:11 +03:00
|
|
|
name: 'Backup database',
|
|
|
|
action_type: 'backupContent',
|
2016-04-08 12:09:26 +03:00
|
|
|
object_type: 'db'
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('findPermissionRelationsForObject', function () {
|
|
|
|
it('should fetch a fixture with multiple entries', function () {
|
2020-04-29 18:44:27 +03:00
|
|
|
const foundFixture = fixtureUtils.findPermissionRelationsForObject('db');
|
2016-04-08 12:09:26 +03:00
|
|
|
foundFixture.should.be.an.Object();
|
|
|
|
foundFixture.entries.should.be.an.Object();
|
|
|
|
foundFixture.entries.should.have.property('Administrator', {db: 'all'});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|