2019-03-06 14:56:26 +03:00
|
|
|
const should = require('should');
|
2019-03-26 06:37:32 +03:00
|
|
|
const sinon = require('sinon');
|
|
|
|
const mockDb = require('mock-knex');
|
2019-03-06 14:56:26 +03:00
|
|
|
const models = require('../../../server/models');
|
2019-03-26 06:37:32 +03:00
|
|
|
const {knex} = require('../../../server/data/db');
|
|
|
|
const common = require('../../../server/lib/common');
|
2019-03-06 14:56:26 +03:00
|
|
|
|
|
|
|
describe('Unit: models/settings', function () {
|
|
|
|
before(function () {
|
|
|
|
models.init();
|
|
|
|
});
|
|
|
|
|
2019-03-26 06:37:32 +03:00
|
|
|
describe('events', function () {
|
|
|
|
let tracker;
|
|
|
|
let eventSpy;
|
|
|
|
|
|
|
|
beforeEach(function () {
|
|
|
|
mockDb.mock(knex);
|
|
|
|
tracker = mockDb.getTracker();
|
|
|
|
tracker.install();
|
|
|
|
});
|
|
|
|
|
|
|
|
afterEach(function () {
|
|
|
|
mockDb.unmock(knex);
|
|
|
|
});
|
|
|
|
|
|
|
|
beforeEach(function () {
|
|
|
|
eventSpy = sinon.spy(common.events, 'emit');
|
|
|
|
});
|
|
|
|
|
|
|
|
afterEach(function () {
|
|
|
|
sinon.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
it('emits add events', function () {
|
|
|
|
tracker.on('query', (query, step) => {
|
|
|
|
return [
|
|
|
|
function fetchAddQuery() {
|
|
|
|
query.response([{}]);
|
|
|
|
},
|
|
|
|
function addQuery() {
|
|
|
|
query.response([{
|
|
|
|
key: 'description',
|
|
|
|
value: 'added value'
|
|
|
|
}]);
|
|
|
|
}
|
|
|
|
][step - 1]();
|
|
|
|
});
|
|
|
|
|
|
|
|
return models.Settings.edit({
|
2019-08-19 14:41:09 +03:00
|
|
|
key: 'description',
|
|
|
|
value: 'added value'
|
|
|
|
})
|
2019-03-26 06:37:32 +03:00
|
|
|
.then(() => {
|
|
|
|
eventSpy.calledTwice.should.be.true();
|
|
|
|
eventSpy.firstCall.calledWith('settings.added').should.be.true();
|
|
|
|
eventSpy.secondCall.calledWith('settings.description.added').should.be.true();
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('emits edit events', function () {
|
|
|
|
tracker.on('query', (query, step) => {
|
|
|
|
return [
|
|
|
|
function fetchEditQuery() {
|
|
|
|
query.response([{
|
2019-08-19 14:41:09 +03:00
|
|
|
id: 1, // NOTE: `id` imitates existing value for 'edit' event
|
2019-03-26 06:37:32 +03:00
|
|
|
key: 'description',
|
|
|
|
value: 'db value'
|
|
|
|
}]);
|
|
|
|
}
|
|
|
|
][step - 1]();
|
|
|
|
});
|
|
|
|
|
|
|
|
return models.Settings.edit({
|
2019-08-19 14:41:09 +03:00
|
|
|
key: 'description',
|
|
|
|
value: 'edited value'
|
|
|
|
})
|
2019-03-26 06:37:32 +03:00
|
|
|
.then(() => {
|
|
|
|
eventSpy.calledTwice.should.be.true();
|
|
|
|
eventSpy.firstCall.calledWith('settings.edited').should.be.true();
|
|
|
|
eventSpy.secondCall.calledWith('settings.description.edited').should.be.true();
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('defaults', function () {
|
|
|
|
let tracker;
|
|
|
|
let eventSpy;
|
|
|
|
|
|
|
|
beforeEach(function () {
|
|
|
|
mockDb.mock(knex);
|
|
|
|
tracker = mockDb.getTracker();
|
|
|
|
tracker.install();
|
|
|
|
});
|
|
|
|
|
|
|
|
afterEach(function () {
|
|
|
|
mockDb.unmock(knex);
|
|
|
|
tracker.uninstall();
|
|
|
|
});
|
|
|
|
|
|
|
|
beforeEach(function () {
|
|
|
|
eventSpy = sinon.spy(common.events, 'emit');
|
|
|
|
});
|
|
|
|
|
|
|
|
afterEach(function () {
|
|
|
|
sinon.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
it('populates unset defaults', function () {
|
|
|
|
tracker.on('query', (query) => {
|
|
|
|
return query.response([{}]);
|
|
|
|
});
|
|
|
|
|
|
|
|
return models.Settings.populateDefaults()
|
|
|
|
.then(() => {
|
2019-07-18 17:24:34 +03:00
|
|
|
eventSpy.callCount.should.equal(78);
|
2019-03-26 06:37:32 +03:00
|
|
|
|
|
|
|
eventSpy.args[1][0].should.equal('settings.db_hash.added');
|
|
|
|
eventSpy.args[1][1].attributes.type.should.equal('core');
|
|
|
|
|
Updated theme layer to use members-ssr (#10676)
* Removed support for cookies in members auth middleware
no-issue
The members middleware will no longer be supporting cookies, the cookie
will be handled by a new middleware specific for serverside rendering,
more informations can be found here:
https://paper.dropbox.com/doc/Members-Auth-II-4WP4vF6coMqDYbSMIajo5
* Removed members auth middleware from site app
no-issue
The site app no longer needs the members auth middleware as it doesn't
support cookies, and will be replaced by ssr specific middleware.
https://paper.dropbox.com/doc/Members-Auth-II-4WP4vF6coMqDYbSMIajo5
* Added comment for session_secret setting
no-issue
We are going to have multiple concepts of sessions, so adding a comment
here to be specific that this is for the Ghost Admin client
* Added theme_session_secret setting dynamic default
no-issue
Sessions for the theme layer will be signed, so we generate a random hex
string to use as a signing key
* Added getPublicConfig method
* Replaced export of httpHandler with POJO apiInstance
no-issue
This is mainly to reduce the public api, so it's easier to document.
* Renamed memberUserObject -> members
no-issue
Simplifies the interface, and is more inline with what we would want to export as an api library.
* Removed use of require options inside members
no-issue
This was too tight of a coupling between Ghost and Members
* Simplified apiInstance definition
no-issue
* Added getMember method to members api
* Added MembersSSR instance to members service
* Wired up routes for members ssr
* Updated members auth middleware to use getPublicConfig
* Removed publicKey static export from members service
* Used real session secret
no-issue
* Added DELETE /members/ssr handler
no-issue
This allows users to log out of the theme layer
* Fixed missing code property
no-issue
Ignition uses the statusCode property to forward status codes to call sites
* Removed superfluous error middleware
no-issue
Before we used generic JWT middleware which would reject, now the
middleware catches it's own error and doesn't error, thus this
middleware is unecessary.
* Removed console.logs
no-issue
* Updated token expirty to hardcoded 20 minutes
no-issue
This returns to our previous state of using short lived tokens, both for
security and simplicity.
* Removed hardcoded default member settings
no-issue
This is no longer needed, as defaults are in default-settings.json
* Removed stripe from default payment processor
no-issue
* Exported `getSiteUrl` method from url utils
no-issue
This keeps inline with newer naming conventions
* Updated how audience access control works
no-issue
Rather than being passed a function, members api now receives an object
which describes which origins have access to which audiences, and how
long those tokens should be allowed to work for. It also allows syntax
for default tokens where audience === origin requesting it. This can be
set to undefined or null to disable this functionality.
{
"http://site.com": {
"http://site.com": {
tokenLength: '5m'
},
"http://othersite.com": {
tokenLength: '1h'
}
},
"*": {
tokenLength: '30m'
}
}
* Updated members service to use access control feature
no-issue
This also cleans up a lot of unecessary variable definitions, and some
other minor cleanups.
* Added status code to auth pages html response
no-issue
This was missing, probably default but better to be explicit
* Updated gateway to have membersApiUrl from config
no-issue
Previously we were parsing the url, this was not very safe as we can
have Ghost hosted on a subdomain, and this would have failed.
* Added issuer to public config for members
no-issue
This can be used to request SSR tokens in the client
* Fixed path for gateway bundle
no-issue
* Updated settings model tests
no-issue
* Revert "Removed stripe from default payment processor"
This reverts commit 1d88d9b6d73a10091070bcc1b7f5779d071c7845.
* Revert "Removed hardcoded default member settings"
This reverts commit 9d899048ba7d4b272b9ac65a95a52af66b30914a.
* Installed @tryghost/members-ssr
* Fixed tests for settings model
2019-04-16 17:50:25 +03:00
|
|
|
eventSpy.args[13][0].should.equal('settings.description.added');
|
|
|
|
eventSpy.args[13][1].attributes.type.should.equal('blog');
|
|
|
|
eventSpy.args[13][1].attributes.value.should.equal('The professional publishing platform');
|
2019-03-26 06:37:32 +03:00
|
|
|
|
2019-07-18 17:24:34 +03:00
|
|
|
eventSpy.args[77][0].should.equal('settings.members_subscription_settings.added');
|
2019-03-26 06:37:32 +03:00
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('doesn\'t overwrite any existing settings', function () {
|
|
|
|
tracker.on('query', (query) => {
|
|
|
|
return query.response([{
|
|
|
|
key: 'description',
|
|
|
|
value: 'Adam\'s Blog'
|
|
|
|
}]);
|
|
|
|
});
|
|
|
|
|
|
|
|
return models.Settings.populateDefaults()
|
|
|
|
.then(() => {
|
2019-07-18 17:24:34 +03:00
|
|
|
eventSpy.callCount.should.equal(76);
|
2019-03-26 06:37:32 +03:00
|
|
|
|
Updated theme layer to use members-ssr (#10676)
* Removed support for cookies in members auth middleware
no-issue
The members middleware will no longer be supporting cookies, the cookie
will be handled by a new middleware specific for serverside rendering,
more informations can be found here:
https://paper.dropbox.com/doc/Members-Auth-II-4WP4vF6coMqDYbSMIajo5
* Removed members auth middleware from site app
no-issue
The site app no longer needs the members auth middleware as it doesn't
support cookies, and will be replaced by ssr specific middleware.
https://paper.dropbox.com/doc/Members-Auth-II-4WP4vF6coMqDYbSMIajo5
* Added comment for session_secret setting
no-issue
We are going to have multiple concepts of sessions, so adding a comment
here to be specific that this is for the Ghost Admin client
* Added theme_session_secret setting dynamic default
no-issue
Sessions for the theme layer will be signed, so we generate a random hex
string to use as a signing key
* Added getPublicConfig method
* Replaced export of httpHandler with POJO apiInstance
no-issue
This is mainly to reduce the public api, so it's easier to document.
* Renamed memberUserObject -> members
no-issue
Simplifies the interface, and is more inline with what we would want to export as an api library.
* Removed use of require options inside members
no-issue
This was too tight of a coupling between Ghost and Members
* Simplified apiInstance definition
no-issue
* Added getMember method to members api
* Added MembersSSR instance to members service
* Wired up routes for members ssr
* Updated members auth middleware to use getPublicConfig
* Removed publicKey static export from members service
* Used real session secret
no-issue
* Added DELETE /members/ssr handler
no-issue
This allows users to log out of the theme layer
* Fixed missing code property
no-issue
Ignition uses the statusCode property to forward status codes to call sites
* Removed superfluous error middleware
no-issue
Before we used generic JWT middleware which would reject, now the
middleware catches it's own error and doesn't error, thus this
middleware is unecessary.
* Removed console.logs
no-issue
* Updated token expirty to hardcoded 20 minutes
no-issue
This returns to our previous state of using short lived tokens, both for
security and simplicity.
* Removed hardcoded default member settings
no-issue
This is no longer needed, as defaults are in default-settings.json
* Removed stripe from default payment processor
no-issue
* Exported `getSiteUrl` method from url utils
no-issue
This keeps inline with newer naming conventions
* Updated how audience access control works
no-issue
Rather than being passed a function, members api now receives an object
which describes which origins have access to which audiences, and how
long those tokens should be allowed to work for. It also allows syntax
for default tokens where audience === origin requesting it. This can be
set to undefined or null to disable this functionality.
{
"http://site.com": {
"http://site.com": {
tokenLength: '5m'
},
"http://othersite.com": {
tokenLength: '1h'
}
},
"*": {
tokenLength: '30m'
}
}
* Updated members service to use access control feature
no-issue
This also cleans up a lot of unecessary variable definitions, and some
other minor cleanups.
* Added status code to auth pages html response
no-issue
This was missing, probably default but better to be explicit
* Updated gateway to have membersApiUrl from config
no-issue
Previously we were parsing the url, this was not very safe as we can
have Ghost hosted on a subdomain, and this would have failed.
* Added issuer to public config for members
no-issue
This can be used to request SSR tokens in the client
* Fixed path for gateway bundle
no-issue
* Updated settings model tests
no-issue
* Revert "Removed stripe from default payment processor"
This reverts commit 1d88d9b6d73a10091070bcc1b7f5779d071c7845.
* Revert "Removed hardcoded default member settings"
This reverts commit 9d899048ba7d4b272b9ac65a95a52af66b30914a.
* Installed @tryghost/members-ssr
* Fixed tests for settings model
2019-04-16 17:50:25 +03:00
|
|
|
eventSpy.args[13][0].should.equal('settings.logo.added');
|
2019-03-26 06:37:32 +03:00
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
2019-03-06 14:56:26 +03:00
|
|
|
describe('parse', function () {
|
|
|
|
it('ensure correct parsing when fetching from db', function () {
|
|
|
|
const setting = models.Settings.forge();
|
|
|
|
|
|
|
|
let returns = setting.parse({key: 'is_private', value: 'false'});
|
|
|
|
should.equal(returns.value, false);
|
|
|
|
|
|
|
|
returns = setting.parse({key: 'is_private', value: false});
|
|
|
|
should.equal(returns.value, false);
|
|
|
|
|
|
|
|
returns = setting.parse({key: 'is_private', value: true});
|
|
|
|
should.equal(returns.value, true);
|
|
|
|
|
|
|
|
returns = setting.parse({key: 'is_private', value: 'true'});
|
|
|
|
should.equal(returns.value, true);
|
|
|
|
|
|
|
|
returns = setting.parse({key: 'is_private', value: '0'});
|
|
|
|
should.equal(returns.value, false);
|
|
|
|
|
|
|
|
returns = setting.parse({key: 'is_private', value: '1'});
|
|
|
|
should.equal(returns.value, true);
|
|
|
|
|
|
|
|
returns = setting.parse({key: 'something', value: 'null'});
|
2019-03-11 19:25:45 +03:00
|
|
|
should.equal(returns.value, 'null');
|
2019-03-06 14:56:26 +03:00
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|