TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-12 16:14:25 +03:00
Code Issues Projects Releases Wiki Activity
b510d9a12c
Ghost/core/test/unit/migration_fixture_spec.js

944 lines
49 KiB
JavaScript
Raw Normal View History

Refactor & test fixture migrations refs #6301 Fixtures: - Removed all the old (and now broken) 003 fixture upgrades - Split the 004 fixture upgrade tasks out, each into their own file - Improved the versioning code that figured out which upgrades we should do - Added lots of test coverage to make sure all the fixtures are still being run correctly. Permissions fixtures: - Changed the code that was populating permissions fixtures to be more automated & based only on what is in the permissions.json file. - Added lots of test coverage to make sure all the permissions are still being created correctly. Merging the two things: - Merged the content of permissions.json and fixtures.json into fixtures.json, but using the new structure from permissions.json. - Changed to use the new automated model & relation creation for all fixtures, not just permissions. - The only thing that can't be auto-populated just now is the owner creation, I think that's important enough to do separately. - There were (so far) never any permission updates, so code for updating fixtures stays the same through the merge. - This results in two clear code paths: populate (fill out a brand new DB) and update (make any changes since the last version) Test coverage is now 100% across both updates and populations.
2016-02-25 10:10:36 +03:00
/*global describe, it, beforeEach, afterEach */
var should = require('should'),
sinon = require('sinon'),
rewire = require('rewire'),
Promise = require('bluebird'),
// Stuff we are testing
configUtils = require('../utils/configUtils'),
models = require('../../server/models'),
notifications = require('../../server/api/notifications'),
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
versioning = require('../../server/data/schema/versioning'),
Refactor & test fixture migrations refs #6301 Fixtures: - Removed all the old (and now broken) 003 fixture upgrades - Split the 004 fixture upgrade tasks out, each into their own file - Improved the versioning code that figured out which upgrades we should do - Added lots of test coverage to make sure all the fixtures are still being run correctly. Permissions fixtures: - Changed the code that was populating permissions fixtures to be more automated & based only on what is in the permissions.json file. - Added lots of test coverage to make sure all the permissions are still being created correctly. Merging the two things: - Merged the content of permissions.json and fixtures.json into fixtures.json, but using the new structure from permissions.json. - Changed to use the new automated model & relation creation for all fixtures, not just permissions. - The only thing that can't be auto-populated just now is the owner creation, I think that's important enough to do separately. - There were (so far) never any permission updates, so code for updating fixtures stays the same through the merge. - This results in two clear code paths: populate (fill out a brand new DB) and update (make any changes since the last version) Test coverage is now 100% across both updates and populations.
2016-02-25 10:10:36 +03:00
update = rewire('../../server/data/migration/fixtures/update'),
populate = rewire('../../server/data/migration/fixtures/populate'),
Improve fixtures & population code refs #6301 - The order of model fixtures matters, so they should be in an array - By splitting out the population code into a utils file, it'll be possible to use this to do updates as well - This should make it much easier to do permissions updates in future
2016-03-29 16:14:44 +03:00
fixtureUtils = rewire('../../server/data/migration/fixtures/utils'),
Refactor & test fixture migrations refs #6301 Fixtures: - Removed all the old (and now broken) 003 fixture upgrades - Split the 004 fixture upgrade tasks out, each into their own file - Improved the versioning code that figured out which upgrades we should do - Added lots of test coverage to make sure all the fixtures are still being run correctly. Permissions fixtures: - Changed the code that was populating permissions fixtures to be more automated & based only on what is in the permissions.json file. - Added lots of test coverage to make sure all the permissions are still being created correctly. Merging the two things: - Merged the content of permissions.json and fixtures.json into fixtures.json, but using the new structure from permissions.json. - Changed to use the new automated model & relation creation for all fixtures, not just permissions. - The only thing that can't be auto-populated just now is the owner creation, I think that's important enough to do separately. - There were (so far) never any permission updates, so code for updating fixtures stays the same through the merge. - This results in two clear code paths: populate (fill out a brand new DB) and update (make any changes since the last version) Test coverage is now 100% across both updates and populations.
2016-02-25 10:10:36 +03:00
fixtures004 = require('../../server/data/migration/fixtures/004'),
Split migrations/index.js & add tests refs #6301 - changes createTable to use createTableIfNotExists, this is consistent with deletion - splits out backup, reset, update and populate functions from migration/index into their own files - moves the wrapped function for populatingDefaultSettings to fixtures.ensureDefaultSettings - moves `modelOptions` down to the fixture files that actually use it - adds test coverage for backup, reset and populate, but not for update as that needs refactoring
2016-03-13 23:49:30 +03:00
ensureDefaultSettings = require('../../server/data/migration/fixtures/settings'),
Refactor & test fixture migrations refs #6301 Fixtures: - Removed all the old (and now broken) 003 fixture upgrades - Split the 004 fixture upgrade tasks out, each into their own file - Improved the versioning code that figured out which upgrades we should do - Added lots of test coverage to make sure all the fixtures are still being run correctly. Permissions fixtures: - Changed the code that was populating permissions fixtures to be more automated & based only on what is in the permissions.json file. - Added lots of test coverage to make sure all the permissions are still being created correctly. Merging the two things: - Merged the content of permissions.json and fixtures.json into fixtures.json, but using the new structure from permissions.json. - Changed to use the new automated model & relation creation for all fixtures, not just permissions. - The only thing that can't be auto-populated just now is the owner creation, I think that's important enough to do separately. - There were (so far) never any permission updates, so code for updating fixtures stays the same through the merge. - This results in two clear code paths: populate (fill out a brand new DB) and update (make any changes since the last version) Test coverage is now 100% across both updates and populations.
2016-02-25 10:10:36 +03:00
sandbox = sinon.sandbox.create();
describe('Fixtures', function () {
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
var loggerStub;
Refactor content deletion - Simplify the `init` method in `models/index.js` so that it no longer returns a promise. Easier to use. - Eliminates the `deleteAllContent` method from `models/index.js` as it can all be handled at the API layer in a single spot. - Optimize `destroyAllContent` in `api/db.js`. Eliminates double-fetching every post from the database and converting it to JSON. Also only fetches ids from the database instead of the entire model. - Eliminates the custom static method `destroy` in the Post model in favor of handling detaching tag relations in a single place (the `destroying` event). This also eliminates a big source of unneeded database round trips--needing to get post ids to feed into `Post.destroy()` which then re-fetches the post again.
2016-03-02 07:42:01 +03:00
beforeEach(function () {
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
loggerStub = {
info: sandbox.stub(),
warn: sandbox.stub()
};
Refactor content deletion - Simplify the `init` method in `models/index.js` so that it no longer returns a promise. Easier to use. - Eliminates the `deleteAllContent` method from `models/index.js` as it can all be handled at the API layer in a single spot. - Optimize `destroyAllContent` in `api/db.js`. Eliminates double-fetching every post from the database and converting it to JSON. Also only fetches ids from the database instead of the entire model. - Eliminates the custom static method `destroy` in the Post model in favor of handling detaching tag relations in a single place (the `destroying` event). This also eliminates a big source of unneeded database round trips--needing to get post ids to feed into `Post.destroy()` which then re-fetches the post again.
2016-03-02 07:42:01 +03:00
models.init();
Refactor & test fixture migrations refs #6301 Fixtures: - Removed all the old (and now broken) 003 fixture upgrades - Split the 004 fixture upgrade tasks out, each into their own file - Improved the versioning code that figured out which upgrades we should do - Added lots of test coverage to make sure all the fixtures are still being run correctly. Permissions fixtures: - Changed the code that was populating permissions fixtures to be more automated & based only on what is in the permissions.json file. - Added lots of test coverage to make sure all the permissions are still being created correctly. Merging the two things: - Merged the content of permissions.json and fixtures.json into fixtures.json, but using the new structure from permissions.json. - Changed to use the new automated model & relation creation for all fixtures, not just permissions. - The only thing that can't be auto-populated just now is the owner creation, I think that's important enough to do separately. - There were (so far) never any permission updates, so code for updating fixtures stays the same through the merge. - This results in two clear code paths: populate (fill out a brand new DB) and update (make any changes since the last version) Test coverage is now 100% across both updates and populations.
2016-02-25 10:10:36 +03:00
});
afterEach(function () {
sandbox.restore();
configUtils.restore();
});
describe('Update fixtures', function () {
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
it('should call `getUpdateFixturesTasks` when upgrading from 003 -> 004', function (done) {
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
var getVersionTasksStub = sandbox.stub(versioning, 'getUpdateFixturesTasks').returns([]);
Refactor & test fixture migrations refs #6301 Fixtures: - Removed all the old (and now broken) 003 fixture upgrades - Split the 004 fixture upgrade tasks out, each into their own file - Improved the versioning code that figured out which upgrades we should do - Added lots of test coverage to make sure all the fixtures are still being run correctly. Permissions fixtures: - Changed the code that was populating permissions fixtures to be more automated & based only on what is in the permissions.json file. - Added lots of test coverage to make sure all the permissions are still being created correctly. Merging the two things: - Merged the content of permissions.json and fixtures.json into fixtures.json, but using the new structure from permissions.json. - Changed to use the new automated model & relation creation for all fixtures, not just permissions. - The only thing that can't be auto-populated just now is the owner creation, I think that's important enough to do separately. - There were (so far) never any permission updates, so code for updating fixtures stays the same through the merge. - This results in two clear code paths: populate (fill out a brand new DB) and update (make any changes since the last version) Test coverage is now 100% across both updates and populations.
2016-02-25 10:10:36 +03:00
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
update(['004'], loggerStub).then(function () {
loggerStub.info.calledOnce.should.be.true();
loggerStub.warn.called.should.be.false();
Refactor & test fixture migrations refs #6301 Fixtures: - Removed all the old (and now broken) 003 fixture upgrades - Split the 004 fixture upgrade tasks out, each into their own file - Improved the versioning code that figured out which upgrades we should do - Added lots of test coverage to make sure all the fixtures are still being run correctly. Permissions fixtures: - Changed the code that was populating permissions fixtures to be more automated & based only on what is in the permissions.json file. - Added lots of test coverage to make sure all the permissions are still being created correctly. Merging the two things: - Merged the content of permissions.json and fixtures.json into fixtures.json, but using the new structure from permissions.json. - Changed to use the new automated model & relation creation for all fixtures, not just permissions. - The only thing that can't be auto-populated just now is the owner creation, I think that's important enough to do separately. - There were (so far) never any permission updates, so code for updating fixtures stays the same through the merge. - This results in two clear code paths: populate (fill out a brand new DB) and update (make any changes since the last version) Test coverage is now 100% across both updates and populations.
2016-02-25 10:10:36 +03:00
getVersionTasksStub.calledOnce.should.be.true();
done();
}).catch(done);
});
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
it('should NOT call `getUpdateFixturesTasks` when upgrading from 004 -> 004', function (done) {
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
var getVersionTasksStub = sandbox.stub(versioning, 'getUpdateFixturesTasks').returns([]);
Refactor & test fixture migrations refs #6301 Fixtures: - Removed all the old (and now broken) 003 fixture upgrades - Split the 004 fixture upgrade tasks out, each into their own file - Improved the versioning code that figured out which upgrades we should do - Added lots of test coverage to make sure all the fixtures are still being run correctly. Permissions fixtures: - Changed the code that was populating permissions fixtures to be more automated & based only on what is in the permissions.json file. - Added lots of test coverage to make sure all the permissions are still being created correctly. Merging the two things: - Merged the content of permissions.json and fixtures.json into fixtures.json, but using the new structure from permissions.json. - Changed to use the new automated model & relation creation for all fixtures, not just permissions. - The only thing that can't be auto-populated just now is the owner creation, I think that's important enough to do separately. - There were (so far) never any permission updates, so code for updating fixtures stays the same through the merge. - This results in two clear code paths: populate (fill out a brand new DB) and update (make any changes since the last version) Test coverage is now 100% across both updates and populations.
2016-02-25 10:10:36 +03:00
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
update([], loggerStub).then(function () {
loggerStub.info.calledOnce.should.be.true();
loggerStub.warn.called.should.be.false();
Refactor & test fixture migrations refs #6301 Fixtures: - Removed all the old (and now broken) 003 fixture upgrades - Split the 004 fixture upgrade tasks out, each into their own file - Improved the versioning code that figured out which upgrades we should do - Added lots of test coverage to make sure all the fixtures are still being run correctly. Permissions fixtures: - Changed the code that was populating permissions fixtures to be more automated & based only on what is in the permissions.json file. - Added lots of test coverage to make sure all the permissions are still being created correctly. Merging the two things: - Merged the content of permissions.json and fixtures.json into fixtures.json, but using the new structure from permissions.json. - Changed to use the new automated model & relation creation for all fixtures, not just permissions. - The only thing that can't be auto-populated just now is the owner creation, I think that's important enough to do separately. - There were (so far) never any permission updates, so code for updating fixtures stays the same through the merge. - This results in two clear code paths: populate (fill out a brand new DB) and update (make any changes since the last version) Test coverage is now 100% across both updates and populations.
2016-02-25 10:10:36 +03:00
getVersionTasksStub.calledOnce.should.be.false();
done();
}).catch(done);
});
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
it('should call tasks in correct order if provided', function (done) {
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
var task1Stub = sandbox.stub().returns(Promise.resolve()),
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
task2Stub = sandbox.stub().returns(Promise.resolve()),
getVersionTasksStub = sandbox.stub(versioning, 'getUpdateFixturesTasks').returns([task1Stub, task2Stub]);
Refactor & test fixture migrations refs #6301 Fixtures: - Removed all the old (and now broken) 003 fixture upgrades - Split the 004 fixture upgrade tasks out, each into their own file - Improved the versioning code that figured out which upgrades we should do - Added lots of test coverage to make sure all the fixtures are still being run correctly. Permissions fixtures: - Changed the code that was populating permissions fixtures to be more automated & based only on what is in the permissions.json file. - Added lots of test coverage to make sure all the permissions are still being created correctly. Merging the two things: - Merged the content of permissions.json and fixtures.json into fixtures.json, but using the new structure from permissions.json. - Changed to use the new automated model & relation creation for all fixtures, not just permissions. - The only thing that can't be auto-populated just now is the owner creation, I think that's important enough to do separately. - There were (so far) never any permission updates, so code for updating fixtures stays the same through the merge. - This results in two clear code paths: populate (fill out a brand new DB) and update (make any changes since the last version) Test coverage is now 100% across both updates and populations.
2016-02-25 10:10:36 +03:00
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
update(['000'], loggerStub).then(function () {
loggerStub.info.calledTwice.should.be.true();
loggerStub.warn.called.should.be.false();
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
getVersionTasksStub.calledOnce.should.be.true();
task1Stub.calledOnce.should.be.true();
task2Stub.calledOnce.should.be.true();
done();
}).catch(done);
Refactor & test fixture migrations refs #6301 Fixtures: - Removed all the old (and now broken) 003 fixture upgrades - Split the 004 fixture upgrade tasks out, each into their own file - Improved the versioning code that figured out which upgrades we should do - Added lots of test coverage to make sure all the fixtures are still being run correctly. Permissions fixtures: - Changed the code that was populating permissions fixtures to be more automated & based only on what is in the permissions.json file. - Added lots of test coverage to make sure all the permissions are still being created correctly. Merging the two things: - Merged the content of permissions.json and fixtures.json into fixtures.json, but using the new structure from permissions.json. - Changed to use the new automated model & relation creation for all fixtures, not just permissions. - The only thing that can't be auto-populated just now is the owner creation, I think that's important enough to do separately. - There were (so far) never any permission updates, so code for updating fixtures stays the same through the merge. - This results in two clear code paths: populate (fill out a brand new DB) and update (make any changes since the last version) Test coverage is now 100% across both updates and populations.
2016-02-25 10:10:36 +03:00
});
describe('Update to 004', function () {
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
it('should call all the 004 fixture upgrade tasks', function (done) {
// Setup
// Create a new stub, this will replace sequence, so that db calls don't actually get run
var sequenceStub = sandbox.stub(),
sequenceReset = update.__set__('sequence', sequenceStub);
// The first time we call sequence, it should be to execute a top level version, e.g 004
// yieldsTo('0') means this stub will execute the function at index 0 of the array passed as the
// first argument. In short the `runVersionTasks` function gets executed, and sequence gets called
// again with the array of tasks to execute for 004, which is what we want to check
sequenceStub.onFirstCall().yieldsTo('0').returns(Promise.resolve([]));
Refactor & test fixture migrations refs #6301 Fixtures: - Removed all the old (and now broken) 003 fixture upgrades - Split the 004 fixture upgrade tasks out, each into their own file - Improved the versioning code that figured out which upgrades we should do - Added lots of test coverage to make sure all the fixtures are still being run correctly. Permissions fixtures: - Changed the code that was populating permissions fixtures to be more automated & based only on what is in the permissions.json file. - Added lots of test coverage to make sure all the permissions are still being created correctly. Merging the two things: - Merged the content of permissions.json and fixtures.json into fixtures.json, but using the new structure from permissions.json. - Changed to use the new automated model & relation creation for all fixtures, not just permissions. - The only thing that can't be auto-populated just now is the owner creation, I think that's important enough to do separately. - There were (so far) never any permission updates, so code for updating fixtures stays the same through the merge. - This results in two clear code paths: populate (fill out a brand new DB) and update (make any changes since the last version) Test coverage is now 100% across both updates and populations.
2016-02-25 10:10:36 +03:00
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
update(['004'], loggerStub).then(function (result) {
Refactor & test fixture migrations refs #6301 Fixtures: - Removed all the old (and now broken) 003 fixture upgrades - Split the 004 fixture upgrade tasks out, each into their own file - Improved the versioning code that figured out which upgrades we should do - Added lots of test coverage to make sure all the fixtures are still being run correctly. Permissions fixtures: - Changed the code that was populating permissions fixtures to be more automated & based only on what is in the permissions.json file. - Added lots of test coverage to make sure all the permissions are still being created correctly. Merging the two things: - Merged the content of permissions.json and fixtures.json into fixtures.json, but using the new structure from permissions.json. - Changed to use the new automated model & relation creation for all fixtures, not just permissions. - The only thing that can't be auto-populated just now is the owner creation, I think that's important enough to do separately. - There were (so far) never any permission updates, so code for updating fixtures stays the same through the merge. - This results in two clear code paths: populate (fill out a brand new DB) and update (make any changes since the last version) Test coverage is now 100% across both updates and populations.
2016-02-25 10:10:36 +03:00
should.exist(result);
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
loggerStub.info.calledTwice.should.be.true();
loggerStub.warn.called.should.be.false();
sequenceStub.calledTwice.should.be.true();
sequenceStub.firstCall.calledWith(sinon.match.array, sinon.match.object, loggerStub).should.be.true();
sequenceStub.secondCall.calledWith(sinon.match.array, sinon.match.object, loggerStub).should.be.true();
sequenceStub.firstCall.args[0].should.be.an.Array().with.lengthOf(1);
sequenceStub.secondCall.args[0].should.be.an.Array().with.lengthOf(8);
sequenceStub.firstCall.args[0][0].should.be.a.Function().with.property('name', 'runVersionTasks');
Refactor & test fixture migrations refs #6301 Fixtures: - Removed all the old (and now broken) 003 fixture upgrades - Split the 004 fixture upgrade tasks out, each into their own file - Improved the versioning code that figured out which upgrades we should do - Added lots of test coverage to make sure all the fixtures are still being run correctly. Permissions fixtures: - Changed the code that was populating permissions fixtures to be more automated & based only on what is in the permissions.json file. - Added lots of test coverage to make sure all the permissions are still being created correctly. Merging the two things: - Merged the content of permissions.json and fixtures.json into fixtures.json, but using the new structure from permissions.json. - Changed to use the new automated model & relation creation for all fixtures, not just permissions. - The only thing that can't be auto-populated just now is the owner creation, I think that's important enough to do separately. - There were (so far) never any permission updates, so code for updating fixtures stays the same through the merge. - This results in two clear code paths: populate (fill out a brand new DB) and update (make any changes since the last version) Test coverage is now 100% across both updates and populations.
2016-02-25 10:10:36 +03:00
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
sequenceStub.secondCall.args[0][0].should.be.a.Function().with.property('name', 'moveJQuery');
sequenceStub.secondCall.args[0][1].should.be.a.Function().with.property('name', 'updatePrivateSetting');
sequenceStub.secondCall.args[0][2].should.be.a.Function().with.property('name', 'updatePasswordSetting');
sequenceStub.secondCall.args[0][3].should.be.a.Function().with.property('name', 'updateGhostAdminClient');
sequenceStub.secondCall.args[0][4].should.be.a.Function().with.property('name', 'addGhostFrontendClient');
sequenceStub.secondCall.args[0][5].should.be.a.Function().with.property('name', 'cleanBrokenTags');
sequenceStub.secondCall.args[0][6].should.be.a.Function().with.property('name', 'addPostTagOrder');
sequenceStub.secondCall.args[0][7].should.be.a.Function().with.property('name', 'addNewPostFixture');
// Reset
sequenceReset();
Refactor & test fixture migrations refs #6301 Fixtures: - Removed all the old (and now broken) 003 fixture upgrades - Split the 004 fixture upgrade tasks out, each into their own file - Improved the versioning code that figured out which upgrades we should do - Added lots of test coverage to make sure all the fixtures are still being run correctly. Permissions fixtures: - Changed the code that was populating permissions fixtures to be more automated & based only on what is in the permissions.json file. - Added lots of test coverage to make sure all the permissions are still being created correctly. Merging the two things: - Merged the content of permissions.json and fixtures.json into fixtures.json, but using the new structure from permissions.json. - Changed to use the new automated model & relation creation for all fixtures, not just permissions. - The only thing that can't be auto-populated just now is the owner creation, I think that's important enough to do separately. - There were (so far) never any permission updates, so code for updating fixtures stays the same through the merge. - This results in two clear code paths: populate (fill out a brand new DB) and update (make any changes since the last version) Test coverage is now 100% across both updates and populations.
2016-02-25 10:10:36 +03:00
done();
}).catch(done);
});
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
describe('Tasks:', function () {
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
var getObjStub, settingsOneStub, settingsEditStub, clientOneStub, clientEditStub;
beforeEach(function () {
getObjStub = {get: sandbox.stub()};
settingsOneStub = sandbox.stub(models.Settings, 'findOne').returns(Promise.resolve(getObjStub));
settingsEditStub = sandbox.stub(models.Settings, 'edit').returns(Promise.resolve());
clientOneStub = sandbox.stub(models.Client, 'findOne').returns(Promise.resolve(getObjStub));
clientEditStub = sandbox.stub(models.Client, 'edit').returns(Promise.resolve());
});
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
describe('01-move-jquery-with-alert', function () {
it('tries to move jQuery to ghost_foot', function (done) {
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
getObjStub.get.returns('');
Refactor & test fixture migrations refs #6301 Fixtures: - Removed all the old (and now broken) 003 fixture upgrades - Split the 004 fixture upgrade tasks out, each into their own file - Improved the versioning code that figured out which upgrades we should do - Added lots of test coverage to make sure all the fixtures are still being run correctly. Permissions fixtures: - Changed the code that was populating permissions fixtures to be more automated & based only on what is in the permissions.json file. - Added lots of test coverage to make sure all the permissions are still being created correctly. Merging the two things: - Merged the content of permissions.json and fixtures.json into fixtures.json, but using the new structure from permissions.json. - Changed to use the new automated model & relation creation for all fixtures, not just permissions. - The only thing that can't be auto-populated just now is the owner creation, I think that's important enough to do separately. - There were (so far) never any permission updates, so code for updating fixtures stays the same through the merge. - This results in two clear code paths: populate (fill out a brand new DB) and update (make any changes since the last version) Test coverage is now 100% across both updates and populations.
2016-02-25 10:10:36 +03:00
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
fixtures004[0]({}, loggerStub).then(function () {
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
settingsOneStub.calledOnce.should.be.true();
settingsOneStub.calledWith('ghost_foot').should.be.true();
settingsEditStub.calledOnce.should.be.true();
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
loggerStub.info.calledOnce.should.be.true();
loggerStub.warn.called.should.be.false();
Refactor & test fixture migrations refs #6301 Fixtures: - Removed all the old (and now broken) 003 fixture upgrades - Split the 004 fixture upgrade tasks out, each into their own file - Improved the versioning code that figured out which upgrades we should do - Added lots of test coverage to make sure all the fixtures are still being run correctly. Permissions fixtures: - Changed the code that was populating permissions fixtures to be more automated & based only on what is in the permissions.json file. - Added lots of test coverage to make sure all the permissions are still being created correctly. Merging the two things: - Merged the content of permissions.json and fixtures.json into fixtures.json, but using the new structure from permissions.json. - Changed to use the new automated model & relation creation for all fixtures, not just permissions. - The only thing that can't be auto-populated just now is the owner creation, I think that's important enough to do separately. - There were (so far) never any permission updates, so code for updating fixtures stays the same through the merge. - This results in two clear code paths: populate (fill out a brand new DB) and update (make any changes since the last version) Test coverage is now 100% across both updates and populations.
2016-02-25 10:10:36 +03:00
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
done();
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
}).catch(done);
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
});
Refactor & test fixture migrations refs #6301 Fixtures: - Removed all the old (and now broken) 003 fixture upgrades - Split the 004 fixture upgrade tasks out, each into their own file - Improved the versioning code that figured out which upgrades we should do - Added lots of test coverage to make sure all the fixtures are still being run correctly. Permissions fixtures: - Changed the code that was populating permissions fixtures to be more automated & based only on what is in the permissions.json file. - Added lots of test coverage to make sure all the permissions are still being created correctly. Merging the two things: - Merged the content of permissions.json and fixtures.json into fixtures.json, but using the new structure from permissions.json. - Changed to use the new automated model & relation creation for all fixtures, not just permissions. - The only thing that can't be auto-populated just now is the owner creation, I think that's important enough to do separately. - There were (so far) never any permission updates, so code for updating fixtures stays the same through the merge. - This results in two clear code paths: populate (fill out a brand new DB) and update (make any changes since the last version) Test coverage is now 100% across both updates and populations.
2016-02-25 10:10:36 +03:00
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
it('does not move jQuery to ghost_foot if it is already there', function (done) {
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
getObjStub.get.returns(
'<!-- You can safely delete this line if your theme does not require jQuery -->\n'
+ '<script type="text/javascript" src="https://code.jquery.com/jquery-1.11.3.min.js"></script>\n\n'
);
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
fixtures004[0]({}, loggerStub).then(function () {
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
settingsOneStub.calledOnce.should.be.true();
settingsOneStub.calledWith('ghost_foot').should.be.true();
settingsEditStub.calledOnce.should.be.false();
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
loggerStub.info.called.should.be.false();
loggerStub.warn.calledOnce.should.be.true();
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
done();
}).catch(done);
});
Refactor & test fixture migrations refs #6301 Fixtures: - Removed all the old (and now broken) 003 fixture upgrades - Split the 004 fixture upgrade tasks out, each into their own file - Improved the versioning code that figured out which upgrades we should do - Added lots of test coverage to make sure all the fixtures are still being run correctly. Permissions fixtures: - Changed the code that was populating permissions fixtures to be more automated & based only on what is in the permissions.json file. - Added lots of test coverage to make sure all the permissions are still being created correctly. Merging the two things: - Merged the content of permissions.json and fixtures.json into fixtures.json, but using the new structure from permissions.json. - Changed to use the new automated model & relation creation for all fixtures, not just permissions. - The only thing that can't be auto-populated just now is the owner creation, I think that's important enough to do separately. - There were (so far) never any permission updates, so code for updating fixtures stays the same through the merge. - This results in two clear code paths: populate (fill out a brand new DB) and update (make any changes since the last version) Test coverage is now 100% across both updates and populations.
2016-02-25 10:10:36 +03:00
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
it('does not move jQuery to ghost_foot if the setting is missing', function (done) {
settingsOneStub.returns(Promise.resolve());
fixtures004[0]({}, loggerStub).then(function () {
settingsOneStub.calledOnce.should.be.true();
settingsOneStub.calledWith('ghost_foot').should.be.true();
settingsEditStub.called.should.be.false();
loggerStub.info.called.should.be.false();
loggerStub.warn.calledOnce.should.be.true();
done();
}).catch(done);
});
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
it('tried to move jQuery AND add a privacy message if any privacy settings are on', function (done) {
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
var notificationsAddStub = sandbox.stub(notifications, 'add').returns(Promise.resolve());
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
configUtils.set({privacy: {useGoogleFonts: false}});
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
getObjStub.get.returns('');
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
fixtures004[0]({}, loggerStub).then(function () {
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
settingsOneStub.calledOnce.should.be.true();
settingsOneStub.calledWith('ghost_foot').should.be.true();
settingsEditStub.calledOnce.should.be.true();
notificationsAddStub.calledOnce.should.be.true();
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
loggerStub.info.calledTwice.should.be.true();
loggerStub.warn.called.should.be.false();
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
done();
}).catch(done);
});
Refactor & test fixture migrations refs #6301 Fixtures: - Removed all the old (and now broken) 003 fixture upgrades - Split the 004 fixture upgrade tasks out, each into their own file - Improved the versioning code that figured out which upgrades we should do - Added lots of test coverage to make sure all the fixtures are still being run correctly. Permissions fixtures: - Changed the code that was populating permissions fixtures to be more automated & based only on what is in the permissions.json file. - Added lots of test coverage to make sure all the permissions are still being created correctly. Merging the two things: - Merged the content of permissions.json and fixtures.json into fixtures.json, but using the new structure from permissions.json. - Changed to use the new automated model & relation creation for all fixtures, not just permissions. - The only thing that can't be auto-populated just now is the owner creation, I think that's important enough to do separately. - There were (so far) never any permission updates, so code for updating fixtures stays the same through the merge. - This results in two clear code paths: populate (fill out a brand new DB) and update (make any changes since the last version) Test coverage is now 100% across both updates and populations.
2016-02-25 10:10:36 +03:00
});
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
describe('02-update-private-setting-type', function () {
it('tries to update setting type correctly', function (done) {
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
fixtures004[1]({}, loggerStub).then(function () {
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
settingsOneStub.calledOnce.should.be.true();
settingsOneStub.calledWith('isPrivate').should.be.true();
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
getObjStub.get.calledOnce.should.be.true();
getObjStub.get.calledWith('type').should.be.true();
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
settingsEditStub.calledOnce.should.be.true();
settingsEditStub.calledWith({key: 'isPrivate', type: 'private'}).should.be.true();
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
loggerStub.info.calledOnce.should.be.true();
loggerStub.warn.called.should.be.false();
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
sinon.assert.callOrder(settingsOneStub, getObjStub.get, loggerStub.info, settingsEditStub);
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
done();
}).catch(done);
});
it('does not try to update setting type if it is already set', function (done) {
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
getObjStub.get.returns('private');
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
fixtures004[1]({}, loggerStub).then(function () {
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
settingsOneStub.calledOnce.should.be.true();
settingsOneStub.calledWith('isPrivate').should.be.true();
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
getObjStub.get.calledOnce.should.be.true();
getObjStub.get.calledWith('type').should.be.true();
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
settingsEditStub.called.should.be.false();
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
loggerStub.info.called.should.be.false();
loggerStub.warn.calledOnce.should.be.true();
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
sinon.assert.callOrder(settingsOneStub, getObjStub.get, loggerStub.warn);
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
done();
}).catch(done);
});
Refactor & test fixture migrations refs #6301 Fixtures: - Removed all the old (and now broken) 003 fixture upgrades - Split the 004 fixture upgrade tasks out, each into their own file - Improved the versioning code that figured out which upgrades we should do - Added lots of test coverage to make sure all the fixtures are still being run correctly. Permissions fixtures: - Changed the code that was populating permissions fixtures to be more automated & based only on what is in the permissions.json file. - Added lots of test coverage to make sure all the permissions are still being created correctly. Merging the two things: - Merged the content of permissions.json and fixtures.json into fixtures.json, but using the new structure from permissions.json. - Changed to use the new automated model & relation creation for all fixtures, not just permissions. - The only thing that can't be auto-populated just now is the owner creation, I think that's important enough to do separately. - There were (so far) never any permission updates, so code for updating fixtures stays the same through the merge. - This results in two clear code paths: populate (fill out a brand new DB) and update (make any changes since the last version) Test coverage is now 100% across both updates and populations.
2016-02-25 10:10:36 +03:00
});
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
describe('03-update-password-setting-type', function () {
it('tries to update setting type correctly', function (done) {
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
fixtures004[2]({}, loggerStub).then(function () {
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
settingsOneStub.calledOnce.should.be.true();
settingsOneStub.calledWith('password').should.be.true();
settingsEditStub.calledOnce.should.be.true();
settingsEditStub.calledWith({key: 'password', type: 'private'}).should.be.true();
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
loggerStub.info.calledOnce.should.be.true();
loggerStub.warn.called.should.be.false();
sinon.assert.callOrder(settingsOneStub, loggerStub.info, settingsEditStub);
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
done();
}).catch(done);
});
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
it('does not try to update setting type if it is already set', function (done) {
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
getObjStub.get.returns('private');
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
fixtures004[2]({}, loggerStub).then(function () {
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
settingsOneStub.calledOnce.should.be.true();
settingsOneStub.calledWith('password').should.be.true();
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
getObjStub.get.calledOnce.should.be.true();
getObjStub.get.calledWith('type').should.be.true();
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
settingsEditStub.called.should.be.false();
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
loggerStub.info.called.should.be.false();
loggerStub.warn.calledOnce.should.be.true();
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
sinon.assert.callOrder(settingsOneStub, getObjStub.get);
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
done();
}).catch(done);
});
Refactor & test fixture migrations refs #6301 Fixtures: - Removed all the old (and now broken) 003 fixture upgrades - Split the 004 fixture upgrade tasks out, each into their own file - Improved the versioning code that figured out which upgrades we should do - Added lots of test coverage to make sure all the fixtures are still being run correctly. Permissions fixtures: - Changed the code that was populating permissions fixtures to be more automated & based only on what is in the permissions.json file. - Added lots of test coverage to make sure all the permissions are still being created correctly. Merging the two things: - Merged the content of permissions.json and fixtures.json into fixtures.json, but using the new structure from permissions.json. - Changed to use the new automated model & relation creation for all fixtures, not just permissions. - The only thing that can't be auto-populated just now is the owner creation, I think that's important enough to do separately. - There were (so far) never any permission updates, so code for updating fixtures stays the same through the merge. - This results in two clear code paths: populate (fill out a brand new DB) and update (make any changes since the last version) Test coverage is now 100% across both updates and populations.
2016-02-25 10:10:36 +03:00
});
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
describe('04-update-ghost-admin-client', function () {
it('tries to update client correctly', function (done) {
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
fixtures004[3]({}, loggerStub).then(function () {
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
clientOneStub.calledOnce.should.be.true();
clientOneStub.calledWith({slug: 'ghost-admin'}).should.be.true();
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
getObjStub.get.calledTwice.should.be.true();
getObjStub.get.calledWith('secret').should.be.true();
getObjStub.get.calledWith('status').should.be.true();
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
clientEditStub.calledOnce.should.be.true();
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
loggerStub.info.calledOnce.should.be.true();
loggerStub.warn.called.should.be.false();
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
sinon.assert.callOrder(
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
clientOneStub, getObjStub.get, getObjStub.get, loggerStub.info, clientEditStub
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
);
done();
}).catch(done);
});
it('does not try to update client if the secret and status are already correct', function (done) {
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
getObjStub.get.withArgs('secret').returns('abc');
getObjStub.get.withArgs('status').returns('enabled');
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
fixtures004[3]({}, loggerStub).then(function () {
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
clientOneStub.calledOnce.should.be.true();
clientOneStub.calledWith({slug: 'ghost-admin'}).should.be.true();
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
getObjStub.get.calledTwice.should.be.true();
getObjStub.get.calledWith('secret').should.be.true();
getObjStub.get.calledWith('status').should.be.true();
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
clientEditStub.called.should.be.false();
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
loggerStub.info.called.should.be.false();
loggerStub.warn.calledOnce.should.be.true();
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
sinon.assert.callOrder(clientOneStub, getObjStub.get, getObjStub.get, loggerStub.warn);
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
done();
}).catch(done);
});
it('tries to update client if secret is correct but status is wrong', function (done) {
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
getObjStub.get.withArgs('secret').returns('abc');
getObjStub.get.withArgs('status').returns('development');
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
fixtures004[3]({}, loggerStub).then(function () {
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
clientOneStub.calledOnce.should.be.true();
clientOneStub.calledWith({slug: 'ghost-admin'}).should.be.true();
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
getObjStub.get.calledTwice.should.be.true();
getObjStub.get.calledWith('secret').should.be.true();
getObjStub.get.calledWith('status').should.be.true();
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
clientEditStub.calledOnce.should.be.true();
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
loggerStub.info.calledOnce.should.be.true();
loggerStub.warn.called.should.be.false();
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
sinon.assert.callOrder(
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
clientOneStub, getObjStub.get, getObjStub.get, loggerStub.info, clientEditStub
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
);
done();
}).catch(done);
});
it('tries to update client if status is correct but secret is wrong', function (done) {
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
getObjStub.get.withArgs('secret').returns('not_available');
getObjStub.get.withArgs('status').returns('enabled');
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
fixtures004[3]({}, loggerStub).then(function () {
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
clientOneStub.calledOnce.should.be.true();
clientOneStub.calledWith({slug: 'ghost-admin'}).should.be.true();
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
getObjStub.get.calledOnce.should.be.true();
getObjStub.get.calledWith('secret').should.be.true();
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
clientEditStub.calledOnce.should.be.true();
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
loggerStub.info.calledOnce.should.be.true();
loggerStub.warn.called.should.be.false();
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
sinon.assert.callOrder(
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
clientOneStub, getObjStub.get, loggerStub.info, clientEditStub
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
);
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
done();
}).catch(done);
});
Refactor & test fixture migrations refs #6301 Fixtures: - Removed all the old (and now broken) 003 fixture upgrades - Split the 004 fixture upgrade tasks out, each into their own file - Improved the versioning code that figured out which upgrades we should do - Added lots of test coverage to make sure all the fixtures are still being run correctly. Permissions fixtures: - Changed the code that was populating permissions fixtures to be more automated & based only on what is in the permissions.json file. - Added lots of test coverage to make sure all the permissions are still being created correctly. Merging the two things: - Merged the content of permissions.json and fixtures.json into fixtures.json, but using the new structure from permissions.json. - Changed to use the new automated model & relation creation for all fixtures, not just permissions. - The only thing that can't be auto-populated just now is the owner creation, I think that's important enough to do separately. - There were (so far) never any permission updates, so code for updating fixtures stays the same through the merge. - This results in two clear code paths: populate (fill out a brand new DB) and update (make any changes since the last version) Test coverage is now 100% across both updates and populations.
2016-02-25 10:10:36 +03:00
});
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
describe('05-add-ghost-frontend-client', function () {
it('tries to add client correctly', function (done) {
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
var clientAddStub = sandbox.stub(models.Client, 'add').returns(Promise.resolve());
clientOneStub.returns(Promise.resolve());
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
fixtures004[4]({}, loggerStub).then(function () {
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
clientOneStub.calledOnce.should.be.true();
clientOneStub.calledWith({slug: 'ghost-frontend'}).should.be.true();
clientAddStub.calledOnce.should.be.true();
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
loggerStub.info.calledOnce.should.be.true();
loggerStub.warn.called.should.be.false();
sinon.assert.callOrder(clientOneStub, loggerStub.info, clientAddStub);
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
done();
}).catch(done);
});
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
it('does not try to add client if it already exists', function (done) {
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
var clientAddStub = sandbox.stub(models.Client, 'add').returns(Promise.resolve());
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
fixtures004[4]({}, loggerStub).then(function () {
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
clientOneStub.calledOnce.should.be.true();
clientOneStub.calledWith({slug: 'ghost-frontend'}).should.be.true();
clientAddStub.called.should.be.false();
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
loggerStub.info.called.should.be.false();
loggerStub.warn.calledOnce.should.be.true();
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
done();
}).catch(done);
});
Refactor & test fixture migrations refs #6301 Fixtures: - Removed all the old (and now broken) 003 fixture upgrades - Split the 004 fixture upgrade tasks out, each into their own file - Improved the versioning code that figured out which upgrades we should do - Added lots of test coverage to make sure all the fixtures are still being run correctly. Permissions fixtures: - Changed the code that was populating permissions fixtures to be more automated & based only on what is in the permissions.json file. - Added lots of test coverage to make sure all the permissions are still being created correctly. Merging the two things: - Merged the content of permissions.json and fixtures.json into fixtures.json, but using the new structure from permissions.json. - Changed to use the new automated model & relation creation for all fixtures, not just permissions. - The only thing that can't be auto-populated just now is the owner creation, I think that's important enough to do separately. - There were (so far) never any permission updates, so code for updating fixtures stays the same through the merge. - This results in two clear code paths: populate (fill out a brand new DB) and update (make any changes since the last version) Test coverage is now 100% across both updates and populations.
2016-02-25 10:10:36 +03:00
});
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
describe('06-clean-broken-tags', function () {
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
var tagObjStub, tagCollStub, tagAllStub;
beforeEach(function () {
tagObjStub = {
get: sandbox.stub(),
save: sandbox.stub().returns(Promise.resolve)
};
tagCollStub = {each: sandbox.stub().callsArgWith(0, tagObjStub)};
tagAllStub = sandbox.stub(models.Tag, 'findAll').returns(Promise.resolve(tagCollStub));
});
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
it('tries to clean broken tags correctly', function (done) {
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
tagObjStub.get.returns(',hello');
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
fixtures004[5]({}, loggerStub).then(function () {
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
tagAllStub.calledOnce.should.be.true();
tagCollStub.each.calledOnce.should.be.true();
tagObjStub.get.calledOnce.should.be.true();
tagObjStub.get.calledWith('name').should.be.true();
tagObjStub.save.calledOnce.should.be.true();
tagObjStub.save.calledWith({name: 'hello'}).should.be.true();
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
loggerStub.info.calledOnce.should.be.true();
loggerStub.warn.called.should.be.false();
sinon.assert.callOrder(tagAllStub, tagCollStub.each, tagObjStub.get, tagObjStub.save, loggerStub.info);
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
done();
}).catch(done);
});
Refactor & test fixture migrations refs #6301 Fixtures: - Removed all the old (and now broken) 003 fixture upgrades - Split the 004 fixture upgrade tasks out, each into their own file - Improved the versioning code that figured out which upgrades we should do - Added lots of test coverage to make sure all the fixtures are still being run correctly. Permissions fixtures: - Changed the code that was populating permissions fixtures to be more automated & based only on what is in the permissions.json file. - Added lots of test coverage to make sure all the permissions are still being created correctly. Merging the two things: - Merged the content of permissions.json and fixtures.json into fixtures.json, but using the new structure from permissions.json. - Changed to use the new automated model & relation creation for all fixtures, not just permissions. - The only thing that can't be auto-populated just now is the owner creation, I think that's important enough to do separately. - There were (so far) never any permission updates, so code for updating fixtures stays the same through the merge. - This results in two clear code paths: populate (fill out a brand new DB) and update (make any changes since the last version) Test coverage is now 100% across both updates and populations.
2016-02-25 10:10:36 +03:00
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
it('tries can handle tags which end up empty', function (done) {
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
tagObjStub.get.returns(',');
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
fixtures004[5]({}, loggerStub).then(function () {
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
tagAllStub.calledOnce.should.be.true();
tagCollStub.each.calledOnce.should.be.true();
tagObjStub.get.calledOnce.should.be.true();
tagObjStub.get.calledWith('name').should.be.true();
tagObjStub.save.calledOnce.should.be.true();
tagObjStub.save.calledWith({name: 'tag'}).should.be.true();
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
loggerStub.info.calledOnce.should.be.true();
loggerStub.warn.called.should.be.false();
sinon.assert.callOrder(tagAllStub, tagCollStub.each, tagObjStub.get, tagObjStub.save, loggerStub.info);
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
done();
}).catch(done);
});
Refactor & test fixture migrations refs #6301 Fixtures: - Removed all the old (and now broken) 003 fixture upgrades - Split the 004 fixture upgrade tasks out, each into their own file - Improved the versioning code that figured out which upgrades we should do - Added lots of test coverage to make sure all the fixtures are still being run correctly. Permissions fixtures: - Changed the code that was populating permissions fixtures to be more automated & based only on what is in the permissions.json file. - Added lots of test coverage to make sure all the permissions are still being created correctly. Merging the two things: - Merged the content of permissions.json and fixtures.json into fixtures.json, but using the new structure from permissions.json. - Changed to use the new automated model & relation creation for all fixtures, not just permissions. - The only thing that can't be auto-populated just now is the owner creation, I think that's important enough to do separately. - There were (so far) never any permission updates, so code for updating fixtures stays the same through the merge. - This results in two clear code paths: populate (fill out a brand new DB) and update (make any changes since the last version) Test coverage is now 100% across both updates and populations.
2016-02-25 10:10:36 +03:00
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
it('does not change tags if not necessary', function (done) {
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
tagObjStub.get.returns('hello');
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
fixtures004[5]({}, loggerStub).then(function () {
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
tagAllStub.calledOnce.should.be.true();
tagCollStub.each.calledOnce.should.be.true();
tagObjStub.get.calledOnce.should.be.true();
tagObjStub.get.calledWith('name').should.be.true();
tagObjStub.save.called.should.be.false();
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
loggerStub.info.called.should.be.false();
loggerStub.warn.calledOnce.should.be.true();
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
sinon.assert.callOrder(tagAllStub, tagCollStub.each, tagObjStub.get, loggerStub.warn);
done();
}).catch(done);
});
it('does nothing if there are no tags', function (done) {
tagAllStub.returns(Promise.resolve());
fixtures004[5]({}, loggerStub).then(function () {
tagAllStub.calledOnce.should.be.true();
tagCollStub.each.called.should.be.false();
tagObjStub.get.called.should.be.false();
tagObjStub.save.called.should.be.false();
loggerStub.info.called.should.be.false();
loggerStub.warn.calledOnce.should.be.true();
sinon.assert.callOrder(tagAllStub, loggerStub.warn);
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
done();
}).catch(done);
});
Refactor & test fixture migrations refs #6301 Fixtures: - Removed all the old (and now broken) 003 fixture upgrades - Split the 004 fixture upgrade tasks out, each into their own file - Improved the versioning code that figured out which upgrades we should do - Added lots of test coverage to make sure all the fixtures are still being run correctly. Permissions fixtures: - Changed the code that was populating permissions fixtures to be more automated & based only on what is in the permissions.json file. - Added lots of test coverage to make sure all the permissions are still being created correctly. Merging the two things: - Merged the content of permissions.json and fixtures.json into fixtures.json, but using the new structure from permissions.json. - Changed to use the new automated model & relation creation for all fixtures, not just permissions. - The only thing that can't be auto-populated just now is the owner creation, I think that's important enough to do separately. - There were (so far) never any permission updates, so code for updating fixtures stays the same through the merge. - This results in two clear code paths: populate (fill out a brand new DB) and update (make any changes since the last version) Test coverage is now 100% across both updates and populations.
2016-02-25 10:10:36 +03:00
});
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
describe('07-add-post-tag-order', function () {
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
var tagOp1Stub, tagOp2Stub, tagObjStub, postObjStub, postCollStub, postAllStub;
beforeEach(function () {
tagOp1Stub = sandbox.stub().returns(Promise.resolve());
tagOp2Stub = sandbox.stub().returns(Promise.resolve());
tagObjStub = {
pivot: {get: sandbox.stub()}
};
postCollStub = {mapThen: sandbox.stub()};
postAllStub = sandbox.stub(models.Post, 'findAll').returns(Promise.resolve(postCollStub));
postObjStub = {
load: sandbox.stub(),
reduce: sandbox.stub(),
// By returning an array from related, we can use native reduce to simulate a result
related: sandbox.stub().returns([tagObjStub]),
// Get called when executing sequence
tags: sandbox.stub().returnsThis(),
updatePivot: sandbox.stub().returns(Promise.resolve())
};
});
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
it('calls load on each post', function (done) {
// Fake mapThen behaviour
postCollStub.mapThen.callsArgWith(0, postObjStub).returns([]);
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
fixtures004[6]({}, loggerStub).then(function () {
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
postAllStub.calledOnce.should.be.true();
postCollStub.mapThen.calledOnce.should.be.true();
postObjStub.load.calledOnce.should.be.true();
postObjStub.load.calledWith(['tags']).should.be.true();
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
loggerStub.info.calledOnce.should.be.true();
// gets called because we're stubbing to return an empty array
loggerStub.warn.calledOnce.should.be.true();
sinon.assert.callOrder(loggerStub.info, postAllStub, postCollStub.mapThen, postObjStub.load);
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
done();
}).catch(done);
});
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
it('returns early, if no posts are found', function (done) {
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
// Fake mapThen behaviour
postCollStub.mapThen.returns([]);
postAllStub.returns(Promise.resolve());
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
fixtures004[6]({}, loggerStub).then(function () {
loggerStub.info.calledOnce.should.be.true();
loggerStub.warn.calledOnce.should.be.true();
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
postAllStub.calledOnce.should.be.true();
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
sinon.assert.callOrder(loggerStub.info, postAllStub, loggerStub.warn);
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
done();
}).catch(done);
});
it('executes sequence, if at least one tag is found', function (done) {
var tagOpStub = sandbox.stub().returns(Promise.resolve()),
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
tagOpsArr = [tagOpStub];
// By stubbing reduce, we can return an array directly without pretending to process tags
postObjStub.reduce.returns(tagOpsArr);
// By returning from mapThen, we can skip doing tag.load in this test
postCollStub.mapThen.returns(postObjStub);
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
fixtures004[6]({}, loggerStub).then(function () {
loggerStub.info.calledThrice.should.be.true();
loggerStub.warn.called.should.be.false();
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
postAllStub.calledOnce.should.be.true();
postCollStub.mapThen.calledOnce.should.be.true();
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
postObjStub.reduce.calledOnce.should.be.true();
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
tagOpStub.calledOnce.should.be.true();
sinon.assert.callOrder(
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
loggerStub.info, postAllStub, postCollStub.mapThen, postObjStub.reduce,
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
loggerStub.info, tagOpStub, loggerStub.info
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
);
done();
}).catch(done);
});
it('executes sequence, if more than one tag is found', function (done) {
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
var tagOpsArr = [tagOp1Stub, tagOp2Stub];
// By stubbing reduce, we can return an array directly without pretending to process tags
postObjStub.reduce.returns(tagOpsArr);
// By returning from mapThen, we can skip doing tag.load in this test
postCollStub.mapThen.returns(postObjStub);
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
fixtures004[6]({}, loggerStub).then(function () {
loggerStub.info.calledThrice.should.be.true();
loggerStub.warn.called.should.be.false();
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
postAllStub.calledOnce.should.be.true();
postCollStub.mapThen.calledOnce.should.be.true();
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
postObjStub.reduce.calledOnce.should.be.true();
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
tagOp1Stub.calledOnce.should.be.true();
tagOp2Stub.calledOnce.should.be.true();
sinon.assert.callOrder(
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
loggerStub.info, postAllStub, postCollStub.mapThen, postObjStub.reduce,
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
loggerStub.info, tagOp1Stub, tagOp2Stub, loggerStub.info
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
);
done();
}).catch(done);
});
it('does not execute sequence, if migrationHasRunFlag gets set to true', function (done) {
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
tagObjStub.pivot.get.returns(1);
// By returning from mapThen, we can skip doing tag.load in this test
postCollStub.mapThen.returns([postObjStub]);
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
fixtures004[6]({}, loggerStub).then(function () {
loggerStub.info.calledOnce.should.be.true();
loggerStub.warn.calledOnce.should.be.true();
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
postAllStub.calledOnce.should.be.true();
postCollStub.mapThen.calledOnce.should.be.true();
postObjStub.related.calledOnce.should.be.true();
tagObjStub.pivot.get.calledOnce.should.be.true();
tagObjStub.pivot.get.calledWith('sort_order').should.be.true();
sinon.assert.callOrder(
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
loggerStub.info, postAllStub, postCollStub.mapThen, postObjStub.related,
tagObjStub.pivot.get, loggerStub.warn
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
);
done();
}).catch(done);
});
it('does execute sequence, if migrationHasRunFlag is false', function (done) {
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
// If pivot gets a non-zero, migrationHasRunFlag gets set to true
tagObjStub.pivot.get.returns(0);
// By returning from mapThen, we can skip doing tag.load in this test
postCollStub.mapThen.returns([postObjStub]);
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
fixtures004[6]({}, loggerStub).then(function () {
loggerStub.info.calledThrice.should.be.true();
loggerStub.warn.called.should.be.false();
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
postAllStub.calledOnce.should.be.true();
postCollStub.mapThen.calledOnce.should.be.true();
postObjStub.related.calledOnce.should.be.true();
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
tagObjStub.pivot.get.calledOnce.should.be.true();
tagObjStub.pivot.get.calledWith('sort_order').should.be.true();
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
postObjStub.tags.calledOnce.should.be.true();
postObjStub.updatePivot.calledOnce.should.be.true();
sinon.assert.callOrder(
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
loggerStub.info, postAllStub, postCollStub.mapThen, postObjStub.related, tagObjStub.pivot.get,
loggerStub.info, postObjStub.tags, postObjStub.updatePivot, loggerStub.info
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
);
done();
}).catch(done);
});
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
it('tries to add incremental sort_order to posts_tags', function (done) {
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
// If pivot gets a non-zero, migrationHasRunFlag gets set to true
tagObjStub.pivot.get.returns(0);
// By returning an array from related, we can use real reduce to simulate a result here
postObjStub.related.returns([tagObjStub, tagObjStub, tagObjStub]);
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
// By returning from mapThen, we can skip doing tag.load in this test
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
postCollStub.mapThen.returns([postObjStub]);
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
fixtures004[6]({}, loggerStub).then(function () {
loggerStub.info.calledThrice.should.be.true();
loggerStub.warn.called.should.be.false();
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
postAllStub.calledOnce.should.be.true();
postCollStub.mapThen.calledOnce.should.be.true();
postObjStub.related.calledOnce.should.be.true();
tagObjStub.pivot.get.calledThrice.should.be.true();
postObjStub.tags.calledThrice.should.be.true();
postObjStub.updatePivot.calledThrice.should.be.true();
postObjStub.updatePivot.firstCall.args[0].should.eql({sort_order: 0});
postObjStub.updatePivot.secondCall.args[0].should.eql({sort_order: 1});
postObjStub.updatePivot.thirdCall.args[0].should.eql({sort_order: 2});
sinon.assert.callOrder(
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
loggerStub.info, postAllStub, postCollStub.mapThen, postObjStub.related,
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
tagObjStub.pivot.get, tagObjStub.pivot.get, tagObjStub.pivot.get,
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
loggerStub.info,
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
postObjStub.tags, postObjStub.updatePivot,
postObjStub.tags, postObjStub.updatePivot,
postObjStub.tags, postObjStub.updatePivot,
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
loggerStub.info
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
);
done();
}).catch(done);
});
Refactor & test fixture migrations refs #6301 Fixtures: - Removed all the old (and now broken) 003 fixture upgrades - Split the 004 fixture upgrade tasks out, each into their own file - Improved the versioning code that figured out which upgrades we should do - Added lots of test coverage to make sure all the fixtures are still being run correctly. Permissions fixtures: - Changed the code that was populating permissions fixtures to be more automated & based only on what is in the permissions.json file. - Added lots of test coverage to make sure all the permissions are still being created correctly. Merging the two things: - Merged the content of permissions.json and fixtures.json into fixtures.json, but using the new structure from permissions.json. - Changed to use the new automated model & relation creation for all fixtures, not just permissions. - The only thing that can't be auto-populated just now is the owner creation, I think that's important enough to do separately. - There were (so far) never any permission updates, so code for updating fixtures stays the same through the merge. - This results in two clear code paths: populate (fill out a brand new DB) and update (make any changes since the last version) Test coverage is now 100% across both updates and populations.
2016-02-25 10:10:36 +03:00
});
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
describe('08-add-post-fixture', function () {
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
var postOneStub, postAddStub;
beforeEach(function () {
postOneStub = sandbox.stub(models.Post, 'findOne').returns(Promise.resolve());
postAddStub = sandbox.stub(models.Post, 'add').returns(Promise.resolve());
});
Refactor & test fixture migrations refs #6301 Fixtures: - Removed all the old (and now broken) 003 fixture upgrades - Split the 004 fixture upgrade tasks out, each into their own file - Improved the versioning code that figured out which upgrades we should do - Added lots of test coverage to make sure all the fixtures are still being run correctly. Permissions fixtures: - Changed the code that was populating permissions fixtures to be more automated & based only on what is in the permissions.json file. - Added lots of test coverage to make sure all the permissions are still being created correctly. Merging the two things: - Merged the content of permissions.json and fixtures.json into fixtures.json, but using the new structure from permissions.json. - Changed to use the new automated model & relation creation for all fixtures, not just permissions. - The only thing that can't be auto-populated just now is the owner creation, I think that's important enough to do separately. - There were (so far) never any permission updates, so code for updating fixtures stays the same through the merge. - This results in two clear code paths: populate (fill out a brand new DB) and update (make any changes since the last version) Test coverage is now 100% across both updates and populations.
2016-02-25 10:10:36 +03:00
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
it('tries to add a new post fixture correctly', function (done) {
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
fixtures004[7]({}, loggerStub).then(function () {
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
postOneStub.calledOnce.should.be.true();
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
loggerStub.info.calledOnce.should.be.true();
loggerStub.warn.called.should.be.false();
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
postAddStub.calledOnce.should.be.true();
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
sinon.assert.callOrder(postOneStub, loggerStub.info, postAddStub);
Refactor & test fixture migrations refs #6301 Fixtures: - Removed all the old (and now broken) 003 fixture upgrades - Split the 004 fixture upgrade tasks out, each into their own file - Improved the versioning code that figured out which upgrades we should do - Added lots of test coverage to make sure all the fixtures are still being run correctly. Permissions fixtures: - Changed the code that was populating permissions fixtures to be more automated & based only on what is in the permissions.json file. - Added lots of test coverage to make sure all the permissions are still being created correctly. Merging the two things: - Merged the content of permissions.json and fixtures.json into fixtures.json, but using the new structure from permissions.json. - Changed to use the new automated model & relation creation for all fixtures, not just permissions. - The only thing that can't be auto-populated just now is the owner creation, I think that's important enough to do separately. - There were (so far) never any permission updates, so code for updating fixtures stays the same through the merge. - This results in two clear code paths: populate (fill out a brand new DB) and update (make any changes since the last version) Test coverage is now 100% across both updates and populations.
2016-02-25 10:10:36 +03:00
Rewrite DB update to be explicit refs #6301 - Replace builder & automated database upgrade with a set of explicit tasks - Ensure the tasks can only happen if they need to - Remove some duplicate code between fixture & db upgrades (more to do) - Add tests
2016-03-14 20:39:00 +03:00
done();
}).catch(done);
});
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
it('does not try to add new post fixture if it already exists', function (done) {
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
postOneStub.returns(Promise.resolve({}));
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
fixtures004[7]({}, loggerStub).then(function () {
postOneStub.calledOnce.should.be.true();
loggerStub.info.called.should.be.false();
loggerStub.warn.calledOnce.should.be.true();
postAddStub.called.should.be.false();
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
sinon.assert.callOrder(postOneStub, loggerStub.warn);
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
done();
}).catch(done);
});
Ensure fixture operations only run if needed refs #6301 - Make sure that every fixture operation has a check to ensure that it hasn't already run - E.g. The update of sort_order on posts_tags should only happen if there are no values which aren't a zero - This makes sure that we don't accidentally overwrite data on FORCE_MIGRATE - No need to try to set settings types if they are already correct - Only update the admin client if it needs it, else we're regenerating secrets each time
2016-03-21 20:53:36 +03:00
});
Refactor & test fixture migrations refs #6301 Fixtures: - Removed all the old (and now broken) 003 fixture upgrades - Split the 004 fixture upgrade tasks out, each into their own file - Improved the versioning code that figured out which upgrades we should do - Added lots of test coverage to make sure all the fixtures are still being run correctly. Permissions fixtures: - Changed the code that was populating permissions fixtures to be more automated & based only on what is in the permissions.json file. - Added lots of test coverage to make sure all the permissions are still being created correctly. Merging the two things: - Merged the content of permissions.json and fixtures.json into fixtures.json, but using the new structure from permissions.json. - Changed to use the new automated model & relation creation for all fixtures, not just permissions. - The only thing that can't be auto-populated just now is the owner creation, I think that's important enough to do separately. - There were (so far) never any permission updates, so code for updating fixtures stays the same through the merge. - This results in two clear code paths: populate (fill out a brand new DB) and update (make any changes since the last version) Test coverage is now 100% across both updates and populations.
2016-02-25 10:10:36 +03:00
});
});
});
describe('Populate fixtures', function () {
// This tests that all the models & relations get called correctly
it('should call all the fixture populations', function (done) {
// Stub all the model methods so that nothing happens
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
var postAddStub = sandbox.stub(models.Post, 'add').returns(Promise.resolve()),
Refactor & test fixture migrations refs #6301 Fixtures: - Removed all the old (and now broken) 003 fixture upgrades - Split the 004 fixture upgrade tasks out, each into their own file - Improved the versioning code that figured out which upgrades we should do - Added lots of test coverage to make sure all the fixtures are still being run correctly. Permissions fixtures: - Changed the code that was populating permissions fixtures to be more automated & based only on what is in the permissions.json file. - Added lots of test coverage to make sure all the permissions are still being created correctly. Merging the two things: - Merged the content of permissions.json and fixtures.json into fixtures.json, but using the new structure from permissions.json. - Changed to use the new automated model & relation creation for all fixtures, not just permissions. - The only thing that can't be auto-populated just now is the owner creation, I think that's important enough to do separately. - There were (so far) never any permission updates, so code for updating fixtures stays the same through the merge. - This results in two clear code paths: populate (fill out a brand new DB) and update (make any changes since the last version) Test coverage is now 100% across both updates and populations.
2016-02-25 10:10:36 +03:00
tagAddStub = sandbox.stub(models.Tag, 'add').returns(Promise.resolve()),
roleAddStub = sandbox.stub(models.Role, 'add').returns(Promise.resolve()),
clientAddStub = sandbox.stub(models.Client, 'add').returns(Promise.resolve()),
permsAddStub = sandbox.stub(models.Permission, 'add').returns(Promise.resolve()),
// Relations
modelMethodStub = {filter: sandbox.stub(), find: sandbox.stub()},
permsAllStub = sandbox.stub(models.Permission, 'findAll').returns(Promise.resolve(modelMethodStub)),
rolesAllStub = sandbox.stub(models.Role, 'findAll').returns(Promise.resolve(modelMethodStub)),
postsAllStub = sandbox.stub(models.Post, 'findAll').returns(Promise.resolve(modelMethodStub)),
tagsAllStub = sandbox.stub(models.Tag, 'findAll').returns(Promise.resolve(modelMethodStub)),
// Create Owner
roleOneStub = sandbox.stub(models.Role, 'findOne').returns(Promise.resolve({id: 1})),
userAddStub = sandbox.stub(models.User, 'add').returns(Promise.resolve({}));
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
populate(loggerStub).then(function () {
loggerStub.info.calledTwice.should.be.true();
loggerStub.warn.called.should.be.false();
Refactor & test fixture migrations refs #6301 Fixtures: - Removed all the old (and now broken) 003 fixture upgrades - Split the 004 fixture upgrade tasks out, each into their own file - Improved the versioning code that figured out which upgrades we should do - Added lots of test coverage to make sure all the fixtures are still being run correctly. Permissions fixtures: - Changed the code that was populating permissions fixtures to be more automated & based only on what is in the permissions.json file. - Added lots of test coverage to make sure all the permissions are still being created correctly. Merging the two things: - Merged the content of permissions.json and fixtures.json into fixtures.json, but using the new structure from permissions.json. - Changed to use the new automated model & relation creation for all fixtures, not just permissions. - The only thing that can't be auto-populated just now is the owner creation, I think that's important enough to do separately. - There were (so far) never any permission updates, so code for updating fixtures stays the same through the merge. - This results in two clear code paths: populate (fill out a brand new DB) and update (make any changes since the last version) Test coverage is now 100% across both updates and populations.
2016-02-25 10:10:36 +03:00
postAddStub.calledOnce.should.be.true();
tagAddStub.calledOnce.should.be.true();
roleAddStub.callCount.should.eql(4);
clientAddStub.calledTwice.should.be.true();
permsAddStub.called.should.be.true();
permsAddStub.callCount.should.eql(30);
permsAllStub.calledOnce.should.be.true();
rolesAllStub.calledOnce.should.be.true();
postsAllStub.calledOnce.should.be.true();
tagsAllStub.calledOnce.should.be.true();
// Relations
modelMethodStub.filter.called.should.be.true();
// 22 permissions, 1 tag
modelMethodStub.filter.callCount.should.eql(22 + 1);
modelMethodStub.find.called.should.be.true();
// 3 roles, 1 post
modelMethodStub.find.callCount.should.eql(3 + 1);
// Create Owner
roleOneStub.calledOnce.should.be.true();
userAddStub.calledOnce.should.be.true();
done();
}).catch(done);
});
describe('Add All Relations', function () {
it('should call attach if relation models are found', function (done) {
var addAllRelations = populate.__get__('addAllRelations'),
emptyMethodStub = {filter: sandbox.stub(), find: sandbox.stub()},
// Setup a chain of methods
dataMethodStub = {
filter: sandbox.stub().returnsThis(),
find: sandbox.stub().returnsThis(),
tags: sandbox.stub().returnsThis(),
attach: sandbox.stub().returns(Promise.resolve())
},
permsAllStub = sandbox.stub(models.Permission, 'findAll').returns(Promise.resolve(emptyMethodStub)),
rolesAllStub = sandbox.stub(models.Role, 'findAll').returns(Promise.resolve(emptyMethodStub)),
postsAllStub = sandbox.stub(models.Post, 'findAll').returns(Promise.resolve(dataMethodStub)),
tagsAllStub = sandbox.stub(models.Tag, 'findAll').returns(Promise.resolve(dataMethodStub));
addAllRelations().then(function () {
permsAllStub.calledOnce.should.be.true();
rolesAllStub.calledOnce.should.be.true();
postsAllStub.calledOnce.should.be.true();
tagsAllStub.calledOnce.should.be.true();
// Permissions & Roles
emptyMethodStub.filter.called.should.be.true();
emptyMethodStub.filter.callCount.should.eql(22);
emptyMethodStub.find.called.should.be.true();
emptyMethodStub.find.callCount.should.eql(3);
// Posts & Tags
dataMethodStub.filter.calledOnce.should.be.true();
dataMethodStub.find.calledOnce.should.be.true();
dataMethodStub.tags.calledOnce.should.be.true();
dataMethodStub.attach.calledOnce.should.be.true();
dataMethodStub.attach.calledWith(dataMethodStub).should.be.true();
done();
}).catch(done);
});
});
describe('Create Owner', function () {
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
var createOwner = populate.__get__('createOwner'),
roleOneStub, userAddStub;
beforeEach(function () {
roleOneStub = sandbox.stub(models.Role, 'findOne');
userAddStub = sandbox.stub(models.User, 'add');
});
Refactor & test fixture migrations refs #6301 Fixtures: - Removed all the old (and now broken) 003 fixture upgrades - Split the 004 fixture upgrade tasks out, each into their own file - Improved the versioning code that figured out which upgrades we should do - Added lots of test coverage to make sure all the fixtures are still being run correctly. Permissions fixtures: - Changed the code that was populating permissions fixtures to be more automated & based only on what is in the permissions.json file. - Added lots of test coverage to make sure all the permissions are still being created correctly. Merging the two things: - Merged the content of permissions.json and fixtures.json into fixtures.json, but using the new structure from permissions.json. - Changed to use the new automated model & relation creation for all fixtures, not just permissions. - The only thing that can't be auto-populated just now is the owner creation, I think that's important enough to do separately. - There were (so far) never any permission updates, so code for updating fixtures stays the same through the merge. - This results in two clear code paths: populate (fill out a brand new DB) and update (make any changes since the last version) Test coverage is now 100% across both updates and populations.
2016-02-25 10:10:36 +03:00
it('createOwner will add user if owner role is present', function (done) {
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
roleOneStub.returns(Promise.resolve({id: 1}));
userAddStub.returns(Promise.resolve({}));
Refactor & test fixture migrations refs #6301 Fixtures: - Removed all the old (and now broken) 003 fixture upgrades - Split the 004 fixture upgrade tasks out, each into their own file - Improved the versioning code that figured out which upgrades we should do - Added lots of test coverage to make sure all the fixtures are still being run correctly. Permissions fixtures: - Changed the code that was populating permissions fixtures to be more automated & based only on what is in the permissions.json file. - Added lots of test coverage to make sure all the permissions are still being created correctly. Merging the two things: - Merged the content of permissions.json and fixtures.json into fixtures.json, but using the new structure from permissions.json. - Changed to use the new automated model & relation creation for all fixtures, not just permissions. - The only thing that can't be auto-populated just now is the owner creation, I think that's important enough to do separately. - There were (so far) never any permission updates, so code for updating fixtures stays the same through the merge. - This results in two clear code paths: populate (fill out a brand new DB) and update (make any changes since the last version) Test coverage is now 100% across both updates and populations.
2016-02-25 10:10:36 +03:00
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
createOwner(loggerStub).then(function () {
loggerStub.info.called.should.be.true();
loggerStub.warn.called.should.be.false();
Refactor & test fixture migrations refs #6301 Fixtures: - Removed all the old (and now broken) 003 fixture upgrades - Split the 004 fixture upgrade tasks out, each into their own file - Improved the versioning code that figured out which upgrades we should do - Added lots of test coverage to make sure all the fixtures are still being run correctly. Permissions fixtures: - Changed the code that was populating permissions fixtures to be more automated & based only on what is in the permissions.json file. - Added lots of test coverage to make sure all the permissions are still being created correctly. Merging the two things: - Merged the content of permissions.json and fixtures.json into fixtures.json, but using the new structure from permissions.json. - Changed to use the new automated model & relation creation for all fixtures, not just permissions. - The only thing that can't be auto-populated just now is the owner creation, I think that's important enough to do separately. - There were (so far) never any permission updates, so code for updating fixtures stays the same through the merge. - This results in two clear code paths: populate (fill out a brand new DB) and update (make any changes since the last version) Test coverage is now 100% across both updates and populations.
2016-02-25 10:10:36 +03:00
roleOneStub.calledOnce.should.be.true();
userAddStub.called.should.be.true();
done();
}).catch(done);
});
it('createOwner does not add user if owner role is not present', function (done) {
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
roleOneStub.returns(Promise.resolve());
userAddStub.returns(Promise.resolve({}));
Refactor & test fixture migrations refs #6301 Fixtures: - Removed all the old (and now broken) 003 fixture upgrades - Split the 004 fixture upgrade tasks out, each into their own file - Improved the versioning code that figured out which upgrades we should do - Added lots of test coverage to make sure all the fixtures are still being run correctly. Permissions fixtures: - Changed the code that was populating permissions fixtures to be more automated & based only on what is in the permissions.json file. - Added lots of test coverage to make sure all the permissions are still being created correctly. Merging the two things: - Merged the content of permissions.json and fixtures.json into fixtures.json, but using the new structure from permissions.json. - Changed to use the new automated model & relation creation for all fixtures, not just permissions. - The only thing that can't be auto-populated just now is the owner creation, I think that's important enough to do separately. - There were (so far) never any permission updates, so code for updating fixtures stays the same through the merge. - This results in two clear code paths: populate (fill out a brand new DB) and update (make any changes since the last version) Test coverage is now 100% across both updates and populations.
2016-02-25 10:10:36 +03:00
createOwner().then(function () {
roleOneStub.calledOnce.should.be.true();
userAddStub.called.should.be.false();
done();
}).catch(done);
});
});
describe('Match Func', function () {
Improve fixtures & population code refs #6301 - The order of model fixtures matters, so they should be in an array - By splitting out the population code into a utils file, it'll be possible to use this to do updates as well - This should make it much easier to do permissions updates in future
2016-03-29 16:14:44 +03:00
var matchFunc = fixtureUtils.__get__('matchFunc'),
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
getStub;
Refactor & test fixture migrations refs #6301 Fixtures: - Removed all the old (and now broken) 003 fixture upgrades - Split the 004 fixture upgrade tasks out, each into their own file - Improved the versioning code that figured out which upgrades we should do - Added lots of test coverage to make sure all the fixtures are still being run correctly. Permissions fixtures: - Changed the code that was populating permissions fixtures to be more automated & based only on what is in the permissions.json file. - Added lots of test coverage to make sure all the permissions are still being created correctly. Merging the two things: - Merged the content of permissions.json and fixtures.json into fixtures.json, but using the new structure from permissions.json. - Changed to use the new automated model & relation creation for all fixtures, not just permissions. - The only thing that can't be auto-populated just now is the owner creation, I think that's important enough to do separately. - There were (so far) never any permission updates, so code for updating fixtures stays the same through the merge. - This results in two clear code paths: populate (fill out a brand new DB) and update (make any changes since the last version) Test coverage is now 100% across both updates and populations.
2016-02-25 10:10:36 +03:00
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
beforeEach(function () {
getStub = sandbox.stub();
getStub.withArgs('foo').returns('bar');
getStub.withArgs('fun').returns('baz');
});
Refactor & test fixture migrations refs #6301 Fixtures: - Removed all the old (and now broken) 003 fixture upgrades - Split the 004 fixture upgrade tasks out, each into their own file - Improved the versioning code that figured out which upgrades we should do - Added lots of test coverage to make sure all the fixtures are still being run correctly. Permissions fixtures: - Changed the code that was populating permissions fixtures to be more automated & based only on what is in the permissions.json file. - Added lots of test coverage to make sure all the permissions are still being created correctly. Merging the two things: - Merged the content of permissions.json and fixtures.json into fixtures.json, but using the new structure from permissions.json. - Changed to use the new automated model & relation creation for all fixtures, not just permissions. - The only thing that can't be auto-populated just now is the owner creation, I think that's important enough to do separately. - There were (so far) never any permission updates, so code for updating fixtures stays the same through the merge. - This results in two clear code paths: populate (fill out a brand new DB) and update (make any changes since the last version) Test coverage is now 100% across both updates and populations.
2016-02-25 10:10:36 +03:00
Data & fixture migration cleanup refs #6621, #6622 - remove unneeded `return new Promise.resolve()` lines - reduce code in tests - improve quality of tests checking that all task functions are executed - add missing test coverage
2016-03-23 18:02:40 +03:00
it('should match undefined with no args', function () {
Refactor & test fixture migrations refs #6301 Fixtures: - Removed all the old (and now broken) 003 fixture upgrades - Split the 004 fixture upgrade tasks out, each into their own file - Improved the versioning code that figured out which upgrades we should do - Added lots of test coverage to make sure all the fixtures are still being run correctly. Permissions fixtures: - Changed the code that was populating permissions fixtures to be more automated & based only on what is in the permissions.json file. - Added lots of test coverage to make sure all the permissions are still being created correctly. Merging the two things: - Merged the content of permissions.json and fixtures.json into fixtures.json, but using the new structure from permissions.json. - Changed to use the new automated model & relation creation for all fixtures, not just permissions. - The only thing that can't be auto-populated just now is the owner creation, I think that's important enough to do separately. - There were (so far) never any permission updates, so code for updating fixtures stays the same through the merge. - This results in two clear code paths: populate (fill out a brand new DB) and update (make any changes since the last version) Test coverage is now 100% across both updates and populations.
2016-02-25 10:10:36 +03:00
matchFunc()({get: getStub}).should.be.true();
getStub.calledOnce.should.be.true();
getStub.calledWith(undefined).should.be.true();
});
it('should match key with match string', function () {
matchFunc('foo', 'bar')({get: getStub}).should.be.true();
getStub.calledOnce.should.be.true();
getStub.calledWith('foo').should.be.true();
matchFunc('foo', 'buz')({get: getStub}).should.be.false();
getStub.calledTwice.should.be.true();
getStub.secondCall.calledWith('foo').should.be.true();
});
it('should match value when key is 0', function () {
matchFunc('foo', 0, 'bar')({get: getStub}).should.be.true();
getStub.calledOnce.should.be.true();
getStub.calledWith('foo').should.be.true();
matchFunc('foo', 0, 'buz')({get: getStub}).should.be.false();
getStub.calledTwice.should.be.true();
getStub.secondCall.calledWith('foo').should.be.true();
});
it('should match key & value when match is array', function () {
matchFunc(['foo', 'fun'], 'bar', 'baz')({get: getStub}).should.be.true();
getStub.calledTwice.should.be.true();
getStub.getCall(0).calledWith('fun').should.be.true();
getStub.getCall(1).calledWith('foo').should.be.true();
matchFunc(['foo', 'fun'], 'baz', 'bar')({get: getStub}).should.be.false();
getStub.callCount.should.eql(4);
getStub.getCall(2).calledWith('fun').should.be.true();
getStub.getCall(3).calledWith('foo').should.be.true();
});
it('should match key only when match is array, but value is all', function () {
matchFunc(['foo', 'fun'], 'bar', 'all')({get: getStub}).should.be.true();
getStub.calledOnce.should.be.true();
getStub.calledWith('foo').should.be.true();
matchFunc(['foo', 'fun'], 'all', 'bar')({get: getStub}).should.be.false();
getStub.callCount.should.eql(3);
getStub.getCall(1).calledWith('fun').should.be.true();
getStub.getCall(2).calledWith('foo').should.be.true();
});
it('should match key & value when match and value are arrays', function () {
matchFunc(['foo', 'fun'], 'bar', ['baz', 'buz'])({get: getStub}).should.be.true();
getStub.calledTwice.should.be.true();
getStub.getCall(0).calledWith('fun').should.be.true();
getStub.getCall(1).calledWith('foo').should.be.true();
matchFunc(['foo', 'fun'], 'bar', ['biz', 'buz'])({get: getStub}).should.be.false();
getStub.callCount.should.eql(4);
getStub.getCall(2).calledWith('fun').should.be.true();
getStub.getCall(3).calledWith('foo').should.be.true();
});
});
});
Split migrations/index.js & add tests refs #6301 - changes createTable to use createTableIfNotExists, this is consistent with deletion - splits out backup, reset, update and populate functions from migration/index into their own files - moves the wrapped function for populatingDefaultSettings to fixtures.ensureDefaultSettings - moves `modelOptions` down to the fixture files that actually use it - adds test coverage for backup, reset and populate, but not for update as that needs refactoring
2016-03-13 23:49:30 +03:00
describe('Ensure default settings', function () {
it('should call populate settings and provide messaging', function (done) {
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
var settingsStub = sandbox.stub(models.Settings, 'populateDefaults').returns(new Promise.resolve());
Split migrations/index.js & add tests refs #6301 - changes createTable to use createTableIfNotExists, this is consistent with deletion - splits out backup, reset, update and populate functions from migration/index into their own files - moves the wrapped function for populatingDefaultSettings to fixtures.ensureDefaultSettings - moves `modelOptions` down to the fixture files that actually use it - adds test coverage for backup, reset and populate, but not for update as that needs refactoring
2016-03-13 23:49:30 +03:00
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
ensureDefaultSettings(loggerStub).then(function () {
Split migrations/index.js & add tests refs #6301 - changes createTable to use createTableIfNotExists, this is consistent with deletion - splits out backup, reset, update and populate functions from migration/index into their own files - moves the wrapped function for populatingDefaultSettings to fixtures.ensureDefaultSettings - moves `modelOptions` down to the fixture files that actually use it - adds test coverage for backup, reset and populate, but not for update as that needs refactoring
2016-03-13 23:49:30 +03:00
settingsStub.calledOnce.should.be.true();
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
loggerStub.info.calledOnce.should.be.true();
Split migrations/index.js & add tests refs #6301 - changes createTable to use createTableIfNotExists, this is consistent with deletion - splits out backup, reset, update and populate functions from migration/index into their own files - moves the wrapped function for populatingDefaultSettings to fixtures.ensureDefaultSettings - moves `modelOptions` down to the fixture files that actually use it - adds test coverage for backup, reset and populate, but not for update as that needs refactoring
2016-03-13 23:49:30 +03:00
done();
Migration messaging improvements refs #6301 - fix messages that joined with comma and therefore missed outputting version no - change `logInfo` to `logger` that has both an info and a warn method - add new warn method to errors - add a warn message everytime a migration (data or fixture) gets skipped over - update logger everywhere, including tests - update tests to check logger.warn gets called
2016-03-21 15:44:23 +03:00
}).catch(done);
Split migrations/index.js & add tests refs #6301 - changes createTable to use createTableIfNotExists, this is consistent with deletion - splits out backup, reset, update and populate functions from migration/index into their own files - moves the wrapped function for populatingDefaultSettings to fixtures.ensureDefaultSettings - moves `modelOptions` down to the fixture files that actually use it - adds test coverage for backup, reset and populate, but not for update as that needs refactoring
2016-03-13 23:49:30 +03:00
});
});
Improve fixtures & population code refs #6301 - The order of model fixtures matters, so they should be in an array - By splitting out the population code into a utils file, it'll be possible to use this to do updates as well - This should make it much easier to do permissions updates in future
2016-03-29 16:14:44 +03:00
describe('Utils', function () {
describe('findModelFixtureEntry', function () {
it('should fetch a single fixture entry', function () {
var foundFixture = fixtureUtils.findModelFixtureEntry('Client', {slug: 'ghost-admin'});
foundFixture.should.be.an.Object();
foundFixture.should.eql({
name: 'Ghost Admin',
slug: 'ghost-admin',
status: 'enabled'
});
});
});
describe('findPermissionModelForObject', function () {
it('should fetch a fixture with multiple entries', function () {
var foundFixture = fixtureUtils.findPermissionModelForObject('Permission', {object_type: 'db'});
foundFixture.should.be.an.Object();
foundFixture.entries.should.be.an.Array().with.lengthOf(3);
foundFixture.entries[0].should.eql({
name: 'Export database',
action_type: 'exportContent',
object_type: 'db'
});
});
});
describe('findPermissionRelationsForObject', function () {
it('should fetch a fixture with multiple entries', function () {
var foundFixture = fixtureUtils.findPermissionRelationsForObject('db');
foundFixture.should.be.an.Object();
foundFixture.entries.should.be.an.Object();
foundFixture.entries.should.have.property('Administrator', {db: 'all'});
});
});
});
Refactor & test fixture migrations refs #6301 Fixtures: - Removed all the old (and now broken) 003 fixture upgrades - Split the 004 fixture upgrade tasks out, each into their own file - Improved the versioning code that figured out which upgrades we should do - Added lots of test coverage to make sure all the fixtures are still being run correctly. Permissions fixtures: - Changed the code that was populating permissions fixtures to be more automated & based only on what is in the permissions.json file. - Added lots of test coverage to make sure all the permissions are still being created correctly. Merging the two things: - Merged the content of permissions.json and fixtures.json into fixtures.json, but using the new structure from permissions.json. - Changed to use the new automated model & relation creation for all fixtures, not just permissions. - The only thing that can't be auto-populated just now is the owner creation, I think that's important enough to do separately. - There were (so far) never any permission updates, so code for updating fixtures stays the same through the merge. - This results in two clear code paths: populate (fill out a brand new DB) and update (make any changes since the last version) Test coverage is now 100% across both updates and populations.
2016-02-25 10:10:36 +03:00
});
Reference in New Issue Copy Permalink