TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-11-29 15:12:58 +03:00
Code Issues Projects Releases Wiki Activity
bcfc3792cd
Ghost/ghost/admin/app/components/gh-image-uploader-with-preview.hbs

19 lines
573 B
Handlebars
Raw Normal View History

Migrated to `<AngleBracketSyntax />` (#1460) no issue Ember is migrating to `<AngleBracketSyntax />` for component invocation, see https://github.com/emberjs/rfcs/blob/master/text/0311-angle-bracket-invocation.md We were in a half-way situation where some templates used angle bracket syntax in some places, this PR updates templates to use the syntax everywhere. This simplifies the rules for what template code is referring to... `<Component>` = a component `{{helper}}` = a helper (or locally assigned handlebars variable) `{{this.foo}}` = data on the template backing context (a component/controller) `{{@foo}}` = a named argument passed into the component that the component backing class has not modified (note: this commit does not introduce any named arguments) - ran codemod https://github.com/ember-codemods/ember-angle-brackets-codemod on the following directories: - `app/templates` - `lib/koenig-editor/addon/templates` - removed positional params from components as angle bracket syntax does not support them - `gh-feature-flag` - `gh-tour-item` - `gh-cm-editor` - `gh-fullscreen-modal` - `gh-task-button` - updates some code that was missed in https://github.com/TryGhost/Ghost-Admin/commit/3c851293c1f92d14bc6a49debf86a4663398315a to use explicit this
2020-01-16 18:14:03 +03:00
{{#if this.image}}
Safari doesn't show dragged-over state for file uploads (#288) closes TryGhost/Ghost#7310 - Removes double dashes from modifier classes as safari won’t allow this.
2016-09-24 12:10:08 +03:00
<div class="gh-image-uploader -with-image">
Migrated to `<AngleBracketSyntax />` (#1460) no issue Ember is migrating to `<AngleBracketSyntax />` for component invocation, see https://github.com/emberjs/rfcs/blob/master/text/0311-angle-bracket-invocation.md We were in a half-way situation where some templates used angle bracket syntax in some places, this PR updates templates to use the syntax everywhere. This simplifies the rules for what template code is referring to... `<Component>` = a component `{{helper}}` = a helper (or locally assigned handlebars variable) `{{this.foo}}` = data on the template backing context (a component/controller) `{{@foo}}` = a named argument passed into the component that the component backing class has not modified (note: this commit does not introduce any named arguments) - ran codemod https://github.com/ember-codemods/ember-angle-brackets-codemod on the following directories: - `app/templates` - `lib/koenig-editor/addon/templates` - removed positional params from components as angle bracket syntax does not support them - `gh-feature-flag` - `gh-tour-item` - `gh-cm-editor` - `gh-fullscreen-modal` - `gh-task-button` - updates some code that was missed in https://github.com/TryGhost/Ghost-Admin/commit/3c851293c1f92d14bc6a49debf86a4663398315a to use explicit this
2020-01-16 18:14:03 +03:00
<div><img src={{this.image}}></div>
No more icon font: `{{inline-svg}}` - Part 2 (#642) closes TryGhost/Ghost#8107 - replaces all icons in Ghost-Admin with SVGs by using our new helper {{inline-svg}}. - removes all ghosticon fonts. This is the second and final batch of the refactor.
2017-04-14 19:22:14 +03:00
<a class="image-cancel" title="Delete" {{action "remove"}}>
Swap out ember-inline-svg for ember-svg-jar (#970) closes TryGhost/Ghost#9506
2018-03-19 12:57:31 +03:00
{{svg-jar "trash"}}
Replace jQuery-based uploader.js with ember components no issue - adds `gh-image-uploader` that handles image uploads in a fully ember fashion and with no dependency on `uploader.js` - adds `gh-image-uploader-with-preview` that can fully replace the old `gh-uploader` - replace uses of `gh-uploader` in PSM & TSM with `gh-image-uploader-with-preview` - updates the editor preview image handling to use the new `gh-image-uploader-with-preview` component - updates the image upload modal to use `gh-image-uploader` (utilises the `saveButton=false` flag which means the preview has to be handled externally to avoid auto-replacement when typing a URL) - removes all old `uploader.js` related code - adds custom `RequestEntityTooLargeError` and `UnsupportedMediaTypeError` errors to our `ajax` service
2016-02-26 16:25:47 +03:00
<span class="hidden">Delete</span>
</a>
</div>
{{else}}
Migrated to `<AngleBracketSyntax />` (#1460) no issue Ember is migrating to `<AngleBracketSyntax />` for component invocation, see https://github.com/emberjs/rfcs/blob/master/text/0311-angle-bracket-invocation.md We were in a half-way situation where some templates used angle bracket syntax in some places, this PR updates templates to use the syntax everywhere. This simplifies the rules for what template code is referring to... `<Component>` = a component `{{helper}}` = a helper (or locally assigned handlebars variable) `{{this.foo}}` = data on the template backing context (a component/controller) `{{@foo}}` = a named argument passed into the component that the component backing class has not modified (note: this commit does not introduce any named arguments) - ran codemod https://github.com/ember-codemods/ember-angle-brackets-codemod on the following directories: - `app/templates` - `lib/koenig-editor/addon/templates` - removed positional params from components as angle bracket syntax does not support them - `gh-feature-flag` - `gh-tour-item` - `gh-cm-editor` - `gh-fullscreen-modal` - `gh-task-button` - updates some code that was missed in https://github.com/TryGhost/Ghost-Admin/commit/3c851293c1f92d14bc6a49debf86a4663398315a to use explicit this
2020-01-16 18:14:03 +03:00
<GhImageUploader
@text={{this.text}}
@altText={{this.altText}}
@allowUnsplash={{this.allowUnsplash}}
@update={{action "update"}}
@uploadStarted={{action "uploadStarted"}}
@uploadFinished={{action "uploadFinished"}}
/>
Replace jQuery-based uploader.js with ember components no issue - adds `gh-image-uploader` that handles image uploads in a fully ember fashion and with no dependency on `uploader.js` - adds `gh-image-uploader-with-preview` that can fully replace the old `gh-uploader` - replace uses of `gh-uploader` in PSM & TSM with `gh-image-uploader-with-preview` - updates the editor preview image handling to use the new `gh-image-uploader-with-preview` component - updates the image upload modal to use `gh-image-uploader` (utilises the `saveButton=false` flag which means the preview has to be handled externally to avoid auto-replacement when typing a URL) - removes all old `uploader.js` related code - adds custom `RequestEntityTooLargeError` and `UnsupportedMediaTypeError` errors to our `ajax` service
2016-02-26 16:25:47 +03:00
{{/if}}
Reference in New Issue Copy Permalink