TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-23 10:53:34 +03:00
Code Issues Projects Releases Wiki Activity
bd597db829
Ghost/test/unit/services/routing/StaticRoutesRouter_spec.js

284 lines
11 KiB
JavaScript
Raw Normal View History

Updated var declarations to const/let and no lists - All var declarations are now const or let as per ES6 - All comma-separated lists / chained declarations are now one declaration per line - This is for clarity/readability but also made running the var-to-const/let switch smoother - ESLint rules updated to match How this was done: - npm install -g jscodeshift - git clone https://github.com/cpojer/js-codemod.git - git clone git@github.com:TryGhost/Ghost.git shallow-ghost - cd shallow-ghost - jscodeshift -t ../js-codemod/transforms/unchain-variables.js . -v=2 - jscodeshift -t ../js-codemod/transforms/no-vars.js . -v=2 - yarn - yarn test - yarn lint / fix various lint errors (almost all indent) by opening files and saving in vscode - grunt test-regression - sorted!
2020-04-29 18:44:27 +03:00
const should = require('should');
const sinon = require('sinon');
Expanded requires of lib/common i18n and events - Having these as destructured from the same package is hindering refactoring now - Events should really only ever be used server-side - i18n should be a shared module for now so it can be used everywhere until we figure out something better - Having them seperate also allows us to lint them properly
2021-04-27 16:18:04 +03:00
const events = require('../../../../core/server/lib/common/events');
Updated var declarations to const/let and no lists - All var declarations are now const or let as per ES6 - All comma-separated lists / chained declarations are now one declaration per line - This is for clarity/readability but also made running the var-to-const/let switch smoother - ESLint rules updated to match How this was done: - npm install -g jscodeshift - git clone https://github.com/cpojer/js-codemod.git - git clone git@github.com:TryGhost/Ghost.git shallow-ghost - cd shallow-ghost - jscodeshift -t ../js-codemod/transforms/unchain-variables.js . -v=2 - jscodeshift -t ../js-codemod/transforms/no-vars.js . -v=2 - yarn - yarn test - yarn lint / fix various lint errors (almost all indent) by opening files and saving in vscode - grunt test-regression - sorted!
2020-04-29 18:44:27 +03:00
const controllers = require('../../../../core/frontend/services/routing/controllers');
const StaticRoutesRouter = require('../../../../core/frontend/services/routing/StaticRoutesRouter');
const configUtils = require('../../../utils/configUtils');
Dynamic Routing Beta: Better template support refs #9601 - single or multiple template definition - possible formats: ``` routes: /about/: about ``` ``` routes: /about/: template: about ``` ``` routes: /about/: template: - about - me ``` ``` collections /posts/: template: - posts - general ``` ``` collections /posts/: template: posts ```
2018-06-21 16:46:42 +03:00
describe('UNIT - services/routing/StaticRoutesRouter', function () {
Updated var declarations to const/let and no lists - All var declarations are now const or let as per ES6 - All comma-separated lists / chained declarations are now one declaration per line - This is for clarity/readability but also made running the var-to-const/let switch smoother - ESLint rules updated to match How this was done: - npm install -g jscodeshift - git clone https://github.com/cpojer/js-codemod.git - git clone git@github.com:TryGhost/Ghost.git shallow-ghost - cd shallow-ghost - jscodeshift -t ../js-codemod/transforms/unchain-variables.js . -v=2 - jscodeshift -t ../js-codemod/transforms/no-vars.js . -v=2 - yarn - yarn test - yarn lint / fix various lint errors (almost all indent) by opening files and saving in vscode - grunt test-regression - sorted!
2020-04-29 18:44:27 +03:00
let req;
let res;
let next;
Dynamic Routing Beta: Better template support refs #9601 - single or multiple template definition - possible formats: ``` routes: /about/: about ``` ``` routes: /about/: template: about ``` ``` routes: /about/: template: - about - me ``` ``` collections /posts/: template: - posts - general ``` ``` collections /posts/: template: posts ```
2018-06-21 16:46:42 +03:00
afterEach(function () {
configUtils.restore();
});
beforeEach(function () {
Refactored tests to destructure `common` lib import (#11838)
2020-05-25 11:49:38 +03:00
sinon.stub(events, 'emit');
sinon.stub(events, 'on');
Dynamic Routing Beta: Better template support refs #9601 - single or multiple template definition - possible formats: ``` routes: /about/: about ``` ``` routes: /about/: template: about ``` ``` routes: /about/: template: - about - me ``` ``` collections /posts/: template: - posts - general ``` ``` collections /posts/: template: posts ```
2018-06-21 16:46:42 +03:00
Bumped sinon from 4.4.6 to 7.3.2 (#10400) refs #9389 - https://github.com/sinonjs/sinon/blob/master/CHANGELOG.md Breaking changes for Ghost: - no need to create a sandbox anymore, each file get's it's own sandbox - just require sinon and use this sandbox - you can still create separate sandboxes with .createSandbox - reset single stubs: use .resetHistory instead of .reset This is a global replace for any sandbox creation. --- From https://sinonjs.org/releases/v7.2.3/sandbox/ > Default sandbox > Since sinon@5.0.0, the sinon object is a default sandbox. Unless you have a very advanced setup or need a special configuration, you probably want to just use that one.
2019-01-21 19:53:44 +03:00
sinon.spy(StaticRoutesRouter.prototype, 'mountRoute');
sinon.spy(StaticRoutesRouter.prototype, 'mountRouter');
Dynamic Routing Beta: Better template support refs #9601 - single or multiple template definition - possible formats: ``` routes: /about/: about ``` ``` routes: /about/: template: about ``` ``` routes: /about/: template: - about - me ``` ``` collections /posts/: template: - posts - general ``` ``` collections /posts/: template: posts ```
2018-06-21 16:46:42 +03:00
Bumped sinon from 4.4.6 to 7.3.2 (#10400) refs #9389 - https://github.com/sinonjs/sinon/blob/master/CHANGELOG.md Breaking changes for Ghost: - no need to create a sandbox anymore, each file get's it's own sandbox - just require sinon and use this sandbox - you can still create separate sandboxes with .createSandbox - reset single stubs: use .resetHistory instead of .reset This is a global replace for any sandbox creation. --- From https://sinonjs.org/releases/v7.2.3/sandbox/ > Default sandbox > Since sinon@5.0.0, the sinon object is a default sandbox. Unless you have a very advanced setup or need a special configuration, you probably want to just use that one.
2019-01-21 19:53:44 +03:00
req = sinon.stub();
res = sinon.stub();
next = sinon.stub();
Dynamic Routing Beta: Better template support refs #9601 - single or multiple template definition - possible formats: ``` routes: /about/: about ``` ``` routes: /about/: template: about ``` ``` routes: /about/: template: - about - me ``` ``` collections /posts/: template: - posts - general ``` ``` collections /posts/: template: posts ```
2018-06-21 16:46:42 +03:00
res.locals = {};
});
afterEach(function () {
Bumped sinon from 4.4.6 to 7.3.2 (#10400) refs #9389 - https://github.com/sinonjs/sinon/blob/master/CHANGELOG.md Breaking changes for Ghost: - no need to create a sandbox anymore, each file get's it's own sandbox - just require sinon and use this sandbox - you can still create separate sandboxes with .createSandbox - reset single stubs: use .resetHistory instead of .reset This is a global replace for any sandbox creation. --- From https://sinonjs.org/releases/v7.2.3/sandbox/ > Default sandbox > Since sinon@5.0.0, the sinon object is a default sandbox. Unless you have a very advanced setup or need a special configuration, you probably want to just use that one.
2019-01-21 19:53:44 +03:00
sinon.restore();
Dynamic Routing Beta: Better template support refs #9601 - single or multiple template definition - possible formats: ``` routes: /about/: about ``` ``` routes: /about/: template: about ``` ``` routes: /about/: template: - about - me ``` ``` collections /posts/: template: - posts - general ``` ``` collections /posts/: template: posts ```
2018-06-21 16:46:42 +03:00
});
describe('static routes', function () {
it('instantiate: default', function () {
const staticRoutesRouter = new StaticRoutesRouter('/about/', {templates: ['test']});
should.exist(staticRoutesRouter.router);
should.not.exist(staticRoutesRouter.getFilter());
should.not.exist(staticRoutesRouter.getPermalinks());
staticRoutesRouter.templates.should.eql(['test']);
Refactored tests to destructure `common` lib import (#11838)
2020-05-25 11:49:38 +03:00
events.emit.calledOnce.should.be.true();
events.emit.calledWith('router.created', staticRoutesRouter).should.be.true();
Dynamic Routing Beta: Better template support refs #9601 - single or multiple template definition - possible formats: ``` routes: /about/: about ``` ``` routes: /about/: template: about ``` ``` routes: /about/: template: - about - me ``` ``` collections /posts/: template: - posts - general ``` ``` collections /posts/: template: posts ```
2018-06-21 16:46:42 +03:00
staticRoutesRouter.mountRoute.callCount.should.eql(1);
// parent route
staticRoutesRouter.mountRoute.args[0][0].should.eql('/about/');
✨ Dynamic Routing Beta: Channels refs #9601 - refactor architecture of routing so you can define a channel - a channel is a different way of looking at your posts (a view) - a channel does not change the url of a resource Example channel ``` routes: /worldcup-2018-russia/: controller: channel filter: tag:football18 data: tag.football18 ``` - added ability to redirect resources to a channel/static route - support templates for channels - ensure we still support static routes (e.g. /about/: home) - ensure pagination + rss works out of the box
2018-06-24 01:32:08 +03:00
staticRoutesRouter.mountRoute.args[0][1].should.eql(controllers.static);
Dynamic Routing Beta: Better template support refs #9601 - single or multiple template definition - possible formats: ``` routes: /about/: about ``` ``` routes: /about/: template: about ``` ``` routes: /about/: template: - about - me ``` ``` collections /posts/: template: - posts - general ``` ``` collections /posts/: template: posts ```
2018-06-21 16:46:42 +03:00
});
✨ Dynamic Routing Beta: Channels refs #9601 - refactor architecture of routing so you can define a channel - a channel is a different way of looking at your posts (a view) - a channel does not change the url of a resource Example channel ``` routes: /worldcup-2018-russia/: controller: channel filter: tag:football18 data: tag.football18 ``` - added ability to redirect resources to a channel/static route - support templates for channels - ensure we still support static routes (e.g. /about/: home) - ensure pagination + rss works out of the box
2018-06-24 01:32:08 +03:00
it('initialise with data+filter', function () {
const staticRoutesRouter = new StaticRoutesRouter('/about/', {
data: {query: {}, router: {}},
filter: 'tag:test'
});
should.exist(staticRoutesRouter.router);
should.not.exist(staticRoutesRouter.getPermalinks());
should.not.exist(staticRoutesRouter.getFilter());
staticRoutesRouter.templates.should.eql([]);
Refactored tests to destructure `common` lib import (#11838)
2020-05-25 11:49:38 +03:00
events.emit.calledOnce.should.be.true();
events.emit.calledWith('router.created', staticRoutesRouter).should.be.true();
✨ Dynamic Routing Beta: Channels refs #9601 - refactor architecture of routing so you can define a channel - a channel is a different way of looking at your posts (a view) - a channel does not change the url of a resource Example channel ``` routes: /worldcup-2018-russia/: controller: channel filter: tag:football18 data: tag.football18 ``` - added ability to redirect resources to a channel/static route - support templates for channels - ensure we still support static routes (e.g. /about/: home) - ensure pagination + rss works out of the box
2018-06-24 01:32:08 +03:00
staticRoutesRouter.mountRoute.callCount.should.eql(1);
// parent route
staticRoutesRouter.mountRoute.args[0][0].should.eql('/about/');
staticRoutesRouter.mountRoute.args[0][1].should.eql(controllers.static);
});
it('fn: _prepareStaticRouteContext', function () {
Dynamic Routing Beta: Better template support refs #9601 - single or multiple template definition - possible formats: ``` routes: /about/: about ``` ``` routes: /about/: template: about ``` ``` routes: /about/: template: - about - me ``` ``` collections /posts/: template: - posts - general ``` ``` collections /posts/: template: posts ```
2018-06-21 16:46:42 +03:00
const staticRoutesRouter = new StaticRoutesRouter('/about/', {templates: []});
✨ Dynamic Routing Beta: Channels refs #9601 - refactor architecture of routing so you can define a channel - a channel is a different way of looking at your posts (a view) - a channel does not change the url of a resource Example channel ``` routes: /worldcup-2018-russia/: controller: channel filter: tag:football18 data: tag.football18 ``` - added ability to redirect resources to a channel/static route - support templates for channels - ensure we still support static routes (e.g. /about/: home) - ensure pagination + rss works out of the box
2018-06-24 01:32:08 +03:00
staticRoutesRouter._prepareStaticRouteContext(req, res, next);
Dynamic Routing Beta: Better template support refs #9601 - single or multiple template definition - possible formats: ``` routes: /about/: about ``` ``` routes: /about/: template: about ``` ``` routes: /about/: template: - about - me ``` ``` collections /posts/: template: - posts - general ``` ``` collections /posts/: template: posts ```
2018-06-21 16:46:42 +03:00
next.called.should.be.true();
💡Changed static router - throw 400 for missing tpl fixes #10990 - Changed the static router to throw a 400 error for a missing template file, rather than falling back to using the default.hbs file - Falling back is weird and hard to understand, but throwing an error makes it clear that the user has to provide the matching template - The new error reads 'Missing template [filename].hbs for route "[route]".' Assume you have a route.yaml file something like: ``` routes: /: home ``` - In Ghost v2, if you don't have a home.hbs template, Ghost falls back to using the default.hbs file if it's available - Most themes have a default.hbs, however this file is a layout file, depended on by other templates, not a template file itself - In production mode, using the default.hbs as a template causes weird, intermittent layout issues depending on which order pages are loaded - This is due to this issue: https://github.com/barc/express-hbs/issues/161 - In Ghost v3, we will throw a 400 error for missing template files instead of having a fallback - In the example above, navigating to '/' would throw the error 'Missing template home.hbs for route "/".'
2019-08-05 21:34:12 +03:00
res.routerOptions.should.have.properties('type', 'templates', 'defaultTemplate', 'context', 'data', 'contentType');
res.routerOptions.type.should.eql('custom');
res.routerOptions.templates.should.eql([]);
res.routerOptions.defaultTemplate.should.be.a.Function();
res.routerOptions.context.should.eql(['about']);
res.routerOptions.data.should.eql({});
should(res.routerOptions.contentType).be.undefined();
Dynamic Routing Beta: StaticRoutesRouter has to respect the route name refs #9601 - this was already working for collections or channels - but the `routeName` was not parsed for static routes - ensure we push the route name into the context object e.g. /about/: about -> name of the route is "about"
2018-06-26 20:04:39 +03:00
should.not.exist(res.locals.slug);
});
it('fn: _prepareStaticRouteContext', function () {
const staticRoutesRouter = new StaticRoutesRouter('/', {templates: []});
staticRoutesRouter._prepareStaticRouteContext(req, res, next);
next.called.should.be.true();
💡Changed static router - throw 400 for missing tpl fixes #10990 - Changed the static router to throw a 400 error for a missing template file, rather than falling back to using the default.hbs file - Falling back is weird and hard to understand, but throwing an error makes it clear that the user has to provide the matching template - The new error reads 'Missing template [filename].hbs for route "[route]".' Assume you have a route.yaml file something like: ``` routes: /: home ``` - In Ghost v2, if you don't have a home.hbs template, Ghost falls back to using the default.hbs file if it's available - Most themes have a default.hbs, however this file is a layout file, depended on by other templates, not a template file itself - In production mode, using the default.hbs as a template causes weird, intermittent layout issues depending on which order pages are loaded - This is due to this issue: https://github.com/barc/express-hbs/issues/161 - In Ghost v3, we will throw a 400 error for missing template files instead of having a fallback - In the example above, navigating to '/' would throw the error 'Missing template home.hbs for route "/".'
2019-08-05 21:34:12 +03:00
res.routerOptions.should.have.properties('type', 'templates', 'defaultTemplate', 'context', 'data', 'contentType');
res.routerOptions.type.should.eql('custom');
res.routerOptions.templates.should.eql([]);
res.routerOptions.defaultTemplate.should.be.a.Function();
res.routerOptions.context.should.eql(['index']);
res.routerOptions.data.should.eql({});
✨ Dynamic Routing Beta: Channels refs #9601 - refactor architecture of routing so you can define a channel - a channel is a different way of looking at your posts (a view) - a channel does not change the url of a resource Example channel ``` routes: /worldcup-2018-russia/: controller: channel filter: tag:football18 data: tag.football18 ``` - added ability to redirect resources to a channel/static route - support templates for channels - ensure we still support static routes (e.g. /about/: home) - ensure pagination + rss works out of the box
2018-06-24 01:32:08 +03:00
should.not.exist(res.locals.slug);
});
});
describe('channels', function () {
describe('initialise', function () {
it('initialise with controller+data+filter', function () {
const staticRoutesRouter = new StaticRoutesRouter('/channel/', {
controller: 'channel',
data: {query: {}, router: {}},
filter: 'tag:test'
});
should.exist(staticRoutesRouter.router);
should.not.exist(staticRoutesRouter.getPermalinks());
staticRoutesRouter.getFilter().should.eql('tag:test');
staticRoutesRouter.templates.should.eql([]);
should.exist(staticRoutesRouter.data);
Refactored tests to destructure `common` lib import (#11838)
2020-05-25 11:49:38 +03:00
events.emit.calledOnce.should.be.true();
events.emit.calledWith('router.created', staticRoutesRouter).should.be.true();
✨ Dynamic Routing Beta: Channels refs #9601 - refactor architecture of routing so you can define a channel - a channel is a different way of looking at your posts (a view) - a channel does not change the url of a resource Example channel ``` routes: /worldcup-2018-russia/: controller: channel filter: tag:football18 data: tag.football18 ``` - added ability to redirect resources to a channel/static route - support templates for channels - ensure we still support static routes (e.g. /about/: home) - ensure pagination + rss works out of the box
2018-06-24 01:32:08 +03:00
staticRoutesRouter.mountRoute.callCount.should.eql(2);
// parent route
staticRoutesRouter.mountRoute.args[0][0].should.eql('/channel/');
staticRoutesRouter.mountRoute.args[0][1].should.eql(controllers.channel);
// pagination feature
staticRoutesRouter.mountRoute.args[1][0].should.eql('/channel/page/:page(\\d+)');
staticRoutesRouter.mountRoute.args[1][1].should.eql(controllers.channel);
});
it('initialise with controller+filter', function () {
const staticRoutesRouter = new StaticRoutesRouter('/channel/', {
controller: 'channel',
filter: 'tag:test'
});
should.exist(staticRoutesRouter.router);
should.not.exist(staticRoutesRouter.getPermalinks());
staticRoutesRouter.getFilter().should.eql('tag:test');
staticRoutesRouter.templates.should.eql([]);
Refactored tests to destructure `common` lib import (#11838)
2020-05-25 11:49:38 +03:00
events.emit.calledOnce.should.be.true();
events.emit.calledWith('router.created', staticRoutesRouter).should.be.true();
✨ Dynamic Routing Beta: Channels refs #9601 - refactor architecture of routing so you can define a channel - a channel is a different way of looking at your posts (a view) - a channel does not change the url of a resource Example channel ``` routes: /worldcup-2018-russia/: controller: channel filter: tag:football18 data: tag.football18 ``` - added ability to redirect resources to a channel/static route - support templates for channels - ensure we still support static routes (e.g. /about/: home) - ensure pagination + rss works out of the box
2018-06-24 01:32:08 +03:00
staticRoutesRouter.mountRoute.callCount.should.eql(2);
// parent route
staticRoutesRouter.mountRoute.args[0][0].should.eql('/channel/');
staticRoutesRouter.mountRoute.args[0][1].should.eql(controllers.channel);
// pagination feature
staticRoutesRouter.mountRoute.args[1][0].should.eql('/channel/page/:page(\\d+)');
staticRoutesRouter.mountRoute.args[1][1].should.eql(controllers.channel);
});
it('initialise with controller+data', function () {
const staticRoutesRouter = new StaticRoutesRouter('/channel/', {
controller: 'channel',
Update Test & linting packages (major) (#10858) no issue - Updated Test & linting packages - Updated use of hasOwnProperty - Using Object.prototype.hasOwnProperty instead (ref. eslint.org/docs/rules/no-prototype-builtins) - Removed already defined built-in global variable Intl - Applied `--fix` with lint command on `core/test` folder - The rules were broken because some of them were made stricter for `eslint: recommended` ruleset (ref. https://eslint.org/docs/user-guide/migrating-to-6.0.0#eslint-recommended-changes) - Removed redundant global variable declarations to pass linting
2019-07-05 14:40:43 +03:00
data: {query: {}, router: {}}
✨ Dynamic Routing Beta: Channels refs #9601 - refactor architecture of routing so you can define a channel - a channel is a different way of looking at your posts (a view) - a channel does not change the url of a resource Example channel ``` routes: /worldcup-2018-russia/: controller: channel filter: tag:football18 data: tag.football18 ``` - added ability to redirect resources to a channel/static route - support templates for channels - ensure we still support static routes (e.g. /about/: home) - ensure pagination + rss works out of the box
2018-06-24 01:32:08 +03:00
});
should.not.exist(staticRoutesRouter.getFilter());
});
it('initialise on subdirectory with controller+data+filter', function () {
configUtils.set('url', 'http://localhost:2366/blog/');
const staticRoutesRouter = new StaticRoutesRouter('/channel/', {
controller: 'channel',
data: {query: {}, router: {}},
filter: 'author:michi'
});
staticRoutesRouter.mountRoute.callCount.should.eql(2);
// parent route
staticRoutesRouter.mountRoute.args[0][0].should.eql('/channel/');
staticRoutesRouter.mountRoute.args[0][1].should.eql(controllers.channel);
// pagination feature
staticRoutesRouter.mountRoute.args[1][0].should.eql('/channel/page/:page(\\d+)');
staticRoutesRouter.mountRoute.args[1][1].should.eql(controllers.channel);
});
});
describe('fn: _prepareChannelContext', function () {
it('with data+filter', function () {
const staticRoutesRouter = new StaticRoutesRouter('/channel/', {
controller: 'channel',
data: {query: {}, router: {}},
filter: 'tag:test'
});
staticRoutesRouter._prepareChannelContext(req, res, next);
next.calledOnce.should.eql(true);
Dynamic Routing Beta: Refactor `res.routerOptions` (#9705) refs #9601 - sort out `res._route` vs. `res.locals.routerOptions` - it was super hard to maintain two different objects
2018-06-26 02:12:50 +03:00
res.routerOptions.should.eql({
type: 'channel',
✨ Dynamic Routing Beta: Channels refs #9601 - refactor architecture of routing so you can define a channel - a channel is a different way of looking at your posts (a view) - a channel does not change the url of a resource Example channel ``` routes: /worldcup-2018-russia/: controller: channel filter: tag:football18 data: tag.football18 ``` - added ability to redirect resources to a channel/static route - support templates for channels - ensure we still support static routes (e.g. /about/: home) - ensure pagination + rss works out of the box
2018-06-24 01:32:08 +03:00
context: ['channel'],
filter: 'tag:test',
name: 'channel',
data: {},
limit: undefined,
order: undefined,
templates: []
});
});
it('with data', function () {
const staticRoutesRouter = new StaticRoutesRouter('/nothingcomparestoyou/', {
controller: 'channel',
data: {query: {type: 'read'}, router: {}}
});
staticRoutesRouter._prepareChannelContext(req, res, next);
next.calledOnce.should.eql(true);
Dynamic Routing Beta: Refactor `res.routerOptions` (#9705) refs #9601 - sort out `res._route` vs. `res.locals.routerOptions` - it was super hard to maintain two different objects
2018-06-26 02:12:50 +03:00
res.routerOptions.should.eql({
type: 'channel',
✨ Dynamic Routing Beta: Channels refs #9601 - refactor architecture of routing so you can define a channel - a channel is a different way of looking at your posts (a view) - a channel does not change the url of a resource Example channel ``` routes: /worldcup-2018-russia/: controller: channel filter: tag:football18 data: tag.football18 ``` - added ability to redirect resources to a channel/static route - support templates for channels - ensure we still support static routes (e.g. /about/: home) - ensure pagination + rss works out of the box
2018-06-24 01:32:08 +03:00
context: ['nothingcomparestoyou'],
name: 'nothingcomparestoyou',
filter: undefined,
data: {type: 'read'},
limit: undefined,
order: undefined,
templates: []
});
});
it('with filter', function () {
const staticRoutesRouter = new StaticRoutesRouter('/channel/', {
controller: 'channel',
filter: 'tag:test'
});
staticRoutesRouter._prepareChannelContext(req, res, next);
next.calledOnce.should.eql(true);
Dynamic Routing Beta: Refactor `res.routerOptions` (#9705) refs #9601 - sort out `res._route` vs. `res.locals.routerOptions` - it was super hard to maintain two different objects
2018-06-26 02:12:50 +03:00
res.routerOptions.should.eql({
type: 'channel',
✨ Dynamic Routing Beta: Channels refs #9601 - refactor architecture of routing so you can define a channel - a channel is a different way of looking at your posts (a view) - a channel does not change the url of a resource Example channel ``` routes: /worldcup-2018-russia/: controller: channel filter: tag:football18 data: tag.football18 ``` - added ability to redirect resources to a channel/static route - support templates for channels - ensure we still support static routes (e.g. /about/: home) - ensure pagination + rss works out of the box
2018-06-24 01:32:08 +03:00
context: ['channel'],
filter: 'tag:test',
name: 'channel',
limit: undefined,
order: undefined,
data: {},
templates: []
});
});
it('with order+limit', function () {
const staticRoutesRouter = new StaticRoutesRouter('/channel/', {
controller: 'channel',
filter: 'tag:test',
limit: 2,
order: 'published_at asc'
});
staticRoutesRouter._prepareChannelContext(req, res, next);
next.calledOnce.should.eql(true);
Dynamic Routing Beta: Refactor `res.routerOptions` (#9705) refs #9601 - sort out `res._route` vs. `res.locals.routerOptions` - it was super hard to maintain two different objects
2018-06-26 02:12:50 +03:00
res.routerOptions.should.eql({
type: 'channel',
✨ Dynamic Routing Beta: Channels refs #9601 - refactor architecture of routing so you can define a channel - a channel is a different way of looking at your posts (a view) - a channel does not change the url of a resource Example channel ``` routes: /worldcup-2018-russia/: controller: channel filter: tag:football18 data: tag.football18 ``` - added ability to redirect resources to a channel/static route - support templates for channels - ensure we still support static routes (e.g. /about/: home) - ensure pagination + rss works out of the box
2018-06-24 01:32:08 +03:00
context: ['channel'],
filter: 'tag:test',
name: 'channel',
limit: 2,
order: 'published_at asc',
data: {},
templates: []
});
});
Dynamic Routing Beta: Better template support refs #9601 - single or multiple template definition - possible formats: ``` routes: /about/: about ``` ``` routes: /about/: template: about ``` ``` routes: /about/: template: - about - me ``` ``` collections /posts/: template: - posts - general ``` ``` collections /posts/: template: posts ```
2018-06-21 16:46:42 +03:00
});
});
});
Reference in New Issue Copy Permalink