2018-06-02 22:48:23 +03:00
|
|
|
var should = require('should'),
|
2017-03-21 11:24:11 +03:00
|
|
|
sinon = require('sinon'),
|
|
|
|
_ = require('lodash'),
|
|
|
|
rewire = require('rewire'),
|
2017-10-25 17:27:56 +03:00
|
|
|
testUtils = require('../../utils'),
|
|
|
|
configUtils = require('../../utils/configUtils'),
|
2016-03-29 11:40:44 +03:00
|
|
|
|
2016-09-09 13:23:47 +03:00
|
|
|
// Stuff we test
|
2017-10-25 17:27:56 +03:00
|
|
|
slack = rewire('../../../server/services/slack'),
|
2017-12-12 00:47:46 +03:00
|
|
|
common = require('../../../server/lib/common'),
|
2019-06-18 16:13:55 +03:00
|
|
|
imageLib = require('../../../server/lib/image'),
|
2019-06-19 12:30:28 +03:00
|
|
|
urlService = require('../../../frontend/services/url'),
|
2017-10-25 17:27:56 +03:00
|
|
|
schema = require('../../../server/data/schema').checks,
|
2017-12-14 05:01:23 +03:00
|
|
|
settingsCache = require('../../../server/services/settings/cache'),
|
2017-03-21 11:24:11 +03:00
|
|
|
|
2016-09-09 13:23:47 +03:00
|
|
|
// Test data
|
2017-10-25 17:27:56 +03:00
|
|
|
slackObjNoUrl = [{url: ''}],
|
|
|
|
slackObjWithUrl = [{url: 'https://hooks.slack.com/services/a-b-c-d'}];
|
2016-03-29 11:40:44 +03:00
|
|
|
|
|
|
|
describe('Slack', function () {
|
2016-06-05 14:22:11 +03:00
|
|
|
var eventStub;
|
|
|
|
|
|
|
|
beforeEach(function () {
|
2019-01-21 19:53:44 +03:00
|
|
|
eventStub = sinon.stub(common.events, 'on');
|
2016-06-05 14:22:11 +03:00
|
|
|
});
|
2016-03-29 11:40:44 +03:00
|
|
|
|
|
|
|
afterEach(function () {
|
2019-01-21 19:53:44 +03:00
|
|
|
sinon.restore();
|
2017-02-02 21:51:35 +03:00
|
|
|
configUtils.restore();
|
2016-03-29 11:40:44 +03:00
|
|
|
});
|
|
|
|
|
2016-06-05 14:22:11 +03:00
|
|
|
it('listen() should initialise event correctly', function () {
|
|
|
|
slack.listen();
|
|
|
|
eventStub.calledTwice.should.be.true();
|
|
|
|
eventStub.firstCall.calledWith('post.published', slack.__get__('listener')).should.be.true();
|
|
|
|
eventStub.secondCall.calledWith('slack.test', slack.__get__('testPing')).should.be.true();
|
|
|
|
});
|
|
|
|
|
|
|
|
it('listener() calls ping() with toJSONified model', function () {
|
|
|
|
var testPost = _.clone(testUtils.DataGenerator.Content.posts[2]),
|
2017-03-21 11:24:11 +03:00
|
|
|
testModel = {
|
|
|
|
toJSON: function () {
|
|
|
|
return testPost;
|
|
|
|
}
|
|
|
|
},
|
2019-01-21 19:53:44 +03:00
|
|
|
pingStub = sinon.stub(),
|
2016-06-05 14:22:11 +03:00
|
|
|
resetSlack = slack.__set__('ping', pingStub),
|
|
|
|
listener = slack.__get__('listener');
|
|
|
|
|
|
|
|
listener(testModel);
|
|
|
|
|
|
|
|
pingStub.calledOnce.should.be.true();
|
|
|
|
pingStub.calledWith(testPost).should.be.true();
|
2016-03-29 11:40:44 +03:00
|
|
|
|
2016-06-05 14:22:11 +03:00
|
|
|
// Reset slack ping method
|
|
|
|
resetSlack();
|
2016-03-29 11:40:44 +03:00
|
|
|
});
|
|
|
|
|
2017-10-23 20:30:33 +03:00
|
|
|
it('listener() does not call ping() when importing', function () {
|
|
|
|
var testPost = _.clone(testUtils.DataGenerator.Content.posts[2]),
|
|
|
|
testModel = {
|
|
|
|
toJSON: function () {
|
|
|
|
return testPost;
|
|
|
|
}
|
|
|
|
},
|
2019-01-21 19:53:44 +03:00
|
|
|
pingStub = sinon.stub(),
|
2017-10-23 20:30:33 +03:00
|
|
|
resetSlack = slack.__set__('ping', pingStub),
|
|
|
|
listener = slack.__get__('listener');
|
|
|
|
|
|
|
|
listener(testModel, {importing: true});
|
|
|
|
|
|
|
|
pingStub.calledOnce.should.be.false();
|
|
|
|
|
|
|
|
// Reset slack ping method
|
|
|
|
resetSlack();
|
|
|
|
});
|
|
|
|
|
2016-06-05 14:22:11 +03:00
|
|
|
it('testPing() calls ping() with default message', function () {
|
2019-01-21 19:53:44 +03:00
|
|
|
var pingStub = sinon.stub(),
|
2016-06-05 14:22:11 +03:00
|
|
|
resetSlack = slack.__set__('ping', pingStub),
|
|
|
|
testPing = slack.__get__('testPing');
|
2016-03-29 11:40:44 +03:00
|
|
|
|
2016-06-05 14:22:11 +03:00
|
|
|
testPing();
|
2016-03-29 11:40:44 +03:00
|
|
|
|
2016-06-05 14:22:11 +03:00
|
|
|
pingStub.calledOnce.should.be.true();
|
|
|
|
pingStub.calledWith(sinon.match.has('message')).should.be.true();
|
2016-03-29 11:40:44 +03:00
|
|
|
|
2016-06-05 14:22:11 +03:00
|
|
|
// Reset slack ping method
|
|
|
|
resetSlack();
|
2016-03-29 11:40:44 +03:00
|
|
|
});
|
|
|
|
|
2016-06-05 14:22:11 +03:00
|
|
|
describe('ping()', function () {
|
2017-10-25 17:27:56 +03:00
|
|
|
var isPostStub,
|
|
|
|
settingsCacheStub,
|
|
|
|
|
2016-06-05 14:22:11 +03:00
|
|
|
slackReset,
|
2017-10-25 17:27:56 +03:00
|
|
|
makeRequestStub,
|
2017-03-21 11:24:11 +03:00
|
|
|
ping = slack.__get__('ping');
|
2016-03-29 11:40:44 +03:00
|
|
|
|
|
|
|
beforeEach(function () {
|
2019-01-21 19:53:44 +03:00
|
|
|
isPostStub = sinon.stub(schema, 'isPost');
|
|
|
|
sinon.stub(urlService, 'getUrlByResourceId');
|
2016-06-05 14:22:11 +03:00
|
|
|
|
2019-01-21 19:53:44 +03:00
|
|
|
settingsCacheStub = sinon.stub(settingsCache, 'get');
|
|
|
|
sinon.spy(common.logging, 'error');
|
2017-02-02 21:51:35 +03:00
|
|
|
|
2019-01-21 19:53:44 +03:00
|
|
|
makeRequestStub = sinon.stub();
|
2017-12-14 18:08:48 +03:00
|
|
|
slackReset = slack.__set__('request', makeRequestStub);
|
|
|
|
makeRequestStub.resolves();
|
2017-02-02 21:51:35 +03:00
|
|
|
|
2019-06-18 16:13:55 +03:00
|
|
|
sinon.stub(imageLib.blogIcon, 'getIconUrl').returns('http://myblog.com/favicon.ico');
|
|
|
|
|
2017-02-02 21:51:35 +03:00
|
|
|
configUtils.set('url', 'http://myblog.com');
|
2016-03-29 11:40:44 +03:00
|
|
|
});
|
|
|
|
|
2016-06-05 14:22:11 +03:00
|
|
|
afterEach(function () {
|
|
|
|
slackReset();
|
|
|
|
});
|
|
|
|
|
2017-10-25 17:27:56 +03:00
|
|
|
it('makes a request for a post if url is provided', function () {
|
2017-12-14 18:08:48 +03:00
|
|
|
var requestUrl, requestData;
|
2016-06-05 14:22:11 +03:00
|
|
|
|
2018-11-12 15:04:50 +03:00
|
|
|
const post = testUtils.DataGenerator.forKnex.createPost({slug: 'webhook-test'});
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
urlService.getUrlByResourceId.withArgs(post.id, {absolute: true}).returns('http://myblog.com/' + post.slug + '/');
|
|
|
|
|
2017-10-25 17:27:56 +03:00
|
|
|
isPostStub.returns(true);
|
|
|
|
settingsCacheStub.withArgs('slack').returns(slackObjWithUrl);
|
2016-06-05 14:22:11 +03:00
|
|
|
|
|
|
|
// execute code
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
ping(post);
|
2017-10-25 17:27:56 +03:00
|
|
|
|
|
|
|
// assertions
|
|
|
|
makeRequestStub.calledOnce.should.be.true();
|
2018-11-12 15:04:50 +03:00
|
|
|
isPostStub.calledTwice.should.be.true();
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
urlService.getUrlByResourceId.calledOnce.should.be.true();
|
2017-10-25 17:27:56 +03:00
|
|
|
settingsCacheStub.calledWith('slack').should.be.true();
|
|
|
|
|
2017-12-14 18:08:48 +03:00
|
|
|
requestUrl = makeRequestStub.firstCall.args[0];
|
|
|
|
requestData = JSON.parse(makeRequestStub.firstCall.args[1].body);
|
2017-10-25 17:27:56 +03:00
|
|
|
|
2017-12-14 18:08:48 +03:00
|
|
|
requestUrl.should.equal(slackObjWithUrl[0].url);
|
2018-11-12 15:04:50 +03:00
|
|
|
requestData.attachments[0].title.should.equal(post.title);
|
|
|
|
requestData.attachments[0].title_link.should.equal('http://myblog.com/webhook-test/');
|
|
|
|
requestData.attachments[0].fields[0].value.should.equal('## markdown.');
|
|
|
|
requestData.attachments[0].should.not.have.property('author_name');
|
2017-12-14 18:08:48 +03:00
|
|
|
requestData.icon_url.should.equal('http://myblog.com/favicon.ico');
|
2019-06-18 16:13:55 +03:00
|
|
|
|
2017-12-14 18:08:48 +03:00
|
|
|
requestData.username.should.equal('Ghost');
|
|
|
|
requestData.unfurl_links.should.equal(true);
|
2016-06-05 14:22:11 +03:00
|
|
|
});
|
|
|
|
|
2017-10-25 17:27:56 +03:00
|
|
|
it('makes a request for a message if url is provided', function () {
|
2017-12-14 18:08:48 +03:00
|
|
|
var requestUrl, requestData;
|
2017-10-25 17:27:56 +03:00
|
|
|
|
2016-06-05 14:22:11 +03:00
|
|
|
isPostStub.returns(false);
|
2017-10-25 17:27:56 +03:00
|
|
|
settingsCacheStub.withArgs('slack').returns(slackObjWithUrl);
|
2016-03-29 11:40:44 +03:00
|
|
|
|
2017-10-25 17:27:56 +03:00
|
|
|
// execute code
|
|
|
|
ping({message: 'Hi!'});
|
|
|
|
|
2016-03-29 11:40:44 +03:00
|
|
|
// assertions
|
2017-10-25 17:27:56 +03:00
|
|
|
makeRequestStub.calledOnce.should.be.true();
|
2018-11-12 15:04:50 +03:00
|
|
|
isPostStub.calledTwice.should.be.true();
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
urlService.getUrlByResourceId.called.should.be.false();
|
2017-10-25 17:27:56 +03:00
|
|
|
settingsCacheStub.calledWith('slack').should.be.true();
|
|
|
|
|
2017-12-14 18:08:48 +03:00
|
|
|
requestUrl = makeRequestStub.firstCall.args[0];
|
|
|
|
requestData = JSON.parse(makeRequestStub.firstCall.args[1].body);
|
|
|
|
|
|
|
|
requestUrl.should.equal(slackObjWithUrl[0].url);
|
2018-11-12 15:04:50 +03:00
|
|
|
requestData.text.should.equal('Hi!');
|
2019-06-18 16:13:55 +03:00
|
|
|
requestData.icon_url.should.equal('http://myblog.com/favicon.ico');
|
2017-12-14 18:08:48 +03:00
|
|
|
requestData.username.should.equal('Ghost');
|
|
|
|
requestData.unfurl_links.should.equal(true);
|
|
|
|
});
|
|
|
|
|
|
|
|
it('makes a request and errors', function (done) {
|
|
|
|
makeRequestStub.rejects();
|
|
|
|
settingsCacheStub.withArgs('slack').returns(slackObjWithUrl);
|
|
|
|
|
|
|
|
// execute code
|
|
|
|
ping({});
|
|
|
|
|
|
|
|
(function retry() {
|
|
|
|
if (common.logging.error.calledOnce) {
|
|
|
|
makeRequestStub.calledOnce.should.be.true();
|
|
|
|
return done();
|
|
|
|
}
|
2017-10-25 17:27:56 +03:00
|
|
|
|
2017-12-14 18:08:48 +03:00
|
|
|
setTimeout(retry, 50);
|
|
|
|
}());
|
2016-06-05 14:22:11 +03:00
|
|
|
});
|
|
|
|
|
2017-10-25 17:27:56 +03:00
|
|
|
it('does not make a request if post is a page', function () {
|
2019-08-16 19:46:00 +03:00
|
|
|
const post = testUtils.DataGenerator.forKnex.createPost({page: true});
|
2016-06-05 14:22:11 +03:00
|
|
|
isPostStub.returns(true);
|
2017-10-25 17:27:56 +03:00
|
|
|
settingsCacheStub.withArgs('slack').returns(slackObjWithUrl);
|
2016-03-29 11:40:44 +03:00
|
|
|
|
|
|
|
// execute code
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
ping(post);
|
2017-10-25 17:27:56 +03:00
|
|
|
|
|
|
|
// assertions
|
|
|
|
makeRequestStub.calledOnce.should.be.false();
|
|
|
|
isPostStub.calledOnce.should.be.true();
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
urlService.getUrlByResourceId.calledOnce.should.be.true();
|
2017-10-25 17:27:56 +03:00
|
|
|
settingsCacheStub.calledWith('slack').should.be.true();
|
2016-03-29 11:40:44 +03:00
|
|
|
});
|
|
|
|
|
2017-10-25 17:27:56 +03:00
|
|
|
it('does not send webhook for \'welcome\' post', function () {
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
const post = testUtils.DataGenerator.forKnex.createPost({slug: 'welcome'});
|
2016-06-05 14:22:11 +03:00
|
|
|
isPostStub.returns(true);
|
2017-10-25 17:27:56 +03:00
|
|
|
settingsCacheStub.withArgs('slack').returns(slackObjWithUrl);
|
2016-03-29 11:40:44 +03:00
|
|
|
|
|
|
|
// execute code
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
ping(post);
|
2017-10-25 17:27:56 +03:00
|
|
|
|
|
|
|
// assertions
|
|
|
|
makeRequestStub.calledOnce.should.be.false();
|
|
|
|
isPostStub.calledOnce.should.be.true();
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
urlService.getUrlByResourceId.calledOnce.should.be.true();
|
2017-10-25 17:27:56 +03:00
|
|
|
settingsCacheStub.calledWith('slack').should.be.true();
|
2016-03-29 11:40:44 +03:00
|
|
|
});
|
2016-06-05 14:22:11 +03:00
|
|
|
|
2017-10-25 17:27:56 +03:00
|
|
|
it('handles broken slack settings', function () {
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
const post = testUtils.DataGenerator.forKnex.createPost({slug: 'any'});
|
2017-10-25 17:27:56 +03:00
|
|
|
settingsCacheStub.withArgs('slack').returns();
|
|
|
|
|
|
|
|
// execute code
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
ping(post);
|
2017-10-25 17:27:56 +03:00
|
|
|
|
|
|
|
// assertions
|
|
|
|
makeRequestStub.calledOnce.should.be.false();
|
|
|
|
isPostStub.calledOnce.should.be.true();
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
urlService.getUrlByResourceId.called.should.be.false();
|
2017-10-25 17:27:56 +03:00
|
|
|
settingsCacheStub.calledWith('slack').should.be.true();
|
2016-06-05 14:22:11 +03:00
|
|
|
});
|
2016-03-29 11:40:44 +03:00
|
|
|
});
|
|
|
|
});
|