2020-04-29 18:44:27 +03:00
|
|
|
const should = require('should');
|
|
|
|
const sinon = require('sinon');
|
|
|
|
const _ = require('lodash');
|
|
|
|
const cheerio = require('cheerio');
|
|
|
|
const testUtils = require('../../utils');
|
|
|
|
const mockUtils = require('../../utils/mocks');
|
|
|
|
const configUtils = require('../../utils/configUtils');
|
|
|
|
const urlUtils = require('../../utils/urlUtils');
|
|
|
|
const appService = require('../../../core/frontend/services/apps');
|
|
|
|
const frontendSettingsService = require('../../../core/frontend/services/settings');
|
|
|
|
const themeService = require('../../../core/frontend/services/themes');
|
|
|
|
const siteApp = require('../../../core/server/web/parent/app');
|
2018-02-14 19:21:31 +03:00
|
|
|
|
|
|
|
describe('Integration - Web - Site', function () {
|
2018-06-12 21:26:16 +03:00
|
|
|
let app;
|
2018-02-14 19:21:31 +03:00
|
|
|
|
2019-01-14 21:04:22 +03:00
|
|
|
before(testUtils.integrationTesting.urlService.resetGenerators);
|
2020-02-24 23:51:09 +03:00
|
|
|
before(testUtils.teardownDb);
|
2018-06-12 21:26:16 +03:00
|
|
|
before(testUtils.setup('users:roles', 'posts'));
|
2018-02-14 19:21:31 +03:00
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
describe('v2', function () {
|
|
|
|
let postSpy;
|
|
|
|
|
|
|
|
describe('default routes.yaml', function () {
|
|
|
|
before(function () {
|
|
|
|
testUtils.integrationTesting.urlService.resetGenerators();
|
2020-03-19 18:23:10 +03:00
|
|
|
testUtils.integrationTesting.defaultMocks(sinon, {amp: true});
|
2019-01-04 23:59:39 +03:00
|
|
|
testUtils.integrationTesting.overrideGhostConfig(configUtils);
|
|
|
|
|
|
|
|
return testUtils.integrationTesting.initGhost()
|
|
|
|
.then(function () {
|
2019-01-21 19:53:44 +03:00
|
|
|
sinon.stub(themeService.getActive(), 'engine').withArgs('ghost-api').returns('v2');
|
|
|
|
sinon.stub(themeService.getActive(), 'config').withArgs('posts_per_page').returns(2);
|
2019-01-04 23:59:39 +03:00
|
|
|
|
|
|
|
app = siteApp({start: true});
|
|
|
|
return testUtils.integrationTesting.urlService.waitTillFinished();
|
2020-03-20 11:58:26 +03:00
|
|
|
})
|
|
|
|
.then(() => {
|
2020-03-23 22:43:01 +03:00
|
|
|
return appService.init();
|
2019-01-04 23:59:39 +03:00
|
|
|
});
|
|
|
|
});
|
|
|
|
|
2019-06-18 16:13:55 +03:00
|
|
|
before(function () {
|
|
|
|
configUtils.set('url', 'http://example.com');
|
|
|
|
urlUtils.stubUrlUtilsFromConfig();
|
|
|
|
});
|
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
beforeEach(function () {
|
2020-03-30 18:26:47 +03:00
|
|
|
const postsAPI = require('../../../core/server/api/v2/posts-public');
|
2019-01-21 19:53:44 +03:00
|
|
|
postSpy = sinon.spy(postsAPI.browse, 'query');
|
2019-01-04 23:59:39 +03:00
|
|
|
});
|
|
|
|
|
|
|
|
afterEach(function () {
|
|
|
|
postSpy.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
after(function () {
|
|
|
|
configUtils.restore();
|
2019-06-18 16:13:55 +03:00
|
|
|
urlUtils.restore();
|
2019-01-21 19:53:44 +03:00
|
|
|
sinon.restore();
|
2019-01-04 23:59:39 +03:00
|
|
|
});
|
|
|
|
|
|
|
|
describe('behaviour: default cases', function () {
|
2020-03-25 17:51:28 +03:00
|
|
|
it('serve post', function () {
|
2019-01-04 23:59:39 +03:00
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/html-ipsum/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('post');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
2019-02-27 19:50:20 +03:00
|
|
|
it('serve amp', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/html-ipsum/amp/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-02-27 19:50:20 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.match(/amp\.hbs/);
|
|
|
|
response.body.should.match(/<h1>HTML Ipsum Presents<\/h1>/);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
it('post not found', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/not-found/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(404);
|
|
|
|
response.template.should.eql('error-404');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve static page', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/static-page-test/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('page');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve author', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/author/joe-bloggs/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
const $ = cheerio.load(response.body);
|
|
|
|
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('author');
|
|
|
|
|
|
|
|
$('.author-bio').length.should.equal(1);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve tag', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/tag/bacon/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('tag');
|
|
|
|
|
2019-09-16 13:51:54 +03:00
|
|
|
postSpy.args[0][0].options.filter.should.eql('(tags:\'bacon\'+tags.visibility:public)+type:post');
|
2019-01-04 23:59:39 +03:00
|
|
|
postSpy.args[0][0].options.page.should.eql(1);
|
|
|
|
postSpy.args[0][0].options.limit.should.eql(2);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve tag rss', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/tag/bacon/rss/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve collection', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
const $ = cheerio.load(response.body);
|
|
|
|
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('index');
|
|
|
|
|
|
|
|
$('.post-card').length.should.equal(2);
|
|
|
|
|
|
|
|
should.exist(response.res.locals.context);
|
|
|
|
should.exist(response.res.locals.version);
|
|
|
|
should.exist(response.res.locals.safeVersion);
|
|
|
|
should.exist(response.res.locals.safeVersion);
|
|
|
|
should.exist(response.res.locals.relativeUrl);
|
|
|
|
should.exist(response.res.locals.secure);
|
|
|
|
should.exist(response.res.routerOptions);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve collection: page 2', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/page/2/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
const $ = cheerio.load(response.body);
|
|
|
|
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('index');
|
|
|
|
|
|
|
|
$('.post-card').length.should.equal(2);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve theme asset', function () {
|
|
|
|
//configUtils.set('url', 'https://example.com');
|
|
|
|
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/assets/css/screen.css',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('behaviour: prettify', function () {
|
|
|
|
it('url without slash', function () {
|
|
|
|
const req = {
|
|
|
|
secure: false,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/prettify-me',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(301);
|
|
|
|
response.headers.location.should.eql('/prettify-me/');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('behaviour: url redirects', function () {
|
|
|
|
describe('pagination', function () {
|
|
|
|
it('redirect /page/1/ to /', function () {
|
|
|
|
const req = {
|
|
|
|
secure: false,
|
|
|
|
host: 'example.com',
|
|
|
|
method: 'GET',
|
|
|
|
url: '/page/1/'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(301);
|
|
|
|
response.headers.location.should.eql('/');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('rss', function () {
|
|
|
|
it('redirect /feed/ to /rss/', function () {
|
|
|
|
const req = {
|
|
|
|
secure: false,
|
|
|
|
host: 'example.com',
|
|
|
|
method: 'GET',
|
|
|
|
url: '/feed/'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(301);
|
|
|
|
response.headers.location.should.eql('/rss/');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
2019-06-18 16:13:55 +03:00
|
|
|
});
|
|
|
|
});
|
2019-01-04 23:59:39 +03:00
|
|
|
|
2019-06-18 16:13:55 +03:00
|
|
|
describe('https', function () {
|
|
|
|
before(function () {
|
|
|
|
configUtils.set('url', 'https://example.com');
|
|
|
|
urlUtils.stubUrlUtilsFromConfig();
|
|
|
|
});
|
2019-01-04 23:59:39 +03:00
|
|
|
|
2019-06-18 16:13:55 +03:00
|
|
|
after(function () {
|
|
|
|
urlUtils.restore();
|
|
|
|
configUtils.restore();
|
|
|
|
});
|
2019-01-04 23:59:39 +03:00
|
|
|
|
2019-06-18 16:13:55 +03:00
|
|
|
describe('protocol', function () {
|
|
|
|
it('blog is https, request is http', function () {
|
|
|
|
const req = {
|
|
|
|
secure: false,
|
|
|
|
host: 'example.com',
|
|
|
|
method: 'GET',
|
|
|
|
url: '/html-ipsum'
|
|
|
|
};
|
2019-01-04 23:59:39 +03:00
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-06-18 16:13:55 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(301);
|
|
|
|
response.headers.location.should.eql('https://example.com/html-ipsum/');
|
|
|
|
});
|
2019-01-04 23:59:39 +03:00
|
|
|
});
|
|
|
|
|
2019-06-18 16:13:55 +03:00
|
|
|
it('blog is https, request is http, trailing slash exists already', function () {
|
|
|
|
const req = {
|
|
|
|
secure: false,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/html-ipsum/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
2019-01-04 23:59:39 +03:00
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-06-18 16:13:55 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(301);
|
|
|
|
response.headers.location.should.eql('https://example.com/html-ipsum/');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
2019-01-04 23:59:39 +03:00
|
|
|
|
2019-06-18 16:13:55 +03:00
|
|
|
describe('assets', function () {
|
|
|
|
it('blog is https, request is http', function () {
|
|
|
|
const req = {
|
|
|
|
secure: false,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/favicon.png',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
2019-01-04 23:59:39 +03:00
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-06-18 16:13:55 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(301);
|
|
|
|
response.headers.location.should.eql('https://example.com/favicon.png');
|
|
|
|
});
|
|
|
|
});
|
2019-01-04 23:59:39 +03:00
|
|
|
|
2019-06-18 16:13:55 +03:00
|
|
|
it('blog is https, request is http', function () {
|
|
|
|
const req = {
|
|
|
|
secure: false,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/assets/css/main.css',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
2019-01-04 23:59:39 +03:00
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-06-18 16:13:55 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(301);
|
|
|
|
response.headers.location.should.eql('https://example.com/assets/css/main.css');
|
|
|
|
});
|
2019-01-04 23:59:39 +03:00
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('extended routes.yaml: collections', function () {
|
|
|
|
describe('2 collections', function () {
|
|
|
|
before(function () {
|
2019-06-26 10:41:37 +03:00
|
|
|
sinon.stub(frontendSettingsService, 'get').returns({
|
2019-01-04 23:59:39 +03:00
|
|
|
routes: {
|
💡Changed static router - throw 400 for missing tpl
fixes #10990
- Changed the static router to throw a 400 error for a missing template file, rather than falling back to using the default.hbs file
- Falling back is weird and hard to understand, but throwing an error makes it clear that the user has to provide the matching template
- The new error reads 'Missing template [filename].hbs for route "[route]".'
Assume you have a route.yaml file something like:
```
routes:
/: home
```
- In Ghost v2, if you don't have a home.hbs template, Ghost falls back to using the default.hbs file if it's available
- Most themes have a default.hbs, however this file is a layout file, depended on by other templates, not a template file itself
- In production mode, using the default.hbs as a template causes weird, intermittent layout issues depending on which order pages are loaded
- This is due to this issue: https://github.com/barc/express-hbs/issues/161
- In Ghost v3, we will throw a 400 error for missing template files instead of having a fallback
- In the example above, navigating to '/' would throw the error 'Missing template home.hbs for route "/".'
2019-08-05 21:34:12 +03:00
|
|
|
'/': {templates: ['home']}
|
2019-01-04 23:59:39 +03:00
|
|
|
},
|
|
|
|
|
|
|
|
collections: {
|
|
|
|
'/podcast/': {
|
|
|
|
permalink: '/podcast/:slug/',
|
|
|
|
filter: 'featured:true'
|
|
|
|
},
|
|
|
|
|
|
|
|
'/something/': {
|
|
|
|
permalink: '/something/:slug/',
|
|
|
|
filter: 'featured:false'
|
|
|
|
}
|
|
|
|
},
|
|
|
|
|
|
|
|
taxonomies: {
|
|
|
|
tag: '/categories/:slug/',
|
|
|
|
author: '/authors/:slug/'
|
|
|
|
}
|
|
|
|
});
|
|
|
|
|
|
|
|
testUtils.integrationTesting.urlService.resetGenerators();
|
💡Changed static router - throw 400 for missing tpl
fixes #10990
- Changed the static router to throw a 400 error for a missing template file, rather than falling back to using the default.hbs file
- Falling back is weird and hard to understand, but throwing an error makes it clear that the user has to provide the matching template
- The new error reads 'Missing template [filename].hbs for route "[route]".'
Assume you have a route.yaml file something like:
```
routes:
/: home
```
- In Ghost v2, if you don't have a home.hbs template, Ghost falls back to using the default.hbs file if it's available
- Most themes have a default.hbs, however this file is a layout file, depended on by other templates, not a template file itself
- In production mode, using the default.hbs as a template causes weird, intermittent layout issues depending on which order pages are loaded
- This is due to this issue: https://github.com/barc/express-hbs/issues/161
- In Ghost v3, we will throw a 400 error for missing template files instead of having a fallback
- In the example above, navigating to '/' would throw the error 'Missing template home.hbs for route "/".'
2019-08-05 21:34:12 +03:00
|
|
|
testUtils.integrationTesting.defaultMocks(sinon, {theme: 'test-theme'});
|
2019-01-04 23:59:39 +03:00
|
|
|
|
|
|
|
return testUtils.integrationTesting.initGhost()
|
|
|
|
.then(function () {
|
2019-01-21 19:53:44 +03:00
|
|
|
sinon.stub(themeService.getActive(), 'engine').withArgs('ghost-api').returns('v2');
|
|
|
|
sinon.stub(themeService.getActive(), 'config').withArgs('posts_per_page').returns(2);
|
2019-01-04 23:59:39 +03:00
|
|
|
|
|
|
|
app = siteApp({start: true});
|
|
|
|
return testUtils.integrationTesting.urlService.waitTillFinished();
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
beforeEach(function () {
|
|
|
|
testUtils.integrationTesting.overrideGhostConfig(configUtils);
|
|
|
|
});
|
|
|
|
|
|
|
|
afterEach(function () {
|
|
|
|
configUtils.restore();
|
2019-06-18 16:13:55 +03:00
|
|
|
urlUtils.restore();
|
2019-01-04 23:59:39 +03:00
|
|
|
});
|
|
|
|
|
|
|
|
after(function () {
|
2019-01-21 19:53:44 +03:00
|
|
|
sinon.restore();
|
2019-01-04 23:59:39 +03:00
|
|
|
});
|
|
|
|
|
|
|
|
it('serve static route', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
💡Changed static router - throw 400 for missing tpl
fixes #10990
- Changed the static router to throw a 400 error for a missing template file, rather than falling back to using the default.hbs file
- Falling back is weird and hard to understand, but throwing an error makes it clear that the user has to provide the matching template
- The new error reads 'Missing template [filename].hbs for route "[route]".'
Assume you have a route.yaml file something like:
```
routes:
/: home
```
- In Ghost v2, if you don't have a home.hbs template, Ghost falls back to using the default.hbs file if it's available
- Most themes have a default.hbs, however this file is a layout file, depended on by other templates, not a template file itself
- In production mode, using the default.hbs as a template causes weird, intermittent layout issues depending on which order pages are loaded
- This is due to this issue: https://github.com/barc/express-hbs/issues/161
- In Ghost v3, we will throw a 400 error for missing template files instead of having a fallback
- In the example above, navigating to '/' would throw the error 'Missing template home.hbs for route "/".'
2019-08-05 21:34:12 +03:00
|
|
|
response.template.should.eql('home');
|
2019-01-04 23:59:39 +03:00
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve rss', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/podcast/rss/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve post', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/something/html-ipsum/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('post');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
💡Changed static router - throw 400 for missing tpl
fixes #10990
- Changed the static router to throw a 400 error for a missing template file, rather than falling back to using the default.hbs file
- Falling back is weird and hard to understand, but throwing an error makes it clear that the user has to provide the matching template
- The new error reads 'Missing template [filename].hbs for route "[route]".'
Assume you have a route.yaml file something like:
```
routes:
/: home
```
- In Ghost v2, if you don't have a home.hbs template, Ghost falls back to using the default.hbs file if it's available
- Most themes have a default.hbs, however this file is a layout file, depended on by other templates, not a template file itself
- In production mode, using the default.hbs as a template causes weird, intermittent layout issues depending on which order pages are loaded
- This is due to this issue: https://github.com/barc/express-hbs/issues/161
- In Ghost v3, we will throw a 400 error for missing template files instead of having a fallback
- In the example above, navigating to '/' would throw the error 'Missing template home.hbs for route "/".'
2019-08-05 21:34:12 +03:00
|
|
|
it('serve collection: podcast with default template', function () {
|
2019-01-04 23:59:39 +03:00
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/podcast/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
const $ = cheerio.load(response.body);
|
|
|
|
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('index');
|
|
|
|
|
|
|
|
$('.post-card').length.should.equal(2);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
💡Changed static router - throw 400 for missing tpl
fixes #10990
- Changed the static router to throw a 400 error for a missing template file, rather than falling back to using the default.hbs file
- Falling back is weird and hard to understand, but throwing an error makes it clear that the user has to provide the matching template
- The new error reads 'Missing template [filename].hbs for route "[route]".'
Assume you have a route.yaml file something like:
```
routes:
/: home
```
- In Ghost v2, if you don't have a home.hbs template, Ghost falls back to using the default.hbs file if it's available
- Most themes have a default.hbs, however this file is a layout file, depended on by other templates, not a template file itself
- In production mode, using the default.hbs as a template causes weird, intermittent layout issues depending on which order pages are loaded
- This is due to this issue: https://github.com/barc/express-hbs/issues/161
- In Ghost v3, we will throw a 400 error for missing template files instead of having a fallback
- In the example above, navigating to '/' would throw the error 'Missing template home.hbs for route "/".'
2019-08-05 21:34:12 +03:00
|
|
|
it('serve collection: something with custom template', function () {
|
2019-01-04 23:59:39 +03:00
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/something/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
const $ = cheerio.load(response.body);
|
|
|
|
|
|
|
|
response.statusCode.should.eql(200);
|
💡Changed static router - throw 400 for missing tpl
fixes #10990
- Changed the static router to throw a 400 error for a missing template file, rather than falling back to using the default.hbs file
- Falling back is weird and hard to understand, but throwing an error makes it clear that the user has to provide the matching template
- The new error reads 'Missing template [filename].hbs for route "[route]".'
Assume you have a route.yaml file something like:
```
routes:
/: home
```
- In Ghost v2, if you don't have a home.hbs template, Ghost falls back to using the default.hbs file if it's available
- Most themes have a default.hbs, however this file is a layout file, depended on by other templates, not a template file itself
- In production mode, using the default.hbs as a template causes weird, intermittent layout issues depending on which order pages are loaded
- This is due to this issue: https://github.com/barc/express-hbs/issues/161
- In Ghost v3, we will throw a 400 error for missing template files instead of having a fallback
- In the example above, navigating to '/' would throw the error 'Missing template home.hbs for route "/".'
2019-08-05 21:34:12 +03:00
|
|
|
response.template.should.eql('something');
|
2019-01-04 23:59:39 +03:00
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('no collections', function () {
|
|
|
|
before(function () {
|
2019-06-26 10:41:37 +03:00
|
|
|
sinon.stub(frontendSettingsService, 'get').returns({
|
2019-01-04 23:59:39 +03:00
|
|
|
routes: {
|
💡Changed static router - throw 400 for missing tpl
fixes #10990
- Changed the static router to throw a 400 error for a missing template file, rather than falling back to using the default.hbs file
- Falling back is weird and hard to understand, but throwing an error makes it clear that the user has to provide the matching template
- The new error reads 'Missing template [filename].hbs for route "[route]".'
Assume you have a route.yaml file something like:
```
routes:
/: home
```
- In Ghost v2, if you don't have a home.hbs template, Ghost falls back to using the default.hbs file if it's available
- Most themes have a default.hbs, however this file is a layout file, depended on by other templates, not a template file itself
- In production mode, using the default.hbs as a template causes weird, intermittent layout issues depending on which order pages are loaded
- This is due to this issue: https://github.com/barc/express-hbs/issues/161
- In Ghost v3, we will throw a 400 error for missing template files instead of having a fallback
- In the example above, navigating to '/' would throw the error 'Missing template home.hbs for route "/".'
2019-08-05 21:34:12 +03:00
|
|
|
'/something/': {templates: ['something']}
|
2019-01-04 23:59:39 +03:00
|
|
|
},
|
|
|
|
collections: {},
|
|
|
|
taxonomies: {}
|
|
|
|
});
|
|
|
|
|
|
|
|
testUtils.integrationTesting.urlService.resetGenerators();
|
💡Changed static router - throw 400 for missing tpl
fixes #10990
- Changed the static router to throw a 400 error for a missing template file, rather than falling back to using the default.hbs file
- Falling back is weird and hard to understand, but throwing an error makes it clear that the user has to provide the matching template
- The new error reads 'Missing template [filename].hbs for route "[route]".'
Assume you have a route.yaml file something like:
```
routes:
/: home
```
- In Ghost v2, if you don't have a home.hbs template, Ghost falls back to using the default.hbs file if it's available
- Most themes have a default.hbs, however this file is a layout file, depended on by other templates, not a template file itself
- In production mode, using the default.hbs as a template causes weird, intermittent layout issues depending on which order pages are loaded
- This is due to this issue: https://github.com/barc/express-hbs/issues/161
- In Ghost v3, we will throw a 400 error for missing template files instead of having a fallback
- In the example above, navigating to '/' would throw the error 'Missing template home.hbs for route "/".'
2019-08-05 21:34:12 +03:00
|
|
|
testUtils.integrationTesting.defaultMocks(sinon, {theme: 'test-theme'});
|
2019-01-04 23:59:39 +03:00
|
|
|
|
|
|
|
return testUtils.integrationTesting.initGhost()
|
|
|
|
.then(function () {
|
2019-01-21 19:53:44 +03:00
|
|
|
sinon.stub(themeService.getActive(), 'engine').withArgs('ghost-api').returns('v2');
|
|
|
|
sinon.stub(themeService.getActive(), 'config').withArgs('posts_per_page').returns(2);
|
2019-01-04 23:59:39 +03:00
|
|
|
|
|
|
|
app = siteApp({start: true});
|
|
|
|
return testUtils.integrationTesting.urlService.waitTillFinished();
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
beforeEach(function () {
|
|
|
|
testUtils.integrationTesting.overrideGhostConfig(configUtils);
|
|
|
|
});
|
|
|
|
|
|
|
|
afterEach(function () {
|
|
|
|
configUtils.restore();
|
2019-06-18 16:13:55 +03:00
|
|
|
urlUtils.restore();
|
2019-01-04 23:59:39 +03:00
|
|
|
});
|
|
|
|
|
|
|
|
after(function () {
|
2019-01-21 19:53:44 +03:00
|
|
|
sinon.restore();
|
2019-01-04 23:59:39 +03:00
|
|
|
});
|
|
|
|
|
|
|
|
it('serve route', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
💡Changed static router - throw 400 for missing tpl
fixes #10990
- Changed the static router to throw a 400 error for a missing template file, rather than falling back to using the default.hbs file
- Falling back is weird and hard to understand, but throwing an error makes it clear that the user has to provide the matching template
- The new error reads 'Missing template [filename].hbs for route "[route]".'
Assume you have a route.yaml file something like:
```
routes:
/: home
```
- In Ghost v2, if you don't have a home.hbs template, Ghost falls back to using the default.hbs file if it's available
- Most themes have a default.hbs, however this file is a layout file, depended on by other templates, not a template file itself
- In production mode, using the default.hbs as a template causes weird, intermittent layout issues depending on which order pages are loaded
- This is due to this issue: https://github.com/barc/express-hbs/issues/161
- In Ghost v3, we will throw a 400 error for missing template files instead of having a fallback
- In the example above, navigating to '/' would throw the error 'Missing template home.hbs for route "/".'
2019-08-05 21:34:12 +03:00
|
|
|
url: '/something/',
|
2019-01-04 23:59:39 +03:00
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
💡Changed static router - throw 400 for missing tpl
fixes #10990
- Changed the static router to throw a 400 error for a missing template file, rather than falling back to using the default.hbs file
- Falling back is weird and hard to understand, but throwing an error makes it clear that the user has to provide the matching template
- The new error reads 'Missing template [filename].hbs for route "[route]".'
Assume you have a route.yaml file something like:
```
routes:
/: home
```
- In Ghost v2, if you don't have a home.hbs template, Ghost falls back to using the default.hbs file if it's available
- Most themes have a default.hbs, however this file is a layout file, depended on by other templates, not a template file itself
- In production mode, using the default.hbs as a template causes weird, intermittent layout issues depending on which order pages are loaded
- This is due to this issue: https://github.com/barc/express-hbs/issues/161
- In Ghost v3, we will throw a 400 error for missing template files instead of having a fallback
- In the example above, navigating to '/' would throw the error 'Missing template home.hbs for route "/".'
2019-08-05 21:34:12 +03:00
|
|
|
response.template.should.eql('something');
|
2019-01-04 23:59:39 +03:00
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('static permalink route', function () {
|
|
|
|
before(function () {
|
2019-06-26 10:41:37 +03:00
|
|
|
sinon.stub(frontendSettingsService, 'get').returns({
|
2019-01-04 23:59:39 +03:00
|
|
|
routes: {},
|
|
|
|
|
|
|
|
collections: {
|
|
|
|
'/podcast/': {
|
|
|
|
permalink: '/featured/',
|
|
|
|
filter: 'featured:true'
|
|
|
|
},
|
|
|
|
|
|
|
|
'/': {
|
|
|
|
permalink: '/:slug/'
|
|
|
|
}
|
|
|
|
},
|
|
|
|
|
|
|
|
taxonomies: {}
|
|
|
|
});
|
|
|
|
|
|
|
|
testUtils.integrationTesting.urlService.resetGenerators();
|
2019-01-21 19:53:44 +03:00
|
|
|
testUtils.integrationTesting.defaultMocks(sinon);
|
2019-01-04 23:59:39 +03:00
|
|
|
|
|
|
|
return testUtils.integrationTesting.initGhost()
|
|
|
|
.then(function () {
|
2019-01-21 19:53:44 +03:00
|
|
|
sinon.stub(themeService.getActive(), 'engine').withArgs('ghost-api').returns('v2');
|
|
|
|
sinon.stub(themeService.getActive(), 'config').withArgs('posts_per_page').returns(2);
|
2019-01-04 23:59:39 +03:00
|
|
|
|
|
|
|
app = siteApp({start: true});
|
|
|
|
return testUtils.integrationTesting.urlService.waitTillFinished();
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
beforeEach(function () {
|
|
|
|
testUtils.integrationTesting.overrideGhostConfig(configUtils);
|
|
|
|
});
|
|
|
|
|
|
|
|
afterEach(function () {
|
|
|
|
configUtils.restore();
|
2019-06-18 16:13:55 +03:00
|
|
|
urlUtils.restore();
|
2019-01-04 23:59:39 +03:00
|
|
|
});
|
|
|
|
|
|
|
|
after(function () {
|
2019-01-21 19:53:44 +03:00
|
|
|
sinon.restore();
|
2019-01-04 23:59:39 +03:00
|
|
|
});
|
|
|
|
|
|
|
|
it('serve post', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/featured/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
// We can't find a post with the slug "featured"
|
|
|
|
response.statusCode.should.eql(404);
|
|
|
|
response.template.should.eql('error-404');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve post', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/html-ipsum/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('post');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve author', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/author/joe-bloggs/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(404);
|
|
|
|
response.template.should.eql('error-404');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve tag', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/tag/bacon/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(404);
|
|
|
|
response.template.should.eql('error-404');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('primary author permalink', function () {
|
|
|
|
before(function () {
|
2019-06-26 10:41:37 +03:00
|
|
|
sinon.stub(frontendSettingsService, 'get').returns({
|
2019-01-04 23:59:39 +03:00
|
|
|
routes: {},
|
|
|
|
|
|
|
|
collections: {
|
|
|
|
'/something/': {
|
|
|
|
permalink: '/:primary_author/:slug/'
|
|
|
|
}
|
|
|
|
},
|
|
|
|
|
|
|
|
taxonomies: {}
|
|
|
|
});
|
|
|
|
|
|
|
|
testUtils.integrationTesting.urlService.resetGenerators();
|
2019-01-21 19:53:44 +03:00
|
|
|
testUtils.integrationTesting.defaultMocks(sinon);
|
2019-01-04 23:59:39 +03:00
|
|
|
|
|
|
|
return testUtils.integrationTesting.initGhost()
|
|
|
|
.then(function () {
|
2019-01-21 19:53:44 +03:00
|
|
|
sinon.stub(themeService.getActive(), 'engine').withArgs('ghost-api').returns('v2');
|
|
|
|
sinon.stub(themeService.getActive(), 'config').withArgs('posts_per_page').returns(2);
|
2019-01-04 23:59:39 +03:00
|
|
|
|
|
|
|
app = siteApp({start: true});
|
|
|
|
return testUtils.integrationTesting.urlService.waitTillFinished();
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
beforeEach(function () {
|
|
|
|
testUtils.integrationTesting.overrideGhostConfig(configUtils);
|
|
|
|
});
|
|
|
|
|
|
|
|
afterEach(function () {
|
|
|
|
configUtils.restore();
|
2019-06-18 16:13:55 +03:00
|
|
|
urlUtils.restore();
|
2019-01-04 23:59:39 +03:00
|
|
|
});
|
|
|
|
|
|
|
|
after(function () {
|
2019-01-21 19:53:44 +03:00
|
|
|
sinon.restore();
|
2019-01-04 23:59:39 +03:00
|
|
|
});
|
|
|
|
|
|
|
|
it('serve post', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/joe-bloggs/html-ipsum/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('post');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('post without author', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/html-ipsum/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(404);
|
|
|
|
response.template.should.eql('error-404');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('page', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/static-page-test/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('page');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('primary tag permalink', function () {
|
|
|
|
before(function () {
|
2019-06-26 10:41:37 +03:00
|
|
|
sinon.stub(frontendSettingsService, 'get').returns({
|
2019-01-04 23:59:39 +03:00
|
|
|
routes: {},
|
|
|
|
|
|
|
|
collections: {
|
|
|
|
'/something/': {
|
|
|
|
permalink: '/something/:primary_tag/:slug/'
|
|
|
|
}
|
|
|
|
},
|
|
|
|
|
|
|
|
taxonomies: {}
|
|
|
|
});
|
|
|
|
|
|
|
|
testUtils.integrationTesting.urlService.resetGenerators();
|
2019-01-21 19:53:44 +03:00
|
|
|
testUtils.integrationTesting.defaultMocks(sinon);
|
2019-01-04 23:59:39 +03:00
|
|
|
|
|
|
|
return testUtils.integrationTesting.initGhost()
|
|
|
|
.then(function () {
|
2019-01-21 19:53:44 +03:00
|
|
|
sinon.stub(themeService.getActive(), 'engine').withArgs('ghost-api').returns('v2');
|
|
|
|
sinon.stub(themeService.getActive(), 'config').withArgs('posts_per_page').returns(2);
|
2019-01-04 23:59:39 +03:00
|
|
|
|
|
|
|
app = siteApp({start: true});
|
|
|
|
return testUtils.integrationTesting.urlService.waitTillFinished();
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
beforeEach(function () {
|
|
|
|
testUtils.integrationTesting.overrideGhostConfig(configUtils);
|
|
|
|
});
|
|
|
|
|
|
|
|
afterEach(function () {
|
|
|
|
configUtils.restore();
|
2019-06-18 16:13:55 +03:00
|
|
|
urlUtils.restore();
|
2019-01-04 23:59:39 +03:00
|
|
|
});
|
|
|
|
|
|
|
|
after(function () {
|
2019-01-21 19:53:44 +03:00
|
|
|
sinon.restore();
|
2019-01-04 23:59:39 +03:00
|
|
|
});
|
2018-06-24 01:32:08 +03:00
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
it('serve post', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/something/kitchen-sink/html-ipsum/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
2018-06-24 01:32:08 +03:00
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('post');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('post without tag', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/something/html-ipsum/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(404);
|
|
|
|
response.template.should.eql('error-404');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('post without tag', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/html-ipsum/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(404);
|
|
|
|
response.template.should.eql('error-404');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('page', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/static-page-test/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('page');
|
|
|
|
});
|
|
|
|
});
|
2018-06-24 01:32:08 +03:00
|
|
|
});
|
|
|
|
|
2019-03-13 13:13:52 +03:00
|
|
|
describe('collection/routes with data key', function () {
|
2019-01-04 23:59:39 +03:00
|
|
|
before(function () {
|
2019-06-26 10:41:37 +03:00
|
|
|
sinon.stub(frontendSettingsService, 'get').returns({
|
2019-03-13 13:13:52 +03:00
|
|
|
routes: {
|
|
|
|
'/my-page/': {
|
|
|
|
data: {
|
|
|
|
query: {
|
|
|
|
page: {
|
|
|
|
controller: 'pagesPublic',
|
|
|
|
resource: 'pages',
|
|
|
|
type: 'read',
|
|
|
|
options: {
|
|
|
|
slug: 'static-page-test'
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
|
|
|
router: {
|
|
|
|
pages: [{redirect: true, slug: 'static-page-test'}]
|
|
|
|
}
|
💡Changed static router - throw 400 for missing tpl
fixes #10990
- Changed the static router to throw a 400 error for a missing template file, rather than falling back to using the default.hbs file
- Falling back is weird and hard to understand, but throwing an error makes it clear that the user has to provide the matching template
- The new error reads 'Missing template [filename].hbs for route "[route]".'
Assume you have a route.yaml file something like:
```
routes:
/: home
```
- In Ghost v2, if you don't have a home.hbs template, Ghost falls back to using the default.hbs file if it's available
- Most themes have a default.hbs, however this file is a layout file, depended on by other templates, not a template file itself
- In production mode, using the default.hbs as a template causes weird, intermittent layout issues depending on which order pages are loaded
- This is due to this issue: https://github.com/barc/express-hbs/issues/161
- In Ghost v3, we will throw a 400 error for missing template files instead of having a fallback
- In the example above, navigating to '/' would throw the error 'Missing template home.hbs for route "/".'
2019-08-05 21:34:12 +03:00
|
|
|
},
|
|
|
|
templates: ['page']
|
2019-03-13 13:13:52 +03:00
|
|
|
}
|
|
|
|
},
|
2019-01-04 23:59:39 +03:00
|
|
|
|
|
|
|
collections: {
|
|
|
|
'/food/': {
|
|
|
|
permalink: '/food/:slug/',
|
|
|
|
filter: 'tag:bacon+tag:-chorizo',
|
|
|
|
data: {
|
|
|
|
query: {
|
|
|
|
tag: {
|
|
|
|
controller: 'tagsPublic',
|
|
|
|
resource: 'tags',
|
|
|
|
type: 'read',
|
|
|
|
options: {
|
|
|
|
slug: 'bacon'
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
|
|
|
router: {
|
|
|
|
tags: [{redirect: true, slug: 'bacon'}]
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
|
|
|
'/sport/': {
|
|
|
|
permalink: '/sport/:slug/',
|
|
|
|
filter: 'tag:chorizo+tag:-bacon',
|
|
|
|
data: {
|
|
|
|
query: {
|
|
|
|
apollo: {
|
|
|
|
controller: 'tagsPublic',
|
|
|
|
resource: 'tags',
|
|
|
|
type: 'read',
|
|
|
|
options: {
|
|
|
|
slug: 'chorizo'
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
|
|
|
router: {
|
|
|
|
tags: [{redirect: false, slug: 'chorizo'}]
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
2018-06-24 01:32:08 +03:00
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
taxonomies: {
|
|
|
|
tag: '/categories/:slug/',
|
|
|
|
author: '/authors/:slug/'
|
|
|
|
}
|
2018-06-24 01:32:08 +03:00
|
|
|
});
|
2019-01-04 23:59:39 +03:00
|
|
|
|
|
|
|
testUtils.integrationTesting.urlService.resetGenerators();
|
2019-01-21 19:53:44 +03:00
|
|
|
testUtils.integrationTesting.defaultMocks(sinon);
|
2019-01-04 23:59:39 +03:00
|
|
|
|
|
|
|
return testUtils.integrationTesting.initGhost()
|
|
|
|
.then(function () {
|
2019-01-21 19:53:44 +03:00
|
|
|
sinon.stub(themeService.getActive(), 'engine').withArgs('ghost-api').returns('v2');
|
|
|
|
sinon.stub(themeService.getActive(), 'config').withArgs('posts_per_page').returns(2);
|
2019-01-04 23:59:39 +03:00
|
|
|
|
|
|
|
app = siteApp({start: true});
|
|
|
|
return testUtils.integrationTesting.urlService.waitTillFinished();
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
beforeEach(function () {
|
|
|
|
testUtils.integrationTesting.overrideGhostConfig(configUtils);
|
|
|
|
});
|
|
|
|
|
|
|
|
afterEach(function () {
|
|
|
|
configUtils.restore();
|
2019-06-18 16:13:55 +03:00
|
|
|
urlUtils.restore();
|
2019-01-04 23:59:39 +03:00
|
|
|
});
|
|
|
|
|
|
|
|
after(function () {
|
2019-01-21 19:53:44 +03:00
|
|
|
sinon.restore();
|
2019-01-04 23:59:39 +03:00
|
|
|
});
|
|
|
|
|
|
|
|
it('serve /food/', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/food/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('index');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve bacon tag', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/categories/bacon/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(301);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve /sport/', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/sport/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('index');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve chorizo tag', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/categories/chorizo/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-03-13 13:13:52 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve my-page', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/my-page/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
});
|
|
|
|
});
|
2018-06-24 01:32:08 +03:00
|
|
|
});
|
|
|
|
});
|
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
describe('extended routes.yaml: templates', function () {
|
|
|
|
describe('default template, no template', function () {
|
|
|
|
before(function () {
|
2019-06-26 10:41:37 +03:00
|
|
|
sinon.stub(frontendSettingsService, 'get').returns({
|
2019-01-04 23:59:39 +03:00
|
|
|
routes: {},
|
2018-06-24 01:32:08 +03:00
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
collections: {
|
|
|
|
'/': {
|
|
|
|
permalink: '/:slug/',
|
|
|
|
templates: ['default']
|
|
|
|
},
|
|
|
|
'/magic/': {
|
|
|
|
permalink: '/magic/:slug/'
|
|
|
|
}
|
2018-06-24 01:32:08 +03:00
|
|
|
}
|
2019-01-04 23:59:39 +03:00
|
|
|
});
|
2018-06-24 01:32:08 +03:00
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
testUtils.integrationTesting.urlService.resetGenerators();
|
2019-01-21 19:53:44 +03:00
|
|
|
testUtils.integrationTesting.defaultMocks(sinon);
|
2019-01-04 23:59:39 +03:00
|
|
|
|
|
|
|
return testUtils.integrationTesting.initGhost()
|
|
|
|
.then(function () {
|
2019-01-21 19:53:44 +03:00
|
|
|
sinon.stub(themeService.getActive(), 'engine').withArgs('ghost-api').returns('v2');
|
|
|
|
sinon.stub(themeService.getActive(), 'config').withArgs('posts_per_page').returns(2);
|
2019-01-04 23:59:39 +03:00
|
|
|
|
|
|
|
app = siteApp({start: true});
|
|
|
|
return testUtils.integrationTesting.urlService.waitTillFinished();
|
|
|
|
});
|
2018-06-24 01:32:08 +03:00
|
|
|
});
|
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
beforeEach(function () {
|
|
|
|
testUtils.integrationTesting.overrideGhostConfig(configUtils);
|
|
|
|
});
|
2018-06-24 01:32:08 +03:00
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
afterEach(function () {
|
|
|
|
configUtils.restore();
|
2019-06-18 16:13:55 +03:00
|
|
|
urlUtils.restore();
|
2019-01-04 23:59:39 +03:00
|
|
|
});
|
2018-06-24 01:32:08 +03:00
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
after(function () {
|
2019-01-21 19:53:44 +03:00
|
|
|
sinon.restore();
|
2019-01-04 23:59:39 +03:00
|
|
|
});
|
2018-06-24 01:32:08 +03:00
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
it('serve collection', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
2018-06-24 01:32:08 +03:00
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('default');
|
|
|
|
});
|
|
|
|
});
|
2018-06-24 01:32:08 +03:00
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
it('serve second collectiom', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/magic/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
2018-06-24 01:32:08 +03:00
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('index');
|
|
|
|
});
|
|
|
|
});
|
2018-06-24 01:32:08 +03:00
|
|
|
});
|
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
describe('two templates', function () {
|
|
|
|
before(function () {
|
2019-06-26 10:41:37 +03:00
|
|
|
sinon.stub(frontendSettingsService, 'get').returns({
|
2019-01-04 23:59:39 +03:00
|
|
|
routes: {},
|
2018-06-24 01:32:08 +03:00
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
collections: {
|
|
|
|
'/': {
|
|
|
|
permalink: '/:slug/',
|
|
|
|
templates: ['something', 'default']
|
|
|
|
}
|
|
|
|
}
|
2018-06-24 01:32:08 +03:00
|
|
|
});
|
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
testUtils.integrationTesting.urlService.resetGenerators();
|
2019-01-21 19:53:44 +03:00
|
|
|
testUtils.integrationTesting.defaultMocks(sinon);
|
2018-06-24 01:32:08 +03:00
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
return testUtils.integrationTesting.initGhost()
|
|
|
|
.then(function () {
|
2019-01-21 19:53:44 +03:00
|
|
|
sinon.stub(themeService.getActive(), 'engine').withArgs('ghost-api').returns('v2');
|
|
|
|
sinon.stub(themeService.getActive(), 'config').withArgs('posts_per_page').returns(2);
|
2019-01-04 23:59:39 +03:00
|
|
|
|
|
|
|
app = siteApp({start: true});
|
|
|
|
return testUtils.integrationTesting.urlService.waitTillFinished();
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
beforeEach(function () {
|
|
|
|
testUtils.integrationTesting.overrideGhostConfig(configUtils);
|
|
|
|
});
|
|
|
|
|
|
|
|
afterEach(function () {
|
|
|
|
configUtils.restore();
|
2019-06-18 16:13:55 +03:00
|
|
|
urlUtils.restore();
|
2019-01-04 23:59:39 +03:00
|
|
|
});
|
|
|
|
|
|
|
|
after(function () {
|
2019-01-21 19:53:44 +03:00
|
|
|
sinon.restore();
|
2019-01-04 23:59:39 +03:00
|
|
|
});
|
|
|
|
|
|
|
|
it('serve collection', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('default');
|
|
|
|
});
|
|
|
|
});
|
2018-06-24 01:32:08 +03:00
|
|
|
});
|
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
describe('home.hbs priority', function () {
|
|
|
|
before(function () {
|
2019-06-26 10:41:37 +03:00
|
|
|
sinon.stub(frontendSettingsService, 'get').returns({
|
2019-01-04 23:59:39 +03:00
|
|
|
routes: {},
|
2018-06-24 01:32:08 +03:00
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
collections: {
|
|
|
|
'/': {
|
|
|
|
permalink: '/:slug/',
|
|
|
|
templates: ['something', 'default']
|
|
|
|
},
|
|
|
|
'/magic/': {
|
|
|
|
permalink: '/magic/:slug/',
|
|
|
|
templates: ['something', 'default']
|
|
|
|
}
|
|
|
|
}
|
2018-06-24 01:32:08 +03:00
|
|
|
});
|
2019-01-04 23:59:39 +03:00
|
|
|
|
|
|
|
testUtils.integrationTesting.urlService.resetGenerators();
|
2019-01-21 19:53:44 +03:00
|
|
|
testUtils.integrationTesting.defaultMocks(sinon, {theme: 'test-theme'});
|
2019-01-04 23:59:39 +03:00
|
|
|
|
|
|
|
return testUtils.integrationTesting.initGhost()
|
|
|
|
.then(function () {
|
2019-01-21 19:53:44 +03:00
|
|
|
sinon.stub(themeService.getActive(), 'engine').withArgs('ghost-api').returns('v2');
|
|
|
|
sinon.stub(themeService.getActive(), 'config').withArgs('posts_per_page').returns(2);
|
2019-01-04 23:59:39 +03:00
|
|
|
|
|
|
|
app = siteApp({start: true});
|
|
|
|
return testUtils.integrationTesting.urlService.waitTillFinished();
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
beforeEach(function () {
|
|
|
|
testUtils.integrationTesting.overrideGhostConfig(configUtils);
|
|
|
|
});
|
|
|
|
|
|
|
|
afterEach(function () {
|
|
|
|
configUtils.restore();
|
2019-06-18 16:13:55 +03:00
|
|
|
urlUtils.restore();
|
2019-01-04 23:59:39 +03:00
|
|
|
});
|
|
|
|
|
|
|
|
after(function () {
|
2019-01-21 19:53:44 +03:00
|
|
|
sinon.restore();
|
2019-01-04 23:59:39 +03:00
|
|
|
});
|
|
|
|
|
|
|
|
it('serve collection', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('home');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve second page collection: should use index.hbs', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/magic/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('something');
|
|
|
|
});
|
|
|
|
});
|
2018-06-24 01:32:08 +03:00
|
|
|
});
|
|
|
|
});
|
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
describe('extended routes.yaml: routes', function () {
|
|
|
|
describe('channels', function () {
|
2019-01-14 21:04:22 +03:00
|
|
|
before(testUtils.integrationTesting.urlService.resetGenerators);
|
2020-02-24 23:51:09 +03:00
|
|
|
before(testUtils.teardownDb);
|
2019-01-04 23:59:39 +03:00
|
|
|
before(testUtils.setup('users:roles', 'posts'));
|
|
|
|
|
|
|
|
before(function () {
|
2019-01-21 19:53:44 +03:00
|
|
|
testUtils.integrationTesting.defaultMocks(sinon, {theme: 'test-theme-channels'});
|
2019-01-04 23:59:39 +03:00
|
|
|
|
2019-06-26 10:41:37 +03:00
|
|
|
sinon.stub(frontendSettingsService, 'get').returns({
|
2019-01-04 23:59:39 +03:00
|
|
|
routes: {
|
|
|
|
'/channel1/': {
|
|
|
|
controller: 'channel',
|
|
|
|
filter: 'tag:kitchen-sink',
|
|
|
|
data: {
|
|
|
|
query: {
|
|
|
|
tag: {
|
|
|
|
controller: 'tagsPublic',
|
|
|
|
resource: 'tags',
|
|
|
|
type: 'read',
|
|
|
|
options: {
|
|
|
|
slug: 'kitchen-sink'
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
|
|
|
router: {
|
|
|
|
tags: [{redirect: true, slug: 'kitchen-sink'}]
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
2018-06-24 01:32:08 +03:00
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
'/channel2/': {
|
|
|
|
controller: 'channel',
|
|
|
|
filter: 'tag:bacon',
|
|
|
|
data: {
|
|
|
|
query: {
|
|
|
|
tag: {
|
|
|
|
controller: 'tagsPublic',
|
|
|
|
resource: 'tags',
|
|
|
|
type: 'read',
|
|
|
|
options: {
|
|
|
|
slug: 'bacon'
|
|
|
|
}
|
2018-06-24 01:32:08 +03:00
|
|
|
}
|
2019-01-04 23:59:39 +03:00
|
|
|
},
|
|
|
|
router: {
|
|
|
|
tags: [{redirect: true, slug: 'bacon'}]
|
2018-06-24 01:32:08 +03:00
|
|
|
}
|
|
|
|
},
|
2019-01-04 23:59:39 +03:00
|
|
|
templates: ['default']
|
|
|
|
},
|
|
|
|
|
|
|
|
'/channel3/': {
|
|
|
|
controller: 'channel',
|
|
|
|
filter: 'author:joe-bloggs',
|
|
|
|
data: {
|
|
|
|
query: {
|
|
|
|
joe: {
|
2019-02-25 21:52:17 +03:00
|
|
|
controller: 'authorsPublic',
|
2019-01-04 23:59:39 +03:00
|
|
|
resource: 'authors',
|
|
|
|
type: 'read',
|
|
|
|
options: {
|
|
|
|
slug: 'joe-bloggs',
|
|
|
|
redirect: false
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
|
|
|
router: {
|
|
|
|
authors: [{redirect: false, slug: 'joe-bloggs'}]
|
|
|
|
}
|
2018-06-24 01:32:08 +03:00
|
|
|
}
|
2019-01-04 23:59:39 +03:00
|
|
|
},
|
|
|
|
|
|
|
|
'/channel4/': {
|
|
|
|
controller: 'channel',
|
|
|
|
filter: 'author:joe-bloggs'
|
|
|
|
},
|
|
|
|
|
|
|
|
'/channel5/': {
|
|
|
|
controller: 'channel',
|
|
|
|
data: {
|
|
|
|
query: {
|
|
|
|
tag: {
|
2019-02-25 21:52:17 +03:00
|
|
|
controller: 'authorsPublic',
|
2019-01-04 23:59:39 +03:00
|
|
|
resource: 'authors',
|
|
|
|
type: 'read',
|
|
|
|
options: {
|
|
|
|
slug: 'joe-bloggs',
|
|
|
|
redirect: false
|
|
|
|
}
|
2018-06-24 01:32:08 +03:00
|
|
|
}
|
2019-01-04 23:59:39 +03:00
|
|
|
},
|
|
|
|
router: {
|
|
|
|
authors: [{redirect: false, slug: 'joe-bloggs'}]
|
2018-06-24 01:32:08 +03:00
|
|
|
}
|
|
|
|
}
|
2019-01-04 23:59:39 +03:00
|
|
|
},
|
2018-06-24 01:32:08 +03:00
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
'/channel6/': {
|
|
|
|
controller: 'channel',
|
|
|
|
data: {
|
|
|
|
query: {
|
|
|
|
post: {
|
2019-02-25 22:40:19 +03:00
|
|
|
controller: 'postsPublic',
|
2019-01-04 23:59:39 +03:00
|
|
|
resource: 'posts',
|
|
|
|
type: 'read',
|
|
|
|
options: {
|
|
|
|
slug: 'html-ipsum',
|
|
|
|
redirect: true
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
|
|
|
router: {
|
|
|
|
posts: [{redirect: true, slug: 'html-ipsum'}]
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
2018-06-24 01:32:08 +03:00
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
collections: {
|
|
|
|
'/': {
|
|
|
|
permalink: '/:slug/'
|
|
|
|
}
|
|
|
|
},
|
2018-06-24 01:32:08 +03:00
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
taxonomies: {
|
|
|
|
tag: '/tag/:slug/',
|
|
|
|
author: '/author/:slug/'
|
|
|
|
}
|
2018-06-24 01:32:08 +03:00
|
|
|
});
|
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
return testUtils.integrationTesting.initGhost()
|
|
|
|
.then(function () {
|
2019-01-21 19:53:44 +03:00
|
|
|
sinon.stub(themeService.getActive(), 'engine').withArgs('ghost-api').returns('v2');
|
|
|
|
sinon.stub(themeService.getActive(), 'config').withArgs('posts_per_page').returns(10);
|
2018-06-24 01:32:08 +03:00
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
app = siteApp({start: true});
|
|
|
|
return testUtils.integrationTesting.urlService.waitTillFinished();
|
|
|
|
});
|
|
|
|
});
|
2018-06-24 01:32:08 +03:00
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
beforeEach(function () {
|
|
|
|
testUtils.integrationTesting.overrideGhostConfig(configUtils);
|
|
|
|
});
|
2018-06-24 01:32:08 +03:00
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
afterEach(function () {
|
|
|
|
configUtils.restore();
|
2019-06-18 16:13:55 +03:00
|
|
|
urlUtils.restore();
|
2019-01-04 23:59:39 +03:00
|
|
|
});
|
2018-06-24 01:32:08 +03:00
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
after(function () {
|
2019-01-21 19:53:44 +03:00
|
|
|
sinon.restore();
|
2019-01-04 23:59:39 +03:00
|
|
|
});
|
2018-06-24 01:32:08 +03:00
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
it('serve channel 1', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/channel1/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
2018-06-24 01:32:08 +03:00
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
const $ = cheerio.load(response.body);
|
2018-06-24 01:32:08 +03:00
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('index');
|
2018-06-24 01:32:08 +03:00
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
$('.post-card').length.should.equal(2);
|
|
|
|
});
|
|
|
|
});
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
it('serve channel 1: rss', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/channel1/rss/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.headers['content-type'].should.eql('text/xml; charset=UTF-8');
|
|
|
|
});
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
});
|
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
it('serve channel 2', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/channel2/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
const $ = cheerio.load(response.body);
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('default');
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
|
2020-04-08 05:26:50 +03:00
|
|
|
// default template does not list posts
|
2019-01-04 23:59:39 +03:00
|
|
|
$('.post-card').length.should.equal(0);
|
|
|
|
});
|
|
|
|
});
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
it('serve channel 3', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/channel3/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
const $ = cheerio.load(response.body);
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('channel3');
|
|
|
|
});
|
|
|
|
});
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
it('serve channel 4', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/channel4/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
const $ = cheerio.load(response.body);
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('index');
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
$('.post-card').length.should.equal(4);
|
|
|
|
});
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
});
|
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
it('serve channel 5', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/channel5/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
const $ = cheerio.load(response.body);
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('index');
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
$('.post-card').length.should.equal(4);
|
|
|
|
});
|
|
|
|
});
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
it('serve channel 6', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/channel6/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
const $ = cheerio.load(response.body);
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('index');
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
$('.post-card').length.should.equal(4);
|
|
|
|
});
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
});
|
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
it('serve kitching-sink: redirect', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/tag/kitchen-sink/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(301);
|
|
|
|
response.headers.location.should.eql('/channel1/');
|
|
|
|
});
|
|
|
|
});
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
it('serve html-ipsum: redirect', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/html-ipsum/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(301);
|
|
|
|
response.headers.location.should.eql('/channel6/');
|
|
|
|
});
|
|
|
|
});
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
it('serve chorizo: no redirect', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/tag/chorizo/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
});
|
|
|
|
});
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
it('serve joe-bloggs', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/author/joe-bloggs/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-01-04 23:59:39 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
});
|
|
|
|
});
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
});
|
|
|
|
});
|
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
describe('extended routes.yaml (5): rss override', function () {
|
2018-06-24 01:32:08 +03:00
|
|
|
before(function () {
|
2019-06-26 10:41:37 +03:00
|
|
|
sinon.stub(frontendSettingsService, 'get').returns({
|
2018-06-24 01:32:08 +03:00
|
|
|
routes: {
|
2019-01-04 23:59:39 +03:00
|
|
|
'/podcast/rss/': {
|
|
|
|
templates: ['podcast/rss'],
|
2019-07-04 16:43:01 +03:00
|
|
|
content_type: 'text/xml'
|
2018-06-24 01:32:08 +03:00
|
|
|
},
|
2019-01-04 23:59:39 +03:00
|
|
|
'/cooking/': {
|
2018-12-03 22:31:48 +03:00
|
|
|
controller: 'channel',
|
2019-01-04 23:59:39 +03:00
|
|
|
rss: false
|
2018-12-03 22:31:48 +03:00
|
|
|
},
|
2019-01-04 23:59:39 +03:00
|
|
|
'/flat/': {
|
|
|
|
controller: 'channel'
|
2018-06-24 01:32:08 +03:00
|
|
|
}
|
|
|
|
},
|
|
|
|
|
2018-12-03 22:31:48 +03:00
|
|
|
collections: {
|
2019-01-04 23:59:39 +03:00
|
|
|
'/podcast/': {
|
|
|
|
permalink: '/:slug/',
|
|
|
|
filter: 'featured:true',
|
|
|
|
templates: ['home'],
|
|
|
|
rss: false
|
|
|
|
},
|
|
|
|
'/music/': {
|
|
|
|
permalink: '/:slug/',
|
|
|
|
rss: false
|
|
|
|
},
|
2018-12-03 22:31:48 +03:00
|
|
|
'/': {
|
|
|
|
permalink: '/:slug/'
|
|
|
|
}
|
|
|
|
},
|
2018-06-24 01:32:08 +03:00
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
taxonomies: {}
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
});
|
|
|
|
|
2018-06-24 01:32:08 +03:00
|
|
|
testUtils.integrationTesting.urlService.resetGenerators();
|
2019-01-21 19:53:44 +03:00
|
|
|
testUtils.integrationTesting.defaultMocks(sinon, {theme: 'test-theme'});
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
|
2018-06-24 01:32:08 +03:00
|
|
|
return testUtils.integrationTesting.initGhost()
|
|
|
|
.then(function () {
|
2019-01-21 19:53:44 +03:00
|
|
|
sinon.stub(themeService.getActive(), 'engine').withArgs('ghost-api').returns('v2');
|
|
|
|
sinon.stub(themeService.getActive(), 'config').withArgs('posts_per_page').returns(2);
|
2019-01-04 23:59:39 +03:00
|
|
|
|
2018-08-06 18:18:59 +03:00
|
|
|
app = siteApp({start: true});
|
2018-06-24 01:32:08 +03:00
|
|
|
return testUtils.integrationTesting.urlService.waitTillFinished();
|
|
|
|
});
|
|
|
|
});
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
|
2018-06-24 01:32:08 +03:00
|
|
|
beforeEach(function () {
|
|
|
|
testUtils.integrationTesting.overrideGhostConfig(configUtils);
|
|
|
|
});
|
|
|
|
|
|
|
|
afterEach(function () {
|
|
|
|
configUtils.restore();
|
2019-06-18 16:13:55 +03:00
|
|
|
urlUtils.restore();
|
2018-06-24 01:32:08 +03:00
|
|
|
});
|
|
|
|
|
|
|
|
after(function () {
|
2019-01-21 19:53:44 +03:00
|
|
|
sinon.restore();
|
2018-06-24 01:32:08 +03:00
|
|
|
});
|
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
it('serve /rss/', function () {
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
2019-08-09 17:25:12 +03:00
|
|
|
url: '/rss/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve /music/rss/', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/music/rss/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(404);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve /cooking/rss/', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/cooking/rss/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(404);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve /flat/rss/', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/flat/rss/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve /podcast/rss/', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/podcast/rss/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('podcast/rss');
|
|
|
|
response.headers['content-type'].should.eql('text/xml; charset=utf-8');
|
|
|
|
response.body.match(/<link>/g).length.should.eql(2);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve /podcast/', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/podcast/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
const $ = cheerio.load(response.body);
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
$('head link')[2].attribs.href.should.eql('https://127.0.0.1:2369/rss/');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('canary', function () {
|
|
|
|
let postSpy;
|
|
|
|
|
|
|
|
describe('default routes.yaml', function () {
|
|
|
|
before(function () {
|
|
|
|
testUtils.integrationTesting.urlService.resetGenerators();
|
2020-03-19 18:23:10 +03:00
|
|
|
testUtils.integrationTesting.defaultMocks(sinon, {amp: true});
|
2019-08-09 17:25:12 +03:00
|
|
|
testUtils.integrationTesting.overrideGhostConfig(configUtils);
|
|
|
|
|
|
|
|
return testUtils.integrationTesting.initGhost()
|
|
|
|
.then(function () {
|
|
|
|
sinon.stub(themeService.getActive(), 'engine').withArgs('ghost-api').returns('canary');
|
|
|
|
sinon.stub(themeService.getActive(), 'config').withArgs('posts_per_page').returns(2);
|
|
|
|
|
|
|
|
app = siteApp({start: true});
|
|
|
|
return testUtils.integrationTesting.urlService.waitTillFinished();
|
2020-03-20 11:58:26 +03:00
|
|
|
})
|
|
|
|
.then(() => {
|
2020-03-23 22:43:01 +03:00
|
|
|
return appService.init();
|
2019-08-09 17:25:12 +03:00
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
before(function () {
|
|
|
|
configUtils.set('url', 'http://example.com');
|
|
|
|
urlUtils.stubUrlUtilsFromConfig();
|
|
|
|
});
|
|
|
|
|
|
|
|
beforeEach(function () {
|
2020-03-30 18:26:47 +03:00
|
|
|
const postsAPI = require('../../../core/server/api/canary/posts-public');
|
2019-08-09 17:25:12 +03:00
|
|
|
postSpy = sinon.spy(postsAPI.browse, 'query');
|
|
|
|
});
|
|
|
|
|
|
|
|
afterEach(function () {
|
|
|
|
postSpy.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
after(function () {
|
|
|
|
configUtils.restore();
|
|
|
|
urlUtils.restore();
|
|
|
|
sinon.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('behaviour: default cases', function () {
|
|
|
|
it('serve post', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/html-ipsum/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('post');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve amp', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/html-ipsum/amp/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.match(/amp\.hbs/);
|
|
|
|
response.body.should.match(/<h1>HTML Ipsum Presents<\/h1>/);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('post not found', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/not-found/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(404);
|
|
|
|
response.template.should.eql('error-404');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve static page', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/static-page-test/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('page');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve author', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/author/joe-bloggs/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
const $ = cheerio.load(response.body);
|
|
|
|
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('author');
|
|
|
|
|
|
|
|
$('.author-bio').length.should.equal(1);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve tag', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/tag/bacon/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('tag');
|
|
|
|
|
2019-09-16 13:51:54 +03:00
|
|
|
postSpy.args[0][0].options.filter.should.eql('(tags:\'bacon\'+tags.visibility:public)+type:post');
|
2019-08-09 17:25:12 +03:00
|
|
|
postSpy.args[0][0].options.page.should.eql(1);
|
|
|
|
postSpy.args[0][0].options.limit.should.eql(2);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve tag rss', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/tag/bacon/rss/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve collection', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
const $ = cheerio.load(response.body);
|
|
|
|
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('index');
|
|
|
|
|
|
|
|
$('.post-card').length.should.equal(2);
|
|
|
|
|
|
|
|
should.exist(response.res.locals.context);
|
|
|
|
should.exist(response.res.locals.version);
|
|
|
|
should.exist(response.res.locals.safeVersion);
|
|
|
|
should.exist(response.res.locals.safeVersion);
|
|
|
|
should.exist(response.res.locals.relativeUrl);
|
|
|
|
should.exist(response.res.locals.secure);
|
|
|
|
should.exist(response.res.routerOptions);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve collection: page 2', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/page/2/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
const $ = cheerio.load(response.body);
|
|
|
|
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('index');
|
|
|
|
|
|
|
|
$('.post-card').length.should.equal(2);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve theme asset', function () {
|
|
|
|
//configUtils.set('url', 'https://example.com');
|
|
|
|
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/assets/css/screen.css',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('behaviour: prettify', function () {
|
|
|
|
it('url without slash', function () {
|
|
|
|
const req = {
|
|
|
|
secure: false,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/prettify-me',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(301);
|
|
|
|
response.headers.location.should.eql('/prettify-me/');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('behaviour: url redirects', function () {
|
|
|
|
describe('pagination', function () {
|
|
|
|
it('redirect /page/1/ to /', function () {
|
|
|
|
const req = {
|
|
|
|
secure: false,
|
|
|
|
host: 'example.com',
|
|
|
|
method: 'GET',
|
|
|
|
url: '/page/1/'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(301);
|
|
|
|
response.headers.location.should.eql('/');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('rss', function () {
|
|
|
|
it('redirect /feed/ to /rss/', function () {
|
|
|
|
const req = {
|
|
|
|
secure: false,
|
|
|
|
host: 'example.com',
|
|
|
|
method: 'GET',
|
|
|
|
url: '/feed/'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(301);
|
|
|
|
response.headers.location.should.eql('/rss/');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('https', function () {
|
|
|
|
before(function () {
|
|
|
|
configUtils.set('url', 'https://example.com');
|
|
|
|
urlUtils.stubUrlUtilsFromConfig();
|
|
|
|
});
|
|
|
|
|
|
|
|
after(function () {
|
|
|
|
urlUtils.restore();
|
|
|
|
configUtils.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('protocol', function () {
|
|
|
|
it('blog is https, request is http', function () {
|
|
|
|
const req = {
|
|
|
|
secure: false,
|
|
|
|
host: 'example.com',
|
|
|
|
method: 'GET',
|
|
|
|
url: '/html-ipsum'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(301);
|
|
|
|
response.headers.location.should.eql('https://example.com/html-ipsum/');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('blog is https, request is http, trailing slash exists already', function () {
|
|
|
|
const req = {
|
|
|
|
secure: false,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/html-ipsum/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(301);
|
|
|
|
response.headers.location.should.eql('https://example.com/html-ipsum/');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('assets', function () {
|
|
|
|
it('blog is https, request is http', function () {
|
|
|
|
const req = {
|
|
|
|
secure: false,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/favicon.png',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(301);
|
|
|
|
response.headers.location.should.eql('https://example.com/favicon.png');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('blog is https, request is http', function () {
|
|
|
|
const req = {
|
|
|
|
secure: false,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/assets/css/main.css',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(301);
|
|
|
|
response.headers.location.should.eql('https://example.com/assets/css/main.css');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('extended routes.yaml: collections', function () {
|
|
|
|
describe('2 collections', function () {
|
|
|
|
before(function () {
|
|
|
|
sinon.stub(frontendSettingsService, 'get').returns({
|
|
|
|
routes: {
|
💡Changed static router - throw 400 for missing tpl
fixes #10990
- Changed the static router to throw a 400 error for a missing template file, rather than falling back to using the default.hbs file
- Falling back is weird and hard to understand, but throwing an error makes it clear that the user has to provide the matching template
- The new error reads 'Missing template [filename].hbs for route "[route]".'
Assume you have a route.yaml file something like:
```
routes:
/: home
```
- In Ghost v2, if you don't have a home.hbs template, Ghost falls back to using the default.hbs file if it's available
- Most themes have a default.hbs, however this file is a layout file, depended on by other templates, not a template file itself
- In production mode, using the default.hbs as a template causes weird, intermittent layout issues depending on which order pages are loaded
- This is due to this issue: https://github.com/barc/express-hbs/issues/161
- In Ghost v3, we will throw a 400 error for missing template files instead of having a fallback
- In the example above, navigating to '/' would throw the error 'Missing template home.hbs for route "/".'
2019-08-05 21:34:12 +03:00
|
|
|
'/': {templates: ['home']}
|
2019-08-09 17:25:12 +03:00
|
|
|
},
|
|
|
|
|
|
|
|
collections: {
|
|
|
|
'/podcast/': {
|
|
|
|
permalink: '/podcast/:slug/',
|
|
|
|
filter: 'featured:true'
|
|
|
|
},
|
|
|
|
|
|
|
|
'/something/': {
|
|
|
|
permalink: '/something/:slug/',
|
|
|
|
filter: 'featured:false'
|
|
|
|
}
|
|
|
|
},
|
|
|
|
|
|
|
|
taxonomies: {
|
|
|
|
tag: '/categories/:slug/',
|
|
|
|
author: '/authors/:slug/'
|
|
|
|
}
|
|
|
|
});
|
|
|
|
|
|
|
|
testUtils.integrationTesting.urlService.resetGenerators();
|
💡Changed static router - throw 400 for missing tpl
fixes #10990
- Changed the static router to throw a 400 error for a missing template file, rather than falling back to using the default.hbs file
- Falling back is weird and hard to understand, but throwing an error makes it clear that the user has to provide the matching template
- The new error reads 'Missing template [filename].hbs for route "[route]".'
Assume you have a route.yaml file something like:
```
routes:
/: home
```
- In Ghost v2, if you don't have a home.hbs template, Ghost falls back to using the default.hbs file if it's available
- Most themes have a default.hbs, however this file is a layout file, depended on by other templates, not a template file itself
- In production mode, using the default.hbs as a template causes weird, intermittent layout issues depending on which order pages are loaded
- This is due to this issue: https://github.com/barc/express-hbs/issues/161
- In Ghost v3, we will throw a 400 error for missing template files instead of having a fallback
- In the example above, navigating to '/' would throw the error 'Missing template home.hbs for route "/".'
2019-08-05 21:34:12 +03:00
|
|
|
testUtils.integrationTesting.defaultMocks(sinon, {theme: 'test-theme'});
|
2019-08-09 17:25:12 +03:00
|
|
|
|
|
|
|
return testUtils.integrationTesting.initGhost()
|
|
|
|
.then(function () {
|
|
|
|
sinon.stub(themeService.getActive(), 'engine').withArgs('ghost-api').returns('canary');
|
|
|
|
sinon.stub(themeService.getActive(), 'config').withArgs('posts_per_page').returns(2);
|
|
|
|
|
|
|
|
app = siteApp({start: true});
|
|
|
|
return testUtils.integrationTesting.urlService.waitTillFinished();
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
beforeEach(function () {
|
|
|
|
testUtils.integrationTesting.overrideGhostConfig(configUtils);
|
|
|
|
});
|
|
|
|
|
|
|
|
afterEach(function () {
|
|
|
|
configUtils.restore();
|
|
|
|
urlUtils.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
after(function () {
|
|
|
|
sinon.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve static route', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
💡Changed static router - throw 400 for missing tpl
fixes #10990
- Changed the static router to throw a 400 error for a missing template file, rather than falling back to using the default.hbs file
- Falling back is weird and hard to understand, but throwing an error makes it clear that the user has to provide the matching template
- The new error reads 'Missing template [filename].hbs for route "[route]".'
Assume you have a route.yaml file something like:
```
routes:
/: home
```
- In Ghost v2, if you don't have a home.hbs template, Ghost falls back to using the default.hbs file if it's available
- Most themes have a default.hbs, however this file is a layout file, depended on by other templates, not a template file itself
- In production mode, using the default.hbs as a template causes weird, intermittent layout issues depending on which order pages are loaded
- This is due to this issue: https://github.com/barc/express-hbs/issues/161
- In Ghost v3, we will throw a 400 error for missing template files instead of having a fallback
- In the example above, navigating to '/' would throw the error 'Missing template home.hbs for route "/".'
2019-08-05 21:34:12 +03:00
|
|
|
response.template.should.eql('home');
|
2019-08-09 17:25:12 +03:00
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve rss', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/podcast/rss/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve post', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/something/html-ipsum/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('post');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
💡Changed static router - throw 400 for missing tpl
fixes #10990
- Changed the static router to throw a 400 error for a missing template file, rather than falling back to using the default.hbs file
- Falling back is weird and hard to understand, but throwing an error makes it clear that the user has to provide the matching template
- The new error reads 'Missing template [filename].hbs for route "[route]".'
Assume you have a route.yaml file something like:
```
routes:
/: home
```
- In Ghost v2, if you don't have a home.hbs template, Ghost falls back to using the default.hbs file if it's available
- Most themes have a default.hbs, however this file is a layout file, depended on by other templates, not a template file itself
- In production mode, using the default.hbs as a template causes weird, intermittent layout issues depending on which order pages are loaded
- This is due to this issue: https://github.com/barc/express-hbs/issues/161
- In Ghost v3, we will throw a 400 error for missing template files instead of having a fallback
- In the example above, navigating to '/' would throw the error 'Missing template home.hbs for route "/".'
2019-08-05 21:34:12 +03:00
|
|
|
it('serve collection: podcast with default template', function () {
|
2019-08-09 17:25:12 +03:00
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/podcast/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
const $ = cheerio.load(response.body);
|
|
|
|
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('index');
|
|
|
|
|
|
|
|
$('.post-card').length.should.equal(2);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
💡Changed static router - throw 400 for missing tpl
fixes #10990
- Changed the static router to throw a 400 error for a missing template file, rather than falling back to using the default.hbs file
- Falling back is weird and hard to understand, but throwing an error makes it clear that the user has to provide the matching template
- The new error reads 'Missing template [filename].hbs for route "[route]".'
Assume you have a route.yaml file something like:
```
routes:
/: home
```
- In Ghost v2, if you don't have a home.hbs template, Ghost falls back to using the default.hbs file if it's available
- Most themes have a default.hbs, however this file is a layout file, depended on by other templates, not a template file itself
- In production mode, using the default.hbs as a template causes weird, intermittent layout issues depending on which order pages are loaded
- This is due to this issue: https://github.com/barc/express-hbs/issues/161
- In Ghost v3, we will throw a 400 error for missing template files instead of having a fallback
- In the example above, navigating to '/' would throw the error 'Missing template home.hbs for route "/".'
2019-08-05 21:34:12 +03:00
|
|
|
it('serve collection: something with custom template', function () {
|
2019-08-09 17:25:12 +03:00
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/something/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
const $ = cheerio.load(response.body);
|
|
|
|
|
|
|
|
response.statusCode.should.eql(200);
|
💡Changed static router - throw 400 for missing tpl
fixes #10990
- Changed the static router to throw a 400 error for a missing template file, rather than falling back to using the default.hbs file
- Falling back is weird and hard to understand, but throwing an error makes it clear that the user has to provide the matching template
- The new error reads 'Missing template [filename].hbs for route "[route]".'
Assume you have a route.yaml file something like:
```
routes:
/: home
```
- In Ghost v2, if you don't have a home.hbs template, Ghost falls back to using the default.hbs file if it's available
- Most themes have a default.hbs, however this file is a layout file, depended on by other templates, not a template file itself
- In production mode, using the default.hbs as a template causes weird, intermittent layout issues depending on which order pages are loaded
- This is due to this issue: https://github.com/barc/express-hbs/issues/161
- In Ghost v3, we will throw a 400 error for missing template files instead of having a fallback
- In the example above, navigating to '/' would throw the error 'Missing template home.hbs for route "/".'
2019-08-05 21:34:12 +03:00
|
|
|
response.template.should.eql('something');
|
2019-08-09 17:25:12 +03:00
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('no collections', function () {
|
|
|
|
before(function () {
|
|
|
|
sinon.stub(frontendSettingsService, 'get').returns({
|
|
|
|
routes: {
|
💡Changed static router - throw 400 for missing tpl
fixes #10990
- Changed the static router to throw a 400 error for a missing template file, rather than falling back to using the default.hbs file
- Falling back is weird and hard to understand, but throwing an error makes it clear that the user has to provide the matching template
- The new error reads 'Missing template [filename].hbs for route "[route]".'
Assume you have a route.yaml file something like:
```
routes:
/: home
```
- In Ghost v2, if you don't have a home.hbs template, Ghost falls back to using the default.hbs file if it's available
- Most themes have a default.hbs, however this file is a layout file, depended on by other templates, not a template file itself
- In production mode, using the default.hbs as a template causes weird, intermittent layout issues depending on which order pages are loaded
- This is due to this issue: https://github.com/barc/express-hbs/issues/161
- In Ghost v3, we will throw a 400 error for missing template files instead of having a fallback
- In the example above, navigating to '/' would throw the error 'Missing template home.hbs for route "/".'
2019-08-05 21:34:12 +03:00
|
|
|
'/something/': {
|
|
|
|
templates: ['something']
|
|
|
|
}
|
2019-08-09 17:25:12 +03:00
|
|
|
},
|
|
|
|
collections: {},
|
|
|
|
taxonomies: {}
|
|
|
|
});
|
|
|
|
|
|
|
|
testUtils.integrationTesting.urlService.resetGenerators();
|
💡Changed static router - throw 400 for missing tpl
fixes #10990
- Changed the static router to throw a 400 error for a missing template file, rather than falling back to using the default.hbs file
- Falling back is weird and hard to understand, but throwing an error makes it clear that the user has to provide the matching template
- The new error reads 'Missing template [filename].hbs for route "[route]".'
Assume you have a route.yaml file something like:
```
routes:
/: home
```
- In Ghost v2, if you don't have a home.hbs template, Ghost falls back to using the default.hbs file if it's available
- Most themes have a default.hbs, however this file is a layout file, depended on by other templates, not a template file itself
- In production mode, using the default.hbs as a template causes weird, intermittent layout issues depending on which order pages are loaded
- This is due to this issue: https://github.com/barc/express-hbs/issues/161
- In Ghost v3, we will throw a 400 error for missing template files instead of having a fallback
- In the example above, navigating to '/' would throw the error 'Missing template home.hbs for route "/".'
2019-08-05 21:34:12 +03:00
|
|
|
testUtils.integrationTesting.defaultMocks(sinon, {theme: 'test-theme'});
|
2019-08-09 17:25:12 +03:00
|
|
|
|
|
|
|
return testUtils.integrationTesting.initGhost()
|
|
|
|
.then(function () {
|
|
|
|
sinon.stub(themeService.getActive(), 'engine').withArgs('ghost-api').returns('canary');
|
|
|
|
sinon.stub(themeService.getActive(), 'config').withArgs('posts_per_page').returns(2);
|
|
|
|
|
|
|
|
app = siteApp({start: true});
|
|
|
|
return testUtils.integrationTesting.urlService.waitTillFinished();
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
beforeEach(function () {
|
|
|
|
testUtils.integrationTesting.overrideGhostConfig(configUtils);
|
|
|
|
});
|
|
|
|
|
|
|
|
afterEach(function () {
|
|
|
|
configUtils.restore();
|
|
|
|
urlUtils.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
after(function () {
|
|
|
|
sinon.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve route', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
💡Changed static router - throw 400 for missing tpl
fixes #10990
- Changed the static router to throw a 400 error for a missing template file, rather than falling back to using the default.hbs file
- Falling back is weird and hard to understand, but throwing an error makes it clear that the user has to provide the matching template
- The new error reads 'Missing template [filename].hbs for route "[route]".'
Assume you have a route.yaml file something like:
```
routes:
/: home
```
- In Ghost v2, if you don't have a home.hbs template, Ghost falls back to using the default.hbs file if it's available
- Most themes have a default.hbs, however this file is a layout file, depended on by other templates, not a template file itself
- In production mode, using the default.hbs as a template causes weird, intermittent layout issues depending on which order pages are loaded
- This is due to this issue: https://github.com/barc/express-hbs/issues/161
- In Ghost v3, we will throw a 400 error for missing template files instead of having a fallback
- In the example above, navigating to '/' would throw the error 'Missing template home.hbs for route "/".'
2019-08-05 21:34:12 +03:00
|
|
|
url: '/something/',
|
2019-08-09 17:25:12 +03:00
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
💡Changed static router - throw 400 for missing tpl
fixes #10990
- Changed the static router to throw a 400 error for a missing template file, rather than falling back to using the default.hbs file
- Falling back is weird and hard to understand, but throwing an error makes it clear that the user has to provide the matching template
- The new error reads 'Missing template [filename].hbs for route "[route]".'
Assume you have a route.yaml file something like:
```
routes:
/: home
```
- In Ghost v2, if you don't have a home.hbs template, Ghost falls back to using the default.hbs file if it's available
- Most themes have a default.hbs, however this file is a layout file, depended on by other templates, not a template file itself
- In production mode, using the default.hbs as a template causes weird, intermittent layout issues depending on which order pages are loaded
- This is due to this issue: https://github.com/barc/express-hbs/issues/161
- In Ghost v3, we will throw a 400 error for missing template files instead of having a fallback
- In the example above, navigating to '/' would throw the error 'Missing template home.hbs for route "/".'
2019-08-05 21:34:12 +03:00
|
|
|
response.template.should.eql('something');
|
2019-08-09 17:25:12 +03:00
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('static permalink route', function () {
|
|
|
|
before(function () {
|
|
|
|
sinon.stub(frontendSettingsService, 'get').returns({
|
|
|
|
routes: {},
|
|
|
|
|
|
|
|
collections: {
|
|
|
|
'/podcast/': {
|
|
|
|
permalink: '/featured/',
|
|
|
|
filter: 'featured:true'
|
|
|
|
},
|
|
|
|
|
|
|
|
'/': {
|
|
|
|
permalink: '/:slug/'
|
|
|
|
}
|
|
|
|
},
|
|
|
|
|
|
|
|
taxonomies: {}
|
|
|
|
});
|
|
|
|
|
|
|
|
testUtils.integrationTesting.urlService.resetGenerators();
|
|
|
|
testUtils.integrationTesting.defaultMocks(sinon);
|
|
|
|
|
|
|
|
return testUtils.integrationTesting.initGhost()
|
|
|
|
.then(function () {
|
|
|
|
sinon.stub(themeService.getActive(), 'engine').withArgs('ghost-api').returns('canary');
|
|
|
|
sinon.stub(themeService.getActive(), 'config').withArgs('posts_per_page').returns(2);
|
|
|
|
|
|
|
|
app = siteApp({start: true});
|
|
|
|
return testUtils.integrationTesting.urlService.waitTillFinished();
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
beforeEach(function () {
|
|
|
|
testUtils.integrationTesting.overrideGhostConfig(configUtils);
|
|
|
|
});
|
|
|
|
|
|
|
|
afterEach(function () {
|
|
|
|
configUtils.restore();
|
|
|
|
urlUtils.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
after(function () {
|
|
|
|
sinon.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve post', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/featured/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
// We can't find a post with the slug "featured"
|
|
|
|
response.statusCode.should.eql(404);
|
|
|
|
response.template.should.eql('error-404');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve post', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/html-ipsum/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('post');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve author', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/author/joe-bloggs/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(404);
|
|
|
|
response.template.should.eql('error-404');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve tag', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/tag/bacon/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(404);
|
|
|
|
response.template.should.eql('error-404');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('primary author permalink', function () {
|
|
|
|
before(function () {
|
|
|
|
sinon.stub(frontendSettingsService, 'get').returns({
|
|
|
|
routes: {},
|
|
|
|
|
|
|
|
collections: {
|
|
|
|
'/something/': {
|
|
|
|
permalink: '/:primary_author/:slug/'
|
|
|
|
}
|
|
|
|
},
|
|
|
|
|
|
|
|
taxonomies: {}
|
|
|
|
});
|
|
|
|
|
|
|
|
testUtils.integrationTesting.urlService.resetGenerators();
|
|
|
|
testUtils.integrationTesting.defaultMocks(sinon);
|
|
|
|
|
|
|
|
return testUtils.integrationTesting.initGhost()
|
|
|
|
.then(function () {
|
|
|
|
sinon.stub(themeService.getActive(), 'engine').withArgs('ghost-api').returns('canary');
|
|
|
|
sinon.stub(themeService.getActive(), 'config').withArgs('posts_per_page').returns(2);
|
|
|
|
|
|
|
|
app = siteApp({start: true});
|
|
|
|
return testUtils.integrationTesting.urlService.waitTillFinished();
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
beforeEach(function () {
|
|
|
|
testUtils.integrationTesting.overrideGhostConfig(configUtils);
|
|
|
|
});
|
|
|
|
|
|
|
|
afterEach(function () {
|
|
|
|
configUtils.restore();
|
|
|
|
urlUtils.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
after(function () {
|
|
|
|
sinon.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve post', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/joe-bloggs/html-ipsum/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('post');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('post without author', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/html-ipsum/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(404);
|
|
|
|
response.template.should.eql('error-404');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('page', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/static-page-test/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('page');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('primary tag permalink', function () {
|
|
|
|
before(function () {
|
|
|
|
sinon.stub(frontendSettingsService, 'get').returns({
|
|
|
|
routes: {},
|
|
|
|
|
|
|
|
collections: {
|
|
|
|
'/something/': {
|
|
|
|
permalink: '/something/:primary_tag/:slug/'
|
|
|
|
}
|
|
|
|
},
|
|
|
|
|
|
|
|
taxonomies: {}
|
|
|
|
});
|
|
|
|
|
|
|
|
testUtils.integrationTesting.urlService.resetGenerators();
|
|
|
|
testUtils.integrationTesting.defaultMocks(sinon);
|
|
|
|
|
|
|
|
return testUtils.integrationTesting.initGhost()
|
|
|
|
.then(function () {
|
|
|
|
sinon.stub(themeService.getActive(), 'engine').withArgs('ghost-api').returns('canary');
|
|
|
|
sinon.stub(themeService.getActive(), 'config').withArgs('posts_per_page').returns(2);
|
|
|
|
|
|
|
|
app = siteApp({start: true});
|
|
|
|
return testUtils.integrationTesting.urlService.waitTillFinished();
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
beforeEach(function () {
|
|
|
|
testUtils.integrationTesting.overrideGhostConfig(configUtils);
|
|
|
|
});
|
|
|
|
|
|
|
|
afterEach(function () {
|
|
|
|
configUtils.restore();
|
|
|
|
urlUtils.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
after(function () {
|
|
|
|
sinon.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve post', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/something/kitchen-sink/html-ipsum/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('post');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('post without tag', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/something/html-ipsum/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(404);
|
|
|
|
response.template.should.eql('error-404');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('post without tag', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/html-ipsum/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(404);
|
|
|
|
response.template.should.eql('error-404');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('page', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/static-page-test/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('page');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('collection/routes with data key', function () {
|
|
|
|
before(function () {
|
|
|
|
sinon.stub(frontendSettingsService, 'get').returns({
|
|
|
|
routes: {
|
|
|
|
'/my-page/': {
|
|
|
|
data: {
|
|
|
|
query: {
|
|
|
|
page: {
|
|
|
|
controller: 'pagesPublic',
|
|
|
|
resource: 'pages',
|
|
|
|
type: 'read',
|
|
|
|
options: {
|
|
|
|
slug: 'static-page-test'
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
|
|
|
router: {
|
|
|
|
pages: [{redirect: true, slug: 'static-page-test'}]
|
|
|
|
}
|
💡Changed static router - throw 400 for missing tpl
fixes #10990
- Changed the static router to throw a 400 error for a missing template file, rather than falling back to using the default.hbs file
- Falling back is weird and hard to understand, but throwing an error makes it clear that the user has to provide the matching template
- The new error reads 'Missing template [filename].hbs for route "[route]".'
Assume you have a route.yaml file something like:
```
routes:
/: home
```
- In Ghost v2, if you don't have a home.hbs template, Ghost falls back to using the default.hbs file if it's available
- Most themes have a default.hbs, however this file is a layout file, depended on by other templates, not a template file itself
- In production mode, using the default.hbs as a template causes weird, intermittent layout issues depending on which order pages are loaded
- This is due to this issue: https://github.com/barc/express-hbs/issues/161
- In Ghost v3, we will throw a 400 error for missing template files instead of having a fallback
- In the example above, navigating to '/' would throw the error 'Missing template home.hbs for route "/".'
2019-08-05 21:34:12 +03:00
|
|
|
},
|
|
|
|
templates: ['page']
|
2019-08-09 17:25:12 +03:00
|
|
|
}
|
|
|
|
},
|
|
|
|
|
|
|
|
collections: {
|
|
|
|
'/food/': {
|
|
|
|
permalink: '/food/:slug/',
|
|
|
|
filter: 'tag:bacon+tag:-chorizo',
|
|
|
|
data: {
|
|
|
|
query: {
|
|
|
|
tag: {
|
|
|
|
controller: 'tagsPublic',
|
|
|
|
resource: 'tags',
|
|
|
|
type: 'read',
|
|
|
|
options: {
|
|
|
|
slug: 'bacon'
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
|
|
|
router: {
|
|
|
|
tags: [{redirect: true, slug: 'bacon'}]
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
|
|
|
'/sport/': {
|
|
|
|
permalink: '/sport/:slug/',
|
|
|
|
filter: 'tag:chorizo+tag:-bacon',
|
|
|
|
data: {
|
|
|
|
query: {
|
|
|
|
apollo: {
|
|
|
|
controller: 'tagsPublic',
|
|
|
|
resource: 'tags',
|
|
|
|
type: 'read',
|
|
|
|
options: {
|
|
|
|
slug: 'chorizo'
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
|
|
|
router: {
|
|
|
|
tags: [{redirect: false, slug: 'chorizo'}]
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
|
|
|
|
|
|
|
taxonomies: {
|
|
|
|
tag: '/categories/:slug/',
|
|
|
|
author: '/authors/:slug/'
|
|
|
|
}
|
|
|
|
});
|
|
|
|
|
|
|
|
testUtils.integrationTesting.urlService.resetGenerators();
|
|
|
|
testUtils.integrationTesting.defaultMocks(sinon);
|
|
|
|
|
|
|
|
return testUtils.integrationTesting.initGhost()
|
|
|
|
.then(function () {
|
|
|
|
sinon.stub(themeService.getActive(), 'engine').withArgs('ghost-api').returns('canary');
|
|
|
|
sinon.stub(themeService.getActive(), 'config').withArgs('posts_per_page').returns(2);
|
|
|
|
|
|
|
|
app = siteApp({start: true});
|
|
|
|
return testUtils.integrationTesting.urlService.waitTillFinished();
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
beforeEach(function () {
|
|
|
|
testUtils.integrationTesting.overrideGhostConfig(configUtils);
|
|
|
|
});
|
|
|
|
|
|
|
|
afterEach(function () {
|
|
|
|
configUtils.restore();
|
|
|
|
urlUtils.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
after(function () {
|
|
|
|
sinon.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve /food/', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/food/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('index');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve bacon tag', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/categories/bacon/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(301);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve /sport/', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/sport/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('index');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve chorizo tag', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/categories/chorizo/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve my-page', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/my-page/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('extended routes.yaml: templates', function () {
|
|
|
|
describe('default template, no template', function () {
|
|
|
|
before(function () {
|
|
|
|
sinon.stub(frontendSettingsService, 'get').returns({
|
|
|
|
routes: {},
|
|
|
|
|
|
|
|
collections: {
|
|
|
|
'/': {
|
|
|
|
permalink: '/:slug/',
|
|
|
|
templates: ['default']
|
|
|
|
},
|
|
|
|
'/magic/': {
|
|
|
|
permalink: '/magic/:slug/'
|
|
|
|
}
|
|
|
|
}
|
|
|
|
});
|
|
|
|
|
|
|
|
testUtils.integrationTesting.urlService.resetGenerators();
|
|
|
|
testUtils.integrationTesting.defaultMocks(sinon);
|
|
|
|
|
|
|
|
return testUtils.integrationTesting.initGhost()
|
|
|
|
.then(function () {
|
|
|
|
sinon.stub(themeService.getActive(), 'engine').withArgs('ghost-api').returns('canary');
|
|
|
|
sinon.stub(themeService.getActive(), 'config').withArgs('posts_per_page').returns(2);
|
|
|
|
|
|
|
|
app = siteApp({start: true});
|
|
|
|
return testUtils.integrationTesting.urlService.waitTillFinished();
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
beforeEach(function () {
|
|
|
|
testUtils.integrationTesting.overrideGhostConfig(configUtils);
|
|
|
|
});
|
|
|
|
|
|
|
|
afterEach(function () {
|
|
|
|
configUtils.restore();
|
|
|
|
urlUtils.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
after(function () {
|
|
|
|
sinon.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve collection', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('default');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve second collectiom', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/magic/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('index');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('two templates', function () {
|
|
|
|
before(function () {
|
|
|
|
sinon.stub(frontendSettingsService, 'get').returns({
|
|
|
|
routes: {},
|
|
|
|
|
|
|
|
collections: {
|
|
|
|
'/': {
|
|
|
|
permalink: '/:slug/',
|
|
|
|
templates: ['something', 'default']
|
|
|
|
}
|
|
|
|
}
|
|
|
|
});
|
|
|
|
|
|
|
|
testUtils.integrationTesting.urlService.resetGenerators();
|
|
|
|
testUtils.integrationTesting.defaultMocks(sinon);
|
|
|
|
|
|
|
|
return testUtils.integrationTesting.initGhost()
|
|
|
|
.then(function () {
|
|
|
|
sinon.stub(themeService.getActive(), 'engine').withArgs('ghost-api').returns('canary');
|
|
|
|
sinon.stub(themeService.getActive(), 'config').withArgs('posts_per_page').returns(2);
|
|
|
|
|
|
|
|
app = siteApp({start: true});
|
|
|
|
return testUtils.integrationTesting.urlService.waitTillFinished();
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
beforeEach(function () {
|
|
|
|
testUtils.integrationTesting.overrideGhostConfig(configUtils);
|
|
|
|
});
|
|
|
|
|
|
|
|
afterEach(function () {
|
|
|
|
configUtils.restore();
|
|
|
|
urlUtils.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
after(function () {
|
|
|
|
sinon.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve collection', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('default');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('home.hbs priority', function () {
|
|
|
|
before(function () {
|
|
|
|
sinon.stub(frontendSettingsService, 'get').returns({
|
|
|
|
routes: {},
|
|
|
|
|
|
|
|
collections: {
|
|
|
|
'/': {
|
|
|
|
permalink: '/:slug/',
|
|
|
|
templates: ['something', 'default']
|
|
|
|
},
|
|
|
|
'/magic/': {
|
|
|
|
permalink: '/magic/:slug/',
|
|
|
|
templates: ['something', 'default']
|
|
|
|
}
|
|
|
|
}
|
|
|
|
});
|
|
|
|
|
|
|
|
testUtils.integrationTesting.urlService.resetGenerators();
|
|
|
|
testUtils.integrationTesting.defaultMocks(sinon, {theme: 'test-theme'});
|
|
|
|
|
|
|
|
return testUtils.integrationTesting.initGhost()
|
|
|
|
.then(function () {
|
|
|
|
sinon.stub(themeService.getActive(), 'engine').withArgs('ghost-api').returns('canary');
|
|
|
|
sinon.stub(themeService.getActive(), 'config').withArgs('posts_per_page').returns(2);
|
|
|
|
|
|
|
|
app = siteApp({start: true});
|
|
|
|
return testUtils.integrationTesting.urlService.waitTillFinished();
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
beforeEach(function () {
|
|
|
|
testUtils.integrationTesting.overrideGhostConfig(configUtils);
|
|
|
|
});
|
|
|
|
|
|
|
|
afterEach(function () {
|
|
|
|
configUtils.restore();
|
|
|
|
urlUtils.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
after(function () {
|
|
|
|
sinon.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve collection', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('home');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve second page collection: should use index.hbs', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/magic/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('something');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('extended routes.yaml: routes', function () {
|
|
|
|
describe('channels', function () {
|
|
|
|
before(testUtils.integrationTesting.urlService.resetGenerators);
|
2020-02-24 23:51:09 +03:00
|
|
|
before(testUtils.teardownDb);
|
2019-08-09 17:25:12 +03:00
|
|
|
before(testUtils.setup('users:roles', 'posts'));
|
|
|
|
|
|
|
|
before(function () {
|
|
|
|
testUtils.integrationTesting.defaultMocks(sinon, {theme: 'test-theme-channels'});
|
|
|
|
|
|
|
|
sinon.stub(frontendSettingsService, 'get').returns({
|
|
|
|
routes: {
|
|
|
|
'/channel1/': {
|
|
|
|
controller: 'channel',
|
|
|
|
filter: 'tag:kitchen-sink',
|
|
|
|
data: {
|
|
|
|
query: {
|
|
|
|
tag: {
|
|
|
|
controller: 'tagsPublic',
|
|
|
|
resource: 'tags',
|
|
|
|
type: 'read',
|
|
|
|
options: {
|
|
|
|
slug: 'kitchen-sink'
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
|
|
|
router: {
|
|
|
|
tags: [{redirect: true, slug: 'kitchen-sink'}]
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
|
|
|
|
|
|
|
'/channel2/': {
|
|
|
|
controller: 'channel',
|
|
|
|
filter: 'tag:bacon',
|
|
|
|
data: {
|
|
|
|
query: {
|
|
|
|
tag: {
|
|
|
|
controller: 'tagsPublic',
|
|
|
|
resource: 'tags',
|
|
|
|
type: 'read',
|
|
|
|
options: {
|
|
|
|
slug: 'bacon'
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
|
|
|
router: {
|
|
|
|
tags: [{redirect: true, slug: 'bacon'}]
|
|
|
|
}
|
|
|
|
},
|
|
|
|
templates: ['default']
|
|
|
|
},
|
|
|
|
|
|
|
|
'/channel3/': {
|
|
|
|
controller: 'channel',
|
|
|
|
filter: 'author:joe-bloggs',
|
|
|
|
data: {
|
|
|
|
query: {
|
|
|
|
joe: {
|
|
|
|
controller: 'authorsPublic',
|
|
|
|
resource: 'authors',
|
|
|
|
type: 'read',
|
|
|
|
options: {
|
|
|
|
slug: 'joe-bloggs',
|
|
|
|
redirect: false
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
|
|
|
router: {
|
|
|
|
authors: [{redirect: false, slug: 'joe-bloggs'}]
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
|
|
|
|
|
|
|
'/channel4/': {
|
|
|
|
controller: 'channel',
|
|
|
|
filter: 'author:joe-bloggs'
|
|
|
|
},
|
|
|
|
|
|
|
|
'/channel5/': {
|
|
|
|
controller: 'channel',
|
|
|
|
data: {
|
|
|
|
query: {
|
|
|
|
tag: {
|
|
|
|
controller: 'authorsPublic',
|
|
|
|
resource: 'authors',
|
|
|
|
type: 'read',
|
|
|
|
options: {
|
|
|
|
slug: 'joe-bloggs',
|
|
|
|
redirect: false
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
|
|
|
router: {
|
|
|
|
authors: [{redirect: false, slug: 'joe-bloggs'}]
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
|
|
|
|
|
|
|
'/channel6/': {
|
|
|
|
controller: 'channel',
|
|
|
|
data: {
|
|
|
|
query: {
|
|
|
|
post: {
|
|
|
|
controller: 'postsPublic',
|
|
|
|
resource: 'posts',
|
|
|
|
type: 'read',
|
|
|
|
options: {
|
|
|
|
slug: 'html-ipsum',
|
|
|
|
redirect: true
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
|
|
|
router: {
|
|
|
|
posts: [{redirect: true, slug: 'html-ipsum'}]
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
|
|
|
|
|
|
|
collections: {
|
|
|
|
'/': {
|
|
|
|
permalink: '/:slug/'
|
|
|
|
}
|
|
|
|
},
|
|
|
|
|
|
|
|
taxonomies: {
|
|
|
|
tag: '/tag/:slug/',
|
|
|
|
author: '/author/:slug/'
|
|
|
|
}
|
|
|
|
});
|
|
|
|
|
|
|
|
return testUtils.integrationTesting.initGhost()
|
|
|
|
.then(function () {
|
|
|
|
sinon.stub(themeService.getActive(), 'engine').withArgs('ghost-api').returns('canary');
|
|
|
|
sinon.stub(themeService.getActive(), 'config').withArgs('posts_per_page').returns(10);
|
|
|
|
|
|
|
|
app = siteApp({start: true});
|
|
|
|
return testUtils.integrationTesting.urlService.waitTillFinished();
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
beforeEach(function () {
|
|
|
|
testUtils.integrationTesting.overrideGhostConfig(configUtils);
|
|
|
|
});
|
|
|
|
|
|
|
|
afterEach(function () {
|
|
|
|
configUtils.restore();
|
|
|
|
urlUtils.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
after(function () {
|
|
|
|
sinon.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve channel 1', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/channel1/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
const $ = cheerio.load(response.body);
|
|
|
|
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('index');
|
|
|
|
|
|
|
|
$('.post-card').length.should.equal(2);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve channel 1: rss', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/channel1/rss/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.headers['content-type'].should.eql('text/xml; charset=UTF-8');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve channel 2', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/channel2/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
const $ = cheerio.load(response.body);
|
|
|
|
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('default');
|
|
|
|
|
2020-04-08 05:26:50 +03:00
|
|
|
// default template does not list posts
|
2019-08-09 17:25:12 +03:00
|
|
|
$('.post-card').length.should.equal(0);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve channel 3', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/channel3/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
const $ = cheerio.load(response.body);
|
|
|
|
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('channel3');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve channel 4', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/channel4/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
const $ = cheerio.load(response.body);
|
|
|
|
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('index');
|
|
|
|
|
|
|
|
$('.post-card').length.should.equal(4);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve channel 5', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/channel5/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
const $ = cheerio.load(response.body);
|
|
|
|
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('index');
|
|
|
|
|
|
|
|
$('.post-card').length.should.equal(4);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve channel 6', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/channel6/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
const $ = cheerio.load(response.body);
|
|
|
|
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('index');
|
|
|
|
|
|
|
|
$('.post-card').length.should.equal(4);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve kitching-sink: redirect', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/tag/kitchen-sink/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(301);
|
|
|
|
response.headers.location.should.eql('/channel1/');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve html-ipsum: redirect', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/html-ipsum/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(301);
|
|
|
|
response.headers.location.should.eql('/channel6/');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve chorizo: no redirect', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/tag/chorizo/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve joe-bloggs', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/author/joe-bloggs/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-08-09 17:25:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('extended routes.yaml (5): rss override', function () {
|
|
|
|
before(function () {
|
|
|
|
sinon.stub(frontendSettingsService, 'get').returns({
|
|
|
|
routes: {
|
|
|
|
'/podcast/rss/': {
|
|
|
|
templates: ['podcast/rss'],
|
|
|
|
content_type: 'text/xml'
|
|
|
|
},
|
|
|
|
'/cooking/': {
|
|
|
|
controller: 'channel',
|
|
|
|
rss: false
|
|
|
|
},
|
|
|
|
'/flat/': {
|
|
|
|
controller: 'channel'
|
|
|
|
}
|
|
|
|
},
|
|
|
|
|
|
|
|
collections: {
|
|
|
|
'/podcast/': {
|
|
|
|
permalink: '/:slug/',
|
|
|
|
filter: 'featured:true',
|
|
|
|
templates: ['home'],
|
|
|
|
rss: false
|
|
|
|
},
|
|
|
|
'/music/': {
|
|
|
|
permalink: '/:slug/',
|
|
|
|
rss: false
|
|
|
|
},
|
|
|
|
'/': {
|
|
|
|
permalink: '/:slug/'
|
|
|
|
}
|
|
|
|
},
|
|
|
|
|
|
|
|
taxonomies: {}
|
|
|
|
});
|
|
|
|
|
|
|
|
testUtils.integrationTesting.urlService.resetGenerators();
|
|
|
|
testUtils.integrationTesting.defaultMocks(sinon, {theme: 'test-theme'});
|
|
|
|
|
|
|
|
return testUtils.integrationTesting.initGhost()
|
|
|
|
.then(function () {
|
|
|
|
sinon.stub(themeService.getActive(), 'engine').withArgs('ghost-api').returns('canary');
|
|
|
|
sinon.stub(themeService.getActive(), 'config').withArgs('posts_per_page').returns(2);
|
|
|
|
|
|
|
|
app = siteApp({start: true});
|
|
|
|
return testUtils.integrationTesting.urlService.waitTillFinished();
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
beforeEach(function () {
|
|
|
|
testUtils.integrationTesting.overrideGhostConfig(configUtils);
|
|
|
|
});
|
|
|
|
|
|
|
|
afterEach(function () {
|
|
|
|
configUtils.restore();
|
|
|
|
urlUtils.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
after(function () {
|
|
|
|
sinon.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve /rss/', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
2019-09-03 10:03:31 +03:00
|
|
|
url: '/rss/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve /music/rss/', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/music/rss/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(404);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve /cooking/rss/', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/cooking/rss/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(404);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve /flat/rss/', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/flat/rss/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve /podcast/rss/', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/podcast/rss/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('podcast/rss');
|
|
|
|
response.headers['content-type'].should.eql('text/xml; charset=utf-8');
|
|
|
|
response.body.match(/<link>/g).length.should.eql(2);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve /podcast/', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/podcast/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
const $ = cheerio.load(response.body);
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
$('head link')[2].attribs.href.should.eql('https://127.0.0.1:2369/rss/');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('v3', function () {
|
|
|
|
let postSpy;
|
|
|
|
|
|
|
|
describe('default routes.yaml', function () {
|
|
|
|
before(function () {
|
|
|
|
testUtils.integrationTesting.urlService.resetGenerators();
|
2020-03-19 18:23:10 +03:00
|
|
|
testUtils.integrationTesting.defaultMocks(sinon, {amp: true});
|
2019-09-03 10:03:31 +03:00
|
|
|
testUtils.integrationTesting.overrideGhostConfig(configUtils);
|
|
|
|
|
|
|
|
return testUtils.integrationTesting.initGhost()
|
|
|
|
.then(function () {
|
|
|
|
sinon.stub(themeService.getActive(), 'engine').withArgs('ghost-api').returns('v3');
|
|
|
|
sinon.stub(themeService.getActive(), 'config').withArgs('posts_per_page').returns(2);
|
|
|
|
|
|
|
|
app = siteApp({start: true});
|
|
|
|
return testUtils.integrationTesting.urlService.waitTillFinished();
|
2020-03-20 11:58:26 +03:00
|
|
|
})
|
|
|
|
.then(() => {
|
2020-03-23 22:43:01 +03:00
|
|
|
return appService.init();
|
2019-09-03 10:03:31 +03:00
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
before(function () {
|
|
|
|
configUtils.set('url', 'http://example.com');
|
|
|
|
urlUtils.stubUrlUtilsFromConfig();
|
|
|
|
});
|
|
|
|
|
|
|
|
beforeEach(function () {
|
2020-03-30 18:26:47 +03:00
|
|
|
const postsAPI = require('../../../core/server/api/canary/posts-public');
|
2019-09-03 10:03:31 +03:00
|
|
|
postSpy = sinon.spy(postsAPI.browse, 'query');
|
|
|
|
});
|
|
|
|
|
|
|
|
afterEach(function () {
|
|
|
|
postSpy.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
after(function () {
|
|
|
|
configUtils.restore();
|
|
|
|
urlUtils.restore();
|
|
|
|
sinon.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('behaviour: default cases', function () {
|
|
|
|
it('serve post', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/html-ipsum/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('post');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve amp', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/html-ipsum/amp/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.match(/amp\.hbs/);
|
|
|
|
response.body.should.match(/<h1>HTML Ipsum Presents<\/h1>/);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('post not found', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/not-found/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(404);
|
|
|
|
response.template.should.eql('error-404');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve static page', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/static-page-test/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('page');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve author', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/author/joe-bloggs/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
const $ = cheerio.load(response.body);
|
|
|
|
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('author');
|
|
|
|
|
|
|
|
$('.author-bio').length.should.equal(1);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve tag', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/tag/bacon/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('tag');
|
|
|
|
|
2019-09-16 13:51:54 +03:00
|
|
|
postSpy.args[0][0].options.filter.should.eql('(tags:\'bacon\'+tags.visibility:public)+type:post');
|
2019-09-03 10:03:31 +03:00
|
|
|
postSpy.args[0][0].options.page.should.eql(1);
|
|
|
|
postSpy.args[0][0].options.limit.should.eql(2);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve tag rss', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/tag/bacon/rss/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve collection', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
const $ = cheerio.load(response.body);
|
|
|
|
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('index');
|
|
|
|
|
|
|
|
$('.post-card').length.should.equal(2);
|
|
|
|
|
|
|
|
should.exist(response.res.locals.context);
|
|
|
|
should.exist(response.res.locals.version);
|
|
|
|
should.exist(response.res.locals.safeVersion);
|
|
|
|
should.exist(response.res.locals.safeVersion);
|
|
|
|
should.exist(response.res.locals.relativeUrl);
|
|
|
|
should.exist(response.res.locals.secure);
|
|
|
|
should.exist(response.res.routerOptions);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve collection: page 2', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/page/2/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
const $ = cheerio.load(response.body);
|
|
|
|
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('index');
|
|
|
|
|
|
|
|
$('.post-card').length.should.equal(2);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve theme asset', function () {
|
|
|
|
//configUtils.set('url', 'https://example.com');
|
|
|
|
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/assets/css/screen.css',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('behaviour: prettify', function () {
|
|
|
|
it('url without slash', function () {
|
|
|
|
const req = {
|
|
|
|
secure: false,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/prettify-me',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(301);
|
|
|
|
response.headers.location.should.eql('/prettify-me/');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('behaviour: url redirects', function () {
|
|
|
|
describe('pagination', function () {
|
|
|
|
it('redirect /page/1/ to /', function () {
|
|
|
|
const req = {
|
|
|
|
secure: false,
|
|
|
|
host: 'example.com',
|
|
|
|
method: 'GET',
|
|
|
|
url: '/page/1/'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(301);
|
|
|
|
response.headers.location.should.eql('/');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('rss', function () {
|
|
|
|
it('redirect /feed/ to /rss/', function () {
|
|
|
|
const req = {
|
|
|
|
secure: false,
|
|
|
|
host: 'example.com',
|
|
|
|
method: 'GET',
|
|
|
|
url: '/feed/'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(301);
|
|
|
|
response.headers.location.should.eql('/rss/');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('https', function () {
|
|
|
|
before(function () {
|
|
|
|
configUtils.set('url', 'https://example.com');
|
|
|
|
urlUtils.stubUrlUtilsFromConfig();
|
|
|
|
});
|
|
|
|
|
|
|
|
after(function () {
|
|
|
|
urlUtils.restore();
|
|
|
|
configUtils.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('protocol', function () {
|
|
|
|
it('blog is https, request is http', function () {
|
|
|
|
const req = {
|
|
|
|
secure: false,
|
|
|
|
host: 'example.com',
|
|
|
|
method: 'GET',
|
|
|
|
url: '/html-ipsum'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(301);
|
|
|
|
response.headers.location.should.eql('https://example.com/html-ipsum/');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('blog is https, request is http, trailing slash exists already', function () {
|
|
|
|
const req = {
|
|
|
|
secure: false,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/html-ipsum/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(301);
|
|
|
|
response.headers.location.should.eql('https://example.com/html-ipsum/');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('assets', function () {
|
|
|
|
it('blog is https, request is http', function () {
|
|
|
|
const req = {
|
|
|
|
secure: false,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/favicon.png',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(301);
|
|
|
|
response.headers.location.should.eql('https://example.com/favicon.png');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('blog is https, request is http', function () {
|
|
|
|
const req = {
|
|
|
|
secure: false,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/assets/css/main.css',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(301);
|
|
|
|
response.headers.location.should.eql('https://example.com/assets/css/main.css');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('extended routes.yaml: collections', function () {
|
|
|
|
describe('2 collections', function () {
|
|
|
|
before(function () {
|
|
|
|
sinon.stub(frontendSettingsService, 'get').returns({
|
|
|
|
routes: {
|
2019-09-10 12:41:42 +03:00
|
|
|
'/': {
|
|
|
|
templates: ['home']
|
|
|
|
}
|
2019-09-03 10:03:31 +03:00
|
|
|
},
|
|
|
|
|
|
|
|
collections: {
|
|
|
|
'/podcast/': {
|
|
|
|
permalink: '/podcast/:slug/',
|
|
|
|
filter: 'featured:true'
|
|
|
|
},
|
|
|
|
|
|
|
|
'/something/': {
|
|
|
|
permalink: '/something/:slug/',
|
|
|
|
filter: 'featured:false'
|
|
|
|
}
|
|
|
|
},
|
|
|
|
|
|
|
|
taxonomies: {
|
|
|
|
tag: '/categories/:slug/',
|
|
|
|
author: '/authors/:slug/'
|
|
|
|
}
|
|
|
|
});
|
|
|
|
|
|
|
|
testUtils.integrationTesting.urlService.resetGenerators();
|
2019-09-10 12:41:42 +03:00
|
|
|
testUtils.integrationTesting.defaultMocks(sinon, {theme: 'test-theme'});
|
2019-09-03 10:03:31 +03:00
|
|
|
|
|
|
|
return testUtils.integrationTesting.initGhost()
|
|
|
|
.then(function () {
|
|
|
|
sinon.stub(themeService.getActive(), 'engine').withArgs('ghost-api').returns('v3');
|
|
|
|
sinon.stub(themeService.getActive(), 'config').withArgs('posts_per_page').returns(2);
|
|
|
|
|
|
|
|
app = siteApp({start: true});
|
|
|
|
return testUtils.integrationTesting.urlService.waitTillFinished();
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
beforeEach(function () {
|
|
|
|
testUtils.integrationTesting.overrideGhostConfig(configUtils);
|
|
|
|
});
|
|
|
|
|
|
|
|
afterEach(function () {
|
|
|
|
configUtils.restore();
|
|
|
|
urlUtils.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
after(function () {
|
|
|
|
sinon.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve static route', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
2019-09-10 12:41:42 +03:00
|
|
|
response.template.should.eql('home');
|
2019-09-03 10:03:31 +03:00
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve rss', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/podcast/rss/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve post', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/something/html-ipsum/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('post');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve collection: podcast', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/podcast/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
const $ = cheerio.load(response.body);
|
|
|
|
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('index');
|
|
|
|
|
|
|
|
$('.post-card').length.should.equal(2);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
2019-09-10 12:41:42 +03:00
|
|
|
it('serve collection: something with custom template', function () {
|
2019-09-03 10:03:31 +03:00
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/something/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
const $ = cheerio.load(response.body);
|
|
|
|
|
|
|
|
response.statusCode.should.eql(200);
|
2019-09-10 12:41:42 +03:00
|
|
|
response.template.should.eql('something');
|
2019-09-03 10:03:31 +03:00
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('no collections', function () {
|
|
|
|
before(function () {
|
|
|
|
sinon.stub(frontendSettingsService, 'get').returns({
|
|
|
|
routes: {
|
2019-09-10 12:41:42 +03:00
|
|
|
'/something/': {templates: ['something']}
|
2019-09-03 10:03:31 +03:00
|
|
|
},
|
|
|
|
collections: {},
|
|
|
|
taxonomies: {}
|
|
|
|
});
|
|
|
|
|
|
|
|
testUtils.integrationTesting.urlService.resetGenerators();
|
2019-09-10 12:41:42 +03:00
|
|
|
testUtils.integrationTesting.defaultMocks(sinon, {theme: 'test-theme'});
|
2019-09-03 10:03:31 +03:00
|
|
|
|
|
|
|
return testUtils.integrationTesting.initGhost()
|
|
|
|
.then(function () {
|
|
|
|
sinon.stub(themeService.getActive(), 'engine').withArgs('ghost-api').returns('v3');
|
|
|
|
sinon.stub(themeService.getActive(), 'config').withArgs('posts_per_page').returns(2);
|
|
|
|
|
|
|
|
app = siteApp({start: true});
|
|
|
|
return testUtils.integrationTesting.urlService.waitTillFinished();
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
beforeEach(function () {
|
|
|
|
testUtils.integrationTesting.overrideGhostConfig(configUtils);
|
|
|
|
});
|
|
|
|
|
|
|
|
afterEach(function () {
|
|
|
|
configUtils.restore();
|
|
|
|
urlUtils.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
after(function () {
|
|
|
|
sinon.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve route', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
2019-09-10 12:41:42 +03:00
|
|
|
url: '/something/',
|
2019-09-03 10:03:31 +03:00
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
2019-09-10 12:41:42 +03:00
|
|
|
response.template.should.eql('something');
|
2019-09-03 10:03:31 +03:00
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('static permalink route', function () {
|
|
|
|
before(function () {
|
|
|
|
sinon.stub(frontendSettingsService, 'get').returns({
|
|
|
|
routes: {},
|
|
|
|
|
|
|
|
collections: {
|
|
|
|
'/podcast/': {
|
|
|
|
permalink: '/featured/',
|
|
|
|
filter: 'featured:true'
|
|
|
|
},
|
|
|
|
|
|
|
|
'/': {
|
|
|
|
permalink: '/:slug/'
|
|
|
|
}
|
|
|
|
},
|
|
|
|
|
|
|
|
taxonomies: {}
|
|
|
|
});
|
|
|
|
|
|
|
|
testUtils.integrationTesting.urlService.resetGenerators();
|
|
|
|
testUtils.integrationTesting.defaultMocks(sinon);
|
|
|
|
|
|
|
|
return testUtils.integrationTesting.initGhost()
|
|
|
|
.then(function () {
|
|
|
|
sinon.stub(themeService.getActive(), 'engine').withArgs('ghost-api').returns('v3');
|
|
|
|
sinon.stub(themeService.getActive(), 'config').withArgs('posts_per_page').returns(2);
|
|
|
|
|
|
|
|
app = siteApp({start: true});
|
|
|
|
return testUtils.integrationTesting.urlService.waitTillFinished();
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
beforeEach(function () {
|
|
|
|
testUtils.integrationTesting.overrideGhostConfig(configUtils);
|
|
|
|
});
|
|
|
|
|
|
|
|
afterEach(function () {
|
|
|
|
configUtils.restore();
|
|
|
|
urlUtils.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
after(function () {
|
|
|
|
sinon.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve post', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/featured/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
// We can't find a post with the slug "featured"
|
|
|
|
response.statusCode.should.eql(404);
|
|
|
|
response.template.should.eql('error-404');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve post', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/html-ipsum/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('post');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve author', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/author/joe-bloggs/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(404);
|
|
|
|
response.template.should.eql('error-404');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve tag', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/tag/bacon/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(404);
|
|
|
|
response.template.should.eql('error-404');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('primary author permalink', function () {
|
|
|
|
before(function () {
|
|
|
|
sinon.stub(frontendSettingsService, 'get').returns({
|
|
|
|
routes: {},
|
|
|
|
|
|
|
|
collections: {
|
|
|
|
'/something/': {
|
|
|
|
permalink: '/:primary_author/:slug/'
|
|
|
|
}
|
|
|
|
},
|
|
|
|
|
|
|
|
taxonomies: {}
|
|
|
|
});
|
|
|
|
|
|
|
|
testUtils.integrationTesting.urlService.resetGenerators();
|
|
|
|
testUtils.integrationTesting.defaultMocks(sinon);
|
|
|
|
|
|
|
|
return testUtils.integrationTesting.initGhost()
|
|
|
|
.then(function () {
|
|
|
|
sinon.stub(themeService.getActive(), 'engine').withArgs('ghost-api').returns('v3');
|
|
|
|
sinon.stub(themeService.getActive(), 'config').withArgs('posts_per_page').returns(2);
|
|
|
|
|
|
|
|
app = siteApp({start: true});
|
|
|
|
return testUtils.integrationTesting.urlService.waitTillFinished();
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
beforeEach(function () {
|
|
|
|
testUtils.integrationTesting.overrideGhostConfig(configUtils);
|
|
|
|
});
|
|
|
|
|
|
|
|
afterEach(function () {
|
|
|
|
configUtils.restore();
|
|
|
|
urlUtils.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
after(function () {
|
|
|
|
sinon.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve post', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/joe-bloggs/html-ipsum/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('post');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('post without author', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/html-ipsum/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(404);
|
|
|
|
response.template.should.eql('error-404');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('page', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/static-page-test/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('page');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('primary tag permalink', function () {
|
|
|
|
before(function () {
|
|
|
|
sinon.stub(frontendSettingsService, 'get').returns({
|
|
|
|
routes: {},
|
|
|
|
|
|
|
|
collections: {
|
|
|
|
'/something/': {
|
|
|
|
permalink: '/something/:primary_tag/:slug/'
|
|
|
|
}
|
|
|
|
},
|
|
|
|
|
|
|
|
taxonomies: {}
|
|
|
|
});
|
|
|
|
|
|
|
|
testUtils.integrationTesting.urlService.resetGenerators();
|
|
|
|
testUtils.integrationTesting.defaultMocks(sinon);
|
|
|
|
|
|
|
|
return testUtils.integrationTesting.initGhost()
|
|
|
|
.then(function () {
|
|
|
|
sinon.stub(themeService.getActive(), 'engine').withArgs('ghost-api').returns('v3');
|
|
|
|
sinon.stub(themeService.getActive(), 'config').withArgs('posts_per_page').returns(2);
|
|
|
|
|
|
|
|
app = siteApp({start: true});
|
|
|
|
return testUtils.integrationTesting.urlService.waitTillFinished();
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
beforeEach(function () {
|
|
|
|
testUtils.integrationTesting.overrideGhostConfig(configUtils);
|
|
|
|
});
|
|
|
|
|
|
|
|
afterEach(function () {
|
|
|
|
configUtils.restore();
|
|
|
|
urlUtils.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
after(function () {
|
|
|
|
sinon.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve post', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/something/kitchen-sink/html-ipsum/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('post');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('post without tag', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/something/html-ipsum/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(404);
|
|
|
|
response.template.should.eql('error-404');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('post without tag', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/html-ipsum/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(404);
|
|
|
|
response.template.should.eql('error-404');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('page', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/static-page-test/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('page');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('collection/routes with data key', function () {
|
|
|
|
before(function () {
|
|
|
|
sinon.stub(frontendSettingsService, 'get').returns({
|
|
|
|
routes: {
|
|
|
|
'/my-page/': {
|
|
|
|
data: {
|
|
|
|
query: {
|
|
|
|
page: {
|
|
|
|
controller: 'pagesPublic',
|
|
|
|
resource: 'pages',
|
|
|
|
type: 'read',
|
|
|
|
options: {
|
|
|
|
slug: 'static-page-test'
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
|
|
|
router: {
|
|
|
|
pages: [{redirect: true, slug: 'static-page-test'}]
|
|
|
|
}
|
2019-09-10 12:41:42 +03:00
|
|
|
},
|
|
|
|
templates: ['page']
|
2019-09-03 10:03:31 +03:00
|
|
|
}
|
|
|
|
},
|
|
|
|
|
|
|
|
collections: {
|
|
|
|
'/food/': {
|
|
|
|
permalink: '/food/:slug/',
|
|
|
|
filter: 'tag:bacon+tag:-chorizo',
|
|
|
|
data: {
|
|
|
|
query: {
|
|
|
|
tag: {
|
|
|
|
controller: 'tagsPublic',
|
|
|
|
resource: 'tags',
|
|
|
|
type: 'read',
|
|
|
|
options: {
|
|
|
|
slug: 'bacon'
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
|
|
|
router: {
|
|
|
|
tags: [{redirect: true, slug: 'bacon'}]
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
|
|
|
'/sport/': {
|
|
|
|
permalink: '/sport/:slug/',
|
|
|
|
filter: 'tag:chorizo+tag:-bacon',
|
|
|
|
data: {
|
|
|
|
query: {
|
|
|
|
apollo: {
|
|
|
|
controller: 'tagsPublic',
|
|
|
|
resource: 'tags',
|
|
|
|
type: 'read',
|
|
|
|
options: {
|
|
|
|
slug: 'chorizo'
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
|
|
|
router: {
|
|
|
|
tags: [{redirect: false, slug: 'chorizo'}]
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
|
|
|
|
|
|
|
taxonomies: {
|
|
|
|
tag: '/categories/:slug/',
|
|
|
|
author: '/authors/:slug/'
|
|
|
|
}
|
|
|
|
});
|
|
|
|
|
|
|
|
testUtils.integrationTesting.urlService.resetGenerators();
|
|
|
|
testUtils.integrationTesting.defaultMocks(sinon);
|
|
|
|
|
|
|
|
return testUtils.integrationTesting.initGhost()
|
|
|
|
.then(function () {
|
|
|
|
sinon.stub(themeService.getActive(), 'engine').withArgs('ghost-api').returns('v3');
|
|
|
|
sinon.stub(themeService.getActive(), 'config').withArgs('posts_per_page').returns(2);
|
|
|
|
|
|
|
|
app = siteApp({start: true});
|
|
|
|
return testUtils.integrationTesting.urlService.waitTillFinished();
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
beforeEach(function () {
|
|
|
|
testUtils.integrationTesting.overrideGhostConfig(configUtils);
|
|
|
|
});
|
|
|
|
|
|
|
|
afterEach(function () {
|
|
|
|
configUtils.restore();
|
|
|
|
urlUtils.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
after(function () {
|
|
|
|
sinon.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve /food/', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/food/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('index');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve bacon tag', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/categories/bacon/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(301);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve /sport/', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/sport/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('index');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve chorizo tag', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/categories/chorizo/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve my-page', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/my-page/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('extended routes.yaml: templates', function () {
|
|
|
|
describe('default template, no template', function () {
|
|
|
|
before(function () {
|
|
|
|
sinon.stub(frontendSettingsService, 'get').returns({
|
|
|
|
routes: {},
|
|
|
|
|
|
|
|
collections: {
|
|
|
|
'/': {
|
|
|
|
permalink: '/:slug/',
|
|
|
|
templates: ['default']
|
|
|
|
},
|
|
|
|
'/magic/': {
|
|
|
|
permalink: '/magic/:slug/'
|
|
|
|
}
|
|
|
|
}
|
|
|
|
});
|
|
|
|
|
|
|
|
testUtils.integrationTesting.urlService.resetGenerators();
|
|
|
|
testUtils.integrationTesting.defaultMocks(sinon);
|
|
|
|
|
|
|
|
return testUtils.integrationTesting.initGhost()
|
|
|
|
.then(function () {
|
|
|
|
sinon.stub(themeService.getActive(), 'engine').withArgs('ghost-api').returns('v3');
|
|
|
|
sinon.stub(themeService.getActive(), 'config').withArgs('posts_per_page').returns(2);
|
|
|
|
|
|
|
|
app = siteApp({start: true});
|
|
|
|
return testUtils.integrationTesting.urlService.waitTillFinished();
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
beforeEach(function () {
|
|
|
|
testUtils.integrationTesting.overrideGhostConfig(configUtils);
|
|
|
|
});
|
|
|
|
|
|
|
|
afterEach(function () {
|
|
|
|
configUtils.restore();
|
|
|
|
urlUtils.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
after(function () {
|
|
|
|
sinon.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve collection', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('default');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve second collectiom', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/magic/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('index');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('two templates', function () {
|
|
|
|
before(function () {
|
|
|
|
sinon.stub(frontendSettingsService, 'get').returns({
|
|
|
|
routes: {},
|
|
|
|
|
|
|
|
collections: {
|
|
|
|
'/': {
|
|
|
|
permalink: '/:slug/',
|
|
|
|
templates: ['something', 'default']
|
|
|
|
}
|
|
|
|
}
|
|
|
|
});
|
|
|
|
|
|
|
|
testUtils.integrationTesting.urlService.resetGenerators();
|
|
|
|
testUtils.integrationTesting.defaultMocks(sinon);
|
|
|
|
|
|
|
|
return testUtils.integrationTesting.initGhost()
|
|
|
|
.then(function () {
|
|
|
|
sinon.stub(themeService.getActive(), 'engine').withArgs('ghost-api').returns('v3');
|
|
|
|
sinon.stub(themeService.getActive(), 'config').withArgs('posts_per_page').returns(2);
|
|
|
|
|
|
|
|
app = siteApp({start: true});
|
|
|
|
return testUtils.integrationTesting.urlService.waitTillFinished();
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
beforeEach(function () {
|
|
|
|
testUtils.integrationTesting.overrideGhostConfig(configUtils);
|
|
|
|
});
|
|
|
|
|
|
|
|
afterEach(function () {
|
|
|
|
configUtils.restore();
|
|
|
|
urlUtils.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
after(function () {
|
|
|
|
sinon.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve collection', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('default');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('home.hbs priority', function () {
|
|
|
|
before(function () {
|
|
|
|
sinon.stub(frontendSettingsService, 'get').returns({
|
|
|
|
routes: {},
|
|
|
|
|
|
|
|
collections: {
|
|
|
|
'/': {
|
|
|
|
permalink: '/:slug/',
|
|
|
|
templates: ['something', 'default']
|
|
|
|
},
|
|
|
|
'/magic/': {
|
|
|
|
permalink: '/magic/:slug/',
|
|
|
|
templates: ['something', 'default']
|
|
|
|
}
|
|
|
|
}
|
|
|
|
});
|
|
|
|
|
|
|
|
testUtils.integrationTesting.urlService.resetGenerators();
|
|
|
|
testUtils.integrationTesting.defaultMocks(sinon, {theme: 'test-theme'});
|
|
|
|
|
|
|
|
return testUtils.integrationTesting.initGhost()
|
|
|
|
.then(function () {
|
|
|
|
sinon.stub(themeService.getActive(), 'engine').withArgs('ghost-api').returns('v3');
|
|
|
|
sinon.stub(themeService.getActive(), 'config').withArgs('posts_per_page').returns(2);
|
|
|
|
|
|
|
|
app = siteApp({start: true});
|
|
|
|
return testUtils.integrationTesting.urlService.waitTillFinished();
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
beforeEach(function () {
|
|
|
|
testUtils.integrationTesting.overrideGhostConfig(configUtils);
|
|
|
|
});
|
|
|
|
|
|
|
|
afterEach(function () {
|
|
|
|
configUtils.restore();
|
|
|
|
urlUtils.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
after(function () {
|
|
|
|
sinon.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve collection', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('home');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve second page collection: should use index.hbs', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/magic/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('something');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('extended routes.yaml: routes', function () {
|
|
|
|
describe('channels', function () {
|
|
|
|
before(testUtils.integrationTesting.urlService.resetGenerators);
|
2020-02-24 23:51:09 +03:00
|
|
|
before(testUtils.teardownDb);
|
2019-09-03 10:03:31 +03:00
|
|
|
before(testUtils.setup('users:roles', 'posts'));
|
|
|
|
|
|
|
|
before(function () {
|
|
|
|
testUtils.integrationTesting.defaultMocks(sinon, {theme: 'test-theme-channels'});
|
|
|
|
|
|
|
|
sinon.stub(frontendSettingsService, 'get').returns({
|
|
|
|
routes: {
|
|
|
|
'/channel1/': {
|
|
|
|
controller: 'channel',
|
|
|
|
filter: 'tag:kitchen-sink',
|
|
|
|
data: {
|
|
|
|
query: {
|
|
|
|
tag: {
|
|
|
|
controller: 'tagsPublic',
|
|
|
|
resource: 'tags',
|
|
|
|
type: 'read',
|
|
|
|
options: {
|
|
|
|
slug: 'kitchen-sink'
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
|
|
|
router: {
|
|
|
|
tags: [{redirect: true, slug: 'kitchen-sink'}]
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
|
|
|
|
|
|
|
'/channel2/': {
|
|
|
|
controller: 'channel',
|
|
|
|
filter: 'tag:bacon',
|
|
|
|
data: {
|
|
|
|
query: {
|
|
|
|
tag: {
|
|
|
|
controller: 'tagsPublic',
|
|
|
|
resource: 'tags',
|
|
|
|
type: 'read',
|
|
|
|
options: {
|
|
|
|
slug: 'bacon'
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
|
|
|
router: {
|
|
|
|
tags: [{redirect: true, slug: 'bacon'}]
|
|
|
|
}
|
|
|
|
},
|
|
|
|
templates: ['default']
|
|
|
|
},
|
|
|
|
|
|
|
|
'/channel3/': {
|
|
|
|
controller: 'channel',
|
|
|
|
filter: 'author:joe-bloggs',
|
|
|
|
data: {
|
|
|
|
query: {
|
|
|
|
joe: {
|
|
|
|
controller: 'authorsPublic',
|
|
|
|
resource: 'authors',
|
|
|
|
type: 'read',
|
|
|
|
options: {
|
|
|
|
slug: 'joe-bloggs',
|
|
|
|
redirect: false
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
|
|
|
router: {
|
|
|
|
authors: [{redirect: false, slug: 'joe-bloggs'}]
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
|
|
|
|
|
|
|
'/channel4/': {
|
|
|
|
controller: 'channel',
|
|
|
|
filter: 'author:joe-bloggs'
|
|
|
|
},
|
|
|
|
|
|
|
|
'/channel5/': {
|
|
|
|
controller: 'channel',
|
|
|
|
data: {
|
|
|
|
query: {
|
|
|
|
tag: {
|
|
|
|
controller: 'authorsPublic',
|
|
|
|
resource: 'authors',
|
|
|
|
type: 'read',
|
|
|
|
options: {
|
|
|
|
slug: 'joe-bloggs',
|
|
|
|
redirect: false
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
|
|
|
router: {
|
|
|
|
authors: [{redirect: false, slug: 'joe-bloggs'}]
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
|
|
|
|
|
|
|
'/channel6/': {
|
|
|
|
controller: 'channel',
|
|
|
|
data: {
|
|
|
|
query: {
|
|
|
|
post: {
|
|
|
|
controller: 'postsPublic',
|
|
|
|
resource: 'posts',
|
|
|
|
type: 'read',
|
|
|
|
options: {
|
|
|
|
slug: 'html-ipsum',
|
|
|
|
redirect: true
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
|
|
|
router: {
|
|
|
|
posts: [{redirect: true, slug: 'html-ipsum'}]
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
|
|
|
|
|
|
|
collections: {
|
|
|
|
'/': {
|
|
|
|
permalink: '/:slug/'
|
|
|
|
}
|
|
|
|
},
|
|
|
|
|
|
|
|
taxonomies: {
|
|
|
|
tag: '/tag/:slug/',
|
|
|
|
author: '/author/:slug/'
|
|
|
|
}
|
|
|
|
});
|
|
|
|
|
|
|
|
return testUtils.integrationTesting.initGhost()
|
|
|
|
.then(function () {
|
|
|
|
sinon.stub(themeService.getActive(), 'engine').withArgs('ghost-api').returns('v3');
|
|
|
|
sinon.stub(themeService.getActive(), 'config').withArgs('posts_per_page').returns(10);
|
|
|
|
|
|
|
|
app = siteApp({start: true});
|
|
|
|
return testUtils.integrationTesting.urlService.waitTillFinished();
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
beforeEach(function () {
|
|
|
|
testUtils.integrationTesting.overrideGhostConfig(configUtils);
|
|
|
|
});
|
|
|
|
|
|
|
|
afterEach(function () {
|
|
|
|
configUtils.restore();
|
|
|
|
urlUtils.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
after(function () {
|
|
|
|
sinon.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve channel 1', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/channel1/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
const $ = cheerio.load(response.body);
|
|
|
|
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('index');
|
|
|
|
|
|
|
|
$('.post-card').length.should.equal(2);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve channel 1: rss', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/channel1/rss/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.headers['content-type'].should.eql('text/xml; charset=UTF-8');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve channel 2', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/channel2/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
const $ = cheerio.load(response.body);
|
|
|
|
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('default');
|
|
|
|
|
2020-04-08 05:26:50 +03:00
|
|
|
// default template does not list posts
|
2019-09-03 10:03:31 +03:00
|
|
|
$('.post-card').length.should.equal(0);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve channel 3', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/channel3/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
const $ = cheerio.load(response.body);
|
|
|
|
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('channel3');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve channel 4', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/channel4/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
const $ = cheerio.load(response.body);
|
|
|
|
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('index');
|
|
|
|
|
|
|
|
$('.post-card').length.should.equal(4);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve channel 5', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/channel5/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
const $ = cheerio.load(response.body);
|
|
|
|
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('index');
|
|
|
|
|
|
|
|
$('.post-card').length.should.equal(4);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve channel 6', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/channel6/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
const $ = cheerio.load(response.body);
|
|
|
|
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
response.template.should.eql('index');
|
|
|
|
|
|
|
|
$('.post-card').length.should.equal(4);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve kitching-sink: redirect', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/tag/kitchen-sink/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(301);
|
|
|
|
response.headers.location.should.eql('/channel1/');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve html-ipsum: redirect', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/html-ipsum/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(301);
|
|
|
|
response.headers.location.should.eql('/channel6/');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve chorizo: no redirect', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/tag/chorizo/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve joe-bloggs', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/author/joe-bloggs/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-03 10:03:31 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('extended routes.yaml (5): rss override', function () {
|
|
|
|
before(function () {
|
|
|
|
sinon.stub(frontendSettingsService, 'get').returns({
|
|
|
|
routes: {
|
|
|
|
'/about/': 'about',
|
|
|
|
'/podcast/rss/': {
|
|
|
|
templates: ['podcast/rss'],
|
|
|
|
content_type: 'text/xml'
|
|
|
|
},
|
|
|
|
'/cooking/': {
|
|
|
|
controller: 'channel',
|
|
|
|
rss: false
|
|
|
|
},
|
|
|
|
'/flat/': {
|
|
|
|
controller: 'channel'
|
|
|
|
}
|
|
|
|
},
|
|
|
|
|
|
|
|
collections: {
|
|
|
|
'/podcast/': {
|
|
|
|
permalink: '/:slug/',
|
|
|
|
filter: 'featured:true',
|
|
|
|
templates: ['home'],
|
|
|
|
rss: false
|
|
|
|
},
|
|
|
|
'/music/': {
|
|
|
|
permalink: '/:slug/',
|
|
|
|
rss: false
|
|
|
|
},
|
|
|
|
'/': {
|
|
|
|
permalink: '/:slug/'
|
|
|
|
}
|
|
|
|
},
|
|
|
|
|
|
|
|
taxonomies: {}
|
|
|
|
});
|
|
|
|
|
|
|
|
testUtils.integrationTesting.urlService.resetGenerators();
|
|
|
|
testUtils.integrationTesting.defaultMocks(sinon, {theme: 'test-theme'});
|
|
|
|
|
|
|
|
return testUtils.integrationTesting.initGhost()
|
|
|
|
.then(function () {
|
|
|
|
sinon.stub(themeService.getActive(), 'engine').withArgs('ghost-api').returns('v3');
|
|
|
|
sinon.stub(themeService.getActive(), 'config').withArgs('posts_per_page').returns(2);
|
|
|
|
|
|
|
|
app = siteApp({start: true});
|
|
|
|
return testUtils.integrationTesting.urlService.waitTillFinished();
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
beforeEach(function () {
|
|
|
|
testUtils.integrationTesting.overrideGhostConfig(configUtils);
|
|
|
|
});
|
|
|
|
|
|
|
|
afterEach(function () {
|
|
|
|
configUtils.restore();
|
|
|
|
urlUtils.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
after(function () {
|
|
|
|
sinon.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
it('serve /rss/', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
2019-01-04 23:59:39 +03:00
|
|
|
url: '/rss/',
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
it('serve /music/rss/', function () {
|
2018-06-24 01:32:08 +03:00
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
2019-01-04 23:59:39 +03:00
|
|
|
url: '/music/rss/',
|
2018-06-24 01:32:08 +03:00
|
|
|
host: 'example.com'
|
|
|
|
};
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2018-06-24 01:32:08 +03:00
|
|
|
.then(function (response) {
|
2019-01-04 23:59:39 +03:00
|
|
|
response.statusCode.should.eql(404);
|
2018-06-24 01:32:08 +03:00
|
|
|
});
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
});
|
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
it('serve /cooking/rss/', function () {
|
2018-06-24 01:32:08 +03:00
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
2019-01-04 23:59:39 +03:00
|
|
|
url: '/cooking/rss/',
|
2018-06-24 01:32:08 +03:00
|
|
|
host: 'example.com'
|
|
|
|
};
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2018-06-24 01:32:08 +03:00
|
|
|
.then(function (response) {
|
2019-01-04 23:59:39 +03:00
|
|
|
response.statusCode.should.eql(404);
|
2018-06-24 01:32:08 +03:00
|
|
|
});
|
|
|
|
});
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
it('serve /flat/rss/', function () {
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
2019-01-04 23:59:39 +03:00
|
|
|
url: '/flat/rss/',
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
✨Dynamic Routing Beta (#9596)
refs #9601
### Dynamic Routing
This is the beta version of dynamic routing.
- we had a initial implementation of "channels" available in the codebase
- we have removed and moved this implementation
- there is now a centralised place for dynamic routing - server/services/routing
- each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts
- keep as much as possible logic of routing helpers, middlewares and controllers
- ensure test coverage
- connect all the things together
- yaml file + validation
- routing + routers
- url service
- sitemaps
- url access
- deeper implementation of yaml validations
- e.g. hard require slashes
- ensure routing hierarchy/order
- e.g. you enable the subscriber app
- you have a custom static page, which lives under the same slug /subscribe
- static pages are stronger than apps
- e.g. the first collection owns the post it has filtered
- a post cannot live in two collections
- ensure apps are still working and hook into the routers layer (or better said: and register in the routing service)
- put as much as possible comments to the code base for better understanding
- ensure a clean debug log
- ensure we can unmount routes
- e.g. you have a collection permalink of /:slug/ represented by {globals.permalink}
- and you change the permalink in the admin to dated permalink
- the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/
- unmount without server restart, yey
- ensure we are backwards compatible
- e.g. render home.hbs for collection index if collection route is /
- ensure you can access your configured permalink from the settings table with {globals.permalink}
### Render 503 if url service did not finish
- return 503 if the url service has not finished generating the resource urls
### Rewrite sitemaps
- we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime
- we generate all urls on bootstrap
- the sitemaps service will consume created resource and router urls
- these urls will be shown on the xml pages
- we listen on url events
- we listen on router events
- we no longer have to fetch the resources, which is nice
- the urlservice pre-fetches resources and emits their urls
- the urlservice is the only component who knows which urls are valid
- i made some ES6 adaptions
- we keep the caching logic -> only regenerate xml if there is a change
- updated tests
- checked test coverage (100%)
### Re-work usage of Url utility
- replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId`
- only for resources e.g. post, author, tag
- this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime
- adapt url utility
- adapt tests
2018-06-05 20:02:20 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
it('serve /podcast/rss/', function () {
|
2018-12-03 22:31:48 +03:00
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
2019-01-04 23:59:39 +03:00
|
|
|
url: '/podcast/rss/',
|
2018-12-03 22:31:48 +03:00
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2018-12-03 22:31:48 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
2019-01-04 23:59:39 +03:00
|
|
|
response.template.should.eql('podcast/rss');
|
|
|
|
response.headers['content-type'].should.eql('text/xml; charset=utf-8');
|
|
|
|
response.body.match(/<link>/g).length.should.eql(2);
|
2018-12-03 22:31:48 +03:00
|
|
|
});
|
|
|
|
});
|
|
|
|
|
2019-01-04 23:59:39 +03:00
|
|
|
it('serve /podcast/', function () {
|
2018-12-03 22:31:48 +03:00
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
2019-01-04 23:59:39 +03:00
|
|
|
url: '/podcast/',
|
2018-12-03 22:31:48 +03:00
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2018-12-03 22:31:48 +03:00
|
|
|
.then(function (response) {
|
|
|
|
const $ = cheerio.load(response.body);
|
2018-08-10 15:11:13 +03:00
|
|
|
response.statusCode.should.eql(200);
|
2019-01-04 23:59:39 +03:00
|
|
|
$('head link')[2].attribs.href.should.eql('https://127.0.0.1:2369/rss/');
|
2018-02-14 19:21:31 +03:00
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
2019-09-09 01:59:28 +03:00
|
|
|
|
|
|
|
describe('parent app vhosts', function () {
|
|
|
|
describe('no separate admin', function () {
|
|
|
|
before(function () {
|
|
|
|
testUtils.integrationTesting.urlService.resetGenerators();
|
2020-03-19 18:23:10 +03:00
|
|
|
testUtils.integrationTesting.defaultMocks(sinon, {amp: true});
|
2019-09-09 01:59:28 +03:00
|
|
|
testUtils.integrationTesting.overrideGhostConfig(configUtils);
|
|
|
|
|
|
|
|
configUtils.set('url', 'http://example.com');
|
|
|
|
configUtils.set('admin:url', null);
|
|
|
|
|
|
|
|
return testUtils.integrationTesting.initGhost()
|
|
|
|
.then(function () {
|
|
|
|
sinon.stub(themeService.getActive(), 'engine').withArgs('ghost-api').returns('v2');
|
|
|
|
sinon.stub(themeService.getActive(), 'config').withArgs('posts_per_page').returns(2);
|
|
|
|
|
|
|
|
app = siteApp({start: true});
|
|
|
|
return testUtils.integrationTesting.urlService.waitTillFinished();
|
2020-03-20 11:58:26 +03:00
|
|
|
})
|
|
|
|
.then(() => {
|
2020-03-23 22:43:01 +03:00
|
|
|
return appService.init();
|
2019-09-09 01:59:28 +03:00
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
before(function () {
|
|
|
|
configUtils.set('url', 'http://example.com');
|
|
|
|
configUtils.set('admin:url', null);
|
|
|
|
urlUtils.stubUrlUtilsFromConfig();
|
|
|
|
});
|
|
|
|
|
|
|
|
after(function () {
|
|
|
|
configUtils.restore();
|
|
|
|
urlUtils.restore();
|
|
|
|
sinon.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
it('loads the front-end on configured url', function () {
|
|
|
|
const req = {
|
|
|
|
secure: false,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-09 01:59:28 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('loads the front-end on localhost', function () {
|
|
|
|
const req = {
|
|
|
|
secure: false,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/',
|
|
|
|
host: 'localhost'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-09 01:59:28 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('loads the admin', function () {
|
|
|
|
const req = {
|
|
|
|
secure: false,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/ghost/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-09 01:59:28 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('loads the admin on localhost', function () {
|
|
|
|
const req = {
|
|
|
|
secure: false,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/ghost/',
|
|
|
|
host: 'localhost'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-09 01:59:28 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('loads the api', function () {
|
|
|
|
const req = {
|
|
|
|
secure: false,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/ghost/api/v2/admin/site/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-09 01:59:28 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('loads the api on localhost', function () {
|
|
|
|
const req = {
|
|
|
|
secure: false,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/ghost/api/v2/admin/site/',
|
|
|
|
host: 'localhost'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-09 01:59:28 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('separate admin host', function () {
|
|
|
|
before(function () {
|
|
|
|
testUtils.integrationTesting.urlService.resetGenerators();
|
2020-03-19 18:23:10 +03:00
|
|
|
testUtils.integrationTesting.defaultMocks(sinon, {amp: true});
|
2019-09-09 01:59:28 +03:00
|
|
|
testUtils.integrationTesting.overrideGhostConfig(configUtils);
|
|
|
|
|
|
|
|
configUtils.set('url', 'http://example.com');
|
|
|
|
configUtils.set('admin:url', 'https://admin.example.com');
|
|
|
|
|
|
|
|
return testUtils.integrationTesting.initGhost()
|
|
|
|
.then(function () {
|
|
|
|
sinon.stub(themeService.getActive(), 'engine').withArgs('ghost-api').returns('v2');
|
|
|
|
sinon.stub(themeService.getActive(), 'config').withArgs('posts_per_page').returns(2);
|
|
|
|
|
|
|
|
app = siteApp({start: true});
|
|
|
|
return testUtils.integrationTesting.urlService.waitTillFinished();
|
2020-03-20 11:58:26 +03:00
|
|
|
})
|
|
|
|
.then(() => {
|
2020-03-23 22:43:01 +03:00
|
|
|
return appService.init();
|
2019-09-09 01:59:28 +03:00
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
before(function () {
|
|
|
|
urlUtils.stubUrlUtilsFromConfig();
|
|
|
|
});
|
|
|
|
|
|
|
|
after(function () {
|
|
|
|
configUtils.restore();
|
|
|
|
urlUtils.restore();
|
|
|
|
sinon.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
it('loads the front-end on configured url', function () {
|
|
|
|
const req = {
|
|
|
|
secure: false,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-09 01:59:28 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('loads the front-end on localhost', function () {
|
|
|
|
const req = {
|
|
|
|
secure: false,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/',
|
|
|
|
host: 'localhost'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-09 01:59:28 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('redirects /ghost/ on configured url', function () {
|
|
|
|
const req = {
|
|
|
|
secure: false,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/ghost/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-09 01:59:28 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(301);
|
|
|
|
response.headers.location.should.eql('https://admin.example.com/ghost/');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('404s the api on configured url', function () {
|
|
|
|
const req = {
|
|
|
|
secure: false,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/ghost/api/v2/admin/site/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-09 01:59:28 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(404);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('404s the api on localhost', function () {
|
|
|
|
const req = {
|
|
|
|
secure: false,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/ghost/api/v2/admin/site/',
|
|
|
|
host: 'localhost'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-09 01:59:28 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(404);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('loads the admin on configured admin url', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/ghost/',
|
|
|
|
host: 'admin.example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-09 01:59:28 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('loads the api on configured admin url', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/ghost/api/v2/admin/site/',
|
|
|
|
host: 'admin.example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-09 01:59:28 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('redirects to the correct protocol on configured admin url', function () {
|
|
|
|
const req = {
|
|
|
|
secure: false,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/ghost/',
|
|
|
|
host: 'admin.example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-09 01:59:28 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(301);
|
|
|
|
response.headers.location.should.eql('https://admin.example.com/ghost/');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('404s the front-end on configured admin url', function () {
|
|
|
|
const req = {
|
|
|
|
secure: false,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/',
|
|
|
|
host: 'admin.example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-09 01:59:28 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(404);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
2019-09-12 14:40:12 +03:00
|
|
|
describe('separate admin host w/ admin redirects disabled', function () {
|
|
|
|
before(function () {
|
|
|
|
testUtils.integrationTesting.urlService.resetGenerators();
|
2020-03-19 18:23:10 +03:00
|
|
|
testUtils.integrationTesting.defaultMocks(sinon, {amp: true});
|
2019-09-12 14:40:12 +03:00
|
|
|
testUtils.integrationTesting.overrideGhostConfig(configUtils);
|
|
|
|
|
|
|
|
configUtils.set('url', 'http://example.com');
|
|
|
|
configUtils.set('admin:url', 'https://admin.example.com');
|
|
|
|
configUtils.set('admin:redirects', false);
|
|
|
|
|
|
|
|
return testUtils.integrationTesting.initGhost()
|
|
|
|
.then(function () {
|
|
|
|
sinon.stub(themeService.getActive(), 'engine').withArgs('ghost-api').returns('v2');
|
|
|
|
sinon.stub(themeService.getActive(), 'config').withArgs('posts_per_page').returns(2);
|
|
|
|
|
|
|
|
app = siteApp({start: true});
|
|
|
|
return testUtils.integrationTesting.urlService.waitTillFinished();
|
2020-03-20 11:58:26 +03:00
|
|
|
})
|
|
|
|
.then(() => {
|
2020-03-23 22:43:01 +03:00
|
|
|
return appService.init();
|
2019-09-12 14:40:12 +03:00
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
before(function () {
|
|
|
|
urlUtils.stubUrlUtilsFromConfig();
|
|
|
|
});
|
|
|
|
|
|
|
|
after(function () {
|
|
|
|
configUtils.restore();
|
|
|
|
urlUtils.restore();
|
|
|
|
sinon.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
it('does not redirect /ghost/ on configured url', function () {
|
|
|
|
const req = {
|
|
|
|
secure: false,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/ghost/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-12 14:40:12 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(404);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
2019-09-09 01:59:28 +03:00
|
|
|
describe('same host separate protocol', function () {
|
|
|
|
before(function () {
|
|
|
|
testUtils.integrationTesting.urlService.resetGenerators();
|
2020-03-19 18:23:10 +03:00
|
|
|
testUtils.integrationTesting.defaultMocks(sinon, {amp: true});
|
2019-09-09 01:59:28 +03:00
|
|
|
testUtils.integrationTesting.overrideGhostConfig(configUtils);
|
|
|
|
|
|
|
|
configUtils.set('url', 'http://example.com');
|
|
|
|
configUtils.set('admin:url', 'https://example.com');
|
|
|
|
|
|
|
|
return testUtils.integrationTesting.initGhost()
|
|
|
|
.then(function () {
|
|
|
|
sinon.stub(themeService.getActive(), 'engine').withArgs('ghost-api').returns('v2');
|
|
|
|
sinon.stub(themeService.getActive(), 'config').withArgs('posts_per_page').returns(2);
|
|
|
|
|
|
|
|
app = siteApp({start: true});
|
|
|
|
return testUtils.integrationTesting.urlService.waitTillFinished();
|
2020-03-20 11:58:26 +03:00
|
|
|
})
|
|
|
|
.then(() => {
|
2020-03-23 22:43:01 +03:00
|
|
|
return appService.init();
|
2019-09-09 01:59:28 +03:00
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
before(function () {
|
|
|
|
urlUtils.stubUrlUtilsFromConfig();
|
|
|
|
});
|
|
|
|
|
|
|
|
it('loads the front-end on configured url (http)', function () {
|
|
|
|
const req = {
|
|
|
|
secure: false,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-09 01:59:28 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('404s the front-end on configured url (https)', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-09 01:59:28 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('loads the front-end on localhost', function () {
|
|
|
|
const req = {
|
|
|
|
secure: false,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/',
|
|
|
|
host: 'localhost'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-09 01:59:28 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('redirects /ghost/ on configured url', function () {
|
|
|
|
const req = {
|
|
|
|
secure: false,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/ghost/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-09 01:59:28 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(301);
|
|
|
|
response.headers.location.should.eql('https://example.com/ghost/');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('redirects /ghost/ on localhost', function () {
|
|
|
|
const req = {
|
|
|
|
secure: false,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/ghost/',
|
|
|
|
host: 'localhost'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-09 01:59:28 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(301);
|
|
|
|
response.headers.location.should.eql('https://example.com/ghost/');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('redirects api to correct protocol on configured admin url', function () {
|
|
|
|
const req = {
|
|
|
|
secure: false,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/ghost/api/v2/admin/site/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-09 01:59:28 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(301);
|
|
|
|
response.headers.location.should.eql('https://example.com/ghost/api/v2/admin/site/');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('loads the admin on configured admin url', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/ghost/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-09 01:59:28 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('redirects the admin on localhost', function () {
|
|
|
|
const req = {
|
|
|
|
secure: false,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/ghost/',
|
|
|
|
host: 'localhost'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-09 01:59:28 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(301);
|
|
|
|
response.headers.location.should.eql('https://example.com/ghost/');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('loads the api on configured admin url', function () {
|
|
|
|
const req = {
|
|
|
|
secure: true,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/ghost/api/v2/admin/site/',
|
|
|
|
host: 'example.com'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-09 01:59:28 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(200);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it('redirects the api on localhost', function () {
|
|
|
|
const req = {
|
|
|
|
secure: false,
|
|
|
|
method: 'GET',
|
|
|
|
url: '/ghost/api/v2/admin/site/',
|
|
|
|
host: 'localhost'
|
|
|
|
};
|
|
|
|
|
2020-03-25 14:19:16 +03:00
|
|
|
return mockUtils.express.invoke(app, req)
|
2019-09-09 01:59:28 +03:00
|
|
|
.then(function (response) {
|
|
|
|
response.statusCode.should.eql(301);
|
|
|
|
response.headers.location.should.eql('https://example.com/ghost/api/v2/admin/site/');
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
2018-02-14 19:21:31 +03:00
|
|
|
});
|