TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-24 19:33:02 +03:00
Code Issues Projects Releases Wiki Activity
d857e0ef15
Ghost/ghost/verification-trigger/package.json

30 lines
723 B
JSON
Raw Normal View History

Added email verification trigger package refs: https://github.com/TryGhost/Toolbox/issues/166 New package handles the email verification workflow to prevent spammers. It currently handles MembersSubscribeEvent to detect potential abuse of the API to add members, and exposes methods for checking the threshold / starting the verification process for use by other areas of the code (at the moment - just member imports). The import package no longer needs to handle anything related to verification since it can be handled in the wrapper function in Ghost, and the API package doesn't need to do anything other than dispatch the new event.
2022-01-27 13:57:51 +03:00
{
"name": "@tryghost/verification-trigger",
Switched to unversioned Members packages - these packages are split apart for local development, but will be bundled into Ghost when publishing - therefore, these packages won't be published so we are resetting the versions to make them cleaner
2022-07-21 10:15:29 +03:00
"version": "0.0.0",
Disabled publishing for Members packages - we don't want to publish these anymore so this commit disables the ability to - also fixes up a missing version that wasn't reset
2022-07-21 10:24:02 +03:00
"private": true,
Added email verification trigger package refs: https://github.com/TryGhost/Toolbox/issues/166 New package handles the email verification workflow to prevent spammers. It currently handles MembersSubscribeEvent to detect potential abuse of the API to add members, and exposes methods for checking the threshold / starting the verification process for use by other areas of the code (at the moment - just member imports). The import package no longer needs to handle anything related to verification since it can be handled in the wrapper function in Ghost, and the API package doesn't need to do anything other than dispatch the new event.
2022-01-27 13:57:51 +03:00
"author": "Ghost Foundation",
"license": "MIT",
"main": "index.js",
"scripts": {
"dev": "echo \"Implement me!\"",
Improved email verification required checks (#16060) fixes https://github.com/TryGhost/Team/issues/2366 refs https://ghost.slack.com/archives/C02G9E68C/p1670232405014209 Probem described in issue. In the old MEGA flow: - The `email_verification_required` check is now repeated inside the job In the new email service flow: - The `email_verification_required` is now checked (didn't happen before) - When generating the email batch recipients, we only include members that were created before the email was created. That way it is impossible to avoid limit checks by inserting new members between creating an email and sending an email. - We don't need to repeat the check inside the job because of the above changes Improved handling of large imports: - When checking `email_verification_required`, we now also check if the import threshold is reached (a new method is introduced in vertificationTrigger specifically for this usage). If it is, we start the verification progress. This is required for long running imports that only check the verification threshold at the very end. - This change increases the concurrency of fastq to 3 (refs https://ghost.slack.com/archives/C02G9E68C/p1670232405014209). So when running a long import, it is now possible to send emails without having to wait for the import. Above change makes sure it is not possible to get around the verification limits. Refactoring: - Removed the need to use `updateVerificationTrigger` by making thresholds getters instead of fixed variables. - Improved awaiting of members import job in regression test
2023-01-04 13:22:12 +03:00
"test:unit": "NODE_ENV=testing c8 --all --check-coverage --100 --reporter text --reporter cobertura mocha './test/**/*.test.js'",
Fixed full Admin test suite running during unit tests - because of how the npm scripts were set up, we were running the full Admin integration tests during the unit tests phase of CI - this commit renames the majority of `test` to `test:unit` in the package.json files, and aliases `test` to `test:unit` - special packages like Admin have no-op'd `test:unit` scripts so we don't end up running its tests
2022-08-15 16:20:45 +03:00
"test": "yarn test:unit",
Removed posttest linting step - linting is done as a separate step in CI and it's a git hook upon pushing locally, so we don't need to run it after tests
2022-07-21 11:09:36 +03:00
"lint": "eslint . --ext .js --cache"
Added email verification trigger package refs: https://github.com/TryGhost/Toolbox/issues/166 New package handles the email verification workflow to prevent spammers. It currently handles MembersSubscribeEvent to detect potential abuse of the API to add members, and exposes methods for checking the threshold / starting the verification process for use by other areas of the code (at the moment - just member imports). The import package no longer needs to handle anything related to verification since it can be handled in the wrapper function in Ghost, and the API package doesn't need to do anything other than dispatch the new event.
2022-01-27 13:57:51 +03:00
},
"files": [
"index.js",
"lib"
],
"devDependencies": {
Update dependency c8 to v7.13.0
2023-02-17 01:15:50 +03:00
"c8": "7.13.0",
Update dependency mocha to v10.2.0
2022-12-12 16:20:22 +03:00
"mocha": "10.2.0",
Added email verification trigger package refs: https://github.com/TryGhost/Toolbox/issues/166 New package handles the email verification workflow to prevent spammers. It currently handles MembersSubscribeEvent to detect potential abuse of the API to add members, and exposes methods for checking the threshold / starting the verification process for use by other areas of the code (at the moment - just member imports). The import package no longer needs to handle anything related to verification since it can be handled in the wrapper function in Ghost, and the API package doesn't need to do anything other than dispatch the new event.
2022-01-27 13:57:51 +03:00
"should": "13.2.3",
Update Test & linting packages
2023-04-05 15:53:35 +03:00
"sinon": "15.0.3"
Added email verification trigger package refs: https://github.com/TryGhost/Toolbox/issues/166 New package handles the email verification workflow to prevent spammers. It currently handles MembersSubscribeEvent to detect potential abuse of the API to add members, and exposes methods for checking the threshold / starting the verification process for use by other areas of the code (at the moment - just member imports). The import package no longer needs to handle anything related to verification since it can be handled in the wrapper function in Ghost, and the API package doesn't need to do anything other than dispatch the new event.
2022-01-27 13:57:51 +03:00
},
"dependencies": {
Pinned internal packages - we're going to be pinning all dependencies within the monorepo - this shouldn't change anything anyway because we're using the same version across all packages
2022-07-21 17:35:19 +03:00
"@tryghost/domain-events": "0.0.0",
Removed heavy dependency within `@tryghost/errors` - we previously used `@stdlib/utils` instead of the child package `@stdlib/copy`, which is a lot smaller and contains our only use of the parent - this saves 140+MB of dependencies
2023-04-05 14:22:00 +03:00
"@tryghost/errors": "1.2.24",
Pinned internal packages - we're going to be pinning all dependencies within the monorepo - this shouldn't change anything anyway because we're using the same version across all packages
2022-07-21 17:35:19 +03:00
"@tryghost/member-events": "0.0.0"
Added email verification trigger package refs: https://github.com/TryGhost/Toolbox/issues/166 New package handles the email verification workflow to prevent spammers. It currently handles MembersSubscribeEvent to detect potential abuse of the API to add members, and exposes methods for checking the threshold / starting the verification process for use by other areas of the code (at the moment - just member imports). The import package no longer needs to handle anything related to verification since it can be handled in the wrapper function in Ghost, and the API package doesn't need to do anything other than dispatch the new event.
2022-01-27 13:57:51 +03:00
}
}
Reference in New Issue Copy Permalink