TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-25 11:55:03 +03:00
Code Issues Projects Releases Wiki Activity

Fixed slack setting migration to follow idempotance rule

Browse Source 
refs https://github.com/TryGhost/Ghost/pull/12631

- Initialy writen migration would break if executed twice
- Also accounted for situation if only part of the migration executed leaving only one of the values migrated
This commit is contained in:
Naz 2021-02-17 16:52:39 +13:00 committed by naz
parent 9964a5c23a
commit 0097f2037c
1 changed files with 58 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

84
core/server/data/migrations/versions/4.0/16-refactor-slack-setting.js
View File

@ -1,7 +1,29 @@
const ObjectId = require('bson-objectid').default;
const {createIrreversibleMigration} = require('../../utils');
const logging = require('../../../../../shared/logging');
module.exports = createIrreversibleMigration(async (knex) => {
logging.info('Populating slack_url and slack_username setting values');
const slackURLSetting = await knex('settings')
.select('value')
.where({
key: 'slack_url'
})
.first();
const slackUsernameSetting = await knex('settings')
.select('value')
.where({
key: 'slack_username'
})
.first();
if (slackURLSetting && slackUsernameSetting) {
logging.warn('slack_url and slack_username setting already exitst');
return;
}
const slackSetting = await knex('settings')
.select('value')
.where({
@ -28,33 +50,43 @@ module.exports = createIrreversibleMigration(async (knex) => {
const now = knex.raw('CURRENT_TIMESTAMP');
await knex('settings')
.insert({
id: ObjectId.generate(),
key: 'slack_url',
group: 'slack',
type: 'string',
flags: null,
value: slackUrl,
created_by: 1,
created_at: now,
updated_by: 1,
updated_at: now
});
if (!slackURLSetting) {
logging.info(`Populating slack_url setting with value: ${slackUrl}`);
await knex('settings')
.insert({
id: ObjectId.generate(),
key: 'slack_username',
group: 'slack',
type: 'string',
flags: null,
value: slackUsername,
created_by: 1,
created_at: now,
updated_by: 1,
updated_at: now
});
await knex('settings')
.insert({
id: ObjectId.generate(),
key: 'slack_url',
group: 'slack',
type: 'string',
flags: null,
value: slackUrl,
created_by: 1,
created_at: now,
updated_by: 1,
updated_at: now
});
}
if (!slackUsernameSetting) {
logging.info(`Populating slack_username setting with value: ${slackUsername}`);
await knex('settings')
.insert({
id: ObjectId.generate(),
key: 'slack_username',
group: 'slack',
type: 'string',
flags: null,
value: slackUsername,
created_by: 1,
created_at: now,
updated_by: 1,
updated_at: now
});
}
logging.info(`Removing slack setting`);
await knex('settings')
.where({