TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-11-25 09:03:12 +03:00
Code Issues Projects Releases Wiki Activity

Update the event output to be less verbose

Browse Source 
- Some events take up quite a bit of space and so want to be less verbose
- Playing with where to add joins in the interface
- Remove references of subscription unless it's for email

refs https://github.com/TryGhost/Team/issues/1840
This commit is contained in:
James Morris 2022-08-24 17:06:14 +01:00
parent 9f4ad3d8d4
commit 0142b4535a
2 changed files with 12 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
ghost/admin/app/components/dashboard/charts/recents.hbs
View File

@ -102,7 +102,6 @@
<span class="gh-dashboard-list-subtext">
{{capitalize-first-letter parsedEvent.action}}
{{#if parsedEvent.url}}
{{parsedEvent.join}}
<a class="ghost-members-activity-object-link {{if (feature "memberAttribution") 'hidden'}}" href="{{parsedEvent.url}}" target="_blank" rel="noopener noreferrer">{{parsedEvent.object}}</a>
{{/if}}
{{#if parsedEvent.info}}

26
ghost/admin/app/helpers/parse-member-event.js
View File

@ -90,13 +90,13 @@ function getAction(event, hasMultipleNewsletters) {
}
if (event.type === 'payment_event') {
return 'made a payment';
return 'made payment';
}
if (event.type === 'newsletter_event') {
let newsletter = 'newsletter';
if (hasMultipleNewsletters && event.data.newsletter && event.data.newsletter.name) {
newsletter = 'newsletter – ' + event.data.newsletter.name;
newsletter = event.data.newsletter.name;
}
if (event.data.subscribed) {
@ -108,39 +108,39 @@ function getAction(event, hasMultipleNewsletters) {
if (event.type === 'subscription_event') {
if (event.data.type === 'created') {
return 'started their subscription';
return 'started paid membership';
}
if (event.data.type === 'updated') {
return 'changed their subscription';
return 'changed paid membership';
}
if (event.data.type === 'canceled') {
return 'canceled their subscription';
return 'canceled paid membership';
}
if (event.data.type === 'reactivated') {
return 'reactivated their subscription';
return 'reactivated paid membership';
}
if (event.data.type === 'expired') {
return 'ended their subscription';
return 'ended paid membership';
}
return 'changed their subscription';
return 'changed paid membership';
}
if (event.type === 'email_opened_event') {
return 'opened an email';
return 'opened email';
}
if (event.type === 'email_delivered_event') {
return 'received an email';
return 'received email';
}
if (event.type === 'email_failed_event') {
return 'failed to receive an email';
return 'failed to receive email';
}
if (event.type === 'comment_event') {
if (event.data.parent) {
return 'replied to a comment';
return 'replied to comment';
}
return 'commented';
}
@ -158,7 +158,6 @@ function getAction(event, hasMultipleNewsletters) {
function getJoin(event) {
if (event.type === 'signup_event' || event.type === 'subscription_event') {
if (event.data.attribution?.title) {
// Add 'Attributed to ' for now, until this is incorporated in the design
return 'on';
}
}
@ -178,7 +177,6 @@ function getJoin(event) {
function getObject(event) {
if (event.type === 'signup_event' || event.type === 'subscription_event') {
if (event.data.attribution?.title) {
// Add 'Attributed to ' for now, until this is incorporated in the design
return event.data.attribution.title;
}
}