TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-25 11:55:03 +03:00
Code Issues Projects Releases Wiki Activity

Added input serialization for settings API v2 to transform "0"/"1" booleans

Browse Source 
refs #10582

- otherwise we will forward string booleans to model layer
- causes trouble if we trigger events
- causes trouble if we want to add conditions to the model e.g. setting.get('value') ?
This commit is contained in:
kirrg001 2019-03-07 12:16:12 +01:00 committed by Katharina Irrgang
parent f80a9429b9
commit 037ac4d748
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
core/server/api/v2/utils/serializers/input/settings.js
View File

@ -26,10 +26,16 @@ module.exports = {
setting.value = JSON.stringify(setting.value);
}
// CASE: Ensure we won't forward strings, otherwise model events or model interactions can fail
if (setting.value === '0' || setting.value === '1') {
setting.value = !!+setting.value;
}
// CASE: Ensure we won't forward strings, otherwise model events or model interactions can fail
if (setting.value === 'false' || setting.value === 'true') {
setting.value = setting.value === 'true';
}
if (setting.key === 'codeinjection_head') {
setting.key = 'ghost_head';
}