TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-11-28 22:43:30 +03:00
Code Issues Projects Releases Wiki Activity

🐛 Fixed failing Facebook URL validation for group urls (#906)

Browse Source 
closes https://github.com/TryGhost/Ghost/issues/9160
- simplified FB validation to allow any valid FB url (autocomplete of raw usernames and facebook-like URLs is still in place)
- fixed a bug with sticky Twitter validation message, if you entered an invalid URL then changed it to an invalid username you still saw the invalid URL message (surfaced through new test helpers for validating facebook/twitter fields)
This commit is contained in:
Kevin Ansfield 2017-11-10 16:38:30 +00:00 committed by GitHub
parent 719c2c3c6e
commit 0572c33e0f
5 changed files with 208 additions and 234 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

73
ghost/admin/app/controllers/settings/general.js
View File

@ -185,10 +185,13 @@ export default Controller.extend({
let oldUrl = this.get('model.facebook');
let errMessage = '';
// reset errors and validation
this.get('model.errors').remove('facebook');
this.get('model.hasValidated').removeObject('facebook');
if (newUrl === '') {
// Clear out the Facebook url
this.set('model.facebook', '');
this.get('model.errors').remove('facebook');
return;
}
@ -197,49 +200,41 @@ export default Controller.extend({
newUrl = oldUrl;
}
// If new url didn't change, exit
if (newUrl === oldUrl) {
this.get('model.errors').remove('facebook');
return;
}
try {
// strip any facebook URLs out
newUrl = newUrl.replace(/(https?:\/\/)?(www\.)?facebook\.com/i, '');
if (newUrl.match(/(?:facebook\.com\/)(\S+)/) || newUrl.match(/([a-z\d.]+)/i)) {
let username = [];
if (newUrl.match(/(?:facebook\.com\/)(\S+)/)) {
[, username] = newUrl.match(/(?:facebook\.com\/)(\S+)/);
} else {
[, username] = newUrl.match(/(?:https:\/\/|http:\/\/)?(?:www\.)?(?:\w+\.\w+\/+)?(\S+)/mi);
// don't allow any non-facebook urls
if (newUrl.match(/^(http|\/\/)/i)) {
throw 'invalid url';
}
// check if we have a /page/username or without
if (username.match(/^(?:\/)?(pages?\/\S+)/mi)) {
// we got a page url, now save the username without the / in the beginning
// strip leading / if we have one then concat to full facebook URL
newUrl = newUrl.replace(/^\//, '');
newUrl = `https://www.facebook.com/${newUrl}`;
[, username] = username.match(/^(?:\/)?(pages?\/\S+)/mi);
} else if (username.match(/^(http|www)|(\/)/) || !username.match(/^([a-z\d.]{1,50})$/mi)) {
errMessage = !username.match(/^([a-z\d.]{1,50})$/mi) ? 'Your Page name is not a valid Facebook Page name' : 'The URL must be in a format like https://www.facebook.com/yourPage';
this.get('model.errors').add('facebook', errMessage);
this.get('model.hasValidated').pushObject('facebook');
return;
// don't allow URL if it's not valid
if (!validator.isURL(newUrl)) {
throw 'invalid url';
}
newUrl = `https://www.facebook.com/${username}`;
this.get('model.errors').remove('facebook');
this.get('model.hasValidated').pushObject('facebook');
this.set('model.facebook', '');
run.schedule('afterRender', this, function () {
this.set('model.facebook', newUrl);
});
} else {
errMessage = 'The URL must be in a format like '
+ 'https://www.facebook.com/yourPage';
this.get('model.errors').add('facebook', errMessage);
} catch (e) {
if (e === 'invalid url') {
errMessage = 'The URL must be in a format like '
+ 'https://www.facebook.com/yourPage';
this.get('model.errors').add('facebook', errMessage);
return;
}
throw e;
} finally {
this.get('model.hasValidated').pushObject('facebook');
return;
}
},
@ -248,10 +243,13 @@ export default Controller.extend({
let oldUrl = this.get('model.twitter');
let errMessage = '';
// reset errors and validation
this.get('model.errors').remove('twitter');
this.get('model.hasValidated').removeObject('twitter');
if (newUrl === '') {
// Clear out the Twitter url
this.set('model.twitter', '');
this.get('model.errors').remove('twitter');
return;
}
@ -260,12 +258,6 @@ export default Controller.extend({
newUrl = oldUrl;
}
// If new url didn't change, exit
if (newUrl === oldUrl) {
this.get('model.errors').remove('twitter');
return;
}
if (newUrl.match(/(?:twitter\.com\/)(\S+)/) || newUrl.match(/([a-z\d.]+)/i)) {
let username = [];
@ -286,7 +278,6 @@ export default Controller.extend({
newUrl = `https://twitter.com/${username}`;
this.get('model.errors').remove('twitter');
this.get('model.hasValidated').pushObject('twitter');
this.set('model.twitter', '');

79
ghost/admin/app/controllers/team/user.js
View File

@ -246,10 +246,13 @@ export default Controller.extend({
let oldUrl = this.get('user.facebook');
let errMessage = '';
// reset errors and validation
this.get('user.errors').remove('facebook');
this.get('user.hasValidated').removeObject('facebook');
if (newUrl === '') {
// Clear out the Facebook url
this.set('user.facebook', '');
this.get('user.errors').remove('facebook');
return;
}
@ -258,52 +261,41 @@ export default Controller.extend({
newUrl = oldUrl;
}
// If new url didn't change, exit
if (newUrl === oldUrl) {
this.get('user.errors').remove('facebook');
return;
}
try {
// strip any facebook URLs out
newUrl = newUrl.replace(/(https?:\/\/)?(www\.)?facebook\.com/i, '');
// TODO: put the validation here into a validator
if (newUrl.match(/(?:facebook\.com\/)(\S+)/) || newUrl.match(/([a-z\d.]+)/i)) {
let username = [];
if (newUrl.match(/(?:facebook\.com\/)(\S+)/)) {
[, username] = newUrl.match(/(?:facebook\.com\/)(\S+)/);
} else {
[, username] = newUrl.match(/(?:https:\/\/|http:\/\/)?(?:www\.)?(?:\w+\.\w+\/+)?(\S+)/mi);
// don't allow any non-facebook urls
if (newUrl.match(/^(http|\/\/)/i)) {
throw 'invalid url';
}
// check if we have a /page/username or without
if (username.match(/^(?:\/)?(pages?\/\S+)/mi)) {
// we got a page url, now save the username without the / in the beginning
// strip leading / if we have one then concat to full facebook URL
newUrl = newUrl.replace(/^\//, '');
newUrl = `https://www.facebook.com/${newUrl}`;
[, username] = username.match(/^(?:\/)?(pages?\/\S+)/mi);
} else if (username.match(/^(http|www)|(\/)/) || !username.match(/^([a-z\d.]{1,50})$/mi)) {
errMessage = !username.match(/^([a-z\d.]{1,50})$/mi) ? 'Your Username is not a valid Facebook Username' : 'The URL must be in a format like https://www.facebook.com/yourUsername';
this.get('user.errors').add('facebook', errMessage);
this.get('user.hasValidated').pushObject('facebook');
return;
// don't allow URL if it's not valid
if (!validator.isURL(newUrl)) {
throw 'invalid url';
}
newUrl = `https://www.facebook.com/${username}`;
this.set('user.facebook', newUrl);
this.get('user.errors').remove('facebook');
this.get('user.hasValidated').pushObject('facebook');
// necessary to update the value in the input field
this.set('user.facebook', '');
run.schedule('afterRender', this, function () {
this.set('user.facebook', newUrl);
});
} else {
errMessage = 'The URL must be in a format like '
+ 'https://www.facebook.com/yourUsername';
this.get('user.errors').add('facebook', errMessage);
} catch (e) {
if (e === 'invalid url') {
errMessage = 'The URL must be in a format like '
+ 'https://www.facebook.com/yourPage';
this.get('user.errors').add('facebook', errMessage);
return;
}
throw e;
} finally {
this.get('user.hasValidated').pushObject('facebook');
return;
}
},
@ -312,10 +304,13 @@ export default Controller.extend({
let oldUrl = this.get('user.twitter');
let errMessage = '';
// reset errors and validation
this.get('user.errors').remove('twitter');
this.get('user.hasValidated').removeObject('twitter');
if (newUrl === '') {
// Clear out the Twitter url
this.set('user.twitter', '');
this.get('user.errors').remove('twitter');
return;
}
@ -324,13 +319,6 @@ export default Controller.extend({
newUrl = oldUrl;
}
// If new url didn't change, exit
if (newUrl === oldUrl) {
this.get('user.errors').remove('twitter');
return;
}
// TODO: put the validation here into a validator
if (newUrl.match(/(?:twitter\.com\/)(\S+)/) || newUrl.match(/([a-z\d.]+)/i)) {
let username = [];
@ -350,12 +338,9 @@ export default Controller.extend({
}
newUrl = `https://twitter.com/${username}`;
this.set('user.twitter', newUrl);
this.get('user.errors').remove('twitter');
this.get('user.hasValidated').pushObject('twitter');
// necessary to update the value in the input field
this.set('user.twitter', '');
run.schedule('afterRender', this, function () {
this.set('user.twitter', newUrl);

10
ghost/admin/app/templates/team/user.hbs
View File

@ -172,35 +172,35 @@
{{#gh-form-group errors=user.errors hasValidated=user.hasValidated property="location"}}
<label for="user-location">Location</label>
{{gh-input user.location type="text" id="user-location" focusOut=(action "validate" "location" target=user) update=(action (mut user.location)) data-test-location-input=true}}
{{gh-error-message errors=user.errors property="location"}}
{{gh-error-message errors=user.errors property="location" data-test-location-error=true}}
<p>Where in the world do you live?</p>
{{/gh-form-group}}
{{#gh-form-group errors=user.errors hasValidated=user.hasValidated property="website"}}
<label for="user-website">Website</label>
{{gh-input user.website type="url" id="user-website" autocapitalize="off" autocorrect="off" autocomplete="off" focusOut=(action "validate" "website" target=user) update=(action (mut user.website)) data-test-website-input=true}}
{{gh-error-message errors=user.errors property="website"}}
{{gh-error-message errors=user.errors property="website" data-test-website-error=true}}
<p>Have a website or blog other than this one? Link it!</p>
{{/gh-form-group}}
{{#gh-form-group errors=user.errors hasValidated=user.hasValidated property="facebook"}}
<label for="user-facebook">Facebook Profile</label>
<input value={{user.facebook}} oninput={{action (mut _scratchFacebook) value="target.value"}} {{action "validateFacebookUrl" on="focusOut"}} type="url" class="gh-input" id="user-facebook" name="user[facebook]" placeholder="https://www.facebook.com/username" autocorrect="off" data-test-facebook-input=true/>
{{gh-error-message errors=user.errors property="facebook"}}
{{gh-error-message errors=user.errors property="facebook" data-test-facebook-error=true}}
<p>URL of your personal Facebook Profile</p>
{{/gh-form-group}}
{{#gh-form-group errors=user.errors hasValidated=user.hasValidated property="twitter"}}
<label for="user-twitter">Twitter Profile</label>
<input value={{user.twitter}} oninput={{action (mut _scratchTwitter) value="target.value"}} {{action "validateTwitterUrl" on="focusOut"}} type="url" class="gh-input" id="user-twitter" name="user[twitter]" placeholder="https://twitter.com/username" autocorrect="off" data-test-twitter-input=true/>
{{gh-error-message errors=user.errors property="twitter"}}
{{gh-error-message errors=user.errors property="twitter" data-test-twitter-error=true}}
<p>URL of your personal Twitter profile</p>
{{/gh-form-group}}
{{#gh-form-group errors=user.errors hasValidated=user.hasValidated property="bio" class="bio-container"}}
<label for="user-bio">Bio</label>
{{gh-textarea user.bio id="user-bio" focusOut=(action "validate" "bio" target=user) update=(action (mut user.bio)) data-test-bio-input=true}}
{{gh-error-message errors=user.errors property="bio"}}
{{gh-error-message errors=user.errors property="bio" data-test-bio-error=true}}
<p>
Write about you, in 200 characters or less.
{{gh-count-characters user.bio}}

150
ghost/admin/tests/acceptance/settings/general-test.js
View File

@ -347,6 +347,29 @@ describe('Acceptance: Settings - General', function () {
});
it('handles social blog settings correctly', async function () {
let testSocialInput = async function(type, input, expectedValue, expectedError = '') {
await fillIn(`[data-test-${type}-input]`, input);
await triggerEvent(`[data-test-${type}-input]`, 'blur');
expect(
find(`[data-test-${type}-input]`).val(),
`${type} value for ${input}`
).to.equal(expectedValue);
expect(
find(`[data-test-${type}-error]`).text().trim(),
`${type} validation response for ${input}`
).to.equal(expectedError);
expect(
find(`[data-test-${type}-input]`).closest('.form-group').hasClass('error'),
`${type} input should be in error state with '${input}'`
).to.equal(!!expectedError);
};
let testFacebookValidation = async (...args) => testSocialInput('facebook', ...args);
let testTwitterValidation = async (...args) => testSocialInput('twitter', ...args);
await visit('/settings/general');
await click('[data-test-toggle-social]');
@ -363,67 +386,43 @@ describe('Acceptance: Settings - General', function () {
expect(find('[data-test-facebook-input]').val(), 'facebook value after blur with no change')
.to.equal('https://www.facebook.com/test');
await fillIn('[data-test-facebook-input]', 'facebook.com/username');
await triggerEvent('[data-test-facebook-input]', 'blur');
await testFacebookValidation(
'facebook.com/username',
'https://www.facebook.com/username');
expect(find('[data-test-facebook-input]').val()).to.be.equal('https://www.facebook.com/username');
expect(find('[data-test-facebook-error]').text().trim(), 'inline validation response')
.to.equal('');
await testFacebookValidation(
'testuser',
'https://www.facebook.com/testuser');
await fillIn('[data-test-facebook-input]', 'facebook.com/pages/some-facebook-page/857469375913?ref=ts');
await triggerEvent('[data-test-facebook-input]', 'blur');
await testFacebookValidation(
'ab99',
'https://www.facebook.com/ab99');
expect(find('[data-test-facebook-input]').val()).to.be.equal('https://www.facebook.com/pages/some-facebook-page/857469375913?ref=ts');
expect(find('[data-test-facebook-error]').text().trim(), 'inline validation response')
.to.equal('');
await testFacebookValidation(
'page/ab99',
'https://www.facebook.com/page/ab99');
await fillIn('[data-test-facebook-input]', '*(&*(%%))');
await triggerEvent('[data-test-facebook-input]', 'blur');
await testFacebookValidation(
'page/*(&*(%%))',
'https://www.facebook.com/page/*(&*(%%))');
expect(find('[data-test-facebook-error]').text().trim(), 'inline validation response')
.to.equal('The URL must be in a format like https://www.facebook.com/yourPage');
await testFacebookValidation(
'facebook.com/pages/some-facebook-page/857469375913?ref=ts',
'https://www.facebook.com/pages/some-facebook-page/857469375913?ref=ts');
await fillIn('[data-test-facebook-input]', 'http://github.com/username');
await triggerEvent('[data-test-facebook-input]', 'blur');
await testFacebookValidation(
'https://www.facebook.com/groups/savethecrowninn',
'https://www.facebook.com/groups/savethecrowninn');
expect(find('[data-test-facebook-input]').val()).to.be.equal('https://www.facebook.com/username');
expect(find('[data-test-facebook-error]').text().trim(), 'inline validation response')
.to.equal('');
await testFacebookValidation(
'http://github.com/username',
'http://github.com/username',
'The URL must be in a format like https://www.facebook.com/yourPage');
await fillIn('[data-test-facebook-input]', 'http://github.com/pages/username');
await triggerEvent('[data-test-facebook-input]', 'blur');
expect(find('[data-test-facebook-input]').val()).to.be.equal('https://www.facebook.com/pages/username');
expect(find('[data-test-facebook-error]').text().trim(), 'inline validation response')
.to.equal('');
await fillIn('[data-test-facebook-input]', 'testuser');
await triggerEvent('[data-test-facebook-input]', 'blur');
expect(find('[data-test-facebook-input]').val()).to.be.equal('https://www.facebook.com/testuser');
expect(find('[data-test-facebook-error]').text().trim(), 'inline validation response')
.to.equal('');
await fillIn('[data-test-facebook-input]', 'ab99');
await triggerEvent('[data-test-facebook-input]', 'blur');
expect(find('[data-test-facebook-input]').val()).to.be.equal('https://www.facebook.com/ab99');
expect(find('[data-test-facebook-error]').text().trim(), 'inline validation response')
.to.equal('');
await fillIn('[data-test-facebook-input]', 'page/ab99');
await triggerEvent('[data-test-facebook-input]', 'blur');
expect(find('[data-test-facebook-input]').val()).to.be.equal('https://www.facebook.com/page/ab99');
expect(find('[data-test-facebook-error]').text().trim(), 'inline validation response')
.to.equal('');
await fillIn('[data-test-facebook-input]', 'page/*(&*(%%))');
await triggerEvent('[data-test-facebook-input]', 'blur');
expect(find('[data-test-facebook-input]').val()).to.be.equal('https://www.facebook.com/page/*(&*(%%))');
expect(find('[data-test-facebook-error]').text().trim(), 'inline validation response')
.to.equal('');
await testFacebookValidation(
'http://github.com/pages/username',
'http://github.com/pages/username',
'The URL must be in a format like https://www.facebook.com/yourPage');
// validates a twitter url correctly
@ -439,38 +438,27 @@ describe('Acceptance: Settings - General', function () {
expect(find('[data-test-twitter-input]').val(), 'twitter value after blur with no change')
.to.equal('https://twitter.com/test');
await fillIn('[data-test-twitter-input]', 'twitter.com/username');
await triggerEvent('[data-test-twitter-input]', 'blur');
await testTwitterValidation(
'twitter.com/username',
'https://twitter.com/username');
expect(find('[data-test-twitter-input]').val()).to.be.equal('https://twitter.com/username');
expect(find('[data-test-twitter-error]').text().trim(), 'inline validation response')
.to.equal('');
await testTwitterValidation(
'testuser',
'https://twitter.com/testuser');
await fillIn('[data-test-twitter-input]', '*(&*(%%))');
await triggerEvent('[data-test-twitter-input]', 'blur');
await testTwitterValidation(
'http://github.com/username',
'https://twitter.com/username');
expect(find('[data-test-twitter-error]').text().trim(), 'inline validation response')
.to.equal('The URL must be in a format like https://twitter.com/yourUsername');
await testTwitterValidation(
'*(&*(%%))',
'*(&*(%%))',
'The URL must be in a format like https://twitter.com/yourUsername');
await fillIn('[data-test-twitter-input]', 'http://github.com/username');
await triggerEvent('[data-test-twitter-input]', 'blur');
expect(find('[data-test-twitter-input]').val()).to.be.equal('https://twitter.com/username');
expect(find('[data-test-twitter-error]').text().trim(), 'inline validation response')
.to.equal('');
await fillIn('[data-test-twitter-input]', 'thisusernamehasmorethan15characters');
await triggerEvent('[data-test-twitter-input]', 'blur');
expect(find('[data-test-twitter-error]').text().trim(), 'inline validation response')
.to.equal('Your Username is not a valid Twitter Username');
await fillIn('[data-test-twitter-input]', 'testuser');
await triggerEvent('[data-test-twitter-input]', 'blur');
expect(find('[data-test-twitter-input]').val()).to.be.equal('https://twitter.com/testuser');
expect(find('[data-test-twitter-error]').text().trim(), 'inline validation response')
.to.equal('');
await testTwitterValidation(
'thisusernamehasmorethan15characters',
'thisusernamehasmorethan15characters',
'Your Username is not a valid Twitter Username');
});
it('warns when leaving without saving', async function () {

130
ghost/admin/tests/acceptance/team-test.js
View File

@ -547,6 +547,29 @@ describe('Acceptance: Team', function () {
expect(find('[data-test-website-input]').closest('.form-group').hasClass('error'), 'website input should be in error state').to.be.true;
let testSocialInput = async function(type, input, expectedValue, expectedError = '') {
await fillIn(`[data-test-${type}-input]`, input);
await triggerEvent(`[data-test-${type}-input]`, 'blur');
expect(
find(`[data-test-${type}-input]`).val(),
`${type} value for ${input}`
).to.equal(expectedValue);
expect(
find(`[data-test-${type}-error]`).text().trim(),
`${type} validation response for ${input}`
).to.equal(expectedError);
expect(
find(`[data-test-${type}-input]`).closest('.form-group').hasClass('error'),
`${type} input should be in error state with '${input}'`
).to.equal(!!expectedError);
};
let testFacebookValidation = async (...args) => testSocialInput('facebook', ...args);
let testTwitterValidation = async (...args) => testSocialInput('twitter', ...args);
// Testing Facebook input
// displays initial value
@ -561,53 +584,43 @@ describe('Acceptance: Team', function () {
expect(find('[data-test-facebook-input]').val(), 'facebook value after blur with no change')
.to.equal('https://www.facebook.com/test');
await fillIn('[data-test-facebook-input]', '');
await fillIn('[data-test-facebook-input]', ')(*&%^%)');
await triggerEvent('[data-test-facebook-input]', 'blur');
await testFacebookValidation(
'facebook.com/username',
'https://www.facebook.com/username');
expect(find('[data-test-facebook-input]').closest('.form-group').hasClass('error'), 'facebook input should be in error state').to.be.true;
await testFacebookValidation(
'testuser',
'https://www.facebook.com/testuser');
await fillIn('[data-test-facebook-input]', '');
await fillIn('[data-test-facebook-input]', 'pages/)(*&%^%)');
await triggerEvent('[data-test-facebook-input]', 'blur');
await testFacebookValidation(
'ab99',
'https://www.facebook.com/ab99');
expect(find('[data-test-facebook-input]').val()).to.be.equal('https://www.facebook.com/pages/)(*&%^%)');
expect(find('[data-test-facebook-input]').closest('.form-group').hasClass('error'), 'facebook input should be in error state').to.be.false;
await testFacebookValidation(
'page/ab99',
'https://www.facebook.com/page/ab99');
await fillIn('[data-test-facebook-input]', '');
await fillIn('[data-test-facebook-input]', 'testing');
await triggerEvent('[data-test-facebook-input]', 'blur');
await testFacebookValidation(
'page/*(&*(%%))',
'https://www.facebook.com/page/*(&*(%%))');
expect(find('[data-test-facebook-input]').val()).to.be.equal('https://www.facebook.com/testing');
expect(find('[data-test-facebook-input]').closest('.form-group').hasClass('error'), 'facebook input should be in error state').to.be.false;
await testFacebookValidation(
'facebook.com/pages/some-facebook-page/857469375913?ref=ts',
'https://www.facebook.com/pages/some-facebook-page/857469375913?ref=ts');
await fillIn('[data-test-facebook-input]', '');
await fillIn('[data-test-facebook-input]', 'somewebsite.com/pages/some-facebook-page/857469375913?ref=ts');
await triggerEvent('[data-test-facebook-input]', 'blur');
await testFacebookValidation(
'https://www.facebook.com/groups/savethecrowninn',
'https://www.facebook.com/groups/savethecrowninn');
expect(find('[data-test-facebook-input]').val()).to.be.equal('https://www.facebook.com/pages/some-facebook-page/857469375913?ref=ts');
expect(find('[data-test-facebook-input]').closest('.form-group').hasClass('error'), 'facebook input should be in error state').to.be.false;
await testFacebookValidation(
'http://github.com/username',
'http://github.com/username',
'The URL must be in a format like https://www.facebook.com/yourPage');
await fillIn('[data-test-facebook-input]', '');
await fillIn('[data-test-facebook-input]', 'test');
await triggerEvent('[data-test-facebook-input]', 'blur');
expect(find('[data-test-facebook-input]').val()).to.be.equal('https://www.facebook.com/test');
expect(find('[data-test-facebook-input]').closest('.form-group').hasClass('error'), 'facebook input should be in error state').to.be.false;
await fillIn('[data-test-facebook-input]', '');
await fillIn('[data-test-facebook-input]', 'http://twitter.com/testuser');
await triggerEvent('[data-test-facebook-input]', 'blur');
expect(find('[data-test-facebook-input]').val()).to.be.equal('https://www.facebook.com/testuser');
expect(find('[data-test-facebook-input]').closest('.form-group').hasClass('error'), 'facebook input should be in error state').to.be.false;
await fillIn('[data-test-facebook-input]', '');
await fillIn('[data-test-facebook-input]', 'facebook.com/testing');
await triggerEvent('[data-test-facebook-input]', 'blur');
expect(find('[data-test-facebook-input]').val()).to.be.equal('https://www.facebook.com/testing');
expect(find('[data-test-facebook-input]').closest('.form-group').hasClass('error'), 'facebook input should be in error state').to.be.false;
await testFacebookValidation(
'http://github.com/pages/username',
'http://github.com/pages/username',
'The URL must be in a format like https://www.facebook.com/yourPage');
// Testing Twitter input
@ -623,32 +636,29 @@ describe('Acceptance: Team', function () {
expect(find('[data-test-twitter-input]').val(), 'twitter value after blur with no change')
.to.equal('https://twitter.com/test');
await fillIn('[data-test-twitter-input]', '');
await fillIn('[data-test-twitter-input]', ')(*&%^%)');
await triggerEvent('[data-test-twitter-input]', 'blur');
await testTwitterValidation(
'twitter.com/username',
'https://twitter.com/username');
expect(find('[data-test-twitter-input]').closest('.form-group').hasClass('error'), 'twitter input should be in error state').to.be.true;
await testTwitterValidation(
'testuser',
'https://twitter.com/testuser');
await fillIn('[data-test-twitter-input]', '');
await fillIn('[data-test-twitter-input]', 'name');
await triggerEvent('[data-test-twitter-input]', 'blur');
await testTwitterValidation(
'http://github.com/username',
'https://twitter.com/username');
expect(find('[data-test-twitter-input]').val()).to.be.equal('https://twitter.com/name');
expect(find('[data-test-twitter-input]').closest('.form-group').hasClass('error'), 'twitter input should be in error state').to.be.false;
await testTwitterValidation(
'*(&*(%%))',
'*(&*(%%))',
'The URL must be in a format like https://twitter.com/yourUsername');
await fillIn('[data-test-twitter-input]', '');
await fillIn('[data-test-twitter-input]', 'http://github.com/user');
await triggerEvent('[data-test-twitter-input]', 'blur');
await testTwitterValidation(
'thisusernamehasmorethan15characters',
'thisusernamehasmorethan15characters',
'Your Username is not a valid Twitter Username');
expect(find('[data-test-twitter-input]').val()).to.be.equal('https://twitter.com/user');
expect(find('[data-test-twitter-input]').closest('.form-group').hasClass('error'), 'twitter input should be in error state').to.be.false;
await fillIn('[data-test-twitter-input]', '');
await fillIn('[data-test-twitter-input]', 'twitter.com/user');
await triggerEvent('[data-test-twitter-input]', 'blur');
expect(find('[data-test-twitter-input]').val()).to.be.equal('https://twitter.com/user');
expect(find('[data-test-twitter-input]').closest('.form-group').hasClass('error'), 'twitter input should be in error state').to.be.false;
// Testing bio input
await fillIn('[data-test-website-input]', '');
await fillIn('[data-test-bio-input]', new Array(210).join('a'));