Fixed invalid selectors in Slack tests that were failing in Safari

This commit is contained in:
Kevin Ansfield 2019-01-22 13:53:34 +00:00
parent 042aecb7f6
commit 09497e9ba4

View File

@ -66,7 +66,7 @@ describe('Acceptance: Settings - Integrations - Slack', function () {
await fillIn('[data-test-slack-url-input]', 'notacorrecturl');
await click('[data-test-save-button]');
expect(find('[data-test-error="slack-url"').textContent.trim(), 'inline validation response')
expect(find('[data-test-error="slack-url"]').textContent.trim(), 'inline validation response')
.to.equal('The URL must be in a format like https://hooks.slack.com/services/<your personal key>');
// CMD-S shortcut works
@ -84,14 +84,14 @@ describe('Acceptance: Settings - Integrations - Slack', function () {
expect(result.url).to.equal('https://hooks.slack.com/services/1275958430');
expect(result.username).to.equal('SlackBot');
expect(find('[data-test-error="slack-url"'), 'inline validation response')
expect(find('[data-test-error="slack-url"]'), 'inline validation response')
.to.not.exist;
await fillIn('[data-test-slack-url-input]', 'https://hooks.slack.com/services/1275958430');
await click('[data-test-send-notification-button]');
expect(findAll('.gh-notification').length, 'number of notifications').to.equal(1);
expect(find('[data-test-error="slack-url"'), 'inline validation response')
expect(find('[data-test-error="slack-url"]'), 'inline validation response')
.to.not.exist;
this.server.put('/settings/', function () {