TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-11-25 09:03:12 +03:00
Code Issues Projects Releases Wiki Activity

Updated target origin to all for portal ready event

Browse Source 
no refs

The purpose of broadcasting portal-ready event is it allows Preview in Admin to have better UX with showing Portal when its ready than show the site while its loading. Having a strict target origin like site url won't work when sites have custom domains as it browser security will block the event due to origin mismatch.

Since `portal-ready` is just an event message and doesn't contain any sensitive data that needs to be restricted to origin, this bumps it to `*` which allows any site listening to be able to read the message.
This commit is contained in:
Rishabh 2021-05-27 13:39:23 +05:30
parent e4cd0034ad
commit 0f31838b35
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ghost/portal/src/App.js
View File

@ -75,10 +75,8 @@ export default class App extends React.Component {
}
sendPortalReadyEvent(siteUrl) {
const siteOrigin = ((new URL(siteUrl)).origin).replace(/\/$/, '');
if (window.self !== window.parent) {
window.parent.postMessage('portal-ready', siteOrigin);
window.parent.postMessage('portal-ready', '*');
}
}