Fixed linter errors in <KoenigCardProduct> template

refs https://github.com/TryGhost/Ghost/issues/14101
This commit is contained in:
Kevin Ansfield 2022-05-26 10:09:00 +01:00
parent f4f519ed90
commit 1130b609c3
2 changed files with 34 additions and 16 deletions

View File

@ -1218,3 +1218,21 @@ remove|ember-template-lint|no-action|2|17|2|17|c31e149422ee6e80dcaf0561a993a93ec
remove|ember-template-lint|no-action|3|19|3|19|80972d8846ff5e8dd8ef7cc359093dfd822a3dd3|1652054400000|1662422400000|1665014400000|app/components/gh-canvas-header.hbs
remove|ember-template-lint|no-action|4|83|4|83|671e1cde0a4afb412c681bb728239241c2cc822f|1652054400000|1662422400000|1665014400000|app/components/gh-alert.hbs
remove|ember-template-lint|no-action|27|90|27|90|671e1cde0a4afb412c681bb728239241c2cc822f|1652054400000|1662422400000|1665014400000|app/components/gh-notification.hbs
remove|ember-template-lint|no-action|32|25|32|25|51bd4f460e5c86c46ccecbcb52638a43f8ca9b07|1652054400000|1662422400000|1665014400000|lib/koenig-editor/addon/components/koenig-card-product.hbs
remove|ember-template-lint|no-action|33|28|33|28|6c35771c823fe159562109db4dbe1dec3cfe82f0|1652054400000|1662422400000|1665014400000|lib/koenig-editor/addon/components/koenig-card-product.hbs
remove|ember-template-lint|no-action|43|193|43|193|0791eeb5a6fa727f27b18b9cbba690b3e7633908|1652054400000|1662422400000|1665014400000|lib/koenig-editor/addon/components/koenig-card-product.hbs
remove|ember-template-lint|no-action|95|34|95|34|485fe526158c0e2d8a6375090421d1a108db08e3|1652054400000|1662422400000|1665014400000|lib/koenig-editor/addon/components/koenig-card-product.hbs
remove|ember-template-lint|no-action|96|41|96|41|db770f15518a0c5269a1e0412a8993b1a29b0ff9|1652054400000|1662422400000|1665014400000|lib/koenig-editor/addon/components/koenig-card-product.hbs
remove|ember-template-lint|no-action|100|160|100|160|8795fb5ce9ff212338a402accb0f4088b172dcf9|1652054400000|1662422400000|1665014400000|lib/koenig-editor/addon/components/koenig-card-product.hbs
remove|ember-template-lint|no-action|103|160|103|160|8795fb5ce9ff212338a402accb0f4088b172dcf9|1652054400000|1662422400000|1665014400000|lib/koenig-editor/addon/components/koenig-card-product.hbs
remove|ember-template-lint|no-action|106|160|106|160|8795fb5ce9ff212338a402accb0f4088b172dcf9|1652054400000|1662422400000|1665014400000|lib/koenig-editor/addon/components/koenig-card-product.hbs
remove|ember-template-lint|no-action|109|160|109|160|8795fb5ce9ff212338a402accb0f4088b172dcf9|1652054400000|1662422400000|1665014400000|lib/koenig-editor/addon/components/koenig-card-product.hbs
remove|ember-template-lint|no-action|112|160|112|160|8795fb5ce9ff212338a402accb0f4088b172dcf9|1652054400000|1662422400000|1665014400000|lib/koenig-editor/addon/components/koenig-card-product.hbs
remove|ember-template-lint|no-action|123|30|123|30|30281ef3d94b7a7a9f47a283184993562e0fb8da|1652054400000|1662422400000|1665014400000|lib/koenig-editor/addon/components/koenig-card-product.hbs
remove|ember-template-lint|no-action|124|37|124|37|97ce84ec3c3e0aec9ad3d95414ffa3aa235d5ef3|1652054400000|1662422400000|1665014400000|lib/koenig-editor/addon/components/koenig-card-product.hbs
remove|ember-template-lint|no-triple-curlies|215|58|215|58|f275e4285fc5c31636bb93b4c3205b1ebcacd1c2|1652054400000|1662422400000|1665014400000|lib/koenig-editor/addon/components/koenig-card-product.hbs
remove|ember-template-lint|no-triple-curlies|227|57|227|57|52f2618c4b4b9dadd3f92637eebe11b8c49439a4|1652054400000|1662422400000|1665014400000|lib/koenig-editor/addon/components/koenig-card-product.hbs
remove|ember-template-lint|no-unused-block-params|1|0|1|0|80177996433f1baa0760bad617719d6bee14321f|1652054400000|1662422400000|1665014400000|lib/koenig-editor/addon/components/koenig-card-product.hbs
remove|ember-template-lint|require-valid-alt-text|39|24|39|24|5c972340e69c179be52c12fcf81ed23f169a6f50|1652054400000|1662422400000|1665014400000|lib/koenig-editor/addon/components/koenig-card-product.hbs
remove|ember-template-lint|require-valid-alt-text|210|20|210|20|00f4e6cd2b8af768b1053aa70e3eaafe975fb917|1652054400000|1662422400000|1665014400000|lib/koenig-editor/addon/components/koenig-card-product.hbs
remove|ember-template-lint|simple-unless|37|88|37|88|ca177565b6e1c5a6175982047708732f5dde7e59|1652054400000|1662422400000|1665014400000|lib/koenig-editor/addon/components/koenig-card-product.hbs

View File

@ -21,7 +21,6 @@
{{on "dragleave" this.dragLeave}}
{{on "drop" this.drop}}
{{did-insert this.registerElement}}
as |card|
>
{{#if @isEditing}}
<div class="kg-product-card">
@ -29,14 +28,14 @@
@files={{this.files}}
@accept={{this.imageMimeTypes}}
@extensions={{this.imageExtensions}}
@onStart={{action "setPreviewSrc"}}
@onComplete={{action "updateSrc"}}
@onFailed={{action "resetSrcs"}}
@onStart={{this.setPreviewSrc}}
@onComplete={{this.updateSrc}}
@onFailed={{this.resetSrcs}}
as |uploader|
>
<div class="relative kg-product-card-image-container hide-child{{unless (or this.previewSrc @payload.productImageSrc) " bg-whitegrey-l2"}}">
<div class="relative kg-product-card-image-container hide-child{{if (not (or this.previewSrc @payload.productImageSrc)) " bg-whitegrey-l2"}}">
{{#if (or this.previewSrc @payload.productImageSrc)}}
<img src={{or this.previewSrc @payload.productImageSrc}} class="{{kg-style this.kgImgStyle sidebar=this.ui.hasSideNav}} kg-product-card-image">
<img src={{or this.previewSrc @payload.productImageSrc}} class="{{kg-style this.kgImgStyle sidebar=this.ui.hasSideNav}} kg-product-card-image" alt="" role="presentation">
{{#unless this.koenigDragDropHandler.isDragging}}
<div class="bg-image-overlay-top child pe-none {{this.image.overlayClasses}}">
<div class="flex flex-row-reverse">
@ -92,24 +91,24 @@
@class="w-100 fw4 bn bg-transparent kg-product-card-title"
@name="title"
@defaultTag="h4"
@onChange={{action "setProductTitle"}}
@didCreateEditor={{action "registerTitleEditor"}}
@onChange={{this.setProductTitle}}
@didCreateEditor={{this.registerTitleEditor}}
/>
{{#if @payload.productRatingEnabled}}
<div class="kg-product-card-rating-edit icons" style="line-height: auto;">
<button class="{{if (gte @payload.productStarRating 1) "kg-product-card-rating-active"}} kg-product-card-rating-star" value="1" onclick={{action "changeStars"}} onmouseover={{this.hoverStarOn}} onmouseout={{this.hoverStarOff}} type="button">
<button class="{{if (gte @payload.productStarRating 1) "kg-product-card-rating-active"}} kg-product-card-rating-star" value="1" {{on "click" this.changeStars}} {{on "mouseover" this.hoverStarOn}} {{on "mouseout" this.hoverStarOff}} type="button">
<span>{{svg-jar "koenig/kg-star"}}</span>
</button>
<button class="{{if (gte @payload.productStarRating 2) "kg-product-card-rating-active"}} kg-product-card-rating-star" value="2" onclick={{action "changeStars"}} onmouseover={{this.hoverStarOn}} onmouseout={{this.hoverStarOff}} type="button">
<button class="{{if (gte @payload.productStarRating 2) "kg-product-card-rating-active"}} kg-product-card-rating-star" value="2" {{on "click" this.changeStars}} {{on "mouseover" this.hoverStarOn}} {{on "mouseout" this.hoverStarOff}} type="button">
<span>{{svg-jar "koenig/kg-star"}}</span>
</button>
<button class="{{if (gte @payload.productStarRating 3) "kg-product-card-rating-active"}} kg-product-card-rating-star" value="3" onclick={{action "changeStars"}} onmouseover={{this.hoverStarOn}} onmouseout={{this.hoverStarOff}} type="button">
<button class="{{if (gte @payload.productStarRating 3) "kg-product-card-rating-active"}} kg-product-card-rating-star" value="3" {{on "click" this.changeStars}} {{on "mouseover" this.hoverStarOn}} {{on "mouseout" this.hoverStarOff}} type="button">
<span>{{svg-jar "koenig/kg-star"}}</span>
</button>
<button class="{{if (gte @payload.productStarRating 4) "kg-product-card-rating-active"}} kg-product-card-rating-star" value="4" onclick={{action "changeStars"}} onmouseover={{this.hoverStarOn}} onmouseout={{this.hoverStarOff}} type="button">
<button class="{{if (gte @payload.productStarRating 4) "kg-product-card-rating-active"}} kg-product-card-rating-star" value="4" {{on "click" this.changeStars}} {{on "mouseover" this.hoverStarOn}} {{on "mouseout" this.hoverStarOff}} type="button">
<span>{{svg-jar "koenig/kg-star"}}</span>
</button>
<button class="{{if (gte @payload.productStarRating 5) "kg-product-card-rating-active"}} kg-product-card-rating-star" value="5" onclick={{action "changeStars"}} onmouseover={{this.hoverStarOn}} onmouseout={{this.hoverStarOff}} type="button">
<button class="{{if (gte @payload.productStarRating 5) "kg-product-card-rating-active"}} kg-product-card-rating-star" value="5" {{on "click" this.changeStars}} {{on "mouseover" this.hoverStarOn}} {{on "mouseout" this.hoverStarOff}} type="button">
<span>{{svg-jar "koenig/kg-star"}}</span>
</button>
</div>
@ -120,8 +119,8 @@
@placeholder="Description"
@class="w-100 fw4 bg-transparent kg-product-card-description"
@name="description"
@onChange={{action "setProductDescription"}}
@didCreateEditor={{action "registerEditor"}}
@onChange={{this.setProductDescription}}
@didCreateEditor={{this.registerEditor}}
/>
{{#if @payload.productButtonEnabled}}
<a href="javascript:void(0)" class="gh-btn gh-btn-accent kg-product-card-button" disabled={{not @payload.productButton}}>
@ -204,10 +203,11 @@
{{else}}
{{!-- template-lint-disable no-triple-curlies --}}
<div class="kg-product-card">
{{#if @payload.productImageSrc}}
<div class="kg-product-card-image-container">
<img src={{@payload.productImageSrc}} class="kg-product-card-image" />
<img src={{@payload.productImageSrc}} class="kg-product-card-image" alt="" role="presentation" />
</div>
{{/if}}
<div class="kg-product-card-header">