TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-26 12:21:36 +03:00
Code Issues Projects Releases Wiki Activity

Removed unused parent property from tag model

Browse Source 
The Posts API does not strip unknown properties when dealing with relations,
which meant that tags were being sent up with a `parent` property which would
always cause the model to be considered "changed". This resulted in the update
methods being called, and leading to unexpected behaviour.

Whilst this change does fix things for the History feature, the correct fix is
to update the admin-api-schema, or the input serializers such that they only
allow through known and allowed properties.
This commit is contained in:
Fabien "egg" O'Carroll 2022-09-06 15:26:47 -04:00 committed by Daniel Lockyer
parent 04e3ee9f10
commit 11cbfcb0b6
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
ghost/admin/app/models/tag.js
View File

@ -9,7 +9,6 @@ export default Model.extend(ValidationEngine, {
name: attr('string'), name: attr('string'),
slug: attr('string'), slug: attr('string'),
description: attr('string'), description: attr('string'),
parent: attr('string'), // unused
metaTitle: attr('string'), metaTitle: attr('string'),
metaDescription: attr('string'), metaDescription: attr('string'),
twitterImage: attr('string'), twitterImage: attr('string'),