Replaced use of Bluebird return method from knex code

no issue

- Knex removed their use of several Bluebird methods, including `return`
- our code used `return`, but mostly to return null after a destroy action
- these uses have been replaced with `.then(() => null)` in order to
  continue returning null and to avoid breaking anything

core/server/api/canary/invites.js

@@ -77,7 +77,7 @@ module.exports = {
             frame.options.require = true;
 
             return models.Invite.destroy(frame.options)
-                .return(null);
+                .then(() => null);
         }
     },
 

core/server/api/canary/labels.js

@@ -139,7 +139,7 @@ module.exports = {
         },
         permissions: true,
         query(frame) {
-            return models.Label.destroy(frame.options).return(null);
+            return models.Label.destroy(frame.options).then(() => null);
         }
     }
 };

core/server/api/canary/pages.js

@@ -196,7 +196,7 @@ module.exports = {
             frame.options.require = true;
 
             return models.Post.destroy(frame.options)
-                .return(null)
+                .then(() => null)
                 .catch(models.Post.NotFoundError, () => {
                     throw new common.errors.NotFoundError({
                         message: common.i18n.t('errors.api.pages.pageNotFound')

core/server/api/canary/posts.js

@@ -231,7 +231,7 @@ module.exports = {
             frame.options.require = true;
 
             return models.Post.destroy(frame.options)
-                .return(null)
+                .then(() => null)
                 .catch(models.Post.NotFoundError, () => {
                     throw new common.errors.NotFoundError({
                         message: common.i18n.t('errors.api.posts.postNotFound')

core/server/api/canary/tags.js

@@ -142,7 +142,7 @@ module.exports = {
         },
         permissions: true,
         query(frame) {
-            return models.Tag.destroy(frame.options).return(null);
+            return models.Tag.destroy(frame.options).then(() => null);
         }
     }
 };

core/server/api/canary/users.js

@@ -130,11 +130,11 @@ module.exports = {
             return models.Base.transaction((t) => {
                 frame.options.transacting = t;
 
-                return Promise.all([
-                    models.Post.destroyByAuthor(frame.options)
-                ]).then(() => {
-                    return models.User.destroy(Object.assign({status: 'all'}, frame.options));
-                }).return(filename);
+                return models.Post.destroyByAuthor(frame.options)
+                    .then(() => {
+                        return models.User.destroy(Object.assign({status: 'all'}, frame.options));
+                    })
+                    .then(() => filename);
             }).catch((err) => {
                 return Promise.reject(new common.errors.NoPermissionError({
                     err: err

core/server/api/canary/webhooks.js

@@ -84,7 +84,7 @@ module.exports = {
         permissions: true,
         query(frame) {
             frame.options.require = true;
-            return models.Webhook.destroy(frame.options).return(null);
+            return models.Webhook.destroy(frame.options).then(() => null);
         }
     }
 };

core/server/api/v2/invites.js

@@ -77,7 +77,7 @@ module.exports = {
             frame.options.require = true;
 
             return models.Invite.destroy(frame.options)
-                .return(null);
+                .then(() => null);
         }
     },
 

core/server/api/v2/pages.js

@@ -196,7 +196,7 @@ module.exports = {
             frame.options.require = true;
 
             return models.Post.destroy(frame.options)
-                .return(null)
+                .then(() => null)
                 .catch(models.Post.NotFoundError, () => {
                     throw new common.errors.NotFoundError({
                         message: common.i18n.t('errors.api.pages.pageNotFound')

core/server/api/v2/posts.js

@@ -191,7 +191,7 @@ module.exports = {
             frame.options.require = true;
 
             return models.Post.destroy(frame.options)
-                .return(null)
+                .then(() => null)
                 .catch(models.Post.NotFoundError, () => {
                     throw new common.errors.NotFoundError({
                         message: common.i18n.t('errors.api.posts.postNotFound')

core/server/api/v2/tags.js

@@ -142,7 +142,7 @@ module.exports = {
         },
         permissions: true,
         query(frame) {
-            return models.Tag.destroy(frame.options).return(null);
+            return models.Tag.destroy(frame.options).then(() => null);
         }
     }
 };

core/server/api/v2/users.js

@@ -129,7 +129,7 @@ module.exports = {
                     models.Post.destroyByAuthor(frame.options)
                 ]).then(() => {
                     return models.User.destroy(Object.assign({status: 'all'}, frame.options));
-                }).return(null);
+                }).then(() => null);
             }).catch((err) => {
                 return Promise.reject(new common.errors.NoPermissionError({
                     err: err

core/server/api/v2/webhooks.js

@@ -84,7 +84,7 @@ module.exports = {
         permissions: true,
         query(frame) {
             frame.options.require = true;
-            return models.Webhook.destroy(frame.options).return(null);
+            return models.Webhook.destroy(frame.options).then(() => null);
         }
     }
 };

core/server/models/relations/authors.js

@@ -314,7 +314,7 @@ module.exports.extendModel = function extendModel(Post, Posts, ghostBookshelf) {
                         return (options.transacting || ghostBookshelf.knex)('posts_authors')
                             .where('author_id', authorId)
                             .del()
-                            .return(response);
+                            .then(() => response);
                     })
                     .catch((err) => {
                         throw new common.errors.GhostError({err: err});