From 1f87c59055a1c820389d0a419d02f3da7f7a27e3 Mon Sep 17 00:00:00 2001
From: Kevin Ansfield <kevin@lookingsideways.co.uk>
Date: Wed, 1 Jul 2020 18:30:00 +0100
Subject: [PATCH] Refactored <GhPostsListItem>

no issue

- moved `primaryTag` CP into the post model as per `primaryAuthor`
- removed all unnecessary or unused CPs in the component's backing class
- switched to using `@post` for direct argument access rather than `this.post`
---
 .../app/components/gh-posts-list-item.hbs     | 34 ++++++++--------
 .../app/components/gh-posts-list-item.js      | 39 -------------------
 ghost/admin/app/models/post.js                |  1 +
 3 files changed, 18 insertions(+), 56 deletions(-)

diff --git a/ghost/admin/app/components/gh-posts-list-item.hbs b/ghost/admin/app/components/gh-posts-list-item.hbs
index 10589d6d17..168a11b75f 100644
--- a/ghost/admin/app/components/gh-posts-list-item.hbs
+++ b/ghost/admin/app/components/gh-posts-list-item.hbs
@@ -1,56 +1,56 @@
-<LinkTo @route="editor.edit" @models={{array this.post.displayName this.post.id}} class="permalink gh-list-data gh-post-list-featured" @title="Edit this post">
-    {{#if this.isFeatured}}
+<LinkTo @route="editor.edit" @models={{array @post.displayName @post.id}} class="permalink gh-list-data gh-post-list-featured" @title="Edit this post">
+    {{#if @post.isFeatured}}
         <span data-tooltip="Featured" class="dib pl1 pr1 nr1 nl1">{{svg-jar "star-filled" class="fill-blue w3 h3"}}</span>
     {{/if}}
 </LinkTo>
 
-<LinkTo @route="editor.edit" @models={{array this.post.displayName this.post.id}} class="permalink gh-list-data gh-post-list-title" @title="Edit this post">
+<LinkTo @route="editor.edit" @models={{array @post.displayName @post.id}} class="permalink gh-list-data gh-post-list-title" @title="Edit this post">
     <h3 class="gh-content-entry-title">
-        {{this.post.title}}
+        {{@post.title}}
     </h3>
     <p>
         <span class="gh-content-entry-meta">
             By <span class="midgrey-l2 fw5">{{this.authorNames}}</span>
 
-            {{#if this.primaryTag}}
-                in <span class="midgrey-l2 fw5">{{this.primaryTag}}</span>
+            {{#if @post.primaryTag}}
+                in <span class="midgrey-l2 fw5">{{@post.primaryTag.name}}</span>
             {{/if}}
 
-            {{#if this.isScheduled}}
-                – <span class="gh-schedule-time">Scheduled to be published and sent {{gh-format-post-time this.post.publishedAtUTC scheduled=true}}</span>
+            {{#if @post.isScheduled}}
+                – <span class="gh-schedule-time">Will be published and sent {{gh-format-post-time @post.publishedAtUTC scheduled=true}}</span>
             {{/if}}
         </span>
     </p>
 </LinkTo>
 
-<LinkTo @route="editor.edit" @models={{array this.post.displayName this.post.id}} class="permalink gh-list-data gh-post-list-status" @title="Edit this post">
+<LinkTo @route="editor.edit" @models={{array @post.displayName @post.id}} class="permalink gh-list-data gh-post-list-status" @title="Edit this post">
     <div class="flex items-center">
-        {{#if this.isScheduled}}
+        {{#if @post.isScheduled}}
         <span class="gh-content-status-draft gh-badge nowrap">
             Scheduled
         </span>
         {{/if}}
 
-        {{#if this.isDraft}}
+        {{#if @post.isDraft}}
         <span class="gh-content-status-draft gh-badge gh-badge-purple nowrap">
             Draft
         </span>
         {{/if}}
 
-        {{#if (and this.isPublished (not this.post.page))}}
+        {{#if @post.isPublished}}
         <span class="gh-content-status-published nowrap" title="Post has been sent by email">
             Published
         </span>
         {{/if}}
 
         {{#if this.session.user.isOwnerOrAdmin}}
-            {{#if (or this.post.email (and this.post.isScheduled this.post.sendEmailWhenPublished))}}
-                {{#if (eq this.post.email.status "failed")}}
+            {{#if (or @post.email (and @post.isScheduled @post.sendEmailWhenPublished))}}
+                {{#if (eq @post.email.status "failed")}}
                     <span data-tooltip="Failed to send post by email" class="gh-content-status-emailed error">
                         {{svg-jar "send-email" class="stroke-red"}}
                     </span>
                 {{else}}
-                    {{#if this.isScheduled}}
+                    {{#if @post.isScheduled}}
                         <span data-tooltip="To be sent by email" class="gh-content-status-emailed scheduled">
                             {{svg-jar "send-email" class="stroke-green-d2"}}
                         </span>
@@ -65,6 +65,6 @@
     </div>
 </LinkTo>
 
-<LinkTo @route="editor.edit" @models={{array this.post.displayName this.post.id}} class="permalink gh-list-data gh-post-list-updated" @title="Edit this post">
-    <span class="nowrap">{{gh-format-post-time this.post.updatedAtUTC draft=true}}</span>
+<LinkTo @route="editor.edit" @models={{array @post.displayName @post.id}} class="permalink gh-list-data gh-post-list-updated" @title="Edit this post">
+    <span class="nowrap">{{gh-format-post-time @post.updatedAtUTC draft=true}}</span>
 </LinkTo>
\ No newline at end of file
diff --git a/ghost/admin/app/components/gh-posts-list-item.js b/ghost/admin/app/components/gh-posts-list-item.js
index 81ef2a56ad..144ff06509 100644
--- a/ghost/admin/app/components/gh-posts-list-item.js
+++ b/ghost/admin/app/components/gh-posts-list-item.js
@@ -1,55 +1,16 @@
 import Component from '@ember/component';
-import {alias, equal} from '@ember/object/computed';
 import {computed} from '@ember/object';
-import {isBlank} from '@ember/utils';
 import {inject as service} from '@ember/service';
 
 export default Component.extend({
-    ghostPaths: service(),
     session: service(),
 
     tagName: 'li',
     classNames: ['gh-list-row', 'gh-posts-list-item'],
 
-    post: null,
-
-    isFeatured: alias('post.featured'),
-    isPage: alias('post.page'),
-    isDraft: equal('post.status', 'draft'),
-    isPublished: equal('post.status', 'published'),
-    isScheduled: equal('post.status', 'scheduled'),
-
     authorNames: computed('post.authors.[]', function () {
         let authors = this.get('post.authors');
 
         return authors.map(author => author.get('name') || author.get('email')).join(', ');
-    }),
-
-    primaryTag: computed('post.authors.[]', function () {
-        let primaryTag = this.get('post.tags.firstObject');
-
-        if (primaryTag) {
-            return primaryTag.get('name');
-        } else {
-            return false;
-        }
-    }),
-
-    subText: computed('post.{excerpt,customExcerpt,metaDescription}', function () {
-        let text = this.get('post.excerpt') || '';
-        let customExcerpt = this.get('post.customExcerpt');
-        let metaDescription = this.get('post.metaDescription');
-
-        if (!isBlank(customExcerpt)) {
-            text = customExcerpt;
-        } else if (!isBlank(metaDescription)) {
-            text = metaDescription;
-        }
-
-        if (this.isScheduled) {
-            return `${text.slice(0, 35)}...`;
-        } else {
-            return `${text.slice(0, 80)}...`;
-        }
     })
 });
diff --git a/ghost/admin/app/models/post.js b/ghost/admin/app/models/post.js
index 781fa98ada..55d0ab3e27 100644
--- a/ghost/admin/app/models/post.js
+++ b/ghost/admin/app/models/post.js
@@ -115,6 +115,7 @@ export default Model.extend(Comparable, ValidationEngine, {
     tags: hasMany('tag', {embedded: 'always', async: false}),
 
     primaryAuthor: reads('authors.firstObject'),
+    primaryTag: reads('tags.firstObject'),
 
     scratch: null,
     titleScratch: null,