TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-11-25 09:03:12 +03:00
Code Issues Projects Releases Wiki Activity

Moved launch complete flag to new editor setting (#2135)

Browse Source 
refs https://github.com/TryGhost/Team/issues/807
refs https://github.com/TryGhost/Ghost/pull/13703

The launch wizard completed flag was previously stored at per user level in accessibility column of user table, so an administrator still got the option to complete the launch wizard even if the owner had completed it previously, which is not expected pattern. This change moves the launch complete flag to be stored in new global setting for site.
This commit is contained in:
Rishabh Garg 2021-11-04 18:04:39 +05:30 committed by GitHub
parent b230b2efff
commit 208b4948ff
4 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ghost/admin/app/components/gh-launch-wizard/finalise.js
View File

@ -50,9 +50,9 @@ export default class GhLaunchWizardFinaliseComponent extends Component {
const data = this.args.getData();
if (data?.product) {
yield this.saveProduct();
this.settings.set('editorIsLaunchComplete', true);
yield this.settings.save();
}
yield this.feature.set('launchComplete', true);
this.router.transitionTo('dashboard');
this.notifications.showNotification(
'Launch complete!',

3
ghost/admin/app/controllers/dashboard.js
View File

@ -235,6 +235,7 @@ export default class DashboardController extends Controller {
@action
dismissLaunchBanner() {
this.feature.set('launchComplete', true);
this.settings.set('editorIsLaunchComplete', true);
this.settings.save();
}
}

1
ghost/admin/app/models/setting.js
View File

@ -94,6 +94,7 @@ export default Model.extend(ValidationEngine, {
/**
* Editor settings
*/
editorIsLaunchComplete: attr('boolean'),
editorDefaultEmailRecipients: attr('string'),
editorDefaultEmailRecipientsFilter: attr('members-segment-string'),
emailVerificationRequired: attr('boolean'),

6
ghost/admin/app/templates/dashboard.hbs
View File

@ -7,7 +7,7 @@
<div class="view-container gh-dashboard">
{{#if (and this.session.user.isOwnerOnly (not this.feature.launchComplete))}}
{{#if (and this.session.user.isOwnerOnly (not this.settings.editorIsLaunchComplete))}}
<section class="gh-dashboard-area lw-banner">
<div class="gh-lw-banner" style="background-image:url(assets/img/launch-wizard-bg.png);">
<h1>Select your publication style</h1>
@ -287,7 +287,7 @@
</div>
{{/if}}
{{#unless (and this.session.user.isOwnerOnly (not this.feature.launchComplete))}}
{{#unless (and this.session.user.isOwnerOnly (not this.feature.editorIsLaunchComplete))}}
<div class="gh-dashboard-box grey activity-feed">
<h4 class="gh-dashboard-header">Activity feed</h4>
<div class="content">
@ -332,4 +332,4 @@
{{/unless}}
</section>
</div>
</section>
</section>