From 2099d1b3eed1709c09dc8e877717766fad11a614 Mon Sep 17 00:00:00 2001
From: Simon Backx <simon@ghost.org>
Date: Thu, 25 Aug 2022 11:34:46 +0200
Subject: [PATCH] Added link to filtered members page on attribution counts

refs https://github.com/TryGhost/Team/issues/1843

- Added link to filtered members list when clicking the signup or conversion member counts in the posts and pages table
- Temporary hover style added
---
 ghost/admin/app/components/gh-posts-list-item.hbs | 8 ++++----
 ghost/admin/app/styles/layouts/content.css        | 5 +++++
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/ghost/admin/app/components/gh-posts-list-item.hbs b/ghost/admin/app/components/gh-posts-list-item.hbs
index 9f7d1dd3df..154cb96751 100644
--- a/ghost/admin/app/components/gh-posts-list-item.hbs
+++ b/ghost/admin/app/components/gh-posts-list-item.hbs
@@ -102,17 +102,17 @@
     {{/if}}
 
     {{#if this.feature.memberAttribution}}
-        <a href={{@post.url}} class="permalink gh-list-data gh-post-list-signups" target="_blank" rel="noopener noreferrer">
+        <LinkTo @route="members" @query={{hash filterParam=(concat "signup:[" @post.id "]") }} class="permalink gh-list-data gh-post-list-signups">
             <span class="midlightgrey {{if (not (eq @post.count.signups 0)) 'darkgrey'}} fw5 gh-content-attribution-stats">{{@post.count.signups}}</span>
             <span class="midgrey-l2 fw4 gh-content-attribution-stats-mobile">{{gh-pluralize @post.count.signups "signup"}}</span>
-        </a>
+        </LinkTo>
     {{/if}}
 
     {{#if this.feature.memberAttribution}}
-        <a href={{@post.url}} class="permalink gh-list-data gh-post-list-conversions" target="_blank" rel="noopener noreferrer">
+        <LinkTo @route="members" @query={{hash filterParam=(concat "conversion:[" @post.id "]") }} class="permalink gh-list-data gh-post-list-conversions">
             <span class="midlightgrey {{if (not (eq @post.count.conversions 0)) 'darkgrey'}} fw5 gh-content-attribution-stats">{{@post.count.conversions}}</span>
             <span class="midgrey-l2 fw4 gh-content-attribution-stats-mobile">{{gh-pluralize @post.count.conversions "conversion"}}</span>
-        </a>
+        </LinkTo>
     {{/if}}
 
     {{#if (and (not-eq this.settings.membersSignupAccess "none") (not-eq this.settings.editorDefaultEmailRecipients "disabled") (not this.session.user.isContributor))}}
diff --git a/ghost/admin/app/styles/layouts/content.css b/ghost/admin/app/styles/layouts/content.css
index 734b33271a..5cb4994e38 100644
--- a/ghost/admin/app/styles/layouts/content.css
+++ b/ghost/admin/app/styles/layouts/content.css
@@ -230,6 +230,11 @@
     padding-right: 8px;
 }
 
+/** TODO: improve this hover style */
+a.gh-post-list-signups:hover > span, a.gh-post-list-conversions:hover > span {
+    opacity: 0.5;
+}
+
 .gh-content-entry-title {
     display: flex;
     align-items: center;