TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-11-25 09:03:12 +03:00
Code Issues Projects Releases Wiki Activity

Fixed offer ui updating offer values directly on input change

Browse Source 
no refs

- without marking input fields in template as `readonly` value, it updates the value directly on any change which is undesirable and causes side-effects in actual update of property
This commit is contained in:
Rishabh 2021-10-19 13:39:16 +05:30
parent 87742482fa
commit 21847b822c
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
ghost/admin/app/templates/offer.hbs
View File

@ -133,7 +133,7 @@
<label for="duration-months" class="fw6">Number of months</label>
<GhTextInput
@name="duration-months"
@value={{this.offer.durationInMonths}}
@value={{readonly this.offer.durationInMonths}}
@input={{this.setDurationInMonths}}
@disabled={{this.isDiscountSectionDisabled}}
@id="duration-months"
@ -153,7 +153,7 @@
<label for="display-title" class="fw6">Display title</label>
<GhTextInput
@name="display-title"
@value={{this.offer.displayTitle}}
@value={{readonly this.offer.displayTitle}}
@input={{this.setPortalTitle}}
@placeholder="Black Friday Special"
@id="display-title"
@ -167,7 +167,7 @@
<GhTextInput
@name="code"
@placeholder="black-friday"
@value={{this.offer.code}}
@value={{readonly this.offer.code}}
@input={{this.setOfferCode}}
@id="code"
@class="gh-input" />
@ -181,7 +181,7 @@
<div class="gh-input-group">
<GhTextInput
@name="url"
@value={{this.offerUrl}}
@value={{readonly this.offerUrl}}
@id="url"
@disabled="disabled"
@class="gh-input" />
@ -200,7 +200,7 @@
@id="description"
@name="description"
@placeholder="Take advantage of this limited-time offer."
@value={{this.offer.displayDescription}}
@value={{readonly this.offer.displayDescription}}
@input={{this.setPortalDescription}}
@stopEnterKeyDownPropagation="true"
/>