TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-11-28 14:03:48 +03:00
Code Issues Projects Releases Wiki Activity

Handled our forced null conversion in bookshelf

Browse Source 
refs https://github.com/TryGhost/Arch/issues/47

We've configured bookshelf to force empty strings to null, but this is
undesired behaviour here, so unfortunately we have to leak some business
logic into the repository.

This needs to be done to correctly support our filter validation logic.
This commit is contained in:
Fabien "egg" O'Carroll 2023-08-23 13:06:16 +07:00 committed by Fabien 'egg' O'Carroll
parent 359617462a
commit 27bfa30f97
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ghost/core/core/server/services/collections/BookshelfCollectionsRepository.js
View File

@ -66,13 +66,17 @@ module.exports = class BookshelfCollectionsRepository {
#modelToCollection(model) { #modelToCollection(model) {
const json = model.toJSON(); const json = model.toJSON();
let filter = json.filter;
if (json.type === 'automatic' && typeof filter !== 'string') {
filter = '';
}
return Collection.create({ return Collection.create({
id: json.id, id: json.id,
slug: json.slug, slug: json.slug,
title: json.title, title: json.title,
description: json.description, description: json.description,
filter: json.filter, filter: filter,
type: json.type, type: json.type,
featureImage: json.feature_image, featureImage: json.feature_image,
posts: json.collectionPosts.map(collectionPost => collectionPost.post_id), posts: json.collectionPosts.map(collectionPost => collectionPost.post_id),