TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-11-28 14:03:48 +03:00
Code Issues Projects Releases Wiki Activity

Added a down() operation to newsletters

Browse Source 
- Without the down operation, the previous migration fails to re-add the
created_at column after a rollback
This commit is contained in:
Matt Hanley 2022-04-22 14:22:26 +01:00 committed by Matt Hanley
parent 69f31074e0
commit 2d27c9d42a
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
core/server/data/migrations/versions/4.46/2022-04-13-13-00-add-default-newsletter.js
View File

@ -35,7 +35,7 @@ module.exports = createTransactionalMigration(
const newsletters = await knex('newsletters').count('*', {as: 'total'});
if (newsletters[0].total !== 0) {
logging.info('Skipping adding the default newsletter - There is already at least one newsletter');
logging.warn('Skipping adding the default newsletter - There is already at least one newsletter');
return;
}
@ -76,9 +76,8 @@ module.exports = createTransactionalMigration(
logging.info('Adding the default newsletter');
await knex('newsletters').insert(newsletter);
},
async function down() {
// Noop because we don't want to reset the default newsletter values
logging.info(`Skipping newsletter design settings backfill rollback - not needed`);
return Promise.resolve();
async function down(knex) {
logging.info(`Removing newsletters`);
await knex('newsletters').delete();
}
);