From 3231863dc2d2f4ebfdccd9e27d31afa01cfb6b00 Mon Sep 17 00:00:00 2001
From: Peter Zimon <peter.zimon@gmail.com>
Date: Wed, 24 Aug 2022 14:22:45 +0200
Subject: [PATCH] Added link on UI for Editors to staff page

refs. https://github.com/TryGhost/Team/issues/1839

- there was no way for an Editor through the Admin UI to be able to invite staff users
---
 ghost/admin/app/components/gh-nav-menu/footer.hbs         | 3 +++
 ghost/admin/app/templates/settings/staff/index.hbs        | 6 ++++--
 ghost/admin/app/templates/settings/staff/user-loading.hbs | 6 ++++--
 ghost/admin/app/templates/settings/staff/user.hbs         | 6 ++++--
 4 files changed, 15 insertions(+), 6 deletions(-)

diff --git a/ghost/admin/app/components/gh-nav-menu/footer.hbs b/ghost/admin/app/components/gh-nav-menu/footer.hbs
index b45124530c..610192e581 100644
--- a/ghost/admin/app/components/gh-nav-menu/footer.hbs
+++ b/ghost/admin/app/components/gh-nav-menu/footer.hbs
@@ -93,6 +93,9 @@
             {{#if (gh-user-can-admin this.session.user)}}
                 <LinkTo class="gh-nav-bottom-tabicon" @route="settings" @current-when={{this.isSettingsRoute}} data-test-nav="settings">{{svg-jar "settings"}}</LinkTo>
             {{/if}}
+            {{#if this.session.user.isEditor}}
+                <LinkTo class="gh-nav-bottom-tabicon" @route="settings.staff" @current-when={{this.isSettingsRoute}} data-test-nav="settings">{{svg-jar "settings"}}</LinkTo>
+            {{/if}}
             <div class="nightshift-toggle-container">
                 <div class="nightshift-toggle {{if this.feature.nightShift "on"}}" {{action (toggle "nightShift" this.feature)}}>
                     <div class="sun">{{svg-jar "sun"}}</div>
diff --git a/ghost/admin/app/templates/settings/staff/index.hbs b/ghost/admin/app/templates/settings/staff/index.hbs
index 59ab2c8a91..d76e206a83 100644
--- a/ghost/admin/app/templates/settings/staff/index.hbs
+++ b/ghost/admin/app/templates/settings/staff/index.hbs
@@ -1,8 +1,10 @@
 <section class="gh-canvas">
     <GhCanvasHeader class="gh-canvas-header">
         <h2 class="gh-canvas-title" data-test-screen-title>
-            <LinkTo @route="settings">Settings</LinkTo>
-            <span>{{svg-jar "arrow-right"}}</span>
+            {{#unless this.session.user.isEditor}}
+                <LinkTo @route="settings">Settings</LinkTo>
+                <span>{{svg-jar "arrow-right"}}</span>
+            {{/unless}}
             Staff
         </h2>
         {{!-- Do not show Invite user button to authors --}}
diff --git a/ghost/admin/app/templates/settings/staff/user-loading.hbs b/ghost/admin/app/templates/settings/staff/user-loading.hbs
index 03583fb7dd..63e193f293 100644
--- a/ghost/admin/app/templates/settings/staff/user-loading.hbs
+++ b/ghost/admin/app/templates/settings/staff/user-loading.hbs
@@ -5,8 +5,10 @@
             <h2 class="gh-canvas-title" data-test-screen-title>Your profile</h2>
         {{else}}
             <h2 class="gh-canvas-title" data-test-screen-title>
-                <LinkTo @route="settings">Settings</LinkTo>
-                <span>{{svg-jar "arrow-right"}}</span>
+                {{#unless this.session.user.isEditor}}
+                    <LinkTo @route="settings">Settings</LinkTo>
+                    <span>{{svg-jar "arrow-right"}}</span>
+                {{/unless}}
                 <LinkTo @route="settings.staff" data-test-staff-link={{true}}>Staff</LinkTo>
                 <span>{{svg-jar "arrow-right"}}</span>
                 {{this.user.name}}
diff --git a/ghost/admin/app/templates/settings/staff/user.hbs b/ghost/admin/app/templates/settings/staff/user.hbs
index 89c83057ef..fe84d63901 100644
--- a/ghost/admin/app/templates/settings/staff/user.hbs
+++ b/ghost/admin/app/templates/settings/staff/user.hbs
@@ -5,8 +5,10 @@
             <h2 class="gh-canvas-title" data-test-screen-title>Your profile</h2>
         {{else}}
             <h2 class="gh-canvas-title" data-test-screen-title>
-                <LinkTo @route="settings">Settings</LinkTo>
-                <span>{{svg-jar "arrow-right"}}</span>
+                {{#unless this.session.user.isEditor}}
+                    <LinkTo @route="settings">Settings</LinkTo>
+                    <span>{{svg-jar "arrow-right"}}</span>
+                {{/unless}}
                 <LinkTo @route="settings.staff" data-test-staff-link={{true}}>Staff</LinkTo>
                 <span>{{svg-jar "arrow-right"}}</span>
                 {{this.user.name}}